All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Elver <elver@google.com>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Andrey Konovalov" <andreyknvl@google.com>
Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	kasan-dev <kasan-dev@googlegroups.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kasan, mm: fix build issue with asmlinkage
Date: Mon, 30 Nov 2020 10:46:01 +0100	[thread overview]
Message-ID: <CANpmjNObtKCG3PPdDRrFczHU3wUnybTqp-F2tMx4CB1T+bThwg@mail.gmail.com> (raw)
In-Reply-To: <35126.1606402815@turing-police>

On Thu, 26 Nov 2020 at 16:00, Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
> commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
> Author: Andrey Konovalov <andreyknvl@google.com>
> Date:   Tue Nov 24 16:45:08 2020 +1100
>
>     kasan: shadow declarations only for software modes
>
> introduces a build failure when it removed an include for linux/pgtable.h
> It actually only needs linux/linkage.h
>
> Test builds on both x86_64 and arm build cleanly
>
> Fixes:   2df573d2ca4c ("kasan: shadow declarations only for software modes")
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

Reviewed-by: Marco Elver <elver@google.com>

Probably want to add

  Link: https://lore.kernel.org/linux-arm-kernel/24105.1606397102@turing-police/

for more context, too.

Thanks,
-- Marco



> ---
> diff --git a/include/linux/kasan.h b/include/linux/kasan.h
> index 83860aa4e89c..5e0655fb2a6f 100644
> --- a/include/linux/kasan.h
> +++ b/include/linux/kasan.h
> @@ -12,6 +12,7 @@ struct task_struct;
>
>  #ifdef CONFIG_KASAN
>
> +#include <linux/linkage.h>
>  #include <asm/kasan.h>
>
>  /* kasan_data struct is used in KUnit tests for KASAN expected failures */
>
>
> --
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/35126.1606402815%40turing-police.

WARNING: multiple messages have this Message-ID
From: Marco Elver <elver@google.com>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Andrey Konovalov" <andreyknvl@google.com>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	kasan-dev <kasan-dev@googlegroups.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kasan, mm: fix build issue with asmlinkage
Date: Mon, 30 Nov 2020 10:46:01 +0100	[thread overview]
Message-ID: <CANpmjNObtKCG3PPdDRrFczHU3wUnybTqp-F2tMx4CB1T+bThwg@mail.gmail.com> (raw)
In-Reply-To: <35126.1606402815@turing-police>

On Thu, 26 Nov 2020 at 16:00, Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
> commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
> Author: Andrey Konovalov <andreyknvl@google.com>
> Date:   Tue Nov 24 16:45:08 2020 +1100
>
>     kasan: shadow declarations only for software modes
>
> introduces a build failure when it removed an include for linux/pgtable.h
> It actually only needs linux/linkage.h
>
> Test builds on both x86_64 and arm build cleanly
>
> Fixes:   2df573d2ca4c ("kasan: shadow declarations only for software modes")
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

Reviewed-by: Marco Elver <elver@google.com>

Probably want to add

  Link: https://lore.kernel.org/linux-arm-kernel/24105.1606397102@turing-police/

for more context, too.

Thanks,
-- Marco



> ---
> diff --git a/include/linux/kasan.h b/include/linux/kasan.h
> index 83860aa4e89c..5e0655fb2a6f 100644
> --- a/include/linux/kasan.h
> +++ b/include/linux/kasan.h
> @@ -12,6 +12,7 @@ struct task_struct;
>
>  #ifdef CONFIG_KASAN
>
> +#include <linux/linkage.h>
>  #include <asm/kasan.h>
>
>  /* kasan_data struct is used in KUnit tests for KASAN expected failures */
>
>
> --
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/35126.1606402815%40turing-police.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-11-30  9:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 15:00 Valdis Klētnieks
2020-11-26 15:00 ` Valdis Klētnieks
2020-11-30  9:46 ` Marco Elver [this message]
2020-11-30  9:46   ` Marco Elver
2020-11-30 15:21   ` Andrey Konovalov
2020-11-30 15:21     ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANpmjNObtKCG3PPdDRrFczHU3wUnybTqp-F2tMx4CB1T+bThwg@mail.gmail.com \
    --to=elver@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@google.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=valdis.kletnieks@vt.edu \
    --subject='Re: [PATCH] kasan, mm: fix build issue with asmlinkage' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.