From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0573C4332F for ; Mon, 13 Sep 2021 17:58:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EB6B610CF for ; Mon, 13 Sep 2021 17:58:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345386AbhIMSAJ (ORCPT ); Mon, 13 Sep 2021 14:00:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344671AbhIMSAI (ORCPT ); Mon, 13 Sep 2021 14:00:08 -0400 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B4C4C061760 for ; Mon, 13 Sep 2021 10:58:52 -0700 (PDT) Received: by mail-oi1-x232.google.com with SMTP id p2so15204301oif.1 for ; Mon, 13 Sep 2021 10:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WYhC7SL+4as2ND/qPy+Y7r2GKb7SvMEFyVMfGu0ciwc=; b=lk5a4NHgzAda8Jp5cOipSeD/mJiI4TGViEw34RypmHjDcyqeAi7CV9o72mRAEqUFU9 C4NTOoZgnkF/s0hUzUJtaTwQtygl1TIey49qXPQx1RkL/vIYwjOuSa53n+Ia3kLB77cT 2+1tPi93FIl67SCsOihJjNHFRafmVdl07ZmshwykesytkL1dI8M3VBDfjFWqAwAjuOuX 4oYXxyAx6nGE+tjLd3AeagRQzBIC1Y7Fz4423pMD02xtAdajKvZY+vFwOjk61++p6O4y 1Z0412rOB9HjQ/KBQ2uzt4xs5PYfThWvvJB/ZtQzgBswPOXxK1VtRvfMjhTmc7JLv07/ CD9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WYhC7SL+4as2ND/qPy+Y7r2GKb7SvMEFyVMfGu0ciwc=; b=qs13zkK4MnMdJeJ4dI1T48QO+FZ1MDXVU/rtXK8tAZOwZ4fOimj6fqircnkTZveVEu EFN4aPRRno/+kZ46sqZYkHRM3L/cpshJSFEgS5CXB3LFi2FEqGZoIEytel31jG4UxDIH mAb9hxKy3EropmqxOGbfkJZsPObWTSBmHfONaixave9lEs0EnSdzKx2l/vSZ3juPEd14 +Zo6pHCwVppMy4CXWp1sbNgjfjJk2HqhbvHypP2fWP1qW3LKJom72UeDlYAZkGnwYKOe J4zmSpcjpDotrUQwtIBflc9GT6gJLFF38P7bfROv5CGhsBCz7tsJZPospjh5Ism8Yo62 jw/Q== X-Gm-Message-State: AOAM532SaimUOLajn6LnLmGFTgkuW41hJACl5pq0NYmUFdtdJstKhs1S e7Rbhbr8EpbVjFNdClHnYeXK2uc/Zfvle9PdnJem/Q== X-Google-Smtp-Source: ABdhPJx1GF0fnNkLpruEj+Lqzz7FmMV1FL51iB1zp2oNxAaujdVlXBEy3MMDpYSYrrm5oGw0MReNlDfpcJb8JE1LLOo= X-Received: by 2002:aca:4344:: with SMTP id q65mr8845158oia.70.1631555931531; Mon, 13 Sep 2021 10:58:51 -0700 (PDT) MIME-Version: 1.0 References: <20210913112609.2651084-1-elver@google.com> <20210913112609.2651084-7-elver@google.com> In-Reply-To: From: Marco Elver Date: Mon, 13 Sep 2021 19:58:39 +0200 Message-ID: Subject: Re: [PATCH v2 6/6] workqueue, kasan: avoid alloc_pages() when recording stack To: Tejun Heo Cc: Andrew Morton , Shuah Khan , Lai Jiangshan , Andrey Konovalov , Walter Wu , Sebastian Andrzej Siewior , Thomas Gleixner , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Vijayanand Jitta , Vinayak Menon , "Gustavo A. R. Silva" , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Aleksandr Nogikh , Taras Madan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Sept 2021 at 19:03, Tejun Heo wrote: > > On Mon, Sep 13, 2021 at 01:26:09PM +0200, Marco Elver wrote: > > While there is an increased risk of failing to insert the stack trace, > > this is typically unlikely, especially if the same insertion had already > > succeeded previously (stack depot hit). For frequent calls from the same > > location, it therefore becomes extremely unlikely that > > kasan_record_aux_stack_noalloc() fails. > > > > Link: https://lkml.kernel.org/r/20210902200134.25603-1-skhan@linuxfoundation.org > > Reported-by: Shuah Khan > > Signed-off-by: Marco Elver > > Tested-by: Shuah Khan > > Acked-by: Sebastian Andrzej Siewior > > Acked-by: Tejun Heo Thanks! > Please feel free to route with the rest of series or if you want me to take > these through the wq tree, please let me know. Usually KASAN & stackdepot patches go via the -mm tree. I hope the 1-line change to workqueue won't conflict with other changes pending in the wq tree. Unless you or Andrew tells us otherwise, I assume these will at some point appear in -mm. Thanks, -- Marco > Thanks. > > -- > tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 953BFC433FE for ; Mon, 13 Sep 2021 17:58:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 230C6610CE for ; Mon, 13 Sep 2021 17:58:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 230C6610CE Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 38BE66B006C; Mon, 13 Sep 2021 13:58:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33BC86B0071; Mon, 13 Sep 2021 13:58:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 251796B0072; Mon, 13 Sep 2021 13:58:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id 1499A6B006C for ; Mon, 13 Sep 2021 13:58:53 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B0165181AEF30 for ; Mon, 13 Sep 2021 17:58:52 +0000 (UTC) X-FDA: 78583310904.01.04BE16D Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by imf22.hostedemail.com (Postfix) with ESMTP id 7291F1900 for ; Mon, 13 Sep 2021 17:58:52 +0000 (UTC) Received: by mail-oi1-f179.google.com with SMTP id 6so15143588oiy.8 for ; Mon, 13 Sep 2021 10:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WYhC7SL+4as2ND/qPy+Y7r2GKb7SvMEFyVMfGu0ciwc=; b=lk5a4NHgzAda8Jp5cOipSeD/mJiI4TGViEw34RypmHjDcyqeAi7CV9o72mRAEqUFU9 C4NTOoZgnkF/s0hUzUJtaTwQtygl1TIey49qXPQx1RkL/vIYwjOuSa53n+Ia3kLB77cT 2+1tPi93FIl67SCsOihJjNHFRafmVdl07ZmshwykesytkL1dI8M3VBDfjFWqAwAjuOuX 4oYXxyAx6nGE+tjLd3AeagRQzBIC1Y7Fz4423pMD02xtAdajKvZY+vFwOjk61++p6O4y 1Z0412rOB9HjQ/KBQ2uzt4xs5PYfThWvvJB/ZtQzgBswPOXxK1VtRvfMjhTmc7JLv07/ CD9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WYhC7SL+4as2ND/qPy+Y7r2GKb7SvMEFyVMfGu0ciwc=; b=fQf27lLjBcB2YckwDfYbTB285OvXLJI3s+Q1gwQV1irqxnyH7VTHdVyyjGYKY0LJvp dWjYSgCmnQvMqr2HbPLyILCCrv24aBj++7UWtPX+sPp1FoN2tpzIzN3wKX7McE6Vq/H6 oBBBk/8uc9R8tR4aI76aEyECqLiuzJmMZZJodqqs//rN7vFGQQXuuQdG4910QI1wJyLh MnmJwslN8ohEQC3VbIdC8AVl76TQnQJ50s57oKMrQSlJ//zyzVe34qkXqDiNrFivtK1N Sa1js5eBrDCIEIypQ6lARugKGZ0FRBXJU4y5wXfIlGNb8Q7evIZPEjIB1aIYd4MW5kEj NRKQ== X-Gm-Message-State: AOAM5339kLJRjF4HhVRl9OWFqstX7YiqJW79K9GJgBpuBARZfvcGwaZf HJcxnHbaw870ZGGw40+lgm+J8IUOvkgLKmTZxvoYlg== X-Google-Smtp-Source: ABdhPJx1GF0fnNkLpruEj+Lqzz7FmMV1FL51iB1zp2oNxAaujdVlXBEy3MMDpYSYrrm5oGw0MReNlDfpcJb8JE1LLOo= X-Received: by 2002:aca:4344:: with SMTP id q65mr8845158oia.70.1631555931531; Mon, 13 Sep 2021 10:58:51 -0700 (PDT) MIME-Version: 1.0 References: <20210913112609.2651084-1-elver@google.com> <20210913112609.2651084-7-elver@google.com> In-Reply-To: From: Marco Elver Date: Mon, 13 Sep 2021 19:58:39 +0200 Message-ID: Subject: Re: [PATCH v2 6/6] workqueue, kasan: avoid alloc_pages() when recording stack To: Tejun Heo Cc: Andrew Morton , Shuah Khan , Lai Jiangshan , Andrey Konovalov , Walter Wu , Sebastian Andrzej Siewior , Thomas Gleixner , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Vijayanand Jitta , Vinayak Menon , "Gustavo A. R. Silva" , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Aleksandr Nogikh , Taras Madan Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 7agi5sn4ycoyd44kh6htythz8r7x3mrf Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=lk5a4NHg; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of elver@google.com designates 209.85.167.179 as permitted sender) smtp.mailfrom=elver@google.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7291F1900 X-HE-Tag: 1631555932-800112 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 13 Sept 2021 at 19:03, Tejun Heo wrote: > > On Mon, Sep 13, 2021 at 01:26:09PM +0200, Marco Elver wrote: > > While there is an increased risk of failing to insert the stack trace, > > this is typically unlikely, especially if the same insertion had already > > succeeded previously (stack depot hit). For frequent calls from the same > > location, it therefore becomes extremely unlikely that > > kasan_record_aux_stack_noalloc() fails. > > > > Link: https://lkml.kernel.org/r/20210902200134.25603-1-skhan@linuxfoundation.org > > Reported-by: Shuah Khan > > Signed-off-by: Marco Elver > > Tested-by: Shuah Khan > > Acked-by: Sebastian Andrzej Siewior > > Acked-by: Tejun Heo Thanks! > Please feel free to route with the rest of series or if you want me to take > these through the wq tree, please let me know. Usually KASAN & stackdepot patches go via the -mm tree. I hope the 1-line change to workqueue won't conflict with other changes pending in the wq tree. Unless you or Andrew tells us otherwise, I assume these will at some point appear in -mm. Thanks, -- Marco > Thanks. > > -- > tejun