From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE959C56201 for ; Wed, 11 Nov 2020 19:05:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43B8D20797 for ; Wed, 11 Nov 2020 19:05:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="IHIZ/9tF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726011AbgKKTFL (ORCPT ); Wed, 11 Nov 2020 14:05:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbgKKTFK (ORCPT ); Wed, 11 Nov 2020 14:05:10 -0500 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D911C0613D1 for ; Wed, 11 Nov 2020 11:05:10 -0800 (PST) Received: by mail-ot1-x342.google.com with SMTP id n11so3179814ota.2 for ; Wed, 11 Nov 2020 11:05:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dqQUt8nF2kgPMW+WfpdEe9JIcv1VB4HVulAU3CTX4MU=; b=IHIZ/9tFgR6oUqI2s20AR2vQEbvYVpaiSYLJuPVf3iwe2ZQV1VwFJ9+pAW89ziWPTO 9dlpBiurvBMFq0/RivSJhV1RO9wMucn8oyQ/k8VPIc0KiK+mL+wcfVOwXQAYdACEdDiy Z1EtjzXKr4mVitKEWIKdU9HTi2vZdEXGthD/g42ZTPEfS/pgLTCxhjwev1uXzFhoO+WO 5PC2y9Kp0PNdwULAeFnTowPwEyAVV7srzimiCunf/CzRr+vzc+SoT5gnQGNjiQIxLC9o 5K1alRUaaVRVStwgo/41+Sxg8AIJE0nGGsCWwN6EgKZZ+dsBOyp8oawS5ER6EBBNZ6xY sFVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dqQUt8nF2kgPMW+WfpdEe9JIcv1VB4HVulAU3CTX4MU=; b=j4PXk5dzey0vCGzx7g7AsFZddvw/XC/DQdJphn9PAUzArg6lWlgt0VL18HUV5dqCOK 7KwGCW2FhF1i0OP/7mZ7j7rmMa1FLjBZrwVQ+Ynltazb+7RzX5kAiDM/dbO8T3asCukJ 6YPnGeWsQkWrAWCFHPWfomIop0ebwNuSgkqYUeJkeTcmAjdd+9aIxv7WIqQucjWwUBmz rBhLaHiIXRnjN/uWpSQMEviR94IhCLrMfKpKAffo366Xs4drvgDmTFDxNT/h0BmQThfV VH45ms5Xza1LyTEjKTMc8u8UrdxMyWgeu6dewTuhm9+t2mHK8Ywk2/sefzzWZgopIIMi UMTQ== X-Gm-Message-State: AOAM5312c4BV5+mvmYFZDRMYnN0PvlRRbeNjPjH579mdBJM/1U7fk4Xn 5ys1WwU8gFkZizN9FVFCyV8YEiIZVDcovwmUaDDT3g== X-Google-Smtp-Source: ABdhPJxXbQWUGNUMQElrxCpcnrSK7G4S7/uSGvEizPe9UE7YdETr/ssdRHzUaHNu9Qf5AnoDXsJutvt7An4JgEB67kk= X-Received: by 2002:a9d:65d5:: with SMTP id z21mr17412658oth.251.1605121509540; Wed, 11 Nov 2020 11:05:09 -0800 (PST) MIME-Version: 1.0 References: <85aba371903b749412fac34e44e54c89e5ddae30.1605046192.git.andreyknvl@google.com> In-Reply-To: From: Marco Elver Date: Wed, 11 Nov 2020 20:04:58 +0100 Message-ID: Subject: Re: [PATCH v9 10/44] kasan: define KASAN_GRANULE_PAGE To: Andrey Konovalov Cc: Alexander Potapenko , Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Nov 2020 at 19:48, Andrey Konovalov wrote: > > On Wed, Nov 11, 2020 at 3:13 PM Alexander Potapenko wrote: > > > > On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov wrote: > > > > > > Define KASAN_GRANULE_PAGE as (KASAN_GRANULE_SIZE << PAGE_SHIFT), which is > > > the same as (KASAN_GRANULE_SIZE * PAGE_SIZE), and use it across KASAN code > > > to simplify it. > > > > What's the physical sense behind KASAN_GRANULE_PAGE? Is it something > > more than just a product of two constants? > > No, just a product. > > > The name suggests it might be something page-sized, but in reality it is not. > > What name would you prefer? Is it actually KASAN_GRANULES_PER_SHADOW_PAGE ? AFAIK we're trying to calculate the granules that we can fit into a page of shadow memory. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD17C388F9 for ; Wed, 11 Nov 2020 19:05:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A19DD20678 for ; Wed, 11 Nov 2020 19:05:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="IHIZ/9tF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A19DD20678 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 072DD6B005D; Wed, 11 Nov 2020 14:05:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0220E6B006C; Wed, 11 Nov 2020 14:05:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2DE26B006E; Wed, 11 Nov 2020 14:05:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id B877D6B005D for ; Wed, 11 Nov 2020 14:05:11 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 671D1181AEF09 for ; Wed, 11 Nov 2020 19:05:11 +0000 (UTC) X-FDA: 77473065222.11.pig67_160319527300 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 367E7180F8B81 for ; Wed, 11 Nov 2020 19:05:11 +0000 (UTC) X-HE-Tag: pig67_160319527300 X-Filterd-Recvd-Size: 4209 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 19:05:10 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id y22so3139551oti.10 for ; Wed, 11 Nov 2020 11:05:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dqQUt8nF2kgPMW+WfpdEe9JIcv1VB4HVulAU3CTX4MU=; b=IHIZ/9tFgR6oUqI2s20AR2vQEbvYVpaiSYLJuPVf3iwe2ZQV1VwFJ9+pAW89ziWPTO 9dlpBiurvBMFq0/RivSJhV1RO9wMucn8oyQ/k8VPIc0KiK+mL+wcfVOwXQAYdACEdDiy Z1EtjzXKr4mVitKEWIKdU9HTi2vZdEXGthD/g42ZTPEfS/pgLTCxhjwev1uXzFhoO+WO 5PC2y9Kp0PNdwULAeFnTowPwEyAVV7srzimiCunf/CzRr+vzc+SoT5gnQGNjiQIxLC9o 5K1alRUaaVRVStwgo/41+Sxg8AIJE0nGGsCWwN6EgKZZ+dsBOyp8oawS5ER6EBBNZ6xY sFVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dqQUt8nF2kgPMW+WfpdEe9JIcv1VB4HVulAU3CTX4MU=; b=jdalnkCgO5oyy1XbMqBUjO6RILiLBoU6s4a5j31y48HDNt5lDN/WSkb1zpc2l/H2Gt 0UCreaOHb6v/kDxODvsz4XN+jqdvJVYom9MsPFc/zLYfsAmPJJa57G/KqnzMCk2wYJq0 CZLfWSV1H5mvNCCoNhWX9WTVGduztsth9rCYuMev7y7awb5JusX+n6DSi1/iSCY9EyH4 SBSbdiV1uGVqDu5V0svUJEajG/I1l2/5wtnl8OPNwG0oy3URRH1kji6/+Uxb3zoCZru2 gR9Fj9QxD74Ywh3xRSx6Onzmvtc8tM96yMtwl+Uq5/2gebr06QBsFpqGoUO7mykSwVpp JkCw== X-Gm-Message-State: AOAM533IEqEN1VNlJd+euOKo4YXj5g8jMOd8q7jzvQfr7uSW8mobmIqG Yvukl5Ra1wSwgPH5IrNx2HWZ7N7RtDwWulDnf0m2rA== X-Google-Smtp-Source: ABdhPJxXbQWUGNUMQElrxCpcnrSK7G4S7/uSGvEizPe9UE7YdETr/ssdRHzUaHNu9Qf5AnoDXsJutvt7An4JgEB67kk= X-Received: by 2002:a9d:65d5:: with SMTP id z21mr17412658oth.251.1605121509540; Wed, 11 Nov 2020 11:05:09 -0800 (PST) MIME-Version: 1.0 References: <85aba371903b749412fac34e44e54c89e5ddae30.1605046192.git.andreyknvl@google.com> In-Reply-To: From: Marco Elver Date: Wed, 11 Nov 2020 20:04:58 +0100 Message-ID: Subject: Re: [PATCH v9 10/44] kasan: define KASAN_GRANULE_PAGE To: Andrey Konovalov Cc: Alexander Potapenko , Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 11 Nov 2020 at 19:48, Andrey Konovalov wrote: > > On Wed, Nov 11, 2020 at 3:13 PM Alexander Potapenko wrote: > > > > On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov wrote: > > > > > > Define KASAN_GRANULE_PAGE as (KASAN_GRANULE_SIZE << PAGE_SHIFT), which is > > > the same as (KASAN_GRANULE_SIZE * PAGE_SIZE), and use it across KASAN code > > > to simplify it. > > > > What's the physical sense behind KASAN_GRANULE_PAGE? Is it something > > more than just a product of two constants? > > No, just a product. > > > The name suggests it might be something page-sized, but in reality it is not. > > What name would you prefer? Is it actually KASAN_GRANULES_PER_SHADOW_PAGE ? AFAIK we're trying to calculate the granules that we can fit into a page of shadow memory. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E00C5517A for ; Wed, 11 Nov 2020 19:05:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54819206E3 for ; Wed, 11 Nov 2020 19:05:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pLNbPDis"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="IHIZ/9tF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54819206E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9s/xi5w2t1l7m2ojCwwibTZO1jSz8xAmZOg/KsFaLFs=; b=pLNbPDisIH9cWShOUGybRy25r PNiFCJrC7elUeWmP/F7+/VQK6Q07yNKDNFhYVWp3h0AGlJzHBoHlgV6FT2yLO/AkT8d6bCWvQxolE Cyy++vNLLWDzBYKwj3BDxsiE7+1gI4Dokr8HPzNifI48E7hj3ntJRoql14NC2iq0r/1b5mwfv4Y1T A7bxib9JD23YK0qN/RsCQAhWvo9q8btuIVgJx0W4mJGjPyLeDgHzlq4Cc0uLptI3BqBBpgegcxE8t 6g8S81+vMUaymaOZug/4+yuYsbu0U51rtoRvYxFKRqQNllNEAhmKFcm60nCJxI1GP4HvycI+FboPM 2AbTNxWHw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcvQg-0004RU-FU; Wed, 11 Nov 2020 19:05:14 +0000 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcvQd-0004Qj-Ty for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2020 19:05:12 +0000 Received: by mail-ot1-x344.google.com with SMTP id f16so3134312otl.11 for ; Wed, 11 Nov 2020 11:05:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dqQUt8nF2kgPMW+WfpdEe9JIcv1VB4HVulAU3CTX4MU=; b=IHIZ/9tFgR6oUqI2s20AR2vQEbvYVpaiSYLJuPVf3iwe2ZQV1VwFJ9+pAW89ziWPTO 9dlpBiurvBMFq0/RivSJhV1RO9wMucn8oyQ/k8VPIc0KiK+mL+wcfVOwXQAYdACEdDiy Z1EtjzXKr4mVitKEWIKdU9HTi2vZdEXGthD/g42ZTPEfS/pgLTCxhjwev1uXzFhoO+WO 5PC2y9Kp0PNdwULAeFnTowPwEyAVV7srzimiCunf/CzRr+vzc+SoT5gnQGNjiQIxLC9o 5K1alRUaaVRVStwgo/41+Sxg8AIJE0nGGsCWwN6EgKZZ+dsBOyp8oawS5ER6EBBNZ6xY sFVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dqQUt8nF2kgPMW+WfpdEe9JIcv1VB4HVulAU3CTX4MU=; b=o/J8Y/Xuk9EK30UqWBMo1nTRPVEXLdW1K5t/2yBcW9+Q/CFK1/lmIYuUF03pheqOm/ kFQUxxMtzxn+4h2TVyvu21TTuMQs9oqp7WCnMjfxmaZ/lu90Xs8ad4R1VYWFyCYbqT9J EZzl2HATeLeE6IFrTliQQLoKnYPiFPvcF+dcjd/r3Z6193feacz9fXAwNiolrbshfZdE X9wtvcj/qnCPU8Ht7KcZd3S4QPAsvVhZWDOkrAlQgh6CGFdnAnbPMXXmYQOcJpXz/nkC sOnjtNYsZ0337ihPR6Wz7Iyqa3L6UT7gB2swMOBRjb02A+/pJTrJtd4dTrlgRHetgG6b C0/A== X-Gm-Message-State: AOAM533DKnDWMgCIgwB6GErzMNlESWGAzTZgq1hmG+9BxapnibIiCaJ9 tYDVsmKN1F8UfgB1rUr79XU5zJ/81O0TgGHe066JXw== X-Google-Smtp-Source: ABdhPJxXbQWUGNUMQElrxCpcnrSK7G4S7/uSGvEizPe9UE7YdETr/ssdRHzUaHNu9Qf5AnoDXsJutvt7An4JgEB67kk= X-Received: by 2002:a9d:65d5:: with SMTP id z21mr17412658oth.251.1605121509540; Wed, 11 Nov 2020 11:05:09 -0800 (PST) MIME-Version: 1.0 References: <85aba371903b749412fac34e44e54c89e5ddae30.1605046192.git.andreyknvl@google.com> In-Reply-To: From: Marco Elver Date: Wed, 11 Nov 2020 20:04:58 +0100 Message-ID: Subject: Re: [PATCH v9 10/44] kasan: define KASAN_GRANULE_PAGE To: Andrey Konovalov X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201111_140511_994774_794B3B09 X-CRM114-Status: GOOD ( 15.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Branislav Rankov , Catalin Marinas , Kevin Brodsky , Will Deacon , LKML , kasan-dev , Linux Memory Management List , Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 11 Nov 2020 at 19:48, Andrey Konovalov wrote: > > On Wed, Nov 11, 2020 at 3:13 PM Alexander Potapenko wrote: > > > > On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov wrote: > > > > > > Define KASAN_GRANULE_PAGE as (KASAN_GRANULE_SIZE << PAGE_SHIFT), which is > > > the same as (KASAN_GRANULE_SIZE * PAGE_SIZE), and use it across KASAN code > > > to simplify it. > > > > What's the physical sense behind KASAN_GRANULE_PAGE? Is it something > > more than just a product of two constants? > > No, just a product. > > > The name suggests it might be something page-sized, but in reality it is not. > > What name would you prefer? Is it actually KASAN_GRANULES_PER_SHADOW_PAGE ? AFAIK we're trying to calculate the granules that we can fit into a page of shadow memory. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel