From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E153C432C3 for ; Fri, 15 Nov 2019 12:02:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CAD12073C for ; Fri, 15 Nov 2019 12:02:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nVJwYDJC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727485AbfKOMCW (ORCPT ); Fri, 15 Nov 2019 07:02:22 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:34825 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727283AbfKOMCW (ORCPT ); Fri, 15 Nov 2019 07:02:22 -0500 Received: by mail-oi1-f193.google.com with SMTP id n16so8418147oig.2 for ; Fri, 15 Nov 2019 04:02:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RRytg93FU7f6sfBrcqBa/NI8/4Q9Vec4eDf1e8YsiLA=; b=nVJwYDJCtXWgpUbdQGvyEnuFLUcgdoMeKxiPthFRXCdtZdTeFIDBqKZ6+bNhKMXARK FiuRwf09ZIePoP7o/Ki7Hfnl+pJjquU+FvzRQG4URKaKiWDYzrj+CImuhHJEJ2NcFIIn mpboR/iTkoBaC8CDx8OxDvhdd72HtlFQl9ugHgGSp3pFy8Jdcdj3EjJAV3NcXjs4jBGG HcWRqotcj1x+8mz1un8uwKWvI1p5uNiUwHjldbs8fjcRCwN5wBTM7BvtzXYUp0JF//Dd 7I+pJyMn6PlWTucSGO3aGtxcpZVvuzFq6Q9pu+lqZ+6Jy9GBjB21YirKDhsibmAdtSdW QtPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RRytg93FU7f6sfBrcqBa/NI8/4Q9Vec4eDf1e8YsiLA=; b=BspDCTGkf03QejxthTt6pBJ+ClINgQMfkmEKfbBewgYY25d0pHK+vymO3WhG/VKOhD hoxwd1ZXGgZ6oNwQVbUAI0odA+euGQ+ubPIv0xO44HxmFmku00ffWMTAOe4wjdTg77Fu LDSLLpSu7NgjRn9IWXeFspMmL77lj0jUwzyvixlk5Ovcqp5i05MAdkuyk1yAjZp5RnWU KUztGZUcRLhFDqK4F6BjzRL3Zfc+Zu3J7JX6MHYlOmyvcL9PjRcsARmukXz97xXm2Zfl jfZLLdOqZpOjHOHX4aMdZqRFIu5Xxnnf0JqmIaxue1mvfBFOYziFw/DsJF6QeoeV84y6 gIYQ== X-Gm-Message-State: APjAAAXBK/HssVblu2T7afU62RCMOG45l/LsCKoR5qYNgMhXgTPkD8Ye IsvVnkenTU9h4VdcmQDIrSC6+YoaI+7RoZuIoumdwQ== X-Google-Smtp-Source: APXvYqx6zqcXYMp7eFJA/krQ5decJuNJdJO30uNxuNlyEY/pcLWFYr8pgT33say7KL4tYPQxYL+H1c4MsqJbhx+1xvc= X-Received: by 2002:aca:5413:: with SMTP id i19mr7842386oib.121.1573819340279; Fri, 15 Nov 2019 04:02:20 -0800 (PST) MIME-Version: 1.0 References: <20191114180303.66955-1-elver@google.com> <20191114195046.GP2865@paulmck-ThinkPad-P72> <20191114213303.GA237245@google.com> <20191114221559.GS2865@paulmck-ThinkPad-P72> In-Reply-To: <20191114221559.GS2865@paulmck-ThinkPad-P72> From: Marco Elver Date: Fri, 15 Nov 2019 13:02:08 +0100 Message-ID: Subject: Re: [PATCH v4 00/10] Add Kernel Concurrency Sanitizer (KCSAN) To: "Paul E. McKenney" Cc: LKMM Maintainers -- Akira Yokosawa , Alan Stern , Alexander Potapenko , Andrea Parri , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Boqun Feng , Borislav Petkov , Daniel Axtens , Daniel Lustig , Dave Hansen , David Howells , Dmitry Vyukov , "H. Peter Anvin" , Ingo Molnar , Jade Alglave , Joel Fernandes , Jonathan Corbet , Josh Poimboeuf , Luc Maranget , Mark Rutland , Nicholas Piggin , Peter Zijlstra , Thomas Gleixner , Will Deacon , Eric Dumazet , kasan-dev , linux-arch , "open list:DOCUMENTATION" , linux-efi@vger.kernel.org, Linux Kbuild mailing list , LKML , Linux Memory Management List , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Nov 2019 at 23:16, Paul E. McKenney wrote: > > On Thu, Nov 14, 2019 at 10:33:03PM +0100, Marco Elver wrote: > > On Thu, 14 Nov 2019, Paul E. McKenney wrote: > > > > > On Thu, Nov 14, 2019 at 07:02:53PM +0100, Marco Elver wrote: > > > > This is the patch-series for the Kernel Concurrency Sanitizer (KCSAN). > > > > KCSAN is a sampling watchpoint-based *data race detector*. More details > > > > are included in **Documentation/dev-tools/kcsan.rst**. This patch-series > > > > only enables KCSAN for x86, but we expect adding support for other > > > > architectures is relatively straightforward (we are aware of > > > > experimental ARM64 and POWER support). > > > > > > > > To gather early feedback, we announced KCSAN back in September, and have > > > > integrated the feedback where possible: > > > > http://lkml.kernel.org/r/CANpmjNPJ_bHjfLZCAPV23AXFfiPiyXXqqu72n6TgWzb2Gnu1eA@mail.gmail.com > > > > > > > > The current list of known upstream fixes for data races found by KCSAN > > > > can be found here: > > > > https://github.com/google/ktsan/wiki/KCSAN#upstream-fixes-of-data-races-found-by-kcsan > > > > > > > > We want to point out and acknowledge the work surrounding the LKMM, > > > > including several articles that motivate why data races are dangerous > > > > [1, 2], justifying a data race detector such as KCSAN. > > > > > > > > [1] https://lwn.net/Articles/793253/ > > > > [2] https://lwn.net/Articles/799218/ > > > > > > I queued this and ran a quick rcutorture on it, which completed > > > successfully with quite a few reports. > > > > Great. Many thanks for queuing this in -rcu. And regarding merge window > > you mentioned, we're fine with your assumption to targeting the next > > (v5.6) merge window. > > > > I've just had a look at linux-next to check what a future rebase > > requires: > > > > - There is a change in lib/Kconfig.debug and moving KCSAN to the > > "Generic Kernel Debugging Instruments" section seems appropriate. > > - bitops-instrumented.h was removed and split into 3 files, and needs > > re-inserting the instrumentation into the right places. > > > > Otherwise there are no issues. Let me know what you recommend. > > Sounds good! > > I will be rebasing onto v5.5-rc1 shortly after it comes out. My usual > approach is to fix any conflicts during that rebasing operation. > Does that make sense, or would you prefer to send me a rebased stack at > that point? Either way is fine for me. That's fine with me, thanks! To avoid too much additional churn on your end, I just replied to the bitops patch with a version that will apply with the change to bitops-instrumented infrastructure. Also considering the merge window, we had a discussion and there are some arguments for targeting the v5.5 merge window: - we'd unblock ARM and POWER ports; - we'd unblock people wanting to use the data_race macro; - we'd unblock syzbot just tracking upstream; Unless there are strong reasons to not target v5.5, I leave it to you if you think it's appropriate. Thanks, -- Marco From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Elver Subject: Re: [PATCH v4 00/10] Add Kernel Concurrency Sanitizer (KCSAN) Date: Fri, 15 Nov 2019 13:02:08 +0100 Message-ID: References: <20191114180303.66955-1-elver@google.com> <20191114195046.GP2865@paulmck-ThinkPad-P72> <20191114213303.GA237245@google.com> <20191114221559.GS2865@paulmck-ThinkPad-P72> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20191114221559.GS2865@paulmck-ThinkPad-P72> Sender: linux-kernel-owner@vger.kernel.org To: "Paul E. McKenney" Cc: LKMM Maintainers -- Akira Yokosawa , Alan Stern , Alexander Potapenko , Andrea Parri , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Boqun Feng , Borislav Petkov , Daniel Axtens , Daniel Lustig , Dave Hansen , David Howells , Dmitry Vyukov , "H. Peter Anvin" , Ingo Molnar , Jade Alglave , Joel Fernandes , Jonathan Corbet List-Id: linux-arch.vger.kernel.org On Thu, 14 Nov 2019 at 23:16, Paul E. McKenney wrote: > > On Thu, Nov 14, 2019 at 10:33:03PM +0100, Marco Elver wrote: > > On Thu, 14 Nov 2019, Paul E. McKenney wrote: > > > > > On Thu, Nov 14, 2019 at 07:02:53PM +0100, Marco Elver wrote: > > > > This is the patch-series for the Kernel Concurrency Sanitizer (KCSAN). > > > > KCSAN is a sampling watchpoint-based *data race detector*. More details > > > > are included in **Documentation/dev-tools/kcsan.rst**. This patch-series > > > > only enables KCSAN for x86, but we expect adding support for other > > > > architectures is relatively straightforward (we are aware of > > > > experimental ARM64 and POWER support). > > > > > > > > To gather early feedback, we announced KCSAN back in September, and have > > > > integrated the feedback where possible: > > > > http://lkml.kernel.org/r/CANpmjNPJ_bHjfLZCAPV23AXFfiPiyXXqqu72n6TgWzb2Gnu1eA@mail.gmail.com > > > > > > > > The current list of known upstream fixes for data races found by KCSAN > > > > can be found here: > > > > https://github.com/google/ktsan/wiki/KCSAN#upstream-fixes-of-data-races-found-by-kcsan > > > > > > > > We want to point out and acknowledge the work surrounding the LKMM, > > > > including several articles that motivate why data races are dangerous > > > > [1, 2], justifying a data race detector such as KCSAN. > > > > > > > > [1] https://lwn.net/Articles/793253/ > > > > [2] https://lwn.net/Articles/799218/ > > > > > > I queued this and ran a quick rcutorture on it, which completed > > > successfully with quite a few reports. > > > > Great. Many thanks for queuing this in -rcu. And regarding merge window > > you mentioned, we're fine with your assumption to targeting the next > > (v5.6) merge window. > > > > I've just had a look at linux-next to check what a future rebase > > requires: > > > > - There is a change in lib/Kconfig.debug and moving KCSAN to the > > "Generic Kernel Debugging Instruments" section seems appropriate. > > - bitops-instrumented.h was removed and split into 3 files, and needs > > re-inserting the instrumentation into the right places. > > > > Otherwise there are no issues. Let me know what you recommend. > > Sounds good! > > I will be rebasing onto v5.5-rc1 shortly after it comes out. My usual > approach is to fix any conflicts during that rebasing operation. > Does that make sense, or would you prefer to send me a rebased stack at > that point? Either way is fine for me. That's fine with me, thanks! To avoid too much additional churn on your end, I just replied to the bitops patch with a version that will apply with the change to bitops-instrumented infrastructure. Also considering the merge window, we had a discussion and there are some arguments for targeting the v5.5 merge window: - we'd unblock ARM and POWER ports; - we'd unblock people wanting to use the data_race macro; - we'd unblock syzbot just tracking upstream; Unless there are strong reasons to not target v5.5, I leave it to you if you think it's appropriate. Thanks, -- Marco From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05BF1C43141 for ; Fri, 15 Nov 2019 12:02:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C1CCD2073B for ; Fri, 15 Nov 2019 12:02:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nVJwYDJC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1CCD2073B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 550636B0007; Fri, 15 Nov 2019 07:02:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 501666B0008; Fri, 15 Nov 2019 07:02:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F0696B000A; Fri, 15 Nov 2019 07:02:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 28F906B0007 for ; Fri, 15 Nov 2019 07:02:23 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id D2D8B7587 for ; Fri, 15 Nov 2019 12:02:22 +0000 (UTC) X-FDA: 76158374124.11.jump81_31cf9a386281c X-HE-Tag: jump81_31cf9a386281c X-Filterd-Recvd-Size: 7195 Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Nov 2019 12:02:22 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id l202so8430725oig.1 for ; Fri, 15 Nov 2019 04:02:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RRytg93FU7f6sfBrcqBa/NI8/4Q9Vec4eDf1e8YsiLA=; b=nVJwYDJCtXWgpUbdQGvyEnuFLUcgdoMeKxiPthFRXCdtZdTeFIDBqKZ6+bNhKMXARK FiuRwf09ZIePoP7o/Ki7Hfnl+pJjquU+FvzRQG4URKaKiWDYzrj+CImuhHJEJ2NcFIIn mpboR/iTkoBaC8CDx8OxDvhdd72HtlFQl9ugHgGSp3pFy8Jdcdj3EjJAV3NcXjs4jBGG HcWRqotcj1x+8mz1un8uwKWvI1p5uNiUwHjldbs8fjcRCwN5wBTM7BvtzXYUp0JF//Dd 7I+pJyMn6PlWTucSGO3aGtxcpZVvuzFq6Q9pu+lqZ+6Jy9GBjB21YirKDhsibmAdtSdW QtPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RRytg93FU7f6sfBrcqBa/NI8/4Q9Vec4eDf1e8YsiLA=; b=oAaKqI6YwmSt3P7aZ0dEA9WUsDuSA67g3x4U4Z1EmuYGEj1KxGPykHR/d4MGdQjxtU 3OYS8hvdIsGsXBdJIR9kqOERA78DB6P9N3PwZ0hPM/isP7w1B5d81l7mNR7KXlOGiY/K 2rD6n+a2KPmsFmA8CGPSn9ttNqapLeryWkkCdOIi0DyTHOcH9/pH47Xw00g1xpqk9PG8 N6KRM/KM6CO/NVbia5Pg1aPUdVq3S2w3dr24M4/4jcZoS0o9FlSQAfgF4vhVDTbI4maU ivFwJ/4OJVEaYNA2/6TsikDwREaofizRfEe4D3op/qIKnBEB9K3hFI4taNEAtwHJ8M/S Xy9A== X-Gm-Message-State: APjAAAVakh9u7wSjHfaW767ZPFMvQ+HQDvqb/G/T7J272HrLUnlBUJ7B rszi2k+ZajoWLHS8bg/94Oli9q7SDWCi/pdmcscQrQ== X-Google-Smtp-Source: APXvYqx6zqcXYMp7eFJA/krQ5decJuNJdJO30uNxuNlyEY/pcLWFYr8pgT33say7KL4tYPQxYL+H1c4MsqJbhx+1xvc= X-Received: by 2002:aca:5413:: with SMTP id i19mr7842386oib.121.1573819340279; Fri, 15 Nov 2019 04:02:20 -0800 (PST) MIME-Version: 1.0 References: <20191114180303.66955-1-elver@google.com> <20191114195046.GP2865@paulmck-ThinkPad-P72> <20191114213303.GA237245@google.com> <20191114221559.GS2865@paulmck-ThinkPad-P72> In-Reply-To: <20191114221559.GS2865@paulmck-ThinkPad-P72> From: Marco Elver Date: Fri, 15 Nov 2019 13:02:08 +0100 Message-ID: Subject: Re: [PATCH v4 00/10] Add Kernel Concurrency Sanitizer (KCSAN) To: "Paul E. McKenney" Cc: LKMM Maintainers -- Akira Yokosawa , Alan Stern , Alexander Potapenko , Andrea Parri , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Boqun Feng , Borislav Petkov , Daniel Axtens , Daniel Lustig , Dave Hansen , David Howells , Dmitry Vyukov , "H. Peter Anvin" , Ingo Molnar , Jade Alglave , Joel Fernandes , Jonathan Corbet , Josh Poimboeuf , Luc Maranget , Mark Rutland , Nicholas Piggin , Peter Zijlstra , Thomas Gleixner , Will Deacon , Eric Dumazet , kasan-dev , linux-arch , "open list:DOCUMENTATION" , linux-efi@vger.kernel.org, Linux Kbuild mailing list , LKML , Linux Memory Management List , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 14 Nov 2019 at 23:16, Paul E. McKenney wrote: > > On Thu, Nov 14, 2019 at 10:33:03PM +0100, Marco Elver wrote: > > On Thu, 14 Nov 2019, Paul E. McKenney wrote: > > > > > On Thu, Nov 14, 2019 at 07:02:53PM +0100, Marco Elver wrote: > > > > This is the patch-series for the Kernel Concurrency Sanitizer (KCSAN). > > > > KCSAN is a sampling watchpoint-based *data race detector*. More details > > > > are included in **Documentation/dev-tools/kcsan.rst**. This patch-series > > > > only enables KCSAN for x86, but we expect adding support for other > > > > architectures is relatively straightforward (we are aware of > > > > experimental ARM64 and POWER support). > > > > > > > > To gather early feedback, we announced KCSAN back in September, and have > > > > integrated the feedback where possible: > > > > http://lkml.kernel.org/r/CANpmjNPJ_bHjfLZCAPV23AXFfiPiyXXqqu72n6TgWzb2Gnu1eA@mail.gmail.com > > > > > > > > The current list of known upstream fixes for data races found by KCSAN > > > > can be found here: > > > > https://github.com/google/ktsan/wiki/KCSAN#upstream-fixes-of-data-races-found-by-kcsan > > > > > > > > We want to point out and acknowledge the work surrounding the LKMM, > > > > including several articles that motivate why data races are dangerous > > > > [1, 2], justifying a data race detector such as KCSAN. > > > > > > > > [1] https://lwn.net/Articles/793253/ > > > > [2] https://lwn.net/Articles/799218/ > > > > > > I queued this and ran a quick rcutorture on it, which completed > > > successfully with quite a few reports. > > > > Great. Many thanks for queuing this in -rcu. And regarding merge window > > you mentioned, we're fine with your assumption to targeting the next > > (v5.6) merge window. > > > > I've just had a look at linux-next to check what a future rebase > > requires: > > > > - There is a change in lib/Kconfig.debug and moving KCSAN to the > > "Generic Kernel Debugging Instruments" section seems appropriate. > > - bitops-instrumented.h was removed and split into 3 files, and needs > > re-inserting the instrumentation into the right places. > > > > Otherwise there are no issues. Let me know what you recommend. > > Sounds good! > > I will be rebasing onto v5.5-rc1 shortly after it comes out. My usual > approach is to fix any conflicts during that rebasing operation. > Does that make sense, or would you prefer to send me a rebased stack at > that point? Either way is fine for me. That's fine with me, thanks! To avoid too much additional churn on your end, I just replied to the bitops patch with a version that will apply with the change to bitops-instrumented infrastructure. Also considering the merge window, we had a discussion and there are some arguments for targeting the v5.5 merge window: - we'd unblock ARM and POWER ports; - we'd unblock people wanting to use the data_race macro; - we'd unblock syzbot just tracking upstream; Unless there are strong reasons to not target v5.5, I leave it to you if you think it's appropriate. Thanks, -- Marco