All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 46/50] drm: store the gem vma offset manager in a typed pointer
Date: Wed, 11 Dec 2013 11:53:39 +0100	[thread overview]
Message-ID: <CANq1E4R3UK5=pe7LNheX31QkiV_CGx3PRCWp4XLcBQ9tTo3rSA@mail.gmail.com> (raw)
In-Reply-To: <1386758111-3446-47-git-send-email-daniel.vetter@ffwll.ch>

Hi Daniel

On Wed, Dec 11, 2013 at 11:35 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> This was hidden in a generic void * dev->mm_private. But only ever
> used for gem. But thanks to this fake generic pretension no one
> noticed that Rob's drm drivers are now all broken.
>
> So just give the offset manager a type pointer and fix up msm, omapdrm
> and tilcdc.
>
> v2: Fixup compile fail.
>
> Cc: David Herrmann <dh.herrmann@gmail.com>
> Cc: Rob Clark <robdclark@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/drm_gem.c              | 27 ++++++++++++---------------
>  drivers/gpu/drm/gma500/psb_intel_drv.h |  5 -----
>  drivers/gpu/drm/msm/msm_drv.c          |  2 +-
>  drivers/gpu/drm/omapdrm/omap_debugfs.c |  2 +-
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c    |  2 +-
>  include/drm/drmP.h                     | 14 ++++++--------
>  6 files changed, 21 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 4761adedad2a..32525b0a473a 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -91,19 +91,19 @@
>  int
>  drm_gem_init(struct drm_device *dev)
>  {
> -       struct drm_gem_mm *mm;
> +       struct drm_vma_offset_manager *vma_offset_manager;
>
>         mutex_init(&dev->object_name_lock);
>         idr_init(&dev->object_name_idr);
>
> -       mm = kzalloc(sizeof(struct drm_gem_mm), GFP_KERNEL);
> -       if (!mm) {
> +       vma_offset_manager = kzalloc(sizeof(*vma_offset_manager), GFP_KERNEL);
> +       if (!vma_offset_manager) {
>                 DRM_ERROR("out of memory\n");
>                 return -ENOMEM;
>         }
>
> -       dev->mm_private = mm;
> -       drm_vma_offset_manager_init(&mm->vma_manager,
> +       dev->vma_offset_manager = vma_offset_manager;
> +       drm_vma_offset_manager_init(vma_offset_manager,
>                                     DRM_FILE_PAGE_OFFSET_START,
>                                     DRM_FILE_PAGE_OFFSET_SIZE);
>
> @@ -113,11 +113,10 @@ drm_gem_init(struct drm_device *dev)
>  void
>  drm_gem_destroy(struct drm_device *dev)
>  {
> -       struct drm_gem_mm *mm = dev->mm_private;
>
> -       drm_vma_offset_manager_destroy(&mm->vma_manager);
> -       kfree(mm);
> -       dev->mm_private = NULL;
> +       drm_vma_offset_manager_destroy(dev->vma_offset_manager);
> +       kfree(dev->vma_offset_manager);
> +       dev->vma_offset_manager = NULL;
>  }
>
>  /**
> @@ -374,9 +373,8 @@ void
>  drm_gem_free_mmap_offset(struct drm_gem_object *obj)
>  {
>         struct drm_device *dev = obj->dev;
> -       struct drm_gem_mm *mm = dev->mm_private;
>
> -       drm_vma_offset_remove(&mm->vma_manager, &obj->vma_node);
> +       drm_vma_offset_remove(dev->vma_offset_manager, &obj->vma_node);
>  }
>  EXPORT_SYMBOL(drm_gem_free_mmap_offset);
>
> @@ -398,9 +396,8 @@ int
>  drm_gem_create_mmap_offset_size(struct drm_gem_object *obj, size_t size)
>  {
>         struct drm_device *dev = obj->dev;
> -       struct drm_gem_mm *mm = dev->mm_private;
>
> -       return drm_vma_offset_add(&mm->vma_manager, &obj->vma_node,
> +       return drm_vma_offset_add(dev->vma_offset_manager, &obj->vma_node,
>                                   size / PAGE_SIZE);
>  }
>  EXPORT_SYMBOL(drm_gem_create_mmap_offset_size);
> @@ -833,7 +830,6 @@ int drm_gem_mmap(struct file *filp, struct vm_area_struct *vma)
>  {
>         struct drm_file *priv = filp->private_data;
>         struct drm_device *dev = priv->minor->dev;
> -       struct drm_gem_mm *mm = dev->mm_private;
>         struct drm_gem_object *obj;
>         struct drm_vma_offset_node *node;
>         int ret = 0;
> @@ -843,7 +839,8 @@ int drm_gem_mmap(struct file *filp, struct vm_area_struct *vma)
>
>         mutex_lock(&dev->struct_mutex);
>
> -       node = drm_vma_offset_exact_lookup(&mm->vma_manager, vma->vm_pgoff,
> +       node = drm_vma_offset_exact_lookup(dev->vma_offset_manager,
> +                                          vma->vm_pgoff,
>                                            vma_pages(vma));
>         if (!node) {
>                 mutex_unlock(&dev->struct_mutex);
> diff --git a/drivers/gpu/drm/gma500/psb_intel_drv.h b/drivers/gpu/drm/gma500/psb_intel_drv.h
> index bde27fdb41bf..dc2c8eb030fa 100644
> --- a/drivers/gpu/drm/gma500/psb_intel_drv.h
> +++ b/drivers/gpu/drm/gma500/psb_intel_drv.h
> @@ -250,11 +250,6 @@ extern void psb_intel_sdvo_set_hotplug(struct drm_connector *connector,
>  extern int intelfb_probe(struct drm_device *dev);
>  extern int intelfb_remove(struct drm_device *dev,
>                           struct drm_framebuffer *fb);
> -extern struct drm_framebuffer *psb_intel_framebuffer_create(struct drm_device
> -                                                       *dev, struct
> -                                                       drm_mode_fb_cmd
> -                                                       *mode_cmd,
> -                                                       void *mm_private);

Where does that come from?

>  extern bool psb_intel_lvds_mode_fixup(struct drm_encoder *encoder,
>                                       const struct drm_display_mode *mode,
>                                       struct drm_display_mode *adjusted_mode);
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 233246641ae9..177169ce01f0 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -415,7 +415,7 @@ static int msm_gem_show(struct drm_device *dev, struct seq_file *m)
>
>  static int msm_mm_show(struct drm_device *dev, struct seq_file *m)
>  {
> -       return drm_mm_dump_table(m, dev->mm_private);
> +       return drm_mm_dump_table(m, &dev->vma_offset_manager->vm_addr_space_mm);
>  }
>
>  static int msm_fb_show(struct drm_device *dev, struct seq_file *m)
> diff --git a/drivers/gpu/drm/omapdrm/omap_debugfs.c b/drivers/gpu/drm/omapdrm/omap_debugfs.c
> index c27f59da7f29..d4c04d69fc4d 100644
> --- a/drivers/gpu/drm/omapdrm/omap_debugfs.c
> +++ b/drivers/gpu/drm/omapdrm/omap_debugfs.c
> @@ -48,7 +48,7 @@ static int mm_show(struct seq_file *m, void *arg)
>  {
>         struct drm_info_node *node = (struct drm_info_node *) m->private;
>         struct drm_device *dev = node->minor->dev;
> -       return drm_mm_dump_table(m, dev->mm_private);
> +       return drm_mm_dump_table(m, &dev->vma_offset_manager->vm_addr_space_mm);
>  }
>
>  static int fb_show(struct seq_file *m, void *arg)
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 4fad1efbce03..b20b69488dc9 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -444,7 +444,7 @@ static int tilcdc_mm_show(struct seq_file *m, void *arg)
>  {
>         struct drm_info_node *node = (struct drm_info_node *) m->private;
>         struct drm_device *dev = node->minor->dev;
> -       return drm_mm_dump_table(m, dev->mm_private);
> +       return drm_mm_dump_table(m, &dev->vma_offset_manager->vm_addr_space_mm);
>  }
>
>  static struct drm_info_list tilcdc_debugfs_list[] = {
> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
> index 3b946beba2e0..610eb5c221c4 100644
> --- a/include/drm/drmP.h
> +++ b/include/drm/drmP.h
> @@ -601,13 +601,6 @@ struct drm_ati_pcigart_info {
>  };
>
>  /**
> - * GEM specific mm private for tracking GEM objects
> - */
> -struct drm_gem_mm {
> -       struct drm_vma_offset_manager vma_manager;
> -};
> -
> -/**
>   * This structure defines the drm_mm memory object, which will be used by the
>   * DRM for its buffer objects.
>   */
> @@ -972,6 +965,11 @@ struct drm_driver {
>         const struct drm_ioctl_desc *ioctls;
>         int num_ioctls;
>         const struct file_operations *fops;
> +       union {
> +               struct pci_driver *pci;
> +               struct platform_device *platform_device;
> +               struct usb_driver *usb;
> +       } kdriver;

Ugh? I think you got some rebase issues in the series. Otherwise, this
patch looks good.

Thanks
David

>         struct drm_bus *bus;
>
>         /* List of devices hanging off this driver with stealth attach. */
> @@ -1156,7 +1154,6 @@ struct drm_device {
>         struct drm_sg_mem *sg;  /**< Scatter gather memory */
>         unsigned int num_crtcs;                  /**< Number of CRTCs on this device */
>         void *dev_private;              /**< device private data */
> -       void *mm_private;
>         struct address_space *dev_mapping;
>         struct drm_sigdata sigdata;        /**< For block_all_signals */
>         sigset_t sigmask;
> @@ -1174,6 +1171,7 @@ struct drm_device {
>         /*@{ */
>         struct mutex object_name_lock;
>         struct idr object_name_idr;
> +       struct drm_vma_offset_manager *vma_offset_manager;
>         /*@} */
>         int switch_power_state;
>
> --
> 1.8.4.3
>

  reply	other threads:[~2013-12-11 10:53 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11 10:34 [PATCH 00/50] more drm de-midlayering Daniel Vetter
2013-12-11 10:34 ` [PATCH 01/50] drm/rcar: call drm_put_dev directly in the ->remove hook Daniel Vetter
2013-12-11 10:34 ` [PATCH 02/50] drm/exynos: call drm_put_dev directly from ->remove Daniel Vetter
2013-12-11 10:34 ` [PATCH 03/50] drm/imx: directly call drm_put_dev in ->remove Daniel Vetter
2013-12-11 10:34 ` [PATCH 04/50] drm/tilcdc: call drm_put_dev directly from ->remove Daniel Vetter
2013-12-11 19:39   ` Rob Clark
2013-12-11 10:34 ` [PATCH 05/50] drm/omap: call drm_put_dev directly in ->remove Daniel Vetter
2013-12-11 12:02   ` Rob Clark
2013-12-11 13:20     ` [PATCH] " Daniel Vetter
2013-12-11 19:35       ` Rob Clark
2013-12-11 10:34 ` [PATCH 06/50] drm/shmob: call drm_put_dev directly from ->remove hook Daniel Vetter
2013-12-11 12:21   ` Laurent Pinchart
2013-12-11 10:34 ` [PATCH 07/50] drm/armada: directly call drm_put_dev in ->remove Daniel Vetter
2013-12-11 10:34 ` [PATCH 08/50] drm/msm: call drm_put_dev directly " Daniel Vetter
2013-12-11 19:38   ` Rob Clark
2013-12-11 10:34 ` [PATCH 09/50] drm: rip out drm_platform_exit Daniel Vetter
2013-12-11 10:34 ` [PATCH 10/50] drm: restrict the device list for shadow attached drivers Daniel Vetter
2013-12-11 10:34 ` [PATCH 11/50] drm/bufs: remove handling of _DRM_GEM mappings Daniel Vetter
2013-12-11 10:34 ` [PATCH 12/50] drm: kill DRIVER_REQUIRE_AGP Daniel Vetter
2013-12-11 10:34 ` [PATCH 13/50] drm: ->agp_init can't fail Daniel Vetter
2013-12-11 10:34 ` [PATCH 14/50] drm: rip out drm_core_has_AGP Daniel Vetter
2013-12-11 10:34 ` [PATCH 15/50] drm: remove agp_init() bus callback Daniel Vetter
2013-12-11 10:34 ` [PATCH 16/50] drm: inline drm_agp_destroy Daniel Vetter
2013-12-11 10:34 ` [PATCH 17/50] drm: kill the ->agp_destroy callback Daniel Vetter
2013-12-11 10:34 ` [PATCH 18/50] drm: remove global_mutex locking around agp_init Daniel Vetter
2013-12-11 10:34 ` [PATCH 19/50] drm: rip out DRM_AGP_MEM and DRM_AGP_KERN Daniel Vetter
2013-12-11 10:34 ` [PATCH 20/50] drm: Kill DRM_HZ Daniel Vetter
2013-12-11 10:34 ` [PATCH 21/50] drm: Kill DRM_IRQ_ARGS Daniel Vetter
2013-12-11 10:34 ` [PATCH 22/50] drm: Kill DRM_WAKUP and DRM_INIT_WAITQUEUE Daniel Vetter
2013-12-11 10:34 ` [PATCH 23/50] drm: Kill DRM_COPY_(TO|FROM)_USER Daniel Vetter
2013-12-11 10:34 ` [PATCH 24/50] drm: Kill DRM_*MEMORYBARRIER Daniel Vetter
2013-12-11 10:34 ` [PATCH 25/50] drm: Kill DRM_SUSER Daniel Vetter
2013-12-11 10:34 ` [PATCH 26/50] drm/gma500: Remove dead code Daniel Vetter
2013-12-11 10:46   ` Patrik Jakobsson
2013-12-11 10:34 ` [PATCH 27/50] drm/irq: Replace DRM_WAIT_ON with wait_event Daniel Vetter
2013-12-11 10:34 ` [PATCH 28/50] drm: Remove DRM_WAIT_ON from all drivers Daniel Vetter
2013-12-18  1:39   ` Dave Airlie
2013-12-18  8:25     ` Daniel Vetter
2013-12-18  9:37       ` Thomas Hellstrom
2013-12-11 10:34 ` [PATCH 29/50] drm/irq: simplify irq checks in drm_wait_vblank Daniel Vetter
2013-12-12 11:29   ` Thierry Reding
2013-12-12 12:51     ` Daniel Vetter
2013-12-16 10:30   ` [PATCH] " Daniel Vetter
2013-12-16 11:18     ` Thierry Reding
2013-12-11 10:34 ` [PATCH 30/50] drm/pci: fold in irq_by_busid support Daniel Vetter
2013-12-11 10:34 ` [PATCH 31/50] drm/irq: drm_control is a legacy ioctl, so pci devices only Daniel Vetter
2013-12-11 10:34 ` [PATCH 32/50] drm/irq: remove cargo-culted locking from irq_install/unistall Daniel Vetter
2013-12-11 10:34 ` [PATCH 33/50] drm: remove drm_dev_to_irq from drivers Daniel Vetter
2013-12-11 10:34 ` [PATCH 34/50] drm: kill drm_bus->bus_type Daniel Vetter
2013-12-11 10:34 ` [PATCH 35/50] drm: Rip out totally bogus vga_switcheroo->can_switch locking Daniel Vetter
2013-12-11 10:34 ` [PATCH 36/50] drm: rename dev->count_lock to dev->buf_lock Daniel Vetter
2013-12-12 11:33   ` Thierry Reding
2013-12-12 12:52     ` Daniel Vetter
2013-12-16 10:29   ` [PATCH] " Daniel Vetter
2013-12-16 11:17     ` Thierry Reding
2013-12-11 10:34 ` [PATCH 37/50] drm/irq: track the irq installed in drm_irq_install in dev->irq Daniel Vetter
2013-12-16 10:29   ` [PATCH] " Daniel Vetter
2013-12-16 11:17     ` Thierry Reding
2013-12-11 10:34 ` [PATCH 38/50] drm/irq: Look up the pci irq directly in the drm_control ioctl Daniel Vetter
2013-12-11 10:35 ` [PATCH 39/50] drm: pass the irq explicitly to drm_irq_install Daniel Vetter
2013-12-11 10:35 ` [PATCH 40/50] drm: remove bus->get_irq implementations Daniel Vetter
2013-12-11 10:35 ` [PATCH 41/50] drm: inline drm_pci_set_unique Daniel Vetter
2013-12-11 10:35 ` [PATCH 42/50] drm: rip out dev->devname Daniel Vetter
2013-12-11 10:35 ` [PATCH 43/50] drm: remove drm_bus->get_name Daniel Vetter
2013-12-11 10:35 ` [PATCH 44/50] drm: Remove dev->kdriver Daniel Vetter
2013-12-11 10:35 ` [PATCH 45/50] drm/<drivers>: don't set driver->dev_priv_size to 0 Daniel Vetter
2014-01-10 15:25   ` Damien Lespiau
2013-12-11 10:35 ` [PATCH 46/50] drm: store the gem vma offset manager in a typed pointer Daniel Vetter
2013-12-11 10:53   ` David Herrmann [this message]
2013-12-11 13:24     ` [PATCH 1/2] " Daniel Vetter
2013-12-11 13:24       ` [PATCH 2/2] drm/gma500: Remove unused function declaration Daniel Vetter
2013-12-11 16:04         ` Patrik Jakobsson
2013-12-18  1:04       ` [PATCH 1/2] drm: store the gem vma offset manager in a typed pointer Dave Airlie
2013-12-18  1:22         ` Rob Clark
2013-12-11 10:35 ` [PATCH 47/50] drm: rip out dev->ioctl_count tracking Daniel Vetter
2013-12-11 10:35 ` [PATCH 48/50] drm: Kill file_priv->ioctl_count tracking Daniel Vetter
2013-12-11 10:35 ` [PATCH 49/50] drm: remove dev->vma_count Daniel Vetter
2013-12-11 10:35 ` [PATCH 50/50] drm: use memdup_user() as a cleanup Daniel Vetter
2013-12-12 18:08 ` [PATCH 00/50] more drm de-midlayering Jakob Bornecrantz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANq1E4R3UK5=pe7LNheX31QkiV_CGx3PRCWp4XLcBQ9tTo3rSA@mail.gmail.com' \
    --to=dh.herrmann@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --subject='Re: [PATCH 46/50] drm: store the gem vma offset manager in a typed pointer' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.