From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Herrmann <dh.herrmann@gmail.com>
Subject: Re: [PATCH v2 4/4] Documentation: drm: describing plane alpha and
 color blending property
Date: Wed, 26 Mar 2014 13:30:03 +0100
Message-ID: <CANq1E4RZSuut5d_n5GO9tRz5bVYXCLGJfdYn4LGYzjYBfmFk=A@mail.gmail.com>
References: <20140320135151.GO6912@strange.amr.corp.intel.com>
 <1395757947-16492-1-git-send-email-sagar.a.kamble@intel.com>
 <1395757947-16492-4-git-send-email-sagar.a.kamble@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <1395757947-16492-4-git-send-email-sagar.a.kamble@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: sagar.a.kamble@intel.com
Cc: linux-doc@vger.kernel.org, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, vijay.a.purushothaman@intel.com, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, rob@landley.net, Alex Deucher <alexander.deucher@amd.com>, Dave Airlie <airlied@redhat.com>
List-Id: dri-devel@lists.freedesktop.org

Hi

On Tue, Mar 25, 2014 at 3:32 PM,  <sagar.a.kamble@intel.com> wrote:
> From: Sagar Kamble <sagar.a.kamble@intel.com>
>
> v2: Added description for "src-color" and "constant-alpha" property.
>
> Cc: Rob Landley <rob at landley.net>
> Cc: Dave Airlie <airlied at redhat.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> Cc: David Herrmann <dh.herrmann at gmail.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: "Ville Syrj=E4l=E4" <ville.syrjala at linux.intel.com>
> Cc: Sagar Kamble <sagar.a.kamble at intel.com>
> Cc: "Purushothaman, Vijay A" <vijay.a.purushothaman at intel.com>
> Cc: linux-doc at vger.kernel.org
> Cc: dri-devel at lists.freedesktop.org
> Signed-off-by: Sagar Kamble <sagar.a.kamble@intel.com>
> ---
>  Documentation/DocBook/drm.tmpl | 23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.t=
mpl
> index 104402a..77a45fb 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -2253,6 +2253,14 @@ void intel_crt_init(struct drm_device *dev)
>              enumerated bits defined by the property.</para></listitem>
>          </varlistentry>
>          <varlistentry>
> +          <term>DRM_MODE_PROP_32BIT_PAIR</term>
> +          <listitem><para>This flag restricts Bitmask properties restric=
ts all
> +           enumerated values to the 0..31 range.
> +            During get operation instance values combine one or more of =
the
> +            enumerated bits defined by the property. During get user can=
 specify
> +           {type, value} pair.</para></listitem>

Please rewrite that, lots of typos in there. Furthermore, if you use
verbs as nouns, you should emphasize them. So in your text, please
somehow emphasize/quote 'get'.

Thanks
David

> +        </varlistentry>
> +        <varlistentry>
>            <term>DRM_MODE_PROP_BLOB</term>
>            <listitem><para>Blob properties store a binary blob without an=
y format
>              restriction. The binary blobs are created as KMS standalone =
objects,
> @@ -2336,7 +2344,7 @@ void intel_crt_init(struct drm_device *dev)
>         </tr>
>         <tr>
>         <td rowspan=3D"19" valign=3D"top" >DRM</td>
> -       <td rowspan=3D"2" valign=3D"top" >Generic</td>
> +       <td rowspan=3D"3" valign=3D"top" >Generic</td>
>         <td valign=3D"top" >"EDID"</td>
>         <td valign=3D"top" >BLOB | IMMUTABLE</td>
>         <td valign=3D"top" >0</td>
> @@ -2351,6 +2359,19 @@ void intel_crt_init(struct drm_device *dev)
>         <td valign=3D"top" >Contains DPMS operation mode value.</td>
>         </tr>
>         <tr>
> +       <td valign=3D"top" >"blend"</td>
> +       <td valign=3D"top" >BITMASK | 32BIT_PAIR</td>
> +       <td valign=3D"top" >{ {0, "zero"}, {1, "one"}, {2, "src-color"}, =
{3, "one-minus-src-color"}
> +       , {4, "dst-color"}, {5, "one-minus-dst-color"}, {6, "src-alpha"},=
 {7, "one-minus-src-alpha"}, {8, "dst-alpha"}
> +       , {9, "one-minus-dst-alpha"}, {10, "constant-color"}, {11, "one-m=
inus-constant-color"}, {12, "constant-alpha"}
> +       , {13, "one-minus-constant-alpha"}, {14, "alpha-saturate"} }</td>
> +       <td valign=3D"top" >Plane</td>
> +       <td valign=3D"top" >Contains plane alpha/color blending operation=
 values. These are modeled after glBlendFunc API
> +       in OpenGL. Currently only "src-color" and "constant-alpha" are su=
pported. <para>"src-color" will consider supplied fb
> +       with plane's pixel format as input without any additional color/a=
lpha changes.</para><para>"constant-alpha" will apply constant
> +       transparency to all pixels in addition to source color.</para></t=
d>
> +       </tr>
> +       <tr>
>         <td rowspan=3D"2" valign=3D"top" >DVI-I</td>
>         <td valign=3D"top" >"subconnector"</td>
>         <td valign=3D"top" >ENUM</td>
> --
> 1.8.5
>