All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@gmail.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memfd_test: Add missing argument to printf()
Date: Mon, 1 Sep 2014 13:30:55 +0200	[thread overview]
Message-ID: <CANq1E4S+neOh0pQgvrN658iCe9Kmdpv0P9V2HTvrxxy3n+yGVQ@mail.gmail.com> (raw)
In-Reply-To: <1409508006-13136-1-git-send-email-bobby.prani@gmail.com>

Hi

On Sun, Aug 31, 2014 at 8:00 PM, Pranith Kumar <bobby.prani@gmail.com> wrote:
> Add a missing path argument buf to printf()
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>

Looks good:

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Thanks
David

> ---
>  tools/testing/selftests/memfd/memfd_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
> index 3634c90..c343df8 100644
> --- a/tools/testing/selftests/memfd/memfd_test.c
> +++ b/tools/testing/selftests/memfd/memfd_test.c
> @@ -205,7 +205,7 @@ static void mfd_fail_open(int fd, int flags, mode_t mode)
>         sprintf(buf, "/proc/self/fd/%d", fd);
>         r = open(buf, flags, mode);
>         if (r >= 0) {
> -               printf("open(%s) didn't fail as expected\n");
> +               printf("open(%s) didn't fail as expected\n", buf);
>                 abort();
>         }
>  }
> --
> 2.1.0
>

      reply	other threads:[~2014-09-01 11:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-31 18:00 [PATCH] memfd_test: Add missing argument to printf() Pranith Kumar
2014-09-01 11:30 ` David Herrmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANq1E4S+neOh0pQgvrN658iCe9Kmdpv0P9V2HTvrxxy3n+yGVQ@mail.gmail.com \
    --to=dh.herrmann@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bobby.prani@gmail.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.