From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752011AbdECLO5 (ORCPT ); Wed, 3 May 2017 07:14:57 -0400 Received: from mail-yw0-f176.google.com ([209.85.161.176]:35831 "EHLO mail-yw0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbdECLOs (ORCPT ); Wed, 3 May 2017 07:14:48 -0400 MIME-Version: 1.0 In-Reply-To: <20170501194708.GD34444@dtor-ws> References: <20170430051103.703-1-sylph23k@gmail.com> <20170501194708.GD34444@dtor-ws> From: David Herrmann Date: Wed, 3 May 2017 13:14:47 +0200 Message-ID: Subject: Re: [PATCH v7] Input: psxpad-spi - Add PlayStation 1/2 joypads via SPI interface Driver To: Dmitry Torokhov Cc: Tomohiro Yoshidomi , Benjamin Tissoires , "open list:HID CORE LAYER" , linux-kernel , sylph23k@gmail.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey On Mon, May 1, 2017 at 9:47 PM, Dmitry Torokhov wrote: > On Sun, Apr 30, 2017 at 02:11:03PM +0900, Tomohiro Yoshidomi wrote: >> PlayStation 1/2 joypads can be connected directly to the SPI interface. >> >> Signed-off-by: Tomohiro Yoshidomi > > Benjamin, David, I think this driver now matches the gamepad spec that > we have in Drivers/input/gamepad.rst. Could you give it an one-over, as > far as mappings go, otherwise I think it can be applied and merged with > my 2nd pull request. Looks good to me: Acked-by: David Herrmann The FF code could be select'ed rather than conditional. Everything else looks fine. I didn't check the SPI internals though. Never touched SPI, sorry. Thanks David