All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@gmail.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 4/9] drm/core: Add drm_for_each_encoder_mask.
Date: Tue, 24 Nov 2015 19:07:34 +0100	[thread overview]
Message-ID: <CANq1E4TOz2p290A_MGSn42J=Nw2hZ--uA0Gan9rBOd30zw2n0Q@mail.gmail.com> (raw)
In-Reply-To: <87twob5lbk.fsf@intel.com>

Hi

On Tue, Nov 24, 2015 at 7:00 PM, Jani Nikula
<jani.nikula@linux.intel.com> wrote:
> On Tue, 24 Nov 2015, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote:
>> +#define drm_for_each_encoder_mask(encoder, dev, encoder_mask) \
>> +     list_for_each_entry((encoder), &(dev)->mode_config.encoder_list, head) \
>> +             if ((encoder_mask) & (1 << drm_encoder_index(encoder)))
>
> How about
>
>         if (!((encoder_mask) & (1 << drm_encoder_index(encoder)))); else
>
> to avoid dangling else problems?

YES! Please use inverted conditions in macros. Otherwise, looks good to me.

But I think an empty block "{ }" is preferable over the empty
statement. llvm tends to warn about empty statements.

Thanks
David
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-11-24 18:07 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24  9:34 [PATCH 0/9] drm/atomic: Add encoder_mask and connector_mask to crtc_state Maarten Lankhorst
2015-11-24  9:34 ` [PATCH 1/9] drm/i915: Set connector_state->connector correctly Maarten Lankhorst
2015-11-24  9:34 ` [PATCH 2/9] drm/tegra: Assign conn_state->connector when allocating connector state Maarten Lankhorst
2015-11-24  9:37   ` Thierry Reding
2015-11-24 10:37   ` Daniel Vetter
2015-11-24 10:51     ` Thierry Reding
2015-11-24 11:26       ` Maarten Lankhorst
2015-11-24 13:35       ` [PATCH 1/3] drm/i915: Set connector_state->connector using the helper Maarten Lankhorst
2015-11-24 13:35         ` [PATCH 2/3] drm/atomic: Add __drm_atomic_helper_connector_reset Maarten Lankhorst
2015-12-07  9:58           ` Thierry Reding
2015-12-07  9:58           ` Thierry Reding
2015-11-24 13:35         ` [PATCH 3/3] drm/tegra: Use __drm_atomic_helper_reset_connector for subclassing connector state Maarten Lankhorst
2015-12-07 10:02           ` Thierry Reding
2015-12-08  8:13             ` Maarten Lankhorst
2015-11-24  9:34 ` [PATCH 3/9] drm/core: Add drm_encoder_index Maarten Lankhorst
2015-11-24  9:34 ` [PATCH 4/9] drm/core: Add drm_for_each_encoder_mask Maarten Lankhorst
2015-11-24 18:00   ` [Intel-gfx] " Jani Nikula
2015-11-24 18:07     ` David Herrmann [this message]
2015-11-24  9:34 ` [PATCH 5/9] drm/atomic: add connector mask to drm_crtc_state Maarten Lankhorst
2015-12-07 10:24   ` Thierry Reding
2015-11-24  9:34 ` [PATCH 6/9] drm/i915: Update connector_mask during readout Maarten Lankhorst
2015-11-24 10:38   ` Daniel Vetter
2015-11-24 11:30     ` [Intel-gfx] " Maarten Lankhorst
2015-12-07 10:36   ` Thierry Reding
2015-11-24  9:34 ` [PATCH 7/9] drm/atomic: Small documentation fix Maarten Lankhorst
2015-11-24 10:48   ` Daniel Vetter
2015-11-24  9:34 ` [PATCH 8/9] drm/atomic: Remove drm_atomic_connectors_for_crtc Maarten Lankhorst
2015-12-07 10:34   ` Thierry Reding
2015-12-08  8:30     ` Maarten Lankhorst
2015-11-24  9:34 ` [PATCH 9/9] drm/atomic: Add encoder_mask to crtc_state Maarten Lankhorst
2015-12-03  9:53   ` [Intel-gfx] " Daniel Vetter
2015-12-03 11:01     ` Maarten Lankhorst
2015-12-04  8:12       ` [Intel-gfx] " Daniel Vetter
2015-12-14 12:06         ` Maarten Lankhorst
2015-12-15  9:17           ` Daniel Vetter
2015-12-17  9:06             ` Maarten Lankhorst
2015-12-17  9:52               ` [Intel-gfx] " Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANq1E4TOz2p290A_MGSn42J=Nw2hZ--uA0Gan9rBOd30zw2n0Q@mail.gmail.com' \
    --to=dh.herrmann@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.