From mboxrd@z Thu Jan 1 00:00:00 1970 From: Magnus Damm Date: Tue, 03 Sep 2013 15:17:44 +0000 Subject: Re: [PATCH 1/4] ARM: shmobile: r8a7778: add Ether DT support Message-Id: List-Id: References: <87ehb8th3c.wl%kuninori.morimoto.gx@renesas.com> In-Reply-To: <87ehb8th3c.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On Sun, Sep 1, 2013 at 8:15 AM, Sergei Shtylyov wrote: > Define the generic R8A777x part of the Ether device node. > > Signed-off-by: Sergei Shtylyov > > --- > arch/arm/boot/dts/r8a7778.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > Index: renesas/arch/arm/boot/dts/r8a7778.dtsi > =================================> --- renesas.orig/arch/arm/boot/dts/r8a7778.dtsi > +++ renesas/arch/arm/boot/dts/r8a7778.dtsi > @@ -98,4 +98,15 @@ > reg = <0xfffc000 0x118>; > #gpio-range-cells = <3>; > }; > + > + ether: ethernet@fde00000 { > + device_type = "network"; > + compatible = "renesas,ether-r8a7779"; Hi Sergei, Thanks for your patch. What's the reason behind the r8a7778 SoC using a compatible string for r8a7779 like "renesas,ether-r8a7779"? It seems that you assume that the r8a7778 ethernet controller is 100% compatible with r8a7779. Is that really true? For earlier versions the sh_eth hardware documentation was anything but accurate, so it seems to me that it must be more safe that r8a7778 would be using "renesas,ether-r8a7778". What do you think? Thanks, / magnus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Magnus Damm Subject: Re: [PATCH 1/4] ARM: shmobile: r8a7778: add Ether DT support Date: Wed, 4 Sep 2013 00:17:44 +0900 Message-ID: References: <201309010311.05466.sergei.shtylyov@cogentembedded.com> <201309010315.49763.sergei.shtylyov@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <201309010315.49763.sergei.shtylyov@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org To: Sergei Shtylyov Cc: "Simon Horman [Horms]" , SH-Linux , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , ian.campbell@citrix.com, devicetree@vger.kernel.org, Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Sun, Sep 1, 2013 at 8:15 AM, Sergei Shtylyov wrote: > Define the generic R8A777x part of the Ether device node. > > Signed-off-by: Sergei Shtylyov > > --- > arch/arm/boot/dts/r8a7778.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > Index: renesas/arch/arm/boot/dts/r8a7778.dtsi > =================================================================== > --- renesas.orig/arch/arm/boot/dts/r8a7778.dtsi > +++ renesas/arch/arm/boot/dts/r8a7778.dtsi > @@ -98,4 +98,15 @@ > reg = <0xfffc000 0x118>; > #gpio-range-cells = <3>; > }; > + > + ether: ethernet@fde00000 { > + device_type = "network"; > + compatible = "renesas,ether-r8a7779"; Hi Sergei, Thanks for your patch. What's the reason behind the r8a7778 SoC using a compatible string for r8a7779 like "renesas,ether-r8a7779"? It seems that you assume that the r8a7778 ethernet controller is 100% compatible with r8a7779. Is that really true? For earlier versions the sh_eth hardware documentation was anything but accurate, so it seems to me that it must be more safe that r8a7778 would be using "renesas,ether-r8a7778". What do you think? Thanks, / magnus From mboxrd@z Thu Jan 1 00:00:00 1970 From: magnus.damm@gmail.com (Magnus Damm) Date: Wed, 4 Sep 2013 00:17:44 +0900 Subject: [PATCH 1/4] ARM: shmobile: r8a7778: add Ether DT support In-Reply-To: <201309010315.49763.sergei.shtylyov@cogentembedded.com> References: <201309010311.05466.sergei.shtylyov@cogentembedded.com> <201309010315.49763.sergei.shtylyov@cogentembedded.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Sep 1, 2013 at 8:15 AM, Sergei Shtylyov wrote: > Define the generic R8A777x part of the Ether device node. > > Signed-off-by: Sergei Shtylyov > > --- > arch/arm/boot/dts/r8a7778.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > Index: renesas/arch/arm/boot/dts/r8a7778.dtsi > =================================================================== > --- renesas.orig/arch/arm/boot/dts/r8a7778.dtsi > +++ renesas/arch/arm/boot/dts/r8a7778.dtsi > @@ -98,4 +98,15 @@ > reg = <0xfffc000 0x118>; > #gpio-range-cells = <3>; > }; > + > + ether: ethernet at fde00000 { > + device_type = "network"; > + compatible = "renesas,ether-r8a7779"; Hi Sergei, Thanks for your patch. What's the reason behind the r8a7778 SoC using a compatible string for r8a7779 like "renesas,ether-r8a7779"? It seems that you assume that the r8a7778 ethernet controller is 100% compatible with r8a7779. Is that really true? For earlier versions the sh_eth hardware documentation was anything but accurate, so it seems to me that it must be more safe that r8a7778 would be using "renesas,ether-r8a7778". What do you think? Thanks, / magnus