From: Gerhard Engleder <gerhard@engleder-embedded.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: yangbo.lu@nxp.com, David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
mlichvar@redhat.com,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v1 2/6] ptp: Request cycles for TX timestamp
Date: Thu, 24 Mar 2022 20:43:44 +0100 [thread overview]
Message-ID: <CANr-f5wrm7ASB61-rR9VPF5ePYC4gb4W-1rM5Ym7TixwMQv_Jw@mail.gmail.com> (raw)
In-Reply-To: <20220324134934.GB27824@hoboy.vegasvil.org>
> > @@ -683,9 +683,17 @@ void __sock_tx_timestamp(__u16 tsflags, __u8 *tx_flags)
> > {
> > u8 flags = *tx_flags;
> >
> > - if (tsflags & SOF_TIMESTAMPING_TX_HARDWARE)
> > + if (tsflags & SOF_TIMESTAMPING_TX_HARDWARE) {
> > flags |= SKBTX_HW_TSTAMP;
> >
> > + /* PTP hardware clocks can provide a free running time called
> > + * cycles as base for virtual clocks.
>
> "PTP hardware clocks can provide a free running cycle counter as a
> time base for virtual clocks."
I'll use your wording here. I'll also update other comments and commit messages
with this wording.
Thanks,
Gerhard
next prev parent reply other threads:[~2022-03-24 19:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 21:07 [PATCH net-next v1 0/6] ptp: Support hardware clocks with additional free running time Gerhard Engleder
2022-03-22 21:07 ` [PATCH net-next v1 1/6] ptp: Add cycles support for virtual clocks Gerhard Engleder
2022-03-24 13:43 ` Richard Cochran
2022-03-24 19:39 ` Gerhard Engleder
2022-03-22 21:07 ` [PATCH net-next v1 2/6] ptp: Request cycles for TX timestamp Gerhard Engleder
2022-03-24 13:49 ` Richard Cochran
2022-03-24 13:55 ` Miroslav Lichvar
2022-03-24 19:43 ` Gerhard Engleder [this message]
2022-03-22 21:07 ` [PATCH net-next v1 3/6] ptp: Pass hwtstamp to ptp_convert_timestamp() Gerhard Engleder
2022-03-24 13:50 ` Richard Cochran
2022-03-22 21:07 ` [PATCH net-next v1 4/6] ethtool: Add kernel API for PHC index Gerhard Engleder
2022-03-24 13:51 ` Richard Cochran
2022-03-22 21:07 ` [PATCH net-next v1 5/6] ptp: Support late timestamp determination Gerhard Engleder
2022-03-23 0:54 ` kernel test robot
2022-03-23 1:05 ` kernel test robot
2022-03-23 2:06 ` kernel test robot
2022-03-24 14:01 ` Richard Cochran
2022-03-24 19:52 ` Gerhard Engleder
2022-03-25 0:04 ` Richard Cochran
2022-03-25 0:08 ` Richard Cochran
2022-03-25 20:51 ` Gerhard Engleder
2022-03-26 0:27 ` Vinicius Costa Gomes
2022-03-22 21:07 ` [PATCH net-next v1 6/6] tsnep: Add physical clock cycles support Gerhard Engleder
2022-03-25 0:01 ` [PATCH net-next v1 0/6] ptp: Support hardware clocks with additional free running time Vinicius Costa Gomes
2022-03-25 22:01 ` Gerhard Engleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANr-f5wrm7ASB61-rR9VPF5ePYC4gb4W-1rM5Ym7TixwMQv_Jw@mail.gmail.com \
--to=gerhard@engleder-embedded.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vinicius.gomes@intel.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.