All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Hershberger <joe.hershberger@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/8] drivers: net: phy: micrel: fix build errors with CONFIG_DM_ETH
Date: Fri, 22 Jan 2016 13:54:14 -0600	[thread overview]
Message-ID: <CANr=Z=Y7jVZptbiVCJ1Mx4UCDEy5q3LdkHsWesmeEJ00SpCYnw@mail.gmail.com> (raw)
In-Reply-To: <1453451002-21444-3-git-send-email-mugunthanvnm@ti.com>

On Fri, Jan 22, 2016 at 2:23 AM, Mugunthan V N <mugunthanvnm@ti.com> wrote:
> When Micrel phy is selected without CONFIG_PHY_MICREL_KSZ9031 or
> CONFIG_PHY_MICREL_KSZ9021 there  is a build error. Fixing this
> by adding proper ifdefs
>
> drivers/net/phy/micrel.c:370:39: error: array type has incomplete element type
>  static const struct ksz90x1_reg_field ksz9031_ctl_grp[] =
>                                        ^
> drivers/net/phy/micrel.c:372:39: error: array type has incomplete element type
>  static const struct ksz90x1_reg_field ksz9031_clk_grp[] =
>                                        ^
> drivers/net/phy/micrel.c: In function ?ksz9031_of_config?:
> drivers/net/phy/micrel.c:377:23: error: array type has incomplete element type
>   struct ksz90x1_ofcfg ofcfg[] = {
>                        ^
> drivers/net/phy/micrel.c:379:13: error: ?ksz90x1_rxd_grp? undeclared (first use in this function)
>    { MII_KSZ9031_EXT_RGMII_RX_DATA_SKEW, 2, ksz90x1_rxd_grp, 4 },
>              ^
> drivers/net/phy/micrel.c:379:13: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/phy/micrel.c:380:13: error: ?ksz90x1_txd_grp? undeclared (first use in this function)
>    { MII_KSZ9031_EXT_RGMII_TX_DATA_SKEW, 2, ksz90x1_txd_grp, 4 },
>              ^
> drivers/net/phy/micrel.c:386:3: warning: implicit declaration of function ?ksz90x1_of_config_group? [-Wimplicit-function-declaration]
>    ret = ksz90x1_of_config_group(phydev, &(ofcfg[i]));
>    ^
> drivers/net/phy/micrel.c:377:23: warning: unused variable ?ofcfg? [-Wunused-variable]
>   struct ksz90x1_ofcfg ofcfg[] = {
>                        ^
> drivers/net/phy/micrel.c: At top level:
> drivers/net/phy/micrel.c:370:39: warning: ?ksz9031_ctl_grp? defined but not used [-Wunused-variable]
>  static const struct ksz90x1_reg_field ksz9031_ctl_grp[] =
>                                        ^
> drivers/net/phy/micrel.c:372:39: warning: ?ksz9031_clk_grp? defined but not used [-Wunused-variable]
>  static const struct ksz90x1_reg_field ksz9031_clk_grp[] =
>                                        ^
> scripts/Makefile.build:277: recipe for target 'drivers/net/phy/micrel.o' failed
> make[1]: *** [drivers/net/phy/micrel.o] Error 1
> Makefile:1201: recipe for target 'drivers/net/phy' failed
> make: *** [drivers/net/phy] Error 2
> make: *** Waiting for unfinished jobs....
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

  reply	other threads:[~2016-01-22 19:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-22  8:23 [U-Boot] [PATCH v2 0/8] driver model bring-up of keystone net on k2hk, k2l, k2e and k2g evm Mugunthan V N
2016-01-22  8:23 ` [U-Boot] [PATCH v2 1/8] board: ti: ks2_evm: remove board_eth_init when CONFIG_DM_ETH is defined Mugunthan V N
2016-01-22 19:53   ` Joe Hershberger
2016-01-22  8:23 ` [U-Boot] [PATCH v2 2/8] drivers: net: phy: micrel: fix build errors with CONFIG_DM_ETH Mugunthan V N
2016-01-22 19:54   ` Joe Hershberger [this message]
2016-01-22  8:23 ` [U-Boot] [PATCH v2 3/8] drivers: net: keystone_net: convert driver to adopt device driver model Mugunthan V N
2016-01-22 20:15   ` Joe Hershberger
2016-01-25  8:30     ` Mugunthan V N
2016-01-25  8:35   ` Bin Meng
2016-01-25 10:10     ` Mugunthan V N
2016-01-22  8:23 ` [U-Boot] [PATCH v2 4/8] defconfig: k2hk_evm_defconfig: enable net " Mugunthan V N
2016-01-22 20:15   ` Joe Hershberger
2016-01-22  8:23 ` [U-Boot] [PATCH v2 5/8] defconfig: k2l_evm_defconfig: " Mugunthan V N
2016-01-22 20:16   ` Joe Hershberger
2016-01-22  8:23 ` [U-Boot] [PATCH v2 6/8] defconfig: k2e_evm_defconfig: " Mugunthan V N
2016-01-22 20:16   ` Joe Hershberger
2016-01-22  8:23 ` [U-Boot] [PATCH v2 7/8] ARM: dts: k2g: Add keystone net dts files Mugunthan V N
2016-01-22 20:17   ` Joe Hershberger
2016-01-22  8:23 ` [U-Boot] [PATCH v2 8/8] defconfig: k2g_evm_defconfig: enable net driver model Mugunthan V N
2016-01-22 20:17   ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANr=Z=Y7jVZptbiVCJ1Mx4UCDEy5q3LdkHsWesmeEJ00SpCYnw@mail.gmail.com' \
    --to=joe.hershberger@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.