From: Joe Hershberger <joe.hershberger@ni.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] net: ping, arp: Fix cache alignment issues
Date: Fri, 8 Jun 2018 15:55:26 -0500 [thread overview]
Message-ID: <CANr=Z=YeEV1fiE-Qei2mCp2nni_cJTyVxBfQ0-rZM5pYs7=F2g@mail.gmail.com> (raw)
In-Reply-To: <1c55b2ef764fd213e69367c79ead7b5294dbd13a.1527659550.git.baruch@tkos.co.il>
On Wed, May 30, 2018 at 12:52 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> From: Jon Nettleton <jon@solid-run.com>
>
> Both ping_receive and arp_receive would transmit a received packet
> back out using its original point. This causes problems with
> certain network cards that add a custom header to the packet.
> Specifically the mvneta driver for the Armada series boards has
> a 2 byte Marvell header that is bypassed and passed along to
> the system, but that 2 byte offset now causes a misalignment if
> it is attempted to be sent back out.
>
> Rather than changing the driver to memcpy all the received packets
> to cache aligned buffers we instead change the two offending
> network commands to copy the packet into a cache aligned net_tx_packet
> before sending it back out.
It seems reasonable to make these match the rest of the network commands.
> This fixes occasional messages like:
>
> CACHE: Misaligned operation at range [3fc01082, 3fc010c2]
>
> Reviewed-by: Stefan Roese <sr@denx.de>
> Signed-off-by: Jon Nettleton <jon@solid-run.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
next prev parent reply other threads:[~2018-06-08 20:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 5:52 [U-Boot] [PATCH v2 1/2] mvebu: neta: align DMA buffers Baruch Siach
2018-05-30 5:52 ` [U-Boot] [PATCH v2 2/2] net: ping,arp: Fix cache alignment issues Baruch Siach
2018-06-08 20:55 ` Joe Hershberger [this message]
2018-06-08 20:56 ` [U-Boot] [PATCH v2 1/2] mvebu: neta: align DMA buffers Joe Hershberger
2018-06-13 19:02 ` [U-Boot] " Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANr=Z=YeEV1fiE-Qei2mCp2nni_cJTyVxBfQ0-rZM5pYs7=F2g@mail.gmail.com' \
--to=joe.hershberger@ni.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.