All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Hershberger <joe.hershberger@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: smsc95xx: fix DM MAC address reading
Date: Fri, 23 Sep 2016 12:43:39 -0500	[thread overview]
Message-ID: <CANr=Z=YifZt2XPZgcd7qoDmg=jxUqxOwJ1nN4W2AzJY-p2ZGwA@mail.gmail.com> (raw)
In-Reply-To: <a55ac173-c7f0-3de8-a0bf-a8515affd456@wwwdotorg.org>

On Fri, Sep 23, 2016 at 11:31 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 09/15/2016 01:20 PM, Joe Hershberger wrote:
>>
>> On Thu, Sep 15, 2016 at 1:53 PM, Stephen Warren <swarren@wwwdotorg.org>
>> wrote:
>>>
>>> From: Stephen Warren <swarren@nvidia.com>
>>>
>>> eth-uclass.c expects DM-capable Ethernet adapters to implement ops->
>>> read_rom_hwaddr(), or for some other mechanism to set pdata->enetaddr, or
>>> for the user to set environment variable $usbethaddr. Without any of
>>> these, it will refuse to initialize the device since no valid MAC address
>>> is known. Implement this function for the smsc95xx driver.
>>>
>>> With this feature implemented, there is no point smsc95xx_init_common()
>>> re-reading the MAC address from ROM, so ifdef out this code when DM_ETH
>>> is enabled.
>>>
>>> This allows (at least) the built-in Ethernet on the NVIDIA Harmony board
>>> to operate again.
>>>
>>> Fixes: 0990fcb77219 ("net: smsc95xx: Add driver-model support")
>>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>>
>>
>> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>
>
> Joe, was that ack just so you remember you've reviewed this when you come to
> applying patches later, or was it a signal to someone else that they should
> apply it?

No, I'll pull it in.

Cheers,
-Joe

  reply	other threads:[~2016-09-23 17:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 18:53 [U-Boot] [PATCH] net: smsc95xx: fix DM MAC address reading Stephen Warren
2016-09-15 19:20 ` Joe Hershberger
2016-09-23 16:31   ` Stephen Warren
2016-09-23 17:43     ` Joe Hershberger [this message]
2016-10-10 16:07       ` Stephen Warren
2016-10-12  0:07         ` Joe Hershberger
2016-10-13 17:39 ` [U-Boot] " Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANr=Z=YifZt2XPZgcd7qoDmg=jxUqxOwJ1nN4W2AzJY-p2ZGwA@mail.gmail.com' \
    --to=joe.hershberger@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.