[PATCH v2 00/12] phy: atheros: dt bindings and cleanup

From: Joe Hershberger <joe.hershberger@ni.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 00/12] phy: atheros: dt bindings and cleanup
Date: Tue, 10 Mar 2020 12:46:36 -0500	[thread overview]
Message-ID: <CANr=Z=YnBACGTw9B1CGXBbT3b11zVhQF=JzVZBu-eTa_h=aQew@mail.gmail.com> (raw)
In-Reply-To: <930e70b709fd0a6eb40108faac1d9bfd@walle.cc>

Hi Michael,

On Tue, Jan 7, 2020 at 5:07 AM Michael Walle <michael@walle.cc> wrote:
>
> Hi all,
>
> Am 2019-12-05 23:57, schrieb Michael Walle:
> > [RESEND because I've forgot to add the mailinglist. Sorry!]
> >
> > This patch series superseeds the following two:
> > From Vladimir Oltean
> >   https://patchwork.ozlabs.org/cover/1031360/
> > From me:
> >   https://patchwork.ozlabs.org/cover/1184507/
> >
> > Although the first is marked as accepted into u-boot-net I guess it was
> > removed due to broken boards ("DT as ABI", RGMII delay was fixed and
> > thus
> > breaks the board).
> >
> > After disussing with Vladimir, I've integrated his patches with this
> > series. Also the first one
> >   Address packet drops at low traffic rate due to SmartEEE feature
> > was dropped because it will likely be fixed by making u-boot support
> > the
> > eee-broken-X device tree properties. Apart from that, only the subject
> > was
> > changed and a note about possible board breakage was added the patch
> > which
> > changes the delay behaviour.
> >
> > For all of those, who will test this patchset, the device tree binding
> > needs the phydev->node property, which needs to be set in every network
> > driver. If the device tree binding is not working for you have a look
> > at
> > the
> >   ar803x_of_init: found PHY node: phy at 0
> > output. In the case above "phy at 0" is the phy node in the device tree.
> > If
> > instead the node of your network device is displayed, you have to set
> > the phydev->node property in your network device driver.
> >
> > For the fsl_enetc driver this patchset will add it:
> >   https://patchwork.ozlabs.org/cover/1188043/
>
> ping :)
>
> would be cool to have that merged in the current window.

I tried to merge in the current window, but it broke some boards.

https://travis-ci.org/jhershbe/u-boot/builds/660395885

Please have a look and send a new version that passes those builds.

Thanks,
-Joe

> -michael
>
>
>
> >
> > changes since v1:
> >  - pull all Vladimirs Oltan's patches and rebase mine onto them
> >  - fix the CLK_25M settings for the AR8035
> >  - add two new patches "fix AR8021 PHY ID mask" and "use defines for
> > PHY
> >    IDs"
> >  - use the new kernel device tree binding for the AR803x PHYs:
> >    https://patchwork.ozlabs.org/patch/1188293/
> >  - add debugging output
> >
> > Michael Walle (7):
> >   phy: atheros: fix AR8021 PHY ID mask
> >   phy: atheros: use defines for PHY IDs
> >   phy: atheros: introduce debug read and write functions
> >   phy: atheros: move delay config to common function
> >   phy: atheros: add device tree bindings and config
> >   phy: atheros: ar8035: remove static clock config
> >   phy: atheros: consolidate {ar8031|ar8035}_config()
> >
> > Vladimir Oltean (5):
> >   phy: atheros: Make RGMII Tx delays actually configurable for AR8035
> >   phy: atheros: Use common functions for RGMII internal delays
> >   phy: atheros: Clarify the configuration of the CLK_25M output pin
> >   phy: atheros: Explicitly disable RGMII delays
> >   phy: atheros: Clarify the intention of ar8021_config
> >
> >  doc/device-tree-bindings/net/phy/atheros.txt |  35 ++
> >  drivers/net/phy/atheros.c                    | 349 ++++++++++++++++---
> >  include/dt-bindings/net/qca-ar803x.h         |  13 +
> >  3 files changed, 344 insertions(+), 53 deletions(-)
> >  create mode 100644 doc/device-tree-bindings/net/phy/atheros.txt
> >  create mode 100644 include/dt-bindings/net/qca-ar803x.h