From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Hershberger Date: Tue, 10 Mar 2020 12:44:52 -0500 Subject: [PATCH] net: eth-uclass: Do not return error when no MAC is found In-Reply-To: <20200109182802.26121-1-festevam@gmail.com> References: <20200109182802.26121-1-festevam@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Fabio, On Thu, Jan 9, 2020 at 12:29 PM Fabio Estevam wrote: > > On some i.MX8QXP MEK boards with no MAC address stored, the following > hang is seen: > > Error: ethernet at 5b040000 address not set. > > (Board hangs) > > One way to avoid this issue is to select CONFIG_NET_RANDOM_ETHADDR, so > that a random MAC is provided and boot proceeds, but the lack of MAC > should not hang the entire system. > > Fix the hang by removing the propagation of error when no MAC is found. > > In this case there are already messages indicating that something > is not correct: > > Error: ethernet at 5b040000 address not set. > > Error: ethernet at 5b040000 address 00:00:00:00:00:00 illegal value > eth0: ethernet at 5b040000 > Error: ethernet at 5b040000 address 00:00:00:00:00:00 illegal value > > Signed-off-by: Fabio Estevam I tried to apply this but it breaks the unit tests. I guess you didn't try "ut dm" in sandbox? https://travis-ci.org/jhershbe/u-boot/builds/660395782 Please test those and update the tests to pass with your change. Thanks, -Joe