From: Joe Hershberger <joe.hershberger@ni.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2] net: zynq_gem: Do not return -ENOSYS on success
Date: Tue, 4 Apr 2017 12:53:23 -0500 [thread overview]
Message-ID: <CANr=Z=Z+aF5rR8CUbM3sQk20Qyo2OB6WXX-bQK5T_tUvV+xfAw@mail.gmail.com> (raw)
In-Reply-To: <20170403141853.11574-1-oliver@schinagl.nl>
On Mon, Apr 3, 2017 at 9:18 AM, Olliver Schinagl <oliver@schinagl.nl> wrote:
>
> The .read_rom_hwaddr net_ops hook does not check the return value, which
> is why it was never caught that we are currently returning 0 if the
> read_rom_hwaddr function return -ENOSYS and -ENOSYS otherwise.
>
> In this case we can simplify this by just returning the result of the
> function.
>
> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
next prev parent reply other threads:[~2017-04-04 17:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 14:18 [U-Boot] [PATCHv2] net: zynq_gem: Do not return -ENOSYS on success Olliver Schinagl
2017-04-04 17:53 ` Joe Hershberger [this message]
2017-04-05 9:17 ` Michal Simek
2017-04-10 22:17 ` Joe Hershberger
2017-04-05 6:29 ` Michal Simek
2017-04-05 9:14 ` Olliver Schinagl
2017-06-02 19:48 ` [U-Boot] " Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANr=Z=Z+aF5rR8CUbM3sQk20Qyo2OB6WXX-bQK5T_tUvV+xfAw@mail.gmail.com' \
--to=joe.hershberger@ni.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.