All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Hershberger <joe.hershberger@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] net: rename and refactor eth_rand_ethaddr() function
Date: Thu, 17 Apr 2014 03:08:36 -0500	[thread overview]
Message-ID: <CANr=Z=ZR_H2Nvv6PWhXta6v+U=Dh1WVJWZZh4Cu=sNDezz-mnQ@mail.gmail.com> (raw)
In-Reply-To: <1397721632-18797-3-git-send-email-yamada.m@jp.panasonic.com>

On Thu, Apr 17, 2014 at 3:00 AM, Masahiro Yamada <yamada.m@jp.panasonic.com>
wrote:
>
> Some functions in include/net.h are ported from
> include/linux/etherdevice.h of Linux Kernel.
>
> For ex.
>   is_zero_ether_addr()
>   is_multicast_ether_addr()
>   is_broadcast_ether_addr()
>   is_valid_ether_addr();
>
> So, we should use the same function name as Linux Kernel,
> eth_rand_addr(), for consistency.
>
> Because eth_rand_addr() is impilemented as inline function,
> it should not be surrounded by ifdef CONFIG_RANDOM_MACADDR.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

  reply	other threads:[~2014-04-17  8:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-17  8:00 [U-Boot] [PATCH 0/5] Do not use __DATE__ and __TIME__ anymore Masahiro Yamada
2014-04-17  8:00 ` [U-Boot] [PATCH 1/5] rand: do not surround function declarations by #ifdef Masahiro Yamada
2014-04-17  8:00 ` [U-Boot] [PATCH 2/5] net: rename and refactor eth_rand_ethaddr() function Masahiro Yamada
2014-04-17  8:08   ` Joe Hershberger [this message]
2014-04-17 11:09   ` Wolfgang Denk
2014-04-17  8:00 ` [U-Boot] [PATCH 3/5] blackfin: replace bfin_gen_rand_mac() with eth_random_addr() Masahiro Yamada
2014-04-17 19:07   ` Mike Frysinger
2014-04-18  9:25     ` Masahiro Yamada
2014-04-17  8:00 ` [U-Boot] [PATCH 4/5] fs: ubifs: drop __DATE__ and __TIME__ Masahiro Yamada
2014-04-17  8:00 ` [U-Boot] [PATCH 5/5] kbuild: build with -Werror=date-time if the compiler supports it Masahiro Yamada
2014-04-17 11:07 ` [U-Boot] [PATCH 0/5] Do not use __DATE__ and __TIME__ anymore Wolfgang Denk
2014-04-17 11:41   ` Masahiro Yamada
2014-04-17 14:48     ` Wolfgang Denk
2014-04-17 19:10 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANr=Z=ZR_H2Nvv6PWhXta6v+U=Dh1WVJWZZh4Cu=sNDezz-mnQ@mail.gmail.com' \
    --to=joe.hershberger@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.