From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Hershberger Date: Mon, 10 Apr 2017 17:17:44 -0500 Subject: [U-Boot] [PATCHv2] net: zynq_gem: Do not return -ENOSYS on success In-Reply-To: References: <20170403141853.11574-1-oliver@schinagl.nl> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Michal, On Wed, Apr 5, 2017 at 4:17 AM, Michal Simek wrote: > On 4.4.2017 19:53, Joe Hershberger wrote: >> On Mon, Apr 3, 2017 at 9:18 AM, Olliver Schinagl wrote: >>> >>> The .read_rom_hwaddr net_ops hook does not check the return value, which >>> is why it was never caught that we are currently returning 0 if the >>> read_rom_hwaddr function return -ENOSYS and -ENOSYS otherwise. >>> >>> In this case we can simplify this by just returning the result of the >>> function. >>> >>> Signed-off-by: Olliver Schinagl >> >> Acked-by: Joe Hershberger >> > > Acked-by: Michal Simek > > Joe: Can you please take this via your tree? Will do. -Joe