All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Hershberger <joe.hershberger@ni.com>
To: u-boot@lists.denx.de
Subject: [PATCH] net: eth-uclass: Do not return error when no MAC is found
Date: Thu, 5 Mar 2020 17:21:44 -0600	[thread overview]
Message-ID: <CANr=Z=a8VDxLq1c3RxxyEaz6ZQrOi0Nz4NfJ3WS26Dih8ioGvA@mail.gmail.com> (raw)
In-Reply-To: <20200109182802.26121-1-festevam@gmail.com>

On Thu, Jan 9, 2020 at 12:29 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> On some i.MX8QXP MEK boards with no MAC address stored, the following
> hang is seen:
>
> Error: ethernet at 5b040000 address not set.
>
> (Board hangs)
>
> One way to avoid this issue is to select CONFIG_NET_RANDOM_ETHADDR, so
> that a random MAC is provided and boot proceeds, but the lack of MAC
> should not hang the entire system.
>
> Fix the hang by removing the propagation of error when no MAC is found.
>
> In this case there are already messages indicating that something
> is not correct:
>
> Error: ethernet at 5b040000 address not set.
>
> Error: ethernet at 5b040000 address 00:00:00:00:00:00 illegal value
> eth0: ethernet at 5b040000
> Error: ethernet at 5b040000 address 00:00:00:00:00:00 illegal value
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

  parent reply	other threads:[~2020-03-05 23:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09 18:28 [PATCH] net: eth-uclass: Do not return error when no MAC is found Fabio Estevam
2020-02-13 18:42 ` Fabio Estevam
2020-03-05 23:21 ` Joe Hershberger [this message]
2020-03-10 17:44 ` Joe Hershberger
2020-03-10 18:34   ` Fabio Estevam
2020-03-11 17:14     ` Joe Hershberger
2020-03-11 17:19       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANr=Z=a8VDxLq1c3RxxyEaz6ZQrOi0Nz4NfJ3WS26Dih8ioGvA@mail.gmail.com' \
    --to=joe.hershberger@ni.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.