All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Hershberger <joe.hershberger@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] FIT: use default configuration, if given configuration is not found
Date: Tue, 12 May 2015 15:18:50 -0500	[thread overview]
Message-ID: <CANr=Z=aN2Yj+hyNths1+Gq0WfS8NdKQx_OQhA0Z0RAibB7ot7w@mail.gmail.com> (raw)
In-Reply-To: <CAGm1_kswvKBjSnCjBw8sC4KMGhMFK8mkHgqgcWwQLvqcxXz8cQ@mail.gmail.com>

Hi Yegor,

On Tue, May 12, 2015 at 1:43 AM, Yegor Yefremov
<yegorslists@googlemail.com> wrote:
> Hi Joe,
>
> On Mon, May 4, 2015 at 8:16 PM, Joe Hershberger
> <joe.hershberger@gmail.com> wrote:
>> Hi Yegor,
>>
>> On Mon, May 4, 2015 at 2:53 AM,  <yegorslists@googlemail.com> wrote:
>>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>>
>>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>>> ---
>>>  common/image-fit.c |    4 ++++
>>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/common/image-fit.c b/common/image-fit.c
>>> index c61be65..b892d06 100644
>>> --- a/common/image-fit.c
>>> +++ b/common/image-fit.c
>>> @@ -1547,6 +1547,10 @@ int fit_image_load(bootm_headers_t *images, ulong addr,
>>>                 } else {
>>>                         cfg_noffset = fit_conf_get_node(fit,
>>>                                                         fit_uname_config);
>>> +
>>> +                       if (cfg_noffset < 0) {
>>> +                               cfg_noffset = fit_conf_get_node(fit, NULL);
>>> +                       }
>>
>> It seems if you ask for a specific configuration that is not
>> available, you should get an error.
>>
>> You can accomplish similar behavior you are implementing here by using
>> the shell to try the default if the specified one returns an error.
>
> Thanks. It is working:
>
> bootm ${loadaddr}#conf${board_name}; if test $? -ne 0; then echo
> "Using default FIT configuration"; bootm ${loadaddr}; fi;

Great!

> Now I have another question, how can I split long line in uEnv.txt? Is
> it possible at all?

I assume you are loading it and eventually calling env import on the memory?

Have you tried passing the -t switch to the env import command?

Or are you talking about a single variable value that is a long line?

-Joe

  reply	other threads:[~2015-05-12 20:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04  7:53 [U-Boot] FIT: workarounding wrong configuration name yegorslists at googlemail.com
2015-05-04  7:53 ` [U-Boot] [RFC] FIT: use default configuration, if given configuration is not found yegorslists at googlemail.com
2015-05-04 18:16   ` Joe Hershberger
2015-05-12  6:43     ` Yegor Yefremov
2015-05-12 20:18       ` Joe Hershberger [this message]
2015-05-12 20:41         ` Yegor Yefremov
2015-05-12 20:46           ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANr=Z=aN2Yj+hyNths1+Gq0WfS8NdKQx_OQhA0Z0RAibB7ot7w@mail.gmail.com' \
    --to=joe.hershberger@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.