All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Hershberger <joe.hershberger@ni.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: phy: realtek: Introduce quirk to mark RXC not stoppable
Date: Wed, 23 Jan 2019 17:04:24 +0000	[thread overview]
Message-ID: <CANr=Z=aX-bUXS9r5KTF8cu5BLK+tXBNbS2_P9QPuY6bCv_zr7w@mail.gmail.com> (raw)
In-Reply-To: <20190123163935.iwniiz6czc5vd3jd@xps>

On Wed, Jan 23, 2019 at 10:39 AM Carlo Caione <ccaione@baylibre.com> wrote:
>
> On 23/01/19 16:19, Joe Hershberger wrote:
>
> /cut
> >> +         transitions to/from a lower power consumption level (Low
> >> Power Idle
> >> +         mode) based on link utilization. When no packets are being
> >> +         transmitted, the system goes to Low Power Idle mode to save power.
> >> +
> >> +         Under particular circumstances this setting can cause issues where
> >> +         the PHY is unable to transmit or receive any packet when in LPI mode.
> >> +         The problem is caused when the PHY is configured to stop receiving
> >> +         the xMII clock while it is signaling LPI. When not stated otherwise
> >> +         this bit is set by libphy in the linux kernel.
> >
> >This seems to be copied from Linux, please update to describe what
> >happens in U-Boot.
>
> It is not copied from Linux. The problem is that the libphy in the
> kernel is flipping this bit and this is causing the issue in U-Boot on
> reboot. So I'm saying exactly that.

I see... you are saying it retains the value that may have be changed
by Linux. "When not stated otherwise" is to mean "If this config is
disabled" Should capitalize Linux.

>
> --
> Carlo Caione
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot

      reply	other threads:[~2019-01-23 17:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-23 13:55 [U-Boot] [PATCH] net: phy: realtek: Introduce quirk to mark RXC not stoppable Carlo Caione
2019-01-23 16:19 ` Joe Hershberger
2019-01-23 16:39   ` Carlo Caione
2019-01-23 17:04     ` Joe Hershberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANr=Z=aX-bUXS9r5KTF8cu5BLK+tXBNbS2_P9QPuY6bCv_zr7w@mail.gmail.com' \
    --to=joe.hershberger@ni.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.