From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58CD8C433EF for ; Tue, 1 Mar 2022 20:38:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9959B83BD3; Tue, 1 Mar 2022 21:38:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=ni.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=ni.com header.i=@ni.com header.b="3F4Rk6p8"; dkim=pass (1024-bit key; unprotected) header.d=nio365.onmicrosoft.com header.i=@nio365.onmicrosoft.com header.b="FvLim1fe"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2744D83C16; Tue, 1 Mar 2022 21:38:47 +0100 (CET) Received: from mx0b-00010702.pphosted.com (mx0b-00010702.pphosted.com [148.163.158.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9351D83BD1 for ; Tue, 1 Mar 2022 21:38:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=ni.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=00592b93e2=joseph.hershberger@ni.com Received: from pps.filterd (m0239463.ppops.net [127.0.0.1]) by mx0b-00010702.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 221FZ6SJ007352 for ; Tue, 1 Mar 2022 14:38:42 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ni.com; h=references : in-reply-to : reply-to : from : date : message-id : subject : to : cc : content-type : mime-version; s=PPS11062020; bh=qTSKk0VP2lx9ZpSuCP6t4DE9VySVmJEqafq6meoQ0ok=; b=3F4Rk6p8Y2He6XXu4NenyuYWV7N2t85pZpb215jW8y8CEk9DQmnQtFNFuzFy6V+8dgpl ok+vJGBXoivwsymr64r5KSpMEeIrJ8ZutZJaUkxWKXYBmxkQldlEp7Ed0HpcYMywuTSN OwRnyx06G/ozEZqEEh8ha9Ny2e5ARJhaZv4+GeJq9MupHwLnB0vF8X/WNIfOPK8AOvfb csMuKB/GJunqPd+TWY1zDgP0U2k1WSqBNYUfTRWj+ro006L+zBv5IU6n5sQhSL8yb2eW b/DBD4ROy5AoY8yqCphumzFYnydiY+Cnr2MfY/4IzwZapPaZcRUug4EJFE7pN57MsBVb iA== Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2176.outbound.protection.outlook.com [104.47.55.176]) by mx0b-00010702.pphosted.com (PPS) with ESMTPS id 3eguh2kkhc-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 01 Mar 2022 14:38:42 -0600 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PZbT6XP0VcGtLyT+k92tVr8w55WGvHLEDv4ApUsB7rpR6seMOeKaczwNiGqtALhYwK2ufNw1mS13w34xx62kGkwtJWGzxKTg7x2V+GSJ2Hla9H6rcRvlshaoo9kN25sxeQvr7NjkcuRxp2Axxruc8exa6tE93n7TsA+PHpKA1sNuJSH6HC+2G1fBrXhYKVYWM2axiFkn55UiD1F2wePMajsHVQ7tEVImroytXbVVEQwULpekOrtfYjHSbiPQqCm85oD2DJVH0QrLgbYSGtJLY6GNUdbs//rZ1OqDovwmwCv8dlnpsBQex/xNSs0CMVFYowzruTYbV0GSq5qALwDK4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qTSKk0VP2lx9ZpSuCP6t4DE9VySVmJEqafq6meoQ0ok=; b=RXdnEeBl3/ZwOoRHCWxwU7+wflcPsc4KZ00nyLwMxZ1KW6pXCVf6WuCiTD4p4bzTePIa2pBeo22oEF6MejAV7Pn8hJURD8bDCOld3tbdz7IXtDItv+5hblZ2hKEeNYQPDjT6/j8V+eaXP/bVFmr+RYhrWrQ6jXamoFUMGPh03mgVuA01dMu5RNbEw/KncaIvKZ/ZjrQPNBx90+jZt4qLdSRSHSppyoxMUYtmZUw4eCUimEdRPLhR2OVNb1nEsIY8tXaIe+Ur23d9VoVB3gGA79Bsevr8cF3DzUtOvjVD34aModqFS6HpoWVCciWMpUZZMrgZ94JFInd0Wbh68U97mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ni.com; dmarc=pass action=none header.from=ni.com; dkim=pass header.d=ni.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nio365.onmicrosoft.com; s=selector2-nio365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qTSKk0VP2lx9ZpSuCP6t4DE9VySVmJEqafq6meoQ0ok=; b=FvLim1fewVYWAc/7LOV5NKC1LocciH3XBx9lNLniSJWckXjplTGA61uu/RwLg9HG3d2VxdUqt/LXFrBvtfGzlT+3whbaCyMaOqnFtOSc3nF/mqQqyUHflzezSKimO99tzV98iMZ0AL4SDVdotNl1VmZ/dDf5gO5TkGmPxtUr0dY= Received: from SN4PR04MB8320.namprd04.prod.outlook.com (2603:10b6:806:1eb::7) by BYAPR04MB5029.namprd04.prod.outlook.com (2603:10b6:a03:48::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Tue, 1 Mar 2022 20:38:40 +0000 Received: from SN4PR04MB8320.namprd04.prod.outlook.com ([fe80::3df7:ac8b:5938:5321]) by SN4PR04MB8320.namprd04.prod.outlook.com ([fe80::3df7:ac8b:5938:5321%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 20:38:40 +0000 X-Gm-Message-State: AOAM531A1k5NwEl4ehcIzTYgjsKd//aU33Iaemvk2X+CE4YX2F0wf6B/ HqKtpg3me0ksDgfX/XzdSSXsYahT8oVKTCUVccQ= X-Google-Smtp-Source: ABdhPJzdxT31vspMa1XvGdlDUS5idamh3zpYgVATLL/uwwSDa+W/gsvrrgl1OtRlVhUyjZGm+VAXJW9MJixODVlzd6c= X-Received: by 2002:a05:6402:10d5:b0:408:f881:f0f3 with SMTP id p21-20020a05640210d500b00408f881f0f3mr26486366edu.112.1646167115371; Tue, 01 Mar 2022 12:38:35 -0800 (PST) References: <20220301201502.28026-1-tharvey@gateworks.com> <20220301201502.28026-3-tharvey@gateworks.com> In-Reply-To: <20220301201502.28026-3-tharvey@gateworks.com> From: Joe Hershberger Date: Tue, 1 Mar 2022 14:38:24 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] net: eth-phy: prevent undesired de-assertion of phy-reset on request To: Tim Harvey Cc: u-boot , Joe Hershberger , Ramon Fried , Sean Anderson Content-Type: text/plain; charset="UTF-8" X-ClientProxiedBy: AM4PR0302CA0034.eurprd03.prod.outlook.com (2603:10a6:205:2::47) To SN4PR04MB8320.namprd04.prod.outlook.com (2603:10b6:806:1eb::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b4c0aca3-1adc-4d2f-beac-08d9fbc377d6 X-MS-TrafficTypeDiagnostic: BYAPR04MB5029:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nS1rAZZ/pn+fqbIExWfqZegBjbJIwzb9jb1DAVECBq4sBoNyUbtRiv4+nQirtykGvP+UbseD0aPP6HVZpvQAjNulZQoJCvHDTCfjyHnAqnpuZwOj/ZzMxynPGaGskOmtPq8/1fiLIqsE9VSXqXNiA4mPETmQp+0t/jAEf+BlgJMKpKlOFeONACxlNmqs0obqr6jmC16WvgBoVXmLFYLLZgSzWJX4uAgFXlHz/BvCmFmZa1VsmJFoRUvDWjwy08rn0MfVwwVVCV405y1O60knKRIU8L/yTIJ8upl2Jz2zLIPOir2P16ZbhS5meNxdB0HfXvT8SYBIbuV3hAx1flSivNRkwb7XT0r0BFjVMmhsIv9dvNQ6KwoYzb9yqJO4d/ucgWhT7hUzfd0aqKsVCNXqKo55Efh2BM8eF8g3aaFYIFKuG49fvIsii0tnchSTuhPaQGhJr7ha3KQPmRX8+BTWcIZg1Iwi2VOtx40pIaDlc4PZi9eDXKTLGKrmGN3d3HE/808A2ZIH6Kpc+JiFH4BHgXVNQDfBSStvKxgRbudd6GGnYNO2yQWHMdYWjJHiJzIO9musX5i49iRt3mWNNq3wQDcTndVux9Gy1mfDUrEGlNC5quNrRXOz6WPdeTwXQAZMfRzWJfQ3r1E1cEJYcJu1oW5x+/sDwSmWrDtTaNUK7zGJiprM143OegJpqkUDsUiXCefYesHgZOP8mdWYy9vF3w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN4PR04MB8320.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6512007)(8936002)(6486002)(53546011)(9686003)(2906002)(3450700001)(5660300002)(6666004)(4744005)(55236004)(83380400001)(508600001)(44832011)(66946007)(52116002)(26005)(66476007)(66556008)(316002)(186003)(6506007)(38100700002)(54906003)(6862004)(8676002)(38350700002)(55446002)(4326008)(107886003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1hMb0RvRzlnN0lDa2dReFFyMUFIMmdQQnduQlI5bk02QUcvVm9qN05DRE1J?= =?utf-8?B?U1RGRFBreGVwYmswYURuZkdRbVk2QS81cHNpSEovRndzNGJIVFg0dWJIZlQr?= =?utf-8?B?SUFGYmkrVnpKR1VSaWd2b0NGRy9rWUR3d0VtZmVaUnZONXJPOHIrSEJkbUhF?= =?utf-8?B?SGRKalRRYU1VWEErRDZiTFk4K0gwR0FEL3NWSnVvYitLbjgwVk1CaEc3bkRX?= =?utf-8?B?M1NBUEFaSzdsYzk2eUJjQU5CK1ZyZmlmVGxJMVZZOWhWWC9FUjJZMXN4NWRh?= =?utf-8?B?cUlCMnArU2l6cDdlaXEwSytmZWJZNWZYdyswS2hWZTBaYWVFZm5VYVQ5Vjdr?= =?utf-8?B?eHNVOThpdE9ac3RzSEJlVDFHZTRUU1orT1luNWw4dmU2U2FnL2NURWt4b3FB?= =?utf-8?B?S3hoWWc0UVZPUVh1dzhZd0x0cjNFN0UvdFdwZzAvNTUwanVWTVN3TTFybmxv?= =?utf-8?B?K2taMFpGUERDbXVhcWhER0lDSitsb25rWjhZUGphZVoxb3p4Q2pNdFZJdHNJ?= =?utf-8?B?WlNiMWx0TEtaai9RblNJZ2RERWs2S25IMk96WXZNYUFVeWEzZFRtWmt4WFcw?= =?utf-8?B?RkpmeHR2RGZwYzV3MEZSL1NFTVJBNktRZHJlZC9UZ1BKb3JvZ3AxdExSRFcz?= =?utf-8?B?VDFlaVM1K0EzbkptbnJUUDlqb3l0UkRQNFExVGR0clpZYVhSUnR2blB1WklI?= =?utf-8?B?ZjFEOG1JT1lsMmhiM1RpTzQ4bXBaUmlqY201NmswUTRqR3F2cGNqeFlNaUNy?= =?utf-8?B?NnF1amVSZXZieXZ2SnFieXdENDNLVjhzNC9IZit0Y3kvd3A3MjhxQnJyVWxJ?= =?utf-8?B?NmorRENQa0dVMlMyWGd4UUVsREN2Y0NZZlpyMElnNlpYUXZLSk1VeUphQm9Z?= =?utf-8?B?ZGtZaDRnRG5yUnhHYmptUHB1RE1wcjExcUJXYUk4SDloZzIvcDJRZ3grRVlS?= =?utf-8?B?bWxRV0hGVk43aldxRTBxTGNtQi95cnZrVUN5ZmhGR3R2NUdTSjcxUExSTzNS?= =?utf-8?B?blo2M0ZjNTlBZzAwWlIrejFjai8zUFFnRHRiMHhmcUdJUHhwbGc3MXZtaWpn?= =?utf-8?B?SVhmY1FpdGdtZDVnNURVZ0UvOGVTSlZ0djdoYnBFejJ3azlwKzFKK0JLMGUx?= =?utf-8?B?NWw3bVVyY01PdWhMNGUyeXFQMlRtdjg0VlZFd2gxSGphQkJQa3I3UlBWNkto?= =?utf-8?B?aHQxMUU5OWtWWVBCKytWakR3ODRReHJRVko1dFIxS0pLTDRqZGwxbktzU1pk?= =?utf-8?B?c1A4N08zK2dlM2lVS1Rtc1AwazdsTGtsRzV5TkhXelM3eTdNb1Z5ekJwK3Vn?= =?utf-8?B?RVlzZHA0UWx1T0lMNHJUZ0MvRlBxR3RNWjdkSmthN0tIeFZEQTlrSVpnWUIv?= =?utf-8?B?M01QVjBzMllHdVFONWpvc0h4eUU2dzNnMEZxZS9PZ2lSWEFxMHcwYVdtLzZZ?= =?utf-8?B?WGUzaXhHY09ZNXBzVlU0RWJJTTIwbCtpWmxjN1MvQjV6Smx5Um9JdnNrdGlm?= =?utf-8?B?WjNMNmVLV0l1L056OFRtUHhVeXNiZDlnNzdRVk9uWDV3cnVDSFhacmRaSXZh?= =?utf-8?B?REtRcHE3MThGZ2xXY1FaM2ozbjJlWUhPS1QzY0lDSGRmaHhvdlR3RUJPOEdR?= =?utf-8?B?WFRmQUoxVEJSdkUzM1RXclNGZ0Q5U2NuZ2t5b1NPSDNzVTJrcEdHZlB1OThl?= =?utf-8?B?anFpZWx3cDNqc0s3WFNKVEtkNmIxbGNnVGVOSmNWTjU0c2dCZHlPa1ZxV1NI?= =?utf-8?B?bW5Id3FHZGNEUU5SMnkwSFFPOFF2Q3dDQTlsMW9KMmhOMjBkbE5wUWsyNWJj?= =?utf-8?B?NmwyRzlocWFLemV0TlJMRVFIM1lnd0xiSjk1WjllejNhWVMvVHAyZ2RhM09w?= =?utf-8?B?WmNQbGVEQ05vMmVtdFBjKys5TTNwOXZ1dklOVVAvKzNjK2toQ2ZSdkt1WURB?= =?utf-8?B?djF1bEpWS20xUXhqU0txWmtHL0M5aEFyYnlUcW8xbHk5OWY1cU5YZnVMd2xR?= =?utf-8?B?bElPRGRRV1hObzJmTG5VZjJjN3pJUllTSVJlOTFMY3EzNnVBejJpZHdRWEdI?= =?utf-8?B?RWRsdERxdU9GTkNKSHpDb0ZMbko2cTZabStsZk50czluZU9IbXZ3TmRYQ0hj?= =?utf-8?B?Y2hQSk0yM3BVa0g1UHlGejY4OHlXVE92ZExycDY3b1Q2TDdIdlh0VlZINFNl?= =?utf-8?B?M1hienJXcFdKMXhHSnIzRndRbFlUTnhPVlpYMWtMUmdLUkMyTzBLYUZIc0ls?= =?utf-8?B?WCtZbzZkTDl3dTBaenkydUVKS09nPT0=?= X-OriginatorOrg: ni.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4c0aca3-1adc-4d2f-beac-08d9fbc377d6 X-MS-Exchange-CrossTenant-AuthSource: SN4PR04MB8320.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 20:38:39.9267 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 87ba1f9a-44cd-43a6-b008-6fdb45a5204e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bnj42ISC0bclg4z8O7lvC5iOd99L6iFUb7/hk40XOxgxkhIrwV7qXTJLyTpWvQ2GCnSwnd6zI6sJePjcTZdEgGwbokcwJR6/TCz0uQqHsDg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB5029 X-Proofpoint-GUID: skAYm4dbTYS2O_s44l7t99ELHoJyRr5G X-Proofpoint-ORIG-GUID: skAYm4dbTYS2O_s44l7t99ELHoJyRr5G X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-01_07,2022-02-26_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=30 mlxscore=0 phishscore=0 adultscore=0 malwarescore=0 impostorscore=0 mlxlogscore=834 spamscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=30 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203010103 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: joe.hershberger@ni.com Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Tue, Mar 1, 2022 at 2:15 PM Tim Harvey wrote: > > When gpio_request_by_name allocates a gpio output it by default will > de-assert the gpio which for phy-reset will take the PHY out of reset. > As this occurs before eth_phy_reset is called to assert the reset > line it can cause undesired affects if reset timings are not properly > met. > > Configure the gpio with GPIOD_IS_OUT_ACTIVE so that reset is kept active > (reset asserted) to avoid this. > > Cc: Sean Anderson > Signed-off-by: Tim Harvey Acked-by: Joe Hershberger