From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chander Kashyap Subject: Re: [PATCH 13/13] ARM: Exynos: extend soft-reset support for Exynos5420 Date: Tue, 11 Jun 2013 18:54:32 +0530 Message-ID: References: <1370516488-25860-1-git-send-email-chander.kashyap@linaro.org> <1370516488-25860-13-git-send-email-chander.kashyap@linaro.org> <51B07631.2010802@linaro.org> <0ea501ce65b8$3046d7a0$90d486e0$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-ob0-f176.google.com ([209.85.214.176]:53587 "EHLO mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751252Ab3FKNYd (ORCPT ); Tue, 11 Jun 2013 09:24:33 -0400 Received: by mail-ob0-f176.google.com with SMTP id v19so11683275obq.21 for ; Tue, 11 Jun 2013 06:24:32 -0700 (PDT) In-Reply-To: <0ea501ce65b8$3046d7a0$90d486e0$%kim@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Kukjin Kim Cc: Tushar Behera , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-serial@vger.kernel.org" , "t.figa@samsung.com" , "s.nawrocki@samsung.com" , "thomas.ab@samsung.com" On 10 June 2013 14:24, Kukjin Kim wrote: > Tushar Behera wrote: >> >> On 06/06/2013 04:31 PM, Chander Kashyap wrote: >> > Extend the soft reset support for Exynos5420 SoC. >> > >> > Signed-off-by: Chander Kashyap >> > --- >> > arch/arm/mach-exynos/common.c | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c >> > index fbe1aa7..dc7c134 100644 >> > --- a/arch/arm/mach-exynos/common.c >> > +++ b/arch/arm/mach-exynos/common.c >> > @@ -321,7 +321,8 @@ void exynos5_restart(char mode, const char *cmd) >> > u32 val; >> > void __iomem *addr; >> > >> > - if (of_machine_is_compatible("samsung,exynos5250")) { >> > + if (of_machine_is_compatible("samsung,exynos5250") || >> > + (of_machine_is_compatible("samsung,exynos5420"))) { >> > val = 0x1; >> > addr = EXYNOS_SWRESET; >> > } else if (of_machine_is_compatible("samsung,exynos5440")) { >> > >> >> How about making 0x1 and EXYNOS_SWRESET as default values of val and >> addr. That way we can remove this check for exynos5250 and exynos5420. >> Also we can remove the trailing else statement as there are no non-DT >> boards for EXYNOS5. >> >> void exynos5_restart(char mode, const char *cmd) >> { >> struct device_node *np; >> - u32 val; >> - void __iomem *addr; >> + u32 val = 0x1; >> + void __iomem *addr = EXYNOS_SWRESET; >> >> - if (of_machine_is_compatible("samsung,exynos5250")) { >> - val = 0x1; >> - addr = EXYNOS_SWRESET; >> - } else if (of_machine_is_compatible("samsung,exynos5440")) { >> + if (of_machine_is_compatible("samsung,exynos5440")) { >> u32 status; >> np = of_find_compatible_node(NULL, NULL, >> "samsung,exynos5440-clock"); >> >> @@ -336,9 +333,6 @@ void exynos5_restart(char mode, const char *cmd) >> val = __raw_readl(addr); >> >> val = (val & 0xffff0000) | (status & 0xffff); >> - } else { >> - pr_err("%s: cannot support non-DT\n", __func__); >> - return; >> } >> >> -- > > Yeah, looks better. Yes i will do the change. Thanks > > - Kukjin > -- with warm regards, Chander Kashyap From mboxrd@z Thu Jan 1 00:00:00 1970 From: chander.kashyap@linaro.org (Chander Kashyap) Date: Tue, 11 Jun 2013 18:54:32 +0530 Subject: [PATCH 13/13] ARM: Exynos: extend soft-reset support for Exynos5420 In-Reply-To: <0ea501ce65b8$3046d7a0$90d486e0$%kim@samsung.com> References: <1370516488-25860-1-git-send-email-chander.kashyap@linaro.org> <1370516488-25860-13-git-send-email-chander.kashyap@linaro.org> <51B07631.2010802@linaro.org> <0ea501ce65b8$3046d7a0$90d486e0$%kim@samsung.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10 June 2013 14:24, Kukjin Kim wrote: > Tushar Behera wrote: >> >> On 06/06/2013 04:31 PM, Chander Kashyap wrote: >> > Extend the soft reset support for Exynos5420 SoC. >> > >> > Signed-off-by: Chander Kashyap >> > --- >> > arch/arm/mach-exynos/common.c | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c >> > index fbe1aa7..dc7c134 100644 >> > --- a/arch/arm/mach-exynos/common.c >> > +++ b/arch/arm/mach-exynos/common.c >> > @@ -321,7 +321,8 @@ void exynos5_restart(char mode, const char *cmd) >> > u32 val; >> > void __iomem *addr; >> > >> > - if (of_machine_is_compatible("samsung,exynos5250")) { >> > + if (of_machine_is_compatible("samsung,exynos5250") || >> > + (of_machine_is_compatible("samsung,exynos5420"))) { >> > val = 0x1; >> > addr = EXYNOS_SWRESET; >> > } else if (of_machine_is_compatible("samsung,exynos5440")) { >> > >> >> How about making 0x1 and EXYNOS_SWRESET as default values of val and >> addr. That way we can remove this check for exynos5250 and exynos5420. >> Also we can remove the trailing else statement as there are no non-DT >> boards for EXYNOS5. >> >> void exynos5_restart(char mode, const char *cmd) >> { >> struct device_node *np; >> - u32 val; >> - void __iomem *addr; >> + u32 val = 0x1; >> + void __iomem *addr = EXYNOS_SWRESET; >> >> - if (of_machine_is_compatible("samsung,exynos5250")) { >> - val = 0x1; >> - addr = EXYNOS_SWRESET; >> - } else if (of_machine_is_compatible("samsung,exynos5440")) { >> + if (of_machine_is_compatible("samsung,exynos5440")) { >> u32 status; >> np = of_find_compatible_node(NULL, NULL, >> "samsung,exynos5440-clock"); >> >> @@ -336,9 +333,6 @@ void exynos5_restart(char mode, const char *cmd) >> val = __raw_readl(addr); >> >> val = (val & 0xffff0000) | (status & 0xffff); >> - } else { >> - pr_err("%s: cannot support non-DT\n", __func__); >> - return; >> } >> >> -- > > Yeah, looks better. Yes i will do the change. Thanks > > - Kukjin > -- with warm regards, Chander Kashyap