From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chander Kashyap <chander.kashyap@linaro.org>
Date: Mon, 1 Aug 2011 17:22:47 +0530
Subject: [U-Boot] [PATCH v4 2/2] ORIGEN: Add MMC SPL support
In-Reply-To: <20110801100911.0431D1673B92@gemini.denx.de>
References: <1311914519-10531-1-git-send-email-chander.kashyap@linaro.org>
	<1311914519-10531-3-git-send-email-chander.kashyap@linaro.org>
	<CALZhoSTV0zYX=ySw-vS6D51X0B_MHxt8sq1sTw7XEkyV1C=Odg@mail.gmail.com>
	<CANuQgHGGaB3fWEFCXfgd97QxOfnizxLYvO8ke-v=5PzHyTN-Jg@mail.gmail.com>
	<20110801100911.0431D1673B92@gemini.denx.de>
Message-ID: <CANuQgHFgsvLfDotp8aeMyGbK6gYeV7yxExpdMzWoqyqT4Qh-tw@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang Denk,

On 1 August 2011 15:39, Wolfgang Denk <wd@denx.de> wrote:

> Dear Chander Kashyap,
>
> In message <CANuQgHGGaB3fWEFCXfgd97QxOfnizxLYvO8ke-v=
> 5PzHyTN-Jg at mail.gmail.com> you wrote:
> >
> [200+ lines of unrelated quote deleted.]
>
> > > > +void copy_uboot_to_ram(void)
> > > > +{
> > > > +       copy_sd_mmc_to_mem copy_bl2 = (copy_sd_mmc_to_mem)*(u32
> *)(0x02020030);
> > > > +       copy_bl2(BL2_START_OFFSET,\
> > > > +               BL2_SIZE_BLOC_COUNT, (u32 *)CONFIG_SYS_TEXT_BASE);
> > > > +}
> > >
> > > Curious to know, what the 0x02020030 hardcoding number means here?
> > > It is a pointer to a API or hardware register, or anything else, how
> > > this simple function perform the
> > > data transfer from mmc to ram?
> > >
> > >  0x02020030 is iROM address, which contains pointer to API (copy from
> mmc
> > from DDR) in iROM.
>
> Well, as you can see yourself here, an external reviewer has no
> chance to reand and understand this code. As mentioned before, this
> needs serious rework.
>
Yes I am reworking on it. I make it more readable. But still i need to use
the inbuilt function to copy u-boot from mmc to ddr.

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Those who hate and fight must stop themselves -- otherwise it is  not
> stopped.
>        -- Spock, "Day of the Dove", stardate unknown
>



-- 
with warm regards,
Chander Kashyap