All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Kuzmin <andrey.v.kuzmin@gmail.com>
To: Sitsofe Wheeler <sitsofe@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: Exit all jobs on error
Date: Thu, 10 Dec 2015 21:11:51 +0300	[thread overview]
Message-ID: <CANvN+e=CtQBfUmj6fQPUgaqHUXwzwY1SLuXV76n=AG2kLFpWSQ@mail.gmail.com> (raw)
In-Reply-To: <CALjAwxjLXTCRe0Ky08DB6in2aq_czkx5Oz8Osi7Mo=+7eFH9PQ@mail.gmail.com>

I've also encountered a similar issue a number of times where the job
failed to stop (and refused to terminate in response to C-C) when a
thread/process fails, e.g. due to an error. My guess is that the loop
that waits for completions doesn't check for td->terminate being set.

Regards,
Andrey
Regards,
Andrey


On Thu, Dec 10, 2015 at 8:58 PM, Sitsofe Wheeler <sitsofe@gmail.com> wrote:
> On 10 December 2015 at 17:11, Jens Axboe <axboe@kernel.dk> wrote:
>> On 12/10/2015 12:01 AM, Sitsofe Wheeler wrote:
>>>
>>> Hi,
>>>
>>> Is there an option to exit all jobs but only on error? If I have a job
>>> like this
>>>
>>> [global]
>>> stonewall=1
>>> verify=crc32
>>> rw=write
>>> [pass1]
>>> bs=4k
>>> [pass2]
>>> bs=8k
>>>
>>> I want fio to stop if pass1 fails verification and for pass2 not to be
>>> performed at all. I'm aware of "exitall" but using that will make fio
>>> quit even if pass1 is successful.
>>
>>
>> That doesn't exist, but we could add a exitall_on_error to have that
>> behavior. Should be pretty easy to add.
>
> That would work for me - that way it could be put in the global
> section or per (stonewall) group.
>
> --
> Sitsofe | http://sucs.org/~sits/
> --
> To unsubscribe from this list: send the line "unsubscribe fio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2015-12-10 18:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10  7:01 Exit all jobs on error Sitsofe Wheeler
2015-12-10 17:11 ` Jens Axboe
2015-12-10 17:58   ` Sitsofe Wheeler
2015-12-10 18:11     ` Andrey Kuzmin [this message]
2015-12-10 18:15       ` Jens Axboe
2015-12-10 18:17         ` Andrey Kuzmin
2015-12-10 18:24           ` Jens Axboe
2015-12-10 18:27             ` Andrey Kuzmin
2015-12-10 18:29               ` Jens Axboe
2015-12-10 18:30                 ` Andrey Kuzmin
2015-12-11 10:01                   ` Andrey Kuzmin
2015-12-11 15:32                     ` Jens Axboe
2015-12-11 19:59                       ` Sitsofe Wheeler
2015-12-11 20:32                         ` Andrey Kuzmin
2015-12-11 20:38                           ` Jens Axboe
2015-12-10 18:15     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANvN+e=CtQBfUmj6fQPUgaqHUXwzwY1SLuXV76n=AG2kLFpWSQ@mail.gmail.com' \
    --to=andrey.v.kuzmin@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=sitsofe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.