From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Jan_M=C4=99dala?= Subject: Re: [PATCH v7 4/4] ena: DPDK polling-mode driver for Amazon Elastic Network Adapters (ENA) Date: Thu, 17 Mar 2016 15:21:20 +0100 Message-ID: References: <1458052810-18418-1-git-send-email-jan@semihalf.com> <20160316143407.GA10288@bricha3-MOBL3> <1796521.zug8sZHtGq@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, Bruce Richardson , Alexander Matushevsky , Evgeny Schemeilin , Jakub Palider To: Thomas Monjalon Return-path: Received: from mail-vk0-f54.google.com (mail-vk0-f54.google.com [209.85.213.54]) by dpdk.org (Postfix) with ESMTP id 4532D137C for ; Thu, 17 Mar 2016 15:21:21 +0100 (CET) Received: by mail-vk0-f54.google.com with SMTP id q138so11890758vkb.3 for ; Thu, 17 Mar 2016 07:21:21 -0700 (PDT) In-Reply-To: <1796521.zug8sZHtGq@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-17 14:57 GMT+01:00 Thomas Monjalon : > 2016-03-17 14:48, Jan M=C4=99dala: > > > > > > > # > > > > +# Compile burst-oriented Amazon ENA PMD driver > > > > +# > > > > +CONFIG_RTE_LIBRTE_ENA_PMD=3Dy > > > > +CONFIG_RTE_LIBRTE_ENA_DEBUG_INIT=3Dy > > > > > > Do you really want initialization debuggin to be on by default? > Normally, > > > we > > > keep all debug options disabled. > > > > This is actually error logging, so it's silent for user until there is > > something wrong with initialization. > > Do you want me to rename it to point more accurately it's role? > > There should not be any option at all to disable error logging. > OK, I'm going to fix that.