All of lore.kernel.org
 help / color / mirror / Atom feed
From: Håvard <hovardslill@gmail.com>
To: tiwai@suse.de
Cc: Connor McAdams <conmanx360@gmail.com>, alsa-devel@alsa-project.org
Subject: Re: Microphone detected, but no output for all ASUS G751xx with ALC668 chipset
Date: Sat, 6 Oct 2018 20:31:28 +0200	[thread overview]
Message-ID: <CANweNF7=KtniM9dvLfVoXC1wGZ2Zn4M1ue19=nCHjb_rko8paA@mail.gmail.com> (raw)
In-Reply-To: <s5hsh1ji3f0.wl-tiwai@suse.de>

OK!

Thank you very much for all that you have done!!

I am looking forward to seeing this in (probably) the 4.20 kernel!

-Håvard

Den lør. 6. okt. 2018 kl. 15:57 skrev Takashi Iwai <tiwai@suse.de>:

> On Sat, 06 Oct 2018 10:20:37 +0200,
> Håvard wrote:
> >
> > Ok!
> >
> > Thank you very much!
> >
> > So for them to work, they have to set model=asus-g751 ?
>
> They can test in that way, and they need to report their PCI SSIDs for
> applying the quirk as default.
>
>
> Takashi
>
> > Sorry for all these questions, but I want to respond to these people as
> > fast as possible!
> >
> > -Håvard
> >
> > Den lør. 6. okt. 2018 kl. 08:55 skrev Takashi Iwai <tiwai@suse.de>:
> >
> > > On Fri, 05 Oct 2018 21:56:20 +0200,
> > > Håvard wrote:
> > > >
> > > > I couldn't get the patch installed automatically, so I added the
> changed
> > > > code myself.
> > > >
> > > > Everything works fine and as expected right after reboot! :) Just
> like we
> > > > want!
> > > >
> > > > I don't understand. So this won't work for other G751xx users? Or do
> they
> > > > have to set model=asus-g751? I'm thinking of reaching out and saying
> it
> > > > will be fixed in 4.19.
> > >
> > > We need to know the exact PCI SSIDs for the matching models.
> > > Yours is 1043:12ff, and others might be different.  They can be added
> > > eventually to the quirk table in the same way once when we are
> > > informed.
> > >
> > > Since it's already a very late stage for 4.19, this fix will go into
> > > 4.20 at earliest.
> > >
> > >
> > > thanks,
> > >
> > > Takashi
> > >
> > > >
> > > > Thank you!
> > > >
> > > > -Håvard
> > > >
> > > > Den fre. 5. okt. 2018 kl. 14:46 skrev Takashi Iwai <tiwai@suse.de>:
> > > >
> > > > > On Fri, 05 Oct 2018 12:31:37 +0200,
> > > > > Håvard wrote:
> > > > > >
> > > > > > Thank you so much!
> > > > > >
> > > > > > Will this work for all G751 models, and will this be in the 4.19
> > > kernel?
> > > > >
> > > > > It's only for yours (the matching PCI SSID).  And it will be
> included
> > > > > only when you test the patch and confirm it working.  So, please
> test
> > > > > it at first.  Then I'll merge after the test rest.
> > > > >
> > > > >
> > > > > thanks,
> > > > >
> > > > > Takashi
> > > > >
> > > > >
> > > > > > I am very thankful for all your hard work!!
> > > > > >
> > > > > > -Håvard
> > > > > >
> > > > > > Den fre. 5. okt. 2018 kl. 12:29 skrev Takashi Iwai <
> tiwai@suse.de>:
> > > > > >
> > > > > > > On Fri, 05 Oct 2018 12:10:52 +0200,
> > > > > > > Håvard wrote:
> > > > > > > >
> > > > > > > > I'll try to answer your previous email first.
> > > > > > > >
> > > > > > > > Everything seems identical to how it was in the 4.18-gentoo
> > > kernel
> > > > > when
> > > > > > > not
> > > > > > > > setting the model=alc668-headset option
> > > > > > > >
> > > > > > > > And using the trick we found:
> > > > > > > >
> > > > > > > > ./hda-verb /dev/snd/hwC0D0 0x20 0x500 0xc3
> > > > > > > > ./hda-verb /dev/snd/hwC0D0 0x20 0x440 0x00
> > > > > > >
> > > > > > > OK, then the following patch may work.  Give it a try.
> > > > > > >
> > > > > > >
> > > > > > > > Made it so loopback worked perfectly fine for both earpieces.
> > > > > > > >
> > > > > > > > One curiosity however (this is just a small thing) is that
> the
> > > > > "base" mic
> > > > > > > > level is far lower than when the "Mic" option in alsamixer is
> > > set to
> > > > > > > 100. I
> > > > > > > > don't know if it was this way in 4.18-gentoo, but that's the
> only
> > > > > thing
> > > > > > > > that doesnt seem correct.
> > > > > > > > Here is a screenshot explaining it:
> > > > > > > > http://i.imgur.com/dKPELX6.png
> > > > > > >
> > > > > > > The Mic volume is only for analog loopback, so it can be
> normal.
> > > > > > >
> > > > > > >
> > > > > > > Takashi
> > > > > > >
> > > > > > > ---
> > > > > > > --- a/sound/pci/hda/patch_realtek.c
> > > > > > > +++ b/sound/pci/hda/patch_realtek.c
> > > > > > > @@ -7738,6 +7738,7 @@ enum {
> > > > > > >         ALC662_FIXUP_ASUS_Nx50,
> > > > > > >         ALC668_FIXUP_ASUS_Nx51_HEADSET_MODE,
> > > > > > >         ALC668_FIXUP_ASUS_Nx51,
> > > > > > > +       ALC668_FIXUP_ASUS_G751,
> > > > > > >         ALC891_FIXUP_HEADSET_MODE,
> > > > > > >         ALC891_FIXUP_DELL_MIC_NO_PRESENCE,
> > > > > > >         ALC662_FIXUP_ACER_VERITON,
> > > > > > > @@ -8007,6 +8008,14 @@ static const struct hda_fixup
> > > alc662_fixups[] =
> > > > > {
> > > > > > >                 .chained = true,
> > > > > > >                 .chain_id =
> ALC668_FIXUP_ASUS_Nx51_HEADSET_MODE,
> > > > > > >         },
> > > > > > > +       [ALC668_FIXUP_ASUS_G751] = {
> > > > > > > +               .type = HDA_FIXUP_VERBS,
> > > > > > > +               .v.verbs = (const struct hda_verb[]) {
> > > > > > > +                       { 0x20, AC_VERB_SET_COEF_INDEX, 0xc3 },
> > > > > > > +                       { 0x20, AC_VERB_SET_PROC_COEF, 0x4000
> },
> > > > > > > +                       {}
> > > > > > > +               },
> > > > > > > +       },
> > > > > > >         [ALC891_FIXUP_HEADSET_MODE] = {
> > > > > > >                 .type = HDA_FIXUP_FUNC,
> > > > > > >                 .v.func = alc_fixup_headset_mode,
> > > > > > > @@ -8080,6 +8089,7 @@ static const struct snd_pci_quirk
> > > > > alc662_fixup_tbl[]
> > > > > > > = {
> > > > > > >         SND_PCI_QUIRK(0x1043, 0x11cd, "Asus N550",
> > > > > ALC662_FIXUP_ASUS_Nx50),
> > > > > > >         SND_PCI_QUIRK(0x1043, 0x13df, "Asus N550JX",
> > > > > ALC662_FIXUP_BASS_1A),
> > > > > > >         SND_PCI_QUIRK(0x1043, 0x129d, "Asus N750",
> > > > > ALC662_FIXUP_ASUS_Nx50),
> > > > > > > +       SND_PCI_QUIRK(0x1043, 0x12ff, "ASUS G751",
> > > > > ALC668_FIXUP_ASUS_G751),
> > > > > > >         SND_PCI_QUIRK(0x1043, 0x1477, "ASUS N56VZ",
> > > > > > > ALC662_FIXUP_BASS_MODE4_CHMAP),
> > > > > > >         SND_PCI_QUIRK(0x1043, 0x15a7, "ASUS UX51VZH",
> > > > > > > ALC662_FIXUP_BASS_16),
> > > > > > >         SND_PCI_QUIRK(0x1043, 0x177d, "ASUS N551",
> > > > > ALC668_FIXUP_ASUS_Nx51),
> > > > > > > @@ -8184,6 +8194,7 @@ static const struct hda_model_fixup
> > > > > > > alc662_fixup_models[] = {
> > > > > > >         {.id = ALC668_FIXUP_DELL_XPS13, .name = "dell-xps13"},
> > > > > > >         {.id = ALC662_FIXUP_ASUS_Nx50, .name = "asus-nx50"},
> > > > > > >         {.id = ALC668_FIXUP_ASUS_Nx51, .name = "asus-nx51"},
> > > > > > > +       {.id = ALC668_FIXUP_ASUS_G751, .name = "asus-g751"},
> > > > > > >         {.id = ALC891_FIXUP_HEADSET_MODE, .name =
> > > "alc891-headset"},
> > > > > > >         {.id = ALC891_FIXUP_DELL_MIC_NO_PRESENCE, .name =
> > > > > > > "alc891-headset-multi"},
> > > > > > >         {.id = ALC662_FIXUP_ACER_VERITON, .name =
> "acer-veriton"},
> > > > > > >
> > > > > > [2  <text/html; UTF-8 (quoted-printable)>]
> > > > > >
> > > > >
> > > > [2  <text/html; UTF-8 (quoted-printable)>]
> > > >
> > >
> > [2  <text/html; UTF-8 (quoted-printable)>]
> >
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2018-10-06 18:31 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06 18:44 Microphone detected, but no output for all ASUS G751xx with ALC668 chipset Håvard
2018-09-10 20:39 ` Takashi Iwai
2018-09-11 16:40   ` Håvard
2018-09-11 16:52     ` Takashi Iwai
2018-09-11 17:14       ` Håvard
2018-09-11 18:02         ` Takashi Iwai
2018-09-11 18:07           ` Takashi Iwai
2018-09-11 18:09           ` Håvard
2018-09-11 18:15             ` Håvard
2018-09-11 18:26               ` Connor McAdams
2018-09-11 19:18                 ` Håvard
2018-09-11 19:20                   ` Connor McAdams
2018-09-11 19:27                     ` Håvard
2018-09-11 21:08                       ` Håvard
2018-09-11 22:31                         ` Connor McAdams
2018-09-12 16:39                           ` Håvard
2018-09-12 16:41                             ` Håvard
2018-09-12 16:42                               ` Connor McAdams
2018-09-12 16:43                                 ` Connor McAdams
2018-09-12 16:49                                   ` Connor McAdams
     [not found]                                     ` <CANweNF4Q9CE5-fO-WJmX9pmaZTOt8U6A7Ey6ELEEhdskrOWw9g@mail.gmail.com>
2018-09-12 17:10                                       ` Connor McAdams
2018-09-12 17:13                                         ` Connor McAdams
2018-09-12 17:14                                           ` Connor McAdams
2018-09-12 17:11                                       ` Håvard
2018-09-12 17:16                                         ` Håvard
2018-09-12 20:01                                           ` Connor McAdams
2018-09-12 20:14                                             ` Håvard
2018-09-12 20:17                                               ` Håvard
2018-09-12 21:16                                                 ` Takashi Iwai
2018-09-14 15:45                                                   ` Håvard
2018-09-14 15:51                                                     ` Håvard
2018-10-04 21:26                                                       ` Takashi Iwai
2018-10-05  9:56                                                         ` Håvard
2018-10-05 10:00                                                           ` Håvard
2018-10-05 10:02                                                             ` Håvard
2018-10-05 10:03                                                             ` Takashi Iwai
2018-10-05 10:10                                                               ` Håvard
2018-10-05 10:14                                                                 ` Håvard
2018-10-05 10:29                                                                 ` Takashi Iwai
2018-10-05 10:31                                                                   ` Håvard
2018-10-05 11:09                                                                     ` Håvard
2018-10-05 12:46                                                                     ` Takashi Iwai
2018-10-05 19:56                                                                       ` Håvard
2018-10-06  6:55                                                                         ` Takashi Iwai
2018-10-06  8:20                                                                           ` Håvard
2018-10-06 13:57                                                                             ` Takashi Iwai
2018-10-06 18:31                                                                               ` Håvard [this message]
2018-10-08 12:05                                                                                 ` Håvard
2018-10-08 12:08                                                                                   ` Håvard
2018-10-08 12:12                                                                                   ` Takashi Iwai
2018-10-05 10:01                                                           ` Takashi Iwai
2018-09-14 15:51                                                     ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2018-09-03 16:26 Håvard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANweNF7=KtniM9dvLfVoXC1wGZ2Zn4M1ue19=nCHjb_rko8paA@mail.gmail.com' \
    --to=hovardslill@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=conmanx360@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.