From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Liu Subject: Re: [V4, 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early boot stages Date: Sun, 23 Oct 2016 14:48:58 +1100 Message-ID: References: <1476915664-27231-2-git-send-email-okaya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1476915664-27231-2-git-send-email-okaya@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Sinan Kaya Cc: linux-acpi@vger.kernel.org, rjw@rjwysocki.net, Bjorn Helgaas , ravikanth.nalla@hpe.com, linux@rainbow-software.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, alex.williamson@redhat.com, linux-pci@vger.kernel.org, Andy Gross , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wim@djo.tudelft.nl, Len Brown , linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On 20 October 2016 at 09:21, Sinan Kaya wrote: > The penalty determination of ISA IRQ goes through 4 paths. > 1. assign PCI_USING during power up via acpi_irq_penalty_init. > 2. update the penalty with acpi_penalize_isa_irq function based on the > active parameter. > 3. kernel command line penalty update via acpi_irq_penalty_update function. > 4. increment the penalty as USING right after the IRQ is assign to PCI. > > acpi_penalize_isa_irq and acpi_irq_penalty_update functions get called > before the ACPI subsystem is started. > > These API need to bypass the acpi_irq_get_penalty function. > > Signed-off-by: Sinan Kaya > --- > drivers/acpi/pci_link.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c > index c983bf7..4f37938 100644 > --- a/drivers/acpi/pci_link.c > +++ b/drivers/acpi/pci_link.c > @@ -849,7 +849,7 @@ static int __init acpi_irq_penalty_update(char *str, int used) > continue; > > if (used) > - new_penalty = acpi_irq_get_penalty(irq) + > + new_penalty = acpi_isa_irq_penalty[irq] + > PIRQ_PENALTY_ISA_USED; > else > new_penalty = 0; > @@ -871,7 +871,7 @@ static int __init acpi_irq_penalty_update(char *str, int used) > void acpi_penalize_isa_irq(int irq, int active) > { > if ((irq >= 0) && (irq < ARRAY_SIZE(acpi_isa_irq_penalty))) > - acpi_isa_irq_penalty[irq] = acpi_irq_get_penalty(irq) + > + acpi_isa_irq_penalty[irq] = acpi_isa_irq_penalty[irq] + > (active ? PIRQ_PENALTY_ISA_USED : PIRQ_PENALTY_PCI_USING); > } > This series fixes one or more network adapters not working in Linux 32-bit x86 guest running inside VirtualBox if I have 4 network adapters enabled. The following message no longer appears in the kernel log: ACPI: No IRQ available for PCI Interrupt Link [LNKD]. Try pci=noacpi or acpi=off Tested-by: Jonathan Liu From mboxrd@z Thu Jan 1 00:00:00 1970 From: net147@gmail.com (Jonathan Liu) Date: Sun, 23 Oct 2016 14:48:58 +1100 Subject: [V4, 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early boot stages In-Reply-To: <1476915664-27231-2-git-send-email-okaya@codeaurora.org> References: <1476915664-27231-2-git-send-email-okaya@codeaurora.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 20 October 2016 at 09:21, Sinan Kaya wrote: > The penalty determination of ISA IRQ goes through 4 paths. > 1. assign PCI_USING during power up via acpi_irq_penalty_init. > 2. update the penalty with acpi_penalize_isa_irq function based on the > active parameter. > 3. kernel command line penalty update via acpi_irq_penalty_update function. > 4. increment the penalty as USING right after the IRQ is assign to PCI. > > acpi_penalize_isa_irq and acpi_irq_penalty_update functions get called > before the ACPI subsystem is started. > > These API need to bypass the acpi_irq_get_penalty function. > > Signed-off-by: Sinan Kaya > --- > drivers/acpi/pci_link.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c > index c983bf7..4f37938 100644 > --- a/drivers/acpi/pci_link.c > +++ b/drivers/acpi/pci_link.c > @@ -849,7 +849,7 @@ static int __init acpi_irq_penalty_update(char *str, int used) > continue; > > if (used) > - new_penalty = acpi_irq_get_penalty(irq) + > + new_penalty = acpi_isa_irq_penalty[irq] + > PIRQ_PENALTY_ISA_USED; > else > new_penalty = 0; > @@ -871,7 +871,7 @@ static int __init acpi_irq_penalty_update(char *str, int used) > void acpi_penalize_isa_irq(int irq, int active) > { > if ((irq >= 0) && (irq < ARRAY_SIZE(acpi_isa_irq_penalty))) > - acpi_isa_irq_penalty[irq] = acpi_irq_get_penalty(irq) + > + acpi_isa_irq_penalty[irq] = acpi_isa_irq_penalty[irq] + > (active ? PIRQ_PENALTY_ISA_USED : PIRQ_PENALTY_PCI_USING); > } > This series fixes one or more network adapters not working in Linux 32-bit x86 guest running inside VirtualBox if I have 4 network adapters enabled. The following message no longer appears in the kernel log: ACPI: No IRQ available for PCI Interrupt Link [LNKD]. Try pci=noacpi or acpi=off Tested-by: Jonathan Liu