All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tim Orling" <ticotimo@gmail.com>
To: Trevor Gamblin <trevor.gamblin@windriver.com>
Cc: Khem Raj <raj.khem@gmail.com>,
	Sakib Sajal <sakib.sajal@windriver.com>,
	 openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [meta-python][PATCH] python3-requests-toolbelt: Remove py3-mock from rdeps
Date: Mon, 6 Jul 2020 18:02:13 -0700	[thread overview]
Message-ID: <CANx9H-CmM8ZDt8TZxmQhCk55ygRQPzDzEwYQYKh9S9WsRc6Qvg@mail.gmail.com> (raw)
In-Reply-To: <412cff58-b4a4-d726-b4d3-bc96321f4b75@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 1878 bytes --]

On Mon, Jul 6, 2020 at 11:47 AM Trevor Gamblin <trevor.gamblin@windriver.com>
wrote:

>
> On 7/6/20 11:01 AM, Tim Orling wrote:
>
>
>
> On Mon, Jul 6, 2020 at 7:51 AM Khem Raj <raj.khem@gmail.com> wrote:
>
>> python3-mock does not exist as independent package
>>
>
> Sakib,
> Perhaps you were bringing it in from meta-cloud-services?
> http://layers.openembedded.org/layerindex/recipe/120255/
>
> Yeah, he's been adding things to support python3-requests-toolbelt (with
> my help), but we missed that dependency. I think requests-toolbelt is minor
> enough (while being a useful addition) that it should be in meta-python
> alongside python3-requests, so for completeness' sake we should move
> python3-mock in as well.
>
>
There are other things that need python3-mock to run ptests (not that I
remember an example off the top of my head at the moment), so I agree this
makes sense. Please coordinate with meta-cloud-services maintainers to make
sure they don’t have any concerns.

>
>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> Cc: Sakib Sajal <sakib.sajal@windriver.com>
>> ---
>>  .../recipes-devtools/python/python3-requests-toolbelt_0.9.1.bb   | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/meta-python/recipes-devtools/python/
>> python3-requests-toolbelt_0.9.1.bb b/meta-python/recipes-devtools/python/
>> python3-requests-toolbelt_0.9.1.bb
>> index e075c019d0..27d122cd52 100644
>> --- a/meta-python/recipes-devtools/python/
>> python3-requests-toolbelt_0.9.1.bb
>> +++ b/meta-python/recipes-devtools/python/
>> python3-requests-toolbelt_0.9.1.bb
>> @@ -20,7 +20,6 @@ RDEPENDS_${PN} += " \
>>  RDEPENDS_${PN}-ptest += " \
>>         ${PYTHON_PN}-pytest \
>>         ${PYTHON_PN}-betamax \
>> -       ${PYTHON_PN}-mock \
>>  "
>>
>>  do_install_ptest() {
>> --
>> 2.27.0
>>
>>
>>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 4483 bytes --]

      reply	other threads:[~2020-07-07  1:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06 14:51 [meta-python][PATCH] python3-requests-toolbelt: Remove py3-mock from rdeps Khem Raj
2020-07-06 15:01 ` [oe] " Tim Orling
2020-07-06 17:51   ` Khem Raj
2020-07-06 18:47   ` Trevor Gamblin
2020-07-07  1:02     ` Tim Orling [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANx9H-CmM8ZDt8TZxmQhCk55ygRQPzDzEwYQYKh9S9WsRc6Qvg@mail.gmail.com \
    --to=ticotimo@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=sakib.sajal@windriver.com \
    --cc=trevor.gamblin@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.