All of lore.kernel.org
 help / color / mirror / Atom feed
From: Danomi Manchego <danomimanchego123@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] boot/arm-trusted-firmware: add missing host-uboot-tools select
Date: Tue, 23 Jul 2019 08:16:45 -0400	[thread overview]
Message-ID: <CANxTyt6eBFuMTicjL7ZGGGGwkQX9kOWx621aJEZ6bxaYR92nsA@mail.gmail.com> (raw)
In-Reply-To: <20190723040220.scotkwrqgsxjcsjl@sapphire.tkos.co.il>

Hi Baruch,

On Tue, Jul 23, 2019 at 2:32 AM Baruch Siach <baruch@tkos.co.il> wrote:
>
> Hi Danomi,
>
> On Mon, Jul 22, 2019 at 09:34:24PM -0400, Danomi Manchego wrote:
> > The "Build BL31 U-Boot image" option uses mkimage to make atf-uboot.ub,
> > and has a make dependency on host-uboot-tools.  Therefore, the Config.in
> > option should select BR2_PACKAGE_HOST_UBOOT_TOOLS.  (Just like similar
> > options in linux, package/xvisor, and fs/cpio.)
> >
> > Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
> > ---
> >  boot/arm-trusted-firmware/Config.in | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/boot/arm-trusted-firmware/Config.in b/boot/arm-trusted-firmware/Config.in
> > index beb95fb..2e41bd0 100644
> > --- a/boot/arm-trusted-firmware/Config.in
> > +++ b/boot/arm-trusted-firmware/Config.in
> > @@ -86,6 +86,7 @@ config BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31
> >  config BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31_UBOOT
> >       bool "Build BL31 U-Boot image"
> >       select BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31
> > +     select BR2_PACKAGE_HOST_UBOOT_TOOLS
>
> BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31_UBOOT adds host-uboot-tools to
> ARM_TRUSTED_FIRMWARE_DEPENDENCIES already. Why isn't that enough?
>
> baruch

Well, why isn't the dependency enough in xvisor for the
BR2_PACKAGE_XVISOR_CREATE_UBOOT_IMAGE option?  Why isn't it enough in
cpio for the BR2_TARGET_ROOTFS_CPIO_UIMAGE option?  I don't know, but
I imagine that the answer is partially due to "truth in advertising"
with regards to the menu configuration (because "host uboot-tools" can
*appear* to be deselected but it gets built anyway if something
depends on it but does not select it).

Isn't consistency with the other places reason enough?

Danomi -

>
> >       help
> >         Generates a U-Boot image named atf-uboot.ub containing
> >         bl31.bin.  This is used for example by the Xilinx version of
>
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2019-07-23 12:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23  1:34 [Buildroot] [PATCH 1/1] boot/arm-trusted-firmware: add missing host-uboot-tools select Danomi Manchego
2019-07-23  4:02 ` Baruch Siach
2019-07-23 12:16   ` Danomi Manchego [this message]
2019-07-23 13:24     ` Baruch Siach
2019-07-23 22:30       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANxTyt6eBFuMTicjL7ZGGGGwkQX9kOWx621aJEZ6bxaYR92nsA@mail.gmail.com \
    --to=danomimanchego123@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.