Re: RTL2831U driver updates

[Alistair Buxton <a.j.buxton@gmail.com>]

On 8 August 2011 20:50, Antti Palosaari <crope@iki.fi> wrote:
> On 08/06/2011 08:13 AM, Alistair Buxton wrote:
>> On 6 August 2011 04:56, Alistair Buxton <a.j.buxton@gmail.com> wrote:
>>> With the latest driver my card never gets a signal lock, not even
>>> once. As before there are no error messages. It does always probe
>>> correctly now though.
>>
>> I tracked this down to:
>>
>> http://git.linuxtv.org/anttip/media_tree.git/commit/e5d3e4f27f0cf71c29d12ce39752195d8994dea3
>>
>> and to this specific change:
>>
>> @@ -459,21 +563,14 @@ static int rtl28xxu_power_ctrl(struct
>> dvb_usb_device *d, int onoff)
>>                 sys0 = sys0 & 0x0f;
>>                 sys0 |= 0xe0;
>>         } else {
>> -
>> -#if 0 /* keep */
>>                 /*
>>                  * FIXME: Use .fe_ioctl_override() to prevent demod
>> -                * IOCTLs in case of device is powered off.
>> -                *
>> -                * For now we cannot power off device because most FE IOCTLs
>> -                * can be performed only when device is powered.
>> -                * Using IOCTLs when device is powered off will result errors
>> -                * because register access to demod fails.
>> +                * IOCTLs in case of device is powered off. Or change
>> +                * RTL2830 demod not perform requestesd IOCTL & IO when sleep.
>>                  */
>>                 gpio &= (~0x01); /* GPIO0 = 0 */
>>                 gpio |= 0x10; /* GPIO4 = 1 */
>>                 sys0 = sys0 & (~0xc0);
>> -#endif
>>         }
>>
>>         deb_info("%s: WR SYS0=%02x GPIO_OUT_VAL=%02x\n", __func__, sys0, gpio);
>>
>>
>> Commenting those three lines makes the driver work again. Don't know
>> yet if it will keep working for longer than a couple of days.
>
> I suspect it is tuner GPIO. It is not clear which GPIO pins are used for
> tuner reset. I should find this out soon. Most likely MXL5005S tuner
> reset have connected to different GPIO than MT2060 design I have.
>
> Could you test commenting out only gpio change to see if it helps?


After a couple of days the card locked up again just like before. Are
there more gpio bits I need to comment? The LED GPIO is definitely
right. Also, is there a way to check the status of the GPIO from
userspace, without recompiling the module? Like maybe with i2c-dev or
something?


-- 
Alistair Buxton
a.j.buxton@gmail.com