1.Could you please review this patch and suggest me any changes? 2. How do I know whether this patch is approved or not? Thanks Sanjana. On Wed, 13 Mar 2019, 08:39 Sanjana Sanikommu, wrote: > Subject: [PATCH] Staging: rtl8188eu: rtw_recv.c: fix a tab indent issue > > Fix a tab issue in 2 lines which removed no extra space before starting > a line warning. This warning appeared when I compiled checkpatch.pl in > rtw_recv.c, > > Signed-off-by: Sanjana Sanikommu > > --- > drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c > b/drivers/staging/rtl8188eu/core/rtw_recv.c > index 1d83affc08ce..cc6f1a23da01 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_recv.c > +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c > @@ -24,11 +24,11 @@ static u8 SNAP_ETH_TYPE_APPLETALK_AARP[2] = {0x80, > 0xf3}; > > /* Bridge-Tunnel header (for EtherTypes ETH_P_AARP and ETH_P_IPX) */ > static u8 rtw_bridge_tunnel_header[] = { > - 0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8 > + 0xaa, 0xaa, 0x03, 0x00, 0x00, 0xf8 > }; > > static u8 rtw_rfc1042_header[] = { > - 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 > + 0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00 > }; > > static void rtw_signal_stat_timer_hdl(struct timer_list *t); > -- > 2.17.1 > > > On Wed, Mar 13, 2019 at 8:36 AM Sanjana Sanikommu < > sanjana99reddy99@gmail.com> wrote: > >> I reedited the file by taking note of the above mentioned mistakes. I >> would be resending the patch as this has lot of mistakes :) >> >> On Wed, Mar 13, 2019 at 1:18 AM Greg KH >> wrote: >> >>> On Tue, Mar 12, 2019 at 12:41:37PM -0700, Greg KH wrote: >>> > On Wed, Mar 13, 2019 at 12:56:34AM +0530, Sanjana Reddy wrote: >>> > > Fixed a space in 2 lines which removed warnings. >>> > > Signed-off-by: Sanjana >>> > >>> > Please put a blank line between the changelog text and your >>> > signed-off-by: line, otherwise the tools will choke :( >>> >>> Also we need a "real" name here, not just a first name. And your email >>> address should be correct, it's bouncing right now :( >>> >>> thanks, >>> >>> greg k-h >>> >>