From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B319EC072B5 for ; Fri, 24 May 2019 09:19:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77CF92168B for ; Fri, 24 May 2019 09:19:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389830AbfEXJTP convert rfc822-to-8bit (ORCPT ); Fri, 24 May 2019 05:19:15 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:41474 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389569AbfEXJTP (ORCPT ); Fri, 24 May 2019 05:19:15 -0400 Received: by mail-qk1-f196.google.com with SMTP id m18so6398796qki.8 for ; Fri, 24 May 2019 02:19:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7+56V34UO6f1yOAZuwtgojwUdZjIaQZjLcC9WjhkGCQ=; b=IyHf/WRrKHqFTo+D64eyTWFIIpzDdRFUwSrakRL6BUQM5v5fBDQ7if9SKKcwuQDOvJ u1d6m2xv3ivLP0UuAvsYrOPru/La3G+hRZbvIZZ054x2XvUCqfplZyy7JU0aPVwgvrc5 fiV3d8JaUN8KHalJQ/QuyFLcPUXIrmcTMXAgfd3CTZ44CpnQPSh8vHV13gNEw3TWk8Fq 1gV16FNPr8UuknTyLRGmpuSOy1hc2pJ3/DbJgN5L/vOluVAEVr0+36SAFowCzKptSmr4 CtRawi3eLHlVHK6lRI8OIUP+qKzKJhaXIdSCLP9P8RIokMoz4ZdKkKm2VC53GjZPfYcW jiZg== X-Gm-Message-State: APjAAAX17XO5mJgDVzQ+a6olUULd6HF4R69ml/HnLCqXqYl+KfRcH+6u bKwLkOi9YoetCtRyF/tnl4odlvizA6mMnTeWDVVUEA== X-Google-Smtp-Source: APXvYqyqRQ8qrEWXLm6DLEhWSrO4D17JdjftR/wwDYbEaVtlNU2URLnO29TsiKgTY4ax7bO0iBI4+FiH/tbgRbNM1WQ= X-Received: by 2002:a37:ea16:: with SMTP id t22mr53587620qkj.337.1558689554600; Fri, 24 May 2019 02:19:14 -0700 (PDT) MIME-Version: 1.0 References: <20190521132712.2818-1-benjamin.tissoires@redhat.com> <20190521132712.2818-10-benjamin.tissoires@redhat.com> <003d01d511de$9da229c0$d8e67d40$@emc.com.tw> <011a01d5120f$146265e0$3d2731a0$@emc.com.tw> In-Reply-To: <011a01d5120f$146265e0$3d2731a0$@emc.com.tw> From: Benjamin Tissoires Date: Fri, 24 May 2019 11:19:03 +0200 Message-ID: Subject: Re: [PATCH v2 09/10] Input: elan_i2c - correct the width/size base value To: =?UTF-8?B?5buW5bSH5qau?= Cc: Dmitry Torokhov , Rob Herring , Aaron Ma , Hans de Goede , "open list:HID CORE LAYER" , lkml , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 24, 2019 at 11:00 AM 廖崇榮 wrote: > > Hi > > -----Original Message----- > From: Benjamin Tissoires [mailto:benjamin.tissoires@redhat.com] > Sent: Friday, May 24, 2019 3:06 PM > To: 廖崇榮 > Cc: Dmitry Torokhov; Rob Herring; Aaron Ma; Hans de Goede; open list:HID CORE LAYER; lkml; devicetree@vger.kernel.org > Subject: Re: [PATCH v2 09/10] Input: elan_i2c - correct the width/size base value > > On Fri, May 24, 2019 at 5:13 AM 廖崇榮 wrote: > > > > Hi Benjamin, > > > > Thanks so much for all you do for Elan touchpad. > > > > For the width_*, I have a question for it. > > Our antenna sensors fully occupied the whole touchpad PCB. > > > > The Gap between 2 sensors are 7.5 mil (0.19mm). > > That's why we did not minus one trace. > > So, with the P52 I have: > [ +0.000009] max: (3045,1731) drivers/input/mouse/elan_i2c_core.c:428 > [ +0.000003] traces: (24,14) drivers/input/mouse/elan_i2c_core.c:429 > [ +0.000002] size: (98,55) drivers/input/mouse/elan_i2c_core.c:430 > [ +0.000001] res: (31,31) drivers/input/mouse/elan_i2c_core.c:431 > > calculated size (max/res): 98 x 56 mm > true size, as measured: 101 x 60 mm > > I list layout information of P52 touchpad as below. > Physical size : 99 x 58 mm > Active Area size : ~ 97 * 56 mm, (boarding is 1.008mm for each side) > > Sensor layout: > X Pitch : 4.0286 mm > Y Pitch : 4.0147 mm > > Which gives (without the minus 1): > width_x = max_x / x_traces = 3045 / 24 = 126.875 -> 3.9885 mm width_y = max_y / y_traces = 1731 / 14 = 123.643 -> 4.0927 mm > > -> this gives a total size of the touchpad of: 96 x 57 mm (width_x * > 24, width_y * 14) > > With the minus 1: > width_x = max_x / x_traces = 3045 / 23 = 132.391 -> 4.2707 mm width_y = max_y / y_traces = 1731 / 14 = 133.154 -> 4.2953 mm > > -> this gives a total size of the touchpad of: 102 x 60 mm (width_x * > 24, width_y * 14) > and considering traces-1: 98 x 56 mm > > Removing 1 to the number of traces gave a squarer values in rows and columns, and this is what is done in the PS/2 driver. > Also, going back to the size of the touchpad gives a better value when removing 1 on the *traces. > So maybe when forwarding the properties we should remove one there in the PS/2 driver? > > Removing 1 trace may be better for some of previous touchpad. (depending on sensor pattern) > mk_* indicate the number of trace which is touched, and it's not a precise value. > I think the usability won't change too much whether removing one trace. > PS/2 have supported plenty of touchpad. It's better to remain the same. > OK, so I guess I should just drop this patch from the series then. Cheers, Benjamin