All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Kosina <jikos@kernel.org>,
	"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] HID: add USB_HID dependancy on some USB HID drivers
Date: Thu, 2 Dec 2021 17:47:45 +0100	[thread overview]
Message-ID: <CAO-hwJJO2v+exB_ORoC7Y3xk8LaDBrSYPtqOnoCrZTDv=bZdzA@mail.gmail.com> (raw)
In-Reply-To: <20211202114819.2511954-1-gregkh@linuxfoundation.org>

On Thu, Dec 2, 2021 at 12:48 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> Some HID drivers are only for USB drivers, yet did not depend on
> CONFIG_USB_HID.  This was hidden by the fact that the USB functions were
> stubbed out in the past, but now that drivers are checking for USB
> devices properly, build errors can occur with some random
> configurations.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---

Now applied to hid.git branch for-5.16/upstream-fixes

Cheers,
Benjamin

>  drivers/hid/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 9f5435b55949..828c2995ec34 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -214,7 +214,7 @@ config HID_CHICONY
>
>  config HID_CORSAIR
>         tristate "Corsair devices"
> -       depends on HID && USB && LEDS_CLASS
> +       depends on USB_HID && LEDS_CLASS
>         help
>         Support for Corsair devices that are not fully compliant with the
>         HID standard.
> @@ -560,7 +560,7 @@ config HID_LENOVO
>
>  config HID_LOGITECH
>         tristate "Logitech devices"
> -       depends on HID
> +       depends on USB_HID
>         depends on LEDS_CLASS
>         default !EXPERT
>         help
> @@ -951,7 +951,7 @@ config HID_SAITEK
>
>  config HID_SAMSUNG
>         tristate "Samsung InfraRed remote control or keyboards"
> -       depends on HID
> +       depends on USB_HID
>         help
>         Support for Samsung InfraRed remote control or keyboards.
>
> --
> 2.34.1
>


      reply	other threads:[~2021-12-02 16:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02 11:48 [PATCH] HID: add USB_HID dependancy on some USB HID drivers Greg Kroah-Hartman
2021-12-02 16:47 ` Benjamin Tissoires [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAO-hwJJO2v+exB_ORoC7Y3xk8LaDBrSYPtqOnoCrZTDv=bZdzA@mail.gmail.com' \
    --to=benjamin.tissoires@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.