Re: [RESEND 00/25] Rid W=1 warnings from HID

From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Anssi Hannula" <anssi.hannula@gmail.com>,
	"Bruno Prémont" <bonbons@linux-vserver.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Daniel Drubin" <daniel.drubin@intel.com>,
	"Dario Pagani" <dario.pagani.146+linuxk@gmail.com>,
	dri-devel@lists.freedesktop.org,
	"Henrik Rydberg" <rydberg@bitmath.org>,
	"Jiri Kosina" <jikos@kernel.org>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
	"Kim Kuparinen" <kimi.h.kuparinen@gmail.com>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	linaro-mm-sig@lists.linaro.org,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	linux-iio <linux-iio@vger.kernel.org>,
	"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
	linux-media@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	"Linux USB Mailing List" <linux-usb@vger.kernel.org>,
	"Lopez Casado" <nlopezcasad@logitech.com>,
	"L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>,
	"Masaki Ota" <masaki.ota@jp.alps.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"message to" <vojtech@ucw.cz>,
	"Michael Haboustak" <mike-@cinci.rr.com>,
	"Rushikesh S Kadam" <rushikesh.s.kadam@intel.com>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Vojtech Pavlik" <vojtech@suse.cz>,
	"Zhang Lixu" <lixu.zhang@intel.com>
Subject: Re: [RESEND 00/25] Rid W=1 warnings from HID
Date: Thu, 8 Apr 2021 13:43:52 +0200	[thread overview]
Message-ID: <CAO-hwJJrn4mzPwzYvusGNa6KhLZ+kCn=svzgGJD=6q+Urz=YsA@mail.gmail.com> (raw)
In-Reply-To: <20210408070605.GC2961413@dell>

On Thu, Apr 8, 2021 at 9:06 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Wed, 07 Apr 2021, Benjamin Tissoires wrote:
>
> > On Tue, Apr 6, 2021 at 10:56 AM Lee Jones <lee.jones@linaro.org> wrote:
> > >
> > > On Fri, 26 Mar 2021, Lee Jones wrote:
> > >
> > > > This set is part of a larger effort attempting to clean-up W=1
> > > > kernel builds, which are currently overwhelmingly riddled with
> > > > niggly little warnings.
> > > >
> > > > Lee Jones (25):
> > > >   HID: intel-ish-hid: Remove unused variable 'err'
> > > >   HID: ishtp-hid-client: Move variable to where it's actually used
> > > >   HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> > > >   HID: intel-ish: Supply some missing param descriptions
> > > >   HID: intel-ish: Fix a naming disparity and a formatting error
> > > >   HID: usbhid: Repair a formatting issue in a struct description
> > > >   HID: intel-ish-hid: Fix a little doc-rot
> > > >   HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> > > >   HID: hid-alps: Correct struct misnaming
> > > >   HID: intel-ish-hid: Fix potential copy/paste error
> > > >   HID: hid-core: Fix incorrect function name in header
> > > >   HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
> > > >     header
> > > >   HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
> > > >   HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> > > >   HID: hid-picolcd_core: Remove unused variable 'ret'
> > > >   HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
> > > >     abuses
> > > >   HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> > > >   HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> > > >   HID: hid-uclogic-params: Ensure function names are present and correct
> > > >     in kernel-doc headers
> > > >   HID: hid-sensor-custom: Remove unused variable 'ret'
> > > >   HID: wacom_sys: Demote kernel-doc abuse
> > > >   HID: hid-sensor-hub: Remove unused struct member 'quirks'
> > > >   HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> > > >     definition
> > > >   HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
> > > >   HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
> > >
> > > These have been on the list for a couple of weeks now.
> > >
> > > Is there anything I can do to help expedite their merge?
> > >
> > > I'm concerned since -rc6 has just been released.
> >
> > Sorry for the delay.
> >
> > I am currently queuing them locally and running a few tests on them. I
> > don't expect anything to happen, but better be safe than anything.
> >
> > FWIW, I am splitting the series in 3:
> > - 11 patches for intel ish are going to be queued in for-5.13/intel-ish
> > - the thrustmaster one in for-5.13/thrustmaster
> > - the rest (13 patches) will be sent in for-5.13/warnings.
>
> Sounds good to me.  Thanks Benjamin.
>
After a few attempts at fixing my CI, I have now pushed this series as
mentioned previously.

Cheers,
Benjamin