From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFEFCC43461 for ; Thu, 8 Apr 2021 11:44:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D094C6112F for ; Thu, 8 Apr 2021 11:44:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231476AbhDHLoX (ORCPT ); Thu, 8 Apr 2021 07:44:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54461 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231381AbhDHLoR (ORCPT ); Thu, 8 Apr 2021 07:44:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617882246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ojI36GqCcSZZKDE7ZJzPVmk370WGjalSRm35dXXJjG4=; b=cP/38F0Ig561h9crlZ7dPXsSrvSLlzzPpn996I9h/JgowVF3rGQaroA1//Dka/XISWeE4p 1/p1Y4M8Wgj+FQc3BTlwCjpJ+53/QO1KVR02ziTofeXFV4qo0GntDr/L3YDBNbsh3er0ax PtgJZjaDhhI5EwDNDCcn7OiabWIobF4= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-DCbWhX_ENIm8IPgZKFEe5w-1; Thu, 08 Apr 2021 07:44:04 -0400 X-MC-Unique: DCbWhX_ENIm8IPgZKFEe5w-1 Received: by mail-pg1-f198.google.com with SMTP id p64so1225410pga.10 for ; Thu, 08 Apr 2021 04:44:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ojI36GqCcSZZKDE7ZJzPVmk370WGjalSRm35dXXJjG4=; b=lvFGkaWloL34GSai9DBKTwRlBXHL3h3nLkJq2YdyrIRsiali6nW8C7jMzShpFda26j MU6ruWhTC58vnfABMX5ibwxsjB9yasyZEvWVYPufNrGROldkKRBwChZlQk8cEWOKpPTu Bi37ZCxWA4+XSjAlx9/HYpQYGiUpDD2t3nyj02mLuN/awNVk+0OiKZRYHzdeYsk2YGLW zkE1iHF8zmYjCOfAYFCVKK2hhzYEtSd6Say9zWGpvfiDdYTmHUvtNi/CbuNClKAVWZY6 RyUORajUfvwIgebsvSZKw2B6Ia+i4DQoM6MACksZcDjmx3lJq8erzLWSzekT/ZaHqrCT yNlw== X-Gm-Message-State: AOAM531LcO+wBRflRw0qOjVVo9++DUWzp5xBQarvCJAuv++PvyHQlisl JI4itJ7jYCiiWB/M8i9C7D783aKV5y4VC/BRA8mdUnOYVu/0ON1+n2Sp3vo7eaXt2Va42TFkJ2p SqGCOIwh2N8uW8G+OnOnyh5HqquiRIKSTczktfdup X-Received: by 2002:a17:90a:bb0c:: with SMTP id u12mr8097129pjr.234.1617882243164; Thu, 08 Apr 2021 04:44:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXWoD4uZFLjX3W//O+WsdPii+AkkUpUkXJnA0RNfYAyKcsVoeyvydz2BlU3advUFqA9gChFbY15nQwPpfmGv8= X-Received: by 2002:a17:90a:bb0c:: with SMTP id u12mr8097093pjr.234.1617882242926; Thu, 08 Apr 2021 04:44:02 -0700 (PDT) MIME-Version: 1.0 References: <20210326143458.508959-1-lee.jones@linaro.org> <20210406085605.GS2916463@dell> <20210408070605.GC2961413@dell> In-Reply-To: <20210408070605.GC2961413@dell> From: Benjamin Tissoires Date: Thu, 8 Apr 2021 13:43:52 +0200 Message-ID: Subject: Re: [RESEND 00/25] Rid W=1 warnings from HID To: Lee Jones Cc: lkml , Alexandre Torgue , Anssi Hannula , =?UTF-8?Q?Bruno_Pr=C3=A9mont?= , =?UTF-8?Q?Christian_K=C3=B6nig?= , Daniel Drubin , Dario Pagani , dri-devel@lists.freedesktop.org, Henrik Rydberg , Jiri Kosina , Jonathan Cameron , Kai-Heng Feng , Kim Kuparinen , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , linaro-mm-sig@lists.linaro.org, Linux ARM , linux-iio , "open list:HID CORE LAYER" , linux-media@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Linux USB Mailing List , Lopez Casado , "L. Vinyard, Jr" , Masaki Ota , Maxime Coquelin , message to , Michael Haboustak , Rushikesh S Kadam , Srinivas Pandruvada , Sumit Semwal , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Vojtech Pavlik , Zhang Lixu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 8, 2021 at 9:06 AM Lee Jones wrote: > > On Wed, 07 Apr 2021, Benjamin Tissoires wrote: > > > On Tue, Apr 6, 2021 at 10:56 AM Lee Jones wrote: > > > > > > On Fri, 26 Mar 2021, Lee Jones wrote: > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > > > Lee Jones (25): > > > > HID: intel-ish-hid: Remove unused variable 'err' > > > > HID: ishtp-hid-client: Move variable to where it's actually used > > > > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' > > > > HID: intel-ish: Supply some missing param descriptions > > > > HID: intel-ish: Fix a naming disparity and a formatting error > > > > HID: usbhid: Repair a formatting issue in a struct description > > > > HID: intel-ish-hid: Fix a little doc-rot > > > > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses > > > > HID: hid-alps: Correct struct misnaming > > > > HID: intel-ish-hid: Fix potential copy/paste error > > > > HID: hid-core: Fix incorrect function name in header > > > > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in > > > > header > > > > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() > > > > HID: hid-kye: Fix incorrect function name for kye_tablet_enable() > > > > HID: hid-picolcd_core: Remove unused variable 'ret' > > > > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote > > > > abuses > > > > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs > > > > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses > > > > HID: hid-uclogic-params: Ensure function names are present and correct > > > > in kernel-doc headers > > > > HID: hid-sensor-custom: Remove unused variable 'ret' > > > > HID: wacom_sys: Demote kernel-doc abuse > > > > HID: hid-sensor-hub: Remove unused struct member 'quirks' > > > > HID: hid-sensor-hub: Move 'hsdev' description to correct struct > > > > definition > > > > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues > > > > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning > > > > > > These have been on the list for a couple of weeks now. > > > > > > Is there anything I can do to help expedite their merge? > > > > > > I'm concerned since -rc6 has just been released. > > > > Sorry for the delay. > > > > I am currently queuing them locally and running a few tests on them. I > > don't expect anything to happen, but better be safe than anything. > > > > FWIW, I am splitting the series in 3: > > - 11 patches for intel ish are going to be queued in for-5.13/intel-ish > > - the thrustmaster one in for-5.13/thrustmaster > > - the rest (13 patches) will be sent in for-5.13/warnings. > > Sounds good to me. Thanks Benjamin. > After a few attempts at fixing my CI, I have now pushed this series as mentioned previously. Cheers, Benjamin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A63C433ED for ; Thu, 8 Apr 2021 11:46:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E50C86112F for ; Thu, 8 Apr 2021 11:46:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E50C86112F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8zMGWbXQTFH7abIhll+lws0JXDFscQiEpC0pb6D5gSg=; b=H162KBrR4EwXdsTw2smwmg/8N pww+g4BEz6f+lEK9CSyWTblgPHPmVS5uJ++1pmQATt7HcezCFsmuG3EtCPH6Bi5OTrb1Z67VfpygM 6enNkrwBRsjjfYTKGDma8qsrTgVGxXoJCISvf/WKwFpdtoIMeFtsYMIIfiHX1jr4U0FpArlmkou34 yq4c0sxFMpjF2jAJQdInoQe4hwj2EzpZc3wLDP3LbCTXdHJfCuNawrc5kSkKnPQK4uPwMp/Da2NdZ wQYpSLaM2r1/xKn87TXKaMnoPbGQr8VIlpLcsg7NXunzc0YQ4A5K45hKiHp0djhASVmFt4xXuHJGE nggUGcYoQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUT55-007sYH-BZ; Thu, 08 Apr 2021 11:44:15 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUT4z-007sX2-Ki for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 11:44:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617882248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ojI36GqCcSZZKDE7ZJzPVmk370WGjalSRm35dXXJjG4=; b=EUJXk+U4oRzsq/vP8gejeHjC4TDjBUOecp/kMKB4VVi+7HZGb99cPevIDOgeWoKeiGOd6V wh3NjcJ/bpGlldElMaDe9MzRdgqrFf+q/7vcMCHcFiU7bDOcEizW3ik5dnqJ8QqxTDG/Pu pfKndW1l6FhCmd3m6mOggUGEK7vmM6o= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-252-Ir42UwsdMpWWjvQWXoAKGQ-1; Thu, 08 Apr 2021 07:44:04 -0400 X-MC-Unique: Ir42UwsdMpWWjvQWXoAKGQ-1 Received: by mail-pg1-f200.google.com with SMTP id h8so1223838pgd.8 for ; Thu, 08 Apr 2021 04:44:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ojI36GqCcSZZKDE7ZJzPVmk370WGjalSRm35dXXJjG4=; b=swW6uXZqvMI3JvUNHrfbRQZFu6p8S/LWABEp+Mm6QEIvAOis4F6OeA9hu0rHbrq8VC VegRU9YfD9y5DzqhMMEvm1xROp34AYJf5wacDeYmaCFS9xa3ikMMawCmbAQzfzxQmFIM vXYkp5FRxOI/21AcGiuFXpAhptwFzezorhLFsE3mBRu7wzZsBeC4ATQEkYGHePJGZUFv 1waHxUMbzHqECVF0ZSa4BVrfnPrFaWHXQE3xjvORShaRtb+Uf3yUtuI0CS2L3jS2cASz BICBKRUbUeSzQlz9lKRQQaT+sP7HJI5fBsSF1YQHJhmVJshe0O71/EMiTppp4MCQshfj Pdhw== X-Gm-Message-State: AOAM5330l0tWKEDS2Vq2ssIX2XxNlnTWMcD2CdQFsTx5r3Fa9wU0TPXC oUlLv17xdb84TJAigPzTP8a9oLfFBunifhzfzVZ6oiSDVGYjMaku0LisqRZvjfN4KfIW+xkh9Zi /+SKTg4O56XukMtqL3SmnEYilW86yBa0qXtdOeK2/1A0oAV51qQc= X-Received: by 2002:a17:90a:bb0c:: with SMTP id u12mr8097123pjr.234.1617882243164; Thu, 08 Apr 2021 04:44:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXWoD4uZFLjX3W//O+WsdPii+AkkUpUkXJnA0RNfYAyKcsVoeyvydz2BlU3advUFqA9gChFbY15nQwPpfmGv8= X-Received: by 2002:a17:90a:bb0c:: with SMTP id u12mr8097093pjr.234.1617882242926; Thu, 08 Apr 2021 04:44:02 -0700 (PDT) MIME-Version: 1.0 References: <20210326143458.508959-1-lee.jones@linaro.org> <20210406085605.GS2916463@dell> <20210408070605.GC2961413@dell> In-Reply-To: <20210408070605.GC2961413@dell> From: Benjamin Tissoires Date: Thu, 8 Apr 2021 13:43:52 +0200 Message-ID: Subject: Re: [RESEND 00/25] Rid W=1 warnings from HID To: Lee Jones Cc: lkml , Alexandre Torgue , Anssi Hannula , =?UTF-8?Q?Bruno_Pr=C3=A9mont?= , =?UTF-8?Q?Christian_K=C3=B6nig?= , Daniel Drubin , Dario Pagani , dri-devel@lists.freedesktop.org, Henrik Rydberg , Jiri Kosina , Jonathan Cameron , Kai-Heng Feng , Kim Kuparinen , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , linaro-mm-sig@lists.linaro.org, Linux ARM , linux-iio , "open list:HID CORE LAYER" , linux-media@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Linux USB Mailing List , Lopez Casado , "L. Vinyard, Jr" , Masaki Ota , Maxime Coquelin , message to , Michael Haboustak , Rushikesh S Kadam , Srinivas Pandruvada , Sumit Semwal , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Vojtech Pavlik , Zhang Lixu Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=btissoir@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_124410_403179_86EF9CA3 X-CRM114-Status: GOOD ( 22.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 8, 2021 at 9:06 AM Lee Jones wrote: > > On Wed, 07 Apr 2021, Benjamin Tissoires wrote: > > > On Tue, Apr 6, 2021 at 10:56 AM Lee Jones wrote: > > > > > > On Fri, 26 Mar 2021, Lee Jones wrote: > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > > > Lee Jones (25): > > > > HID: intel-ish-hid: Remove unused variable 'err' > > > > HID: ishtp-hid-client: Move variable to where it's actually used > > > > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' > > > > HID: intel-ish: Supply some missing param descriptions > > > > HID: intel-ish: Fix a naming disparity and a formatting error > > > > HID: usbhid: Repair a formatting issue in a struct description > > > > HID: intel-ish-hid: Fix a little doc-rot > > > > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses > > > > HID: hid-alps: Correct struct misnaming > > > > HID: intel-ish-hid: Fix potential copy/paste error > > > > HID: hid-core: Fix incorrect function name in header > > > > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in > > > > header > > > > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() > > > > HID: hid-kye: Fix incorrect function name for kye_tablet_enable() > > > > HID: hid-picolcd_core: Remove unused variable 'ret' > > > > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote > > > > abuses > > > > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs > > > > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses > > > > HID: hid-uclogic-params: Ensure function names are present and correct > > > > in kernel-doc headers > > > > HID: hid-sensor-custom: Remove unused variable 'ret' > > > > HID: wacom_sys: Demote kernel-doc abuse > > > > HID: hid-sensor-hub: Remove unused struct member 'quirks' > > > > HID: hid-sensor-hub: Move 'hsdev' description to correct struct > > > > definition > > > > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues > > > > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning > > > > > > These have been on the list for a couple of weeks now. > > > > > > Is there anything I can do to help expedite their merge? > > > > > > I'm concerned since -rc6 has just been released. > > > > Sorry for the delay. > > > > I am currently queuing them locally and running a few tests on them. I > > don't expect anything to happen, but better be safe than anything. > > > > FWIW, I am splitting the series in 3: > > - 11 patches for intel ish are going to be queued in for-5.13/intel-ish > > - the thrustmaster one in for-5.13/thrustmaster > > - the rest (13 patches) will be sent in for-5.13/warnings. > > Sounds good to me. Thanks Benjamin. > After a few attempts at fixing my CI, I have now pushed this series as mentioned previously. Cheers, Benjamin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB5E3C43460 for ; Thu, 8 Apr 2021 11:44:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86860611AF for ; Thu, 8 Apr 2021 11:44:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86860611AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD3306EAB6; Thu, 8 Apr 2021 11:44:08 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE63C6EAB6 for ; Thu, 8 Apr 2021 11:44:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617882246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ojI36GqCcSZZKDE7ZJzPVmk370WGjalSRm35dXXJjG4=; b=cP/38F0Ig561h9crlZ7dPXsSrvSLlzzPpn996I9h/JgowVF3rGQaroA1//Dka/XISWeE4p 1/p1Y4M8Wgj+FQc3BTlwCjpJ+53/QO1KVR02ziTofeXFV4qo0GntDr/L3YDBNbsh3er0ax PtgJZjaDhhI5EwDNDCcn7OiabWIobF4= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-ZaofdfVxMbah9Zd2qOm-3A-1; Thu, 08 Apr 2021 07:44:04 -0400 X-MC-Unique: ZaofdfVxMbah9Zd2qOm-3A-1 Received: by mail-pg1-f199.google.com with SMTP id j4so1216154pgs.18 for ; Thu, 08 Apr 2021 04:44:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ojI36GqCcSZZKDE7ZJzPVmk370WGjalSRm35dXXJjG4=; b=BeVXQuLUFwvXPtXAVnZihgvx5c1OBejwdngQsGAdZuCz/kdBxZJniwHztJGo3tO8gP 22YJmSc+iVHaVB95v2f+DbIDCM2tibfyD3Sdn2YK+/7zI03PiIgF4XM79cj+B5yGQf0F YDzg7FjsmqYDc9gPLfkFLWQHTqe7Tkdqt/RYmMOI3BHXJUbpsC0kbd/gdF7NXqwE9+2K tul2b4mDuz4om091sptsERwP8nXUiFhVFH6ctG5z1rheir2/n8lyY2ABfIuHaDCzYhl2 gk65ZO7qOSzUsipLaDjsljtWkdw8mj2OZBwhvXccoapaEud9ui6a4yU1yHK70+K+4r48 A1ig== X-Gm-Message-State: AOAM531Wir+rDF5vkeRIOVThPFtGkhkzlJY20bF/kMsfINjENokWra6U 2OGwu+wzi0BASPbmGWG+LtNAhYgxiCILznbCjWX94e9w5AlHosco2KuEsqLJt+oOdH+bxGaeCcj NNFbtTRMOdN5ihFVkxbNAmd/8F0YUrH8xAUCrFgYrgBiD X-Received: by 2002:a17:90a:bb0c:: with SMTP id u12mr8097133pjr.234.1617882243164; Thu, 08 Apr 2021 04:44:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXWoD4uZFLjX3W//O+WsdPii+AkkUpUkXJnA0RNfYAyKcsVoeyvydz2BlU3advUFqA9gChFbY15nQwPpfmGv8= X-Received: by 2002:a17:90a:bb0c:: with SMTP id u12mr8097093pjr.234.1617882242926; Thu, 08 Apr 2021 04:44:02 -0700 (PDT) MIME-Version: 1.0 References: <20210326143458.508959-1-lee.jones@linaro.org> <20210406085605.GS2916463@dell> <20210408070605.GC2961413@dell> In-Reply-To: <20210408070605.GC2961413@dell> From: Benjamin Tissoires Date: Thu, 8 Apr 2021 13:43:52 +0200 Message-ID: Subject: Re: [RESEND 00/25] Rid W=1 warnings from HID To: Lee Jones Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=btissoir@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Zhang Lixu , linux-iio , Alexandre Torgue , dri-devel@lists.freedesktop.org, Kai-Heng Feng , Anssi Hannula , Kim Kuparinen , Srinivas Pandruvada , Dario Pagani , linux-stm32@st-md-mailman.stormreply.com, Henrik Rydberg , Lopez Casado , Rushikesh S Kadam , Masaki Ota , =?UTF-8?Q?Bruno_Pr=C3=A9mont?= , Vojtech Pavlik , "open list:HID CORE LAYER" , linux-media@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , message to , Jiri Kosina , "L. Vinyard, Jr" , linaro-mm-sig@lists.linaro.org, Michael Haboustak , Linux ARM , Daniel Drubin , Linux USB Mailing List , lkml , Maxime Coquelin , =?UTF-8?Q?Christian_K=C3=B6nig?= , Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Apr 8, 2021 at 9:06 AM Lee Jones wrote: > > On Wed, 07 Apr 2021, Benjamin Tissoires wrote: > > > On Tue, Apr 6, 2021 at 10:56 AM Lee Jones wrote: > > > > > > On Fri, 26 Mar 2021, Lee Jones wrote: > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > > > Lee Jones (25): > > > > HID: intel-ish-hid: Remove unused variable 'err' > > > > HID: ishtp-hid-client: Move variable to where it's actually used > > > > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' > > > > HID: intel-ish: Supply some missing param descriptions > > > > HID: intel-ish: Fix a naming disparity and a formatting error > > > > HID: usbhid: Repair a formatting issue in a struct description > > > > HID: intel-ish-hid: Fix a little doc-rot > > > > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses > > > > HID: hid-alps: Correct struct misnaming > > > > HID: intel-ish-hid: Fix potential copy/paste error > > > > HID: hid-core: Fix incorrect function name in header > > > > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in > > > > header > > > > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() > > > > HID: hid-kye: Fix incorrect function name for kye_tablet_enable() > > > > HID: hid-picolcd_core: Remove unused variable 'ret' > > > > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote > > > > abuses > > > > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs > > > > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses > > > > HID: hid-uclogic-params: Ensure function names are present and correct > > > > in kernel-doc headers > > > > HID: hid-sensor-custom: Remove unused variable 'ret' > > > > HID: wacom_sys: Demote kernel-doc abuse > > > > HID: hid-sensor-hub: Remove unused struct member 'quirks' > > > > HID: hid-sensor-hub: Move 'hsdev' description to correct struct > > > > definition > > > > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues > > > > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning > > > > > > These have been on the list for a couple of weeks now. > > > > > > Is there anything I can do to help expedite their merge? > > > > > > I'm concerned since -rc6 has just been released. > > > > Sorry for the delay. > > > > I am currently queuing them locally and running a few tests on them. I > > don't expect anything to happen, but better be safe than anything. > > > > FWIW, I am splitting the series in 3: > > - 11 patches for intel ish are going to be queued in for-5.13/intel-ish > > - the thrustmaster one in for-5.13/thrustmaster > > - the rest (13 patches) will be sent in for-5.13/warnings. > > Sounds good to me. Thanks Benjamin. > After a few attempts at fixing my CI, I have now pushed this series as mentioned previously. Cheers, Benjamin _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel