From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EBB4C05027 for ; Wed, 1 Feb 2023 10:43:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231431AbjBAKns (ORCPT ); Wed, 1 Feb 2023 05:43:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbjBAKnq (ORCPT ); Wed, 1 Feb 2023 05:43:46 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B70C32CC62 for ; Wed, 1 Feb 2023 02:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675248154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bltFVBhEHfXNoDMWpukukFuhV9he/3kOb9+wG6ySsOI=; b=I3zeoMuRLco/1J03J2gvxlJNFjLA8bhKkCiyL5Nnj2C7Hn+7BMyRJw+NrO90LibNCeQQkd XGgJhiO+a0ohuMGRAXNwXTxjMZLB75HlFXGU1d4HabZI9DLEEC3+8cyxwJt+y+yMFe+Ils Qy0dKYDRKk90hQP+U8HYBVJFpoDiKuA= Received: from mail-yb1-f197.google.com (mail-yb1-f197.google.com [209.85.219.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-288-bppCRb4vOnqjhGCKqjtEpQ-1; Wed, 01 Feb 2023 05:42:33 -0500 X-MC-Unique: bppCRb4vOnqjhGCKqjtEpQ-1 Received: by mail-yb1-f197.google.com with SMTP id p125-20020a257483000000b0080f161f5253so12334863ybc.21 for ; Wed, 01 Feb 2023 02:42:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bltFVBhEHfXNoDMWpukukFuhV9he/3kOb9+wG6ySsOI=; b=V+61Z2qEIZjd6n6QbEefxDo5HbYMRUuconYZXSyjkR6NUt1GUgixWeVeoTXspYtxwy oRIj/rGSn0eTs6LTnkuAfpVwEJ7EACAyuo7dVKMvyBqBg0uF5XkxHKuf7BpYV2ABrEQL JwoBIPIkNSWmJ1OuLEJztdG8lXVU5egInTxpzDaQpL7iUNKc88bJjoRMIl1WHdSlN2X3 RxAk8ilyvJiwX86p43ZlHCbKQYStYdgYyI7bC/lF6/CXPqQ4qE4s4zK5+wT//qTiiR/N 5m6KWO3saKaVeWQHJQF0ZidEH8WsywvOhZqbNLfHtL8vFOkR2A4Jkeb5LvNJEWaHAUOp bj2Q== X-Gm-Message-State: AO0yUKU7eNh763gA6bKxXGrEJHW9bee43cdzlvWr/mCrK1ytyD2WNA5P r8iJUNHEbyYla9ImA2hZZsJzzZ+IDnbdkrEguaEf5L/tEGmPUoqTWc2EbWBiFsIVVKn/Ehy7toY UzkYMWDCiFVbIL/srCwes0zS/Vt/hPMMsalFvtbGY X-Received: by 2002:a25:e001:0:b0:735:ea17:94d9 with SMTP id x1-20020a25e001000000b00735ea1794d9mr295380ybg.378.1675248152479; Wed, 01 Feb 2023 02:42:32 -0800 (PST) X-Google-Smtp-Source: AK7set/nOQlGCejCPSeRFXJAbHnnr5nt0177Ds1BMktMEZlVCYFUQtDqgg60bZ4PhLFjfgTUgTKrUgTSQjzR+rKOoOs= X-Received: by 2002:a25:e001:0:b0:735:ea17:94d9 with SMTP id x1-20020a25e001000000b00735ea1794d9mr295372ybg.378.1675248152233; Wed, 01 Feb 2023 02:42:32 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Benjamin Tissoires Date: Wed, 1 Feb 2023 11:42:21 +0100 Message-ID: Subject: Re: Dependency on non-existing config I2C_DMI_CORE in commit a2f416bf062a ("HID: multitouch: Add quirks for flipped axes") To: Allen Ballway Cc: Lukas Bulwahn , linux-input@vger.kernel.org, Jiri Kosina , Jiri Kosina , Henrik Rydberg , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Allen, On Tue, Jan 31, 2023 at 3:44 PM Allen Ballway wrote: > > Hi Lukas, > > Thanks for catching this, that's definitely a mistake in my code. > That was supposed to be CONFIG_I2C_HID_CORE. > > Should I send a follow-up patch for this, or another revision for the patch? > It looks like it hasn't been pulled into the mainline branch yet and I'm not > familiar with updating it while in a maintainer branch. I saw that you sent a followup on the initial series, but can you instead send a fix on top of https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/log/?h=for-6.3/multitouch (hid.git tree, branch for-6.3/multitouch)? Cheers, Benjamin > > Thanks, > Allen > > On Mon, Jan 30, 2023 at 3:44 AM Lukas Bulwahn wrote: > > > > Dear Allen, > > > > with commit a2f416bf062a ("HID: multitouch: Add quirks for flipped > > axes"), you add code that is dependent on the CONFIG_I2C_DMI_CORE. > > However, this config symbol has not been defined anywhere in the > > kernel repository. Is this a mistake in your code and you intended to > > refer to another config symbol? Is there another patch to come that > > adds this config symbol? Or is this a config symbol that only exists > > in some out-of-tree repository? > > > > Something might be odd here, because this code is effectively dead now > > with being dependent on a non-existing config symbol. > > > > Best regards, > > > > Lukas >