From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47550C43603 for ; Wed, 18 Dec 2019 15:50:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A15A20717 for ; Wed, 18 Dec 2019 15:50:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F2Bv6OYQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727341AbfLRPuQ (ORCPT ); Wed, 18 Dec 2019 10:50:16 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:44305 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726960AbfLRPuQ (ORCPT ); Wed, 18 Dec 2019 10:50:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576684214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TSBYzL3RvwtpaWRXze2pPZqSb38MjVmyVZC3bc6sEik=; b=F2Bv6OYQdB7cZKUbkMyWWi60QPJqfzx9HajjBvzY5qxjaK0/Jri/Co6fD3Hc1GcpLRjNcD NhPPV0G9VcuA/LTGzkgxRm0N+fB0+3XPVUrCDof4wrbCOFQNMhkiDfSWvlVAjfiP+uNcCZ 0w1k3qpvY0WgJbxuV6aLnM9v1VcBOPo= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-ElED3G1oPxubStsl4zvCIQ-1; Wed, 18 Dec 2019 10:50:08 -0500 X-MC-Unique: ElED3G1oPxubStsl4zvCIQ-1 Received: by mail-qk1-f199.google.com with SMTP id 24so1570975qka.16 for ; Wed, 18 Dec 2019 07:50:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TSBYzL3RvwtpaWRXze2pPZqSb38MjVmyVZC3bc6sEik=; b=D4hwsWDcTMdVH/H2isTQf+i/KWxKrPqGxJmF2rI9Z7UGqGyVMjuhwdt8ssOkxEuWt5 xrFwWEZzEIlUjSUfcAlJ14Y7Xk1y5QkfzVVUElJa1+SuM1IMGy27aJbrqf86y0XxVrhl kGC7KU5uRAJD5rFKBxzs4juIElnkjSVAKb0DKMQC9Zir2unIHIXZhRUpXJAuIuZs8xp/ E9wKzjR5QVNjKHWmxqmpEOroVfTCPiSmbZHavO2mQzJWRPtJoJU7437yblTHuHwF/yFh tKqtV3ck/dLKC6yAprieYlLRHe402jHOCbL7KfeZQTN0uULC8U3ifa/Mqz7Ul6HfokCq 7Gug== X-Gm-Message-State: APjAAAVKUooY4k5v006O8ZBe8QTUdsa8HSV0i9nfR9B9t830bdG6Wwvh 3S9GQXxXxWCfYWo4w4rlG9eUoaqaI+igSpCNqy7PDIsMMHWGYtvLTib6EGds1sb0A6AbcxoVK0Q mWGrb4HDrgz+hlUMYoQlUVXqcar6AYfB8zBebH2Vg X-Received: by 2002:ad4:43c4:: with SMTP id o4mr2969070qvs.101.1576684207555; Wed, 18 Dec 2019 07:50:07 -0800 (PST) X-Google-Smtp-Source: APXvYqwL3AIVYpfTBgHpMz7x9eLQxybCBM1cNKRjEYz6tWakShna5PjExsgap3j5RTv8+91Vbu47QONGylUi0McygWM= X-Received: by 2002:ad4:43c4:: with SMTP id o4mr2969056qvs.101.1576684207299; Wed, 18 Dec 2019 07:50:07 -0800 (PST) MIME-Version: 1.0 References: <_0snBXtGhwWiRLYmuVIeDLYkvksMVMxiBv1lW_bTTaFpcVN45l6yCU5gWZ_5oJr8SQOZA6qCZSkVskkEX0ZePpboYtDYRsTdVg3xfcwmw6M=@protonmail.com> In-Reply-To: From: Benjamin Tissoires Date: Wed, 18 Dec 2019 16:49:56 +0100 Message-ID: Subject: Re: [PATCH v8 0/2] Logitech HID++ Bluetooth LE support To: Mazin Rezk Cc: "linux-input@vger.kernel.org" , "jikos@kernel.org" , "linux-kernel@vger.kernel.org" , =?UTF-8?Q?Filipe_La=C3=ADns?= Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 18, 2019 at 3:44 PM Benjamin Tissoires wrote: > > Hi Mazin, > > On Sun, Nov 24, 2019 at 10:05 PM Mazin Rezk wrote: > > > > On Sunday, October 27, 2019 1:44 PM, Mazin Rezk wrote: > > > > > This series allows hid-logitech-hidpp to support Bluetooth LE HID++ > > > devices. Only the MX Master (b012 and b01e) is added right now but more > > > HID++ Bluetooth LE devices can be added once they are tested. > > > > > > Changes since [v7]: > > > - Squashed "HID: logitech-hidpp: Support MX Master (b012, b01e) > > > over Bluetooth" into "HID: logitech-hidpp: Support translations > > > from short to long reports" > > > > > > Changes since [v6]: > > > > > > - Based patch on "HID: logitech-hidpp: rework device validation" > > > > > > - Removed the need for additional quirks > > > > > > Changes since [v5]: > > > > > > - Fixed bug where added quirks would overflow an unsigned long > > > > > > - Changed the reserved quirk class bits from 0..20 to 0..15 > > > > > > Changes since [v4]: > > > > > > - Omitted "HID: logitech: Add feature 0x0001: FeatureSet" > > > > > > - Stored WirelessDeviceStatus feature index in hidpp_device > > > > > > - Made Bluetooth quirk class alias quirks instead of vice versa > > > > > > - Omitted non-tested devices > > > > > > Changes since [v3]: > > > > > > - Renamed hidpp20_featureset_get_feature to > > > hidpp20_featureset_get_feature_id. > > > > > > - Re-ordered hidpp20_featureset_get_count and > > > hidpp20_featureset_get_feature_id based on their command IDs. > > > > > > - Made feature_count initialize to 0 before running > > > hidpp20_get_features. > > > > > > Changes since [v2]: > > > > > > - Split up the single patch into a series > > > > > > Changes since [v1]: > > > > > > - Added WirelessDeviceStatus support > > > > > > [v7] https://lore.kernel.org/lkml/t5LOL-A4W7aknqQdC-3TavitC94BY_Ra1qyxCZMh_nprrDNSl4UF-jYpWtaDSU-0oQ5xzRyAo9o_mvSnA78bib_p6I3ePSJnTrp3Eb0X_yg=@protonmail.com > > > [v6] https://lore.kernel.org/lkml/ggKipcQplIlTFmoP3hPnrQ-7_5-C0PKGd5feFymts3uenIBA8zOwz47YmKheD34H1rpkguDAGdx5YbS9UqpwfjT5Ir0Lji941liLVp--QtQ=@protonmail.com > > > [v5] https://lore.kernel.org/lkml/Mbf4goGxXZTfWwWtQQUke_rNf8kezpNOS9DVEVHf6RnnmjS1oRtMOJf4r14WfCC6GRYVs7gi0uZcIJ18Va2OJowzSbyMUGwLrl6I5fjW48o=@protonmail.com > > > [v4] https://lore.kernel.org/lkml/uBbIS3nFJ1jdYNLHcqjW5wxQAwmZv0kmYEoeoPrxNhfzi6cHwmCOY-ewdqe7S1hNEj-p4Hd9D0_Y3PymUTdh_6WFXuMmIYUkV2xaKCPMYz0=@protonmail.com > > > [v3] https://lore.kernel.org/lkml/l7xYjnA9EGfZe03FsrFhnH2aMq8qS8plWhHVvOtY_l4ShZ1NV6HA6hn9aI-jAzbLYUGFCIQCIKkx9z42Uoj4-AZDwBfRcAecYIn-0ZA5upE=@protonmail.com > > > [v2] https://www.spinics.net/lists/linux-input/msg63467.html > > > [v1] https://www.spinics.net/lists/linux-input/msg63317.html > > > > > > Mazin Rezk (2): > > > HID: logitech-hidpp: Support translations from short to long reports > > > HID: logitech-hidpp: Support WirelessDeviceStatus connect events > > > > > > drivers/hid/hid-logitech-hidpp.c | 69 +++++++++++++++++++++++++++----- > > > 1 file changed, 59 insertions(+), 10 deletions(-) > > > > > > --- > > > 2.23.0 > > > > I recently saw "HID: logitech-hidpp: Silence intermittent > > get_battery_capacity errors" get applied into the kernel, would I need to > > rebase this patch on top of https://patchwork.kernel.org/patch/11243871/ > > No worries, your series still applies cleanly (git magic). > > I am in the process of doing some final tests for this series, and I > plan to merge it for 5.6. Sorry we missed 5.5. And done. Applied to for-5.6/logitech, sorry for the delay. Cheers, Benjamin > > Cheers, > Benjamin > > > > > Thanks, > > Mazin > >