Re: [PATCH v2] HID: multitouch: Add support for Google Whiskers Touchpad

[Benjamin Tissoires <benjamin.tissoires@redhat.com>]

On Thu, Apr 21, 2022 at 9:46 AM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Tue, 5 Apr 2022, Marek Maślanka wrote:
>
> > The Google Whiskers touchpad does not work properly with the default
> > multitouch configuration. Instead, use the same configuration as Google
> > Rose.
> >
> > Signed-off-by: Marek Maslanka <mm@semihalf.com>
> > ---
> >
> > Changes in v2:
> >   - As a HID device group use HID_GROUP_MULTITOUCH_WIN_8.
> >
> >  drivers/hid/hid-multitouch.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> > index 99eabfb4145b..87a92f2654c0 100644
> > --- a/drivers/hid/hid-multitouch.c
> > +++ b/drivers/hid/hid-multitouch.c
> > @@ -2178,6 +2178,9 @@ static const struct hid_device_id mt_devices[] = {
> >       { .driver_data = MT_CLS_GOOGLE,
> >               HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY, USB_VENDOR_ID_GOOGLE,
> >                       USB_DEVICE_ID_GOOGLE_TOUCH_ROSE) },
> > +     { .driver_data = MT_CLS_GOOGLE,
> > +             HID_DEVICE(BUS_USB, HID_GROUP_MULTITOUCH_WIN_8,
> > USB_VENDOR_ID_GOOGLE,
> > +                     USB_DEVICE_ID_GOOGLE_WHISKERS) },
>
> This device is already claimed by google-hammer driver though ... ?

See my answer at [0].

hid-google-hammer entry is using the group HID_GROUP_GENERIC, and here
we use HID_GROUP_MULTITOUCH_WIN_8, so the 2 are not stepping on each
other's toes.

FWIW:
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Cheers,
Benjamin

[0] https://lore.kernel.org/linux-input/CAO-hwJ+18Ce_A8F-QVp=TJj2iu60r=f4MkrktYbou-rkXsj+mA@mail.gmail.com/

>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>