From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kiernan Date: Mon, 14 May 2018 21:39:04 +0100 Subject: [U-Boot] [PATCH v3 10/13] fastboot: Extract common definitions from USB fastboot In-Reply-To: References: <1526288948-24977-1-git-send-email-alex.kiernan@gmail.com> <1526288948-24977-11-git-send-email-alex.kiernan@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, May 14, 2018 at 8:53 PM Simon Glass wrote: > Hi, > On 14 May 2018 at 03:09, Alex Kiernan wrote: > > Move strcmp_l1() to include/common.h so we can can call it from elsewhere. > > Move FASTBOOT_VERSION to include/fastboot.h so when we merge the UDP code > > we only have one definition. > > > > Signed-off-by: Alex Kiernan > > --- > > > > Changes in v3: > > - new > > > > Changes in v2: None > > > > drivers/usb/gadget/f_fastboot.c | 10 ---------- > > include/common.h | 13 +++++++++++++ > > include/fastboot.h | 2 ++ > > 3 files changed, 15 insertions(+), 10 deletions(-) > Can you please add this to string.h instead? We are trying to reduce / > remove common.h When I was looking through the size changes, I realised that by the time I was done I'd removed this completely, so I'll just drop it altogether. -- Alex Kiernan