From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kiernan <alex.kiernan@gmail.com>
Date: Fri, 12 Apr 2019 14:03:59 +0100
Subject: [U-Boot] [PATCH v2 2/2] tools: fit_image: Add the loadable
	property to configs
In-Reply-To: <1552379663-13984-2-git-send-email-abel.vesa@nxp.com>
References: <1552379663-13984-1-git-send-email-abel.vesa@nxp.com>
 <1552379663-13984-2-git-send-email-abel.vesa@nxp.com>
Message-ID: <CAO5Uq5ROYrfFJq_5cSJqTCnzVVGpF24hjn7-R_AS0e-u1L7i6w@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, Mar 12, 2019 at 8:34 AM Abel Vesa <abel.vesa@nxp.com> wrote:
>
> When running mkimage with "-f auto", the loadable property
> needs to be set in order to allow SPL FIT support to boot.
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>

I've just bisected out to this commit breaking Y-Modem booting of FIT
U-Boot on am335x. Right now I'm at a bit of a loss as to why, as I
can't find a code path where FIT_LOADABLE_PROP would be treated
differently between UART and MMC booting (which still works).

That said the loadables stuff with this patch doesn't seem to match up
with what doc/uImage.FIT/howto.txt has to say about loadables:

/ {
    timestamp = <0x5cb08987>;
    description = "Firmware image with one or more FDT blobs";
    creator = "U-Boot mkimage 2019.04-00217-g38927694f48a-dirty";
    #address-cells = <0x00000001>;
    images {
        firmware-1 {
            data-size = <0x0005e204>;
            data-offset = <0x00000000>;
            description = "U-Boot 2019.04-00217-g38927694f48a-dirty
for A335XHUB board";
            type = "firmware";
            arch = "arm";
            os = "u-boot";
            compression = "none";
            load = <0x80800000>;
            entry = <0x00000000>;
        };
        fdt-1 {
            data-size = <0x000080c4>;
            data-offset = <0x0005e204>;
            description = "A335XHUB-0001";
            type = "firmware";
            arch = "arm";
            compression = "none";
        };
        fdt-2 {
            data-size = <0x000088f4>;
            data-offset = <0x000662c8>;
            description = "A335XHUB-0003";
            type = "firmware";
            arch = "arm";
            compression = "none";
        };
    };
    configurations {
        default = "conf-1";
        conf-1 {
            description = "A335XHUB-0001";
            firmware = "firmware-1";
            loadables = "firmware-1";
            fdt = "fdt-1";
        };
        conf-2 {
            description = "A335XHUB-0003";
            firmware = "firmware-1";
            loadables = "firmware-1";
            fdt = "fdt-2";
        };
    };
};

Still digging...

-- 
Alex Kiernan