From: Alex Kiernan <alex.kiernan@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/1 v1] cmd: gpio: Correct do_gpio() return value
Date: Tue, 10 Mar 2020 09:47:33 +0000 [thread overview]
Message-ID: <CAO5Uq5SPGGENPnoAdzs4bwWq3ao9-VUj9OT3CWLdX-68K4EXjQ@mail.gmail.com> (raw)
In-Reply-To: <20200208000558.GM13379@bill-the-cat>
On Sat, Feb 8, 2020 at 12:06 AM Tom Rini <trini@konsulko.com> wrote:
>
> On Sun, Jan 05, 2020 at 08:10:56PM +0100, Luka Kovacic wrote:
>
> > Use the correct return value in function do_gpio() and update
> > commands documentation with the return values from command_ret_t enum.
> >
> > CMD_RET_SUCCESS is returned on command success and CMD_RET_FAILURE is
> > returned on command failure.
> >
> > The command was returning the pin value, which caused confusion when
> > debugging (#define DEBUG).
> >
> > Signed-off-by: Luka Kovacic <luka.kovacic@sartura.hr>
> > Tested-by: Robert Marko <robert.marko@sartura.hr>
>
> Applied to u-boot/master, thanks!
>
I just pulled in HEAD for a test build and our boot scripts are broken
with this gpio change - I don't see a way to get the value of a gpio
pin in a script now?
Whilst I agree what's there was wrong, I'm really not sure we can
change an existing interface like this.
--
Alex Kiernan
next prev parent reply other threads:[~2020-03-10 9:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 19:10 [PATCH 0/1 v1] cmd: gpio: Correct do_gpio() return value Luka Kovacic
2020-01-05 19:10 ` [PATCH 1/1 " Luka Kovacic
2020-01-23 12:31 ` Tom Rini
2020-01-23 21:04 ` Luka Kovačič
2020-01-23 21:12 ` Tom Rini
2020-01-27 6:30 ` [PATCH 1/2 v1] cmd: doc: Update command return values luka.kovacic at sartura.hr
2020-01-27 6:30 ` [PATCH 2/2 v1] cmd: gpio: Add the command return value to the help text luka.kovacic at sartura.hr
2020-01-30 2:17 ` [PATCH 1/1 v1] cmd: gpio: Correct do_gpio() return value Simon Glass
2020-01-30 18:52 ` Tom Rini
2020-01-31 2:27 ` Simon Glass
2020-01-31 20:59 ` Tom Rini
2020-02-02 22:50 ` Simon Glass
2020-02-08 0:05 ` Tom Rini
2020-03-10 9:47 ` Alex Kiernan [this message]
2020-03-10 12:37 ` Tom Rini
2020-03-10 13:23 ` Alex Kiernan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO5Uq5SPGGENPnoAdzs4bwWq3ao9-VUj9OT3CWLdX-68K4EXjQ@mail.gmail.com \
--to=alex.kiernan@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.