From: Jeff Merkey <linux.mdb@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, peterz@infradead.org, luto@kernel.org
Subject: Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints
Date: Sat, 19 Dec 2015 16:12:43 -0700 [thread overview]
Message-ID: <CAO6TR8XQK-NNYSTbSuL_Y88TXEWPeqVBQF49LmrNwO4mkbn3Sg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1512191603300.28591@nanos>
I cleaned up the areas you identified and I am building and testing
the the patch
with the debugger test harness. As soon as it passes the build completes and
it passes the test harness I will submit v4 of the patch.
Jeff
On 12/19/15, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Mon, 14 Dec 2015, Jeff Merkey wrote:
>> + /*
>> + * check if we got an execute breakpoint
>> + * from the dr7 register. if we did, set
>> + * the resume flag to avoid int1 recursion.
>
> Malformatted comment as any other comment you touched.
>
>> + */
>> + if ((dr7 & (3 << ((i * 4) + 16))) == 0)
>> + args->regs->flags |= X86_EFLAGS_RF;
>
> This still uses magic numbers instead of the proper defines. I asked
> for that before.
>
> Thanks,
>
> tglx
>
prev parent reply other threads:[~2015-12-19 23:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 6:12 [PATCH V3] Fix INT1 Recursion with unregistered breakpoints Jeff Merkey
2015-12-15 18:37 ` Jeff Merkey
2015-12-15 19:12 ` Jeff Merkey
2015-12-19 15:05 ` Thomas Gleixner
2015-12-19 22:22 ` Jeff Merkey
2015-12-19 23:12 ` Jeff Merkey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO6TR8XQK-NNYSTbSuL_Y88TXEWPeqVBQF49LmrNwO4mkbn3Sg@mail.gmail.com \
--to=linux.mdb@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.