[PATCH] input: synaptics: min_max quirk for Thinkpad E440

[PATCH] input: synaptics: min_max quirk for Thinkpad E440

[Filip Ayazi]

Sets min_max_quirk values for LEN2006 touchpad found in Lenovo Thinkpad E440
(board_id=2691).

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=89641
Signed-off-by: Filip Ayazi <filipayazi@gmail.com>
---
 drivers/input/mouse/synaptics.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index dda6058..63942d4 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -154,6 +154,11 @@ static const struct min_max_quirk min_max_pnpid_table[] = {
 	},
 	{
 		(const char * const []){"LEN2006", NULL},
+		{2691, 2691},
+		1024, 5045, 2457, 4832
+	},
+	{
+		(const char * const []){"LEN2006", NULL},
 		{ANY_BOARD_ID, ANY_BOARD_ID},
 		1264, 5675, 1171, 4688
 	},
-- 
1.9.1

Re: [PATCH] input: synaptics: min_max quirk for Thinkpad E440

[Daniel Martin]

On 25 March 2015 at 02:20, Filip Ayazi <filipayazi@gmail.com> wrote:
> Sets min_max_quirk values for LEN2006 touchpad found in Lenovo Thinkpad E440
> (board_id=2691).

Dmitry already applied a patch for the E440:
    http://www.spinics.net/lists/linux-input/msg37497.html

Re: [PATCH] input: synaptics: min_max quirk for Thinkpad E440

[Ramiro Morales]

On Wed, Mar 25, 2015 at 6:04 AM, Daniel Martin <consume.noise@gmail.com> wrote:
> On 25 March 2015 at 02:20, Filip Ayazi <filipayazi@gmail.com> wrote:
>> Sets min_max_quirk values for LEN2006 touchpad found in Lenovo Thinkpad E440
>> (board_id=2691).
>
> Dmitry already applied a patch for the E440:
>     http://www.spinics.net/lists/linux-input/msg37497.html

There are two great things about this second submission from Filip.

First, it confirms the values sent by the hardware in a second laptop
as reported by touchpad-edge-detector.

Second, it reveals I made a stupid mistake transcribing the y_max
value to the quirks able. The correct value is 4832 and my patch
wrongly contains 4632.

I'm very sorry for this. I see my patch has already been pushed to the
'for-linus' branch and I don't know which process should we follow to
fix the issue.

Regards,

-- 
Ramiro Morales

Re: [PATCH] input: synaptics: min_max quirk for Thinkpad E440

[Dmitry Torokhov]

On Wed, Mar 25, 2015 at 09:57:51AM -0300, Ramiro Morales wrote:
> On Wed, Mar 25, 2015 at 6:04 AM, Daniel Martin <consume.noise@gmail.com> wrote:
> > On 25 March 2015 at 02:20, Filip Ayazi <filipayazi@gmail.com> wrote:
> >> Sets min_max_quirk values for LEN2006 touchpad found in Lenovo Thinkpad E440
> >> (board_id=2691).
> >
> > Dmitry already applied a patch for the E440:
> >     http://www.spinics.net/lists/linux-input/msg37497.html
> 
> There are two great things about this second submission from Filip.
> 
> First, it confirms the values sent by the hardware in a second laptop
> as reported by touchpad-edge-detector.
> 
> Second, it reveals I made a stupid mistake transcribing the y_max
> value to the quirks able. The correct value is 4832 and my patch
> wrongly contains 4632.
> 
> I'm very sorry for this. I see my patch has already been pushed to the
> 'for-linus' branch and I don't know which process should we follow to
> fix the issue.

My 'for-linus' branch is stable so we need a fixup on top on the
incorrect patch, the same way as if it was already in mainline.

Thanks.

-- 
Dmitry

Re: [PATCH] input: synaptics: min_max quirk for Thinkpad E440

[Filip Ayazi]

On 03/25/2015 06:22 PM, Dmitry Torokhov wrote:
> On Wed, Mar 25, 2015 at 09:57:51AM -0300, Ramiro Morales wrote:
>> On Wed, Mar 25, 2015 at 6:04 AM, Daniel Martin <consume.noise@gmail.com> wrote:
>>> On 25 March 2015 at 02:20, Filip Ayazi <filipayazi@gmail.com> wrote:
>>>> Sets min_max_quirk values for LEN2006 touchpad found in Lenovo Thinkpad E440
>>>> (board_id=2691).
>>> Dmitry already applied a patch for the E440:
>>>      http://www.spinics.net/lists/linux-input/msg37497.html
>> There are two great things about this second submission from Filip.
>>
>> First, it confirms the values sent by the hardware in a second laptop
>> as reported by touchpad-edge-detector.
>>
>> Second, it reveals I made a stupid mistake transcribing the y_max
>> value to the quirks able. The correct value is 4832 and my patch
>> wrongly contains 4632.
>>
>> I'm very sorry for this. I see my patch has already been pushed to the
>> 'for-linus' branch and I don't know which process should we follow to
>> fix the issue.
> My 'for-linus' branch is stable so we need a fixup on top on the
> incorrect patch, the same way as if it was already in mainline.
I too have noticed the typo in the commit earlier today and have a patch
to apply on top to fix it, which I will sent in another email.

Sincerely,

Filip Ayazi