Regards,

Kun

--000000000000ba553f059221e327-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::441; helo=mail-pf1-x441.google.com; envelope-from=venture@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="CXkyuZwN"; dkim-atps=neutral Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46Rw4t0t51zDqLW for ; Tue, 10 Sep 2019 03:24:13 +1000 (AEST) Received: by mail-pf1-x441.google.com with SMTP id y22so9587709pfr.3 for ; Mon, 09 Sep 2019 10:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=rib0SP+APdhS5qIqKziiYhd2VqEDI1oDOSZrK15+mlY=; b=CXkyuZwNjw9IY/qOnfKDbcp9p6iqAYaXgFuYYAvwftxLnEMYFsg/4ZCh+7UyqkvVuE +x4i2yV+MHVFM1omocdrxzz3qnNHsEOFATiJuRH+tO1BAKRb3/9c69OUZIkTGM08L6vd DBWo894xfHX312bGdd5VOfD5sDqSm8A1STopnNNK/PYUBvasEj+qxKf2uB2glnbAA1AC bzguBEJuKI6prOU5Mav4f4QGZ2k24viwmPy/yKSG2prZuHdwKieUV9HXcXkyaZrp/m1p vQ3vYAZq9Qx92r8t8/sd41oZzoCE3HDGDxI3KXsexN0yOfL/lq67ljsyJAcDiu78WZMk 5pLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=rib0SP+APdhS5qIqKziiYhd2VqEDI1oDOSZrK15+mlY=; b=LUsljnUHql+LKGX8861GFIJPkHA9wEJ7/fq5SRx6ntEs3ptl2mPGT7FnRg4PEOqj+8 TTqdRjeI6TWxzILcudSipkRFHC/0qy8PKO03TDT3nUflgGzRbsuz8IfoSamgM37p8rNS dY/nIuXPwU7NoocFsUFw1cwFhRLk/7oJ3zkgKGOcK1sOM0JCWZi9l70Rgulccydl51F/ DQSQ9fInf94ILHlg7BX/7CjoKA+mR0SsTD/WTSqPWBA2VcPr5AI9mYlEOp/x+CqvCAw4 wJy9qu2DpPz7+2ZAYpnmdO2IVFbP/fAed3xwWbSHzaP1sDnz+p2XCOYLBDTB31pyVqlC G0og== X-Gm-Message-State: APjAAAWfQmIFQVuaV7P4IiHiPrG4OSban1901qbbYVW1jcy9TdFy2n4N f14F0TI8A6pF6yMjWxl3BTOyLjxQhQdwQm7DIKDcoQ== X-Google-Smtp-Source: APXvYqzV5EtF4/4tKSyXEvFoYZMrAeiFNvT42hqwA4yN1zCqsj/c8Igp/9iUSMX9GZCik7tJzT0b1o2vN1lejZGvM68= X-Received: by 2002:a65:6288:: with SMTP id f8mr22325125pgv.292.1568049850608; Mon, 09 Sep 2019 10:24:10 -0700 (PDT) MIME-Version: 1.0 References: <369926533c3e448c9d1a0d28391fd688@quantatw.com> <02128993d3064b53ac289500746666ab@quantatw.com>

In-Reply-To: From: Patrick Venture Date: Mon, 9 Sep 2019 10:23:59 -0700 Message-ID: Subject: Re: [phosphor-pid-control] scaling issue To: Kun Yi Cc: =?UTF-8?B?SGFuayBMaW91ICjlionmmYnnv7Ap?= , "openbmc@lists.ozlabs.org" , James Feist Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Sep 2019 17:24:15 -0000 On Mon, Sep 9, 2019 at 10:12 AM Kun Yi wrote: > > Sorry about the regression issue, Hank. > IIRC I proposed to have separate groups of min/max values in D-Bus and js= on files since they convey different semantics. > At the end the min/max value was merged in the current way, because the a= ssumption that min/max values in json is only used for fan pwm and nothing = else -- which obviously is not true now. > Should we revisit the approach? Having something like 'fanPwmScale' as a = separate config param is a cleaner approach in my opinion. Kun, it was my understanding that the issue they're seeing is that they're reading min/max from dbus. But maybe I have if flipped. I disagree that fanPwmScale is cleaner because it's now specific to fan pwm. In theory, using min/max could have some future purpose. Perhaps minWrite/maxWrite would be more ... separate. However, I think the issue seen is unrelated. > > On Mon, Sep 9, 2019 at 9:59 AM Patrick Venture wrote= : >> >> On Thu, Sep 5, 2019 at 12:25 AM Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) = wrote: >> > >> > Hi Patrick, >> > >> > >> > Sorry for not clearly stating our problem. We have the following issue= : >> > >> > >> > temp sensor gets 31(C) -> 31 / 0.255 =3D 121.57 -> pid uses 127.57 as = input for temp sensor -> >> > >> > stepwise fan table output 100 duty -> full speed fan >> >> Ok, so you're getting a dbus-based min/max value and you want to >> ignore it? In the json configuration, if you set the values to 0, >> they are set to the default (0), so there'd be no clean way to know to >> ignore dbus in this case, without adding a small check to only >> consider min/max from dbus when sensor is not temp/margin. Basically, >> only care about min/max on dbus if type is "fan" >> >> If that's right, James do you have a cycle to look at this one-liner? >> >> > >> > >> > As a result, fan will be at full speed while temp is low. Before the c= ommit fc2e803 [1], this won't happen. The root cause is that, before fc2e80= 3, pid will use config min/max, which is 0 in our case. This would not trig= ger scaling function, namely scaleSensorReading, in util.cpp. However, afte= r such commit, min/max would be non-zero (-128/127 from DBus). This will tr= igger scaling function. >> > >> > >> > [1] https://github.com/openbmc/phosphor-pid-control/commit/fc2e803f5d9= 256944e18c7c878a441606b1f121c >> > >> > >> > Hank >> > >> > >> > ________________________________ >> > From: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) >> > Sent: Monday, September 2, 2019 4:52 PM >> > To: Patrick Venture >> > Cc: James Feist; openbmc@lists.ozlabs.org >> > Subject: Re: [phosphor-pid-control] scaling issue >> > >> > >> > Hi Patrick, >> > >> > >> > Since we use phosphor-sel-logger [1] at the same time, we do assign mi= n and max of temp sensors to Dbus (max: 127, min: -128). So in the present = case, our temp value will be divided by 0.255 (also due to exponent is -3 h= ere). This will cause re-scaling problem. Therefore there should be an stat= ement to distinguish sensor types. If it is "temp", then one assigns 0 to t= he min and max from Dbus. >> > >> > >> > [1] https://github.com/openbmc/phosphor-sel-logger/blob/3d300fca24b308= 64b3e9a4f5768cfe5e769458ae/include/sensorutils.hpp#L59 >> > >> > >> > Hank >> > >> > >> > ________________________________ >> > From: Patrick Venture >> > Sent: Friday, August 30, 2019 1:47 AM >> > To: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) >> > Cc: James Feist; openbmc@lists.ozlabs.org >> > Subject: Re: [phosphor-pid-control] scaling issue >> > >> > PTAL - https://gerrit.openbmc-project.xyz/24827 - this is merged, and >> > the srcrev bump should propagate into openbmc/openbmc in a day or two. >> > >> > On Wed, Aug 28, 2019 at 11:00 PM Hank Liou (=E5=8A=89=E6=99=89=E7=BF= =B0) wrote: >> > > >> > > Hi Patrick, >> > > >> > > I think it's OK to parse the config min&max for temp sensors. >> > > >> > > Any suggestion? >> > > >> > > Thanks, >> > > Hank >> > > >> > > >-----Original Message----- >> > > >From: openbmc [mailto:openbmc- >> > > >bounces+hank.liou=3Dquantatw.com@lists.ozlabs.org] On Behalf Of Han= k Liou >> > > >(=E5=8A=89=E6=99=89=E7=BF=B0) >> > > >Sent: Friday, August 23, 2019 4:31 PM >> > > >To: Patrick Venture ; James Feist >> > > > >> > > >Cc: openbmc@lists.ozlabs.org >> > > >Subject: RE: [phosphor-pid-control] scaling issue >> > > > >> > > >Hi Patrick, >> > > > >> > > >>-----Original Message----- >> > > >>From: Patrick Venture [mailto:venture@google.com] >> > > >>Sent: Wednesday, August 21, 2019 10:32 PM >> > > >>To: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) ; James Feist >> > > >> >> > > >>Cc: openbmc@lists.ozlabs.org >> > > >>Subject: Re: [phosphor-pid-control] scaling issue >> > > >> >> > > >>On Wed, Aug 21, 2019 at 1:11 AM Hank Liou (=E5=8A=89=E6=99=89=E7= =BF=B0) >> > > >> wrote: >> > > >>> >> > > >>> Hi All, >> > > >>> >> > > >>> >> > > >>> After commit [1], I found my temp sensor reading would be re-sca= led >> > > >>> by >> > > >>multiplying 1 over 255, making temperature into unfamiliar unit. A= lso >> > > >>the fan rpm reading would lie in [0,1] interval, letting the fan i= nput >> > > >>to be 0 (since the input value of fan is from an integer array [2]= ). Are these >> > > >normal behaviors? >> > > >>Or do I miss something? >> > > >> >> > > >>Are you using dbus configuration or json? If json, can you attach= your config. >> > > >>Since you're saying it was working and now isn't, I'm assuming the= re's >> > > >>something about the config being treated differently with the code >> > > >>changes in an unexpected way. >> > > > >> > > >I found pid control will first read min and max from dbus and then = (before >> > > >commit [1]) revise them if >> > > > >> > > >info->min !=3D conf::inheritValueFromDbus (in dbus/dbuspassive.cpp) >> > > > >> > > >After value initialization, the min and max would be the ones in js= on file (Json >> > > >file [3]). However, after commit [1] the min and max values of conf= ig would >> > > >not be fed into the fan control process. The scaling issue is origi= nated from >> > > >commit [4] with the aim to treat fan rpm as percentage. It seems th= at commit >> > > >[1] unexpectedly affects temp sensors in the sense that the temp is= the >> > > >integer reading not percentage. Before commit [1], it would not re-= scale the >> > > >temp reading since my min and max are 0 [6]. >> > > > >> > > > >> > > > >> > > >There is another issue with commit [1]. Now the fan rpm would be so= mething >> > > >like >> > > > >> > > >1500 / 20000 =3D 0.075 >> > > > >> > > >where rpm max 20000 is from dbus. However the fan input function wo= uld >> > > >transfer double into int, which is 0 for 0.075 (see [5]). Hence the= fan input is 0 >> > > >not percentage. Is there something wrong? >> > > > >> > > >[1] https://github.com/openbmc/phosphor-pid- >> > > >control/commit/fc2e803f5d9256944e18c7c878a441606b1f121c >> > > >[2] https://github.com/openbmc/phosphor-pid- >> > > >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontro= lle >> > > >r.cpp#L86 >> > > >[3] >> > > > { >> > > > "name": "fan1", >> > > > "type": "fan", >> > > > "readPath": "/sys/class/hwmon/hwmon1/fan1_input", >> > > > "writePath": "/sys/class/hwmon/hwmon1/pwm1", >> > > > "min": 0, >> > > > "max": 255 >> > > > }, >> > > > { >> > > > "name": "temp1", >> > > > "type": "temp", >> > > > "readPath": "/xyz/openbmc_project/sensors/temperature/t= emp1", >> > > > "writePath": "", >> > > > "min": 0, >> > > > "max": 0 >> > > > } >> > > >[4] https://github.com/openbmc/phosphor-pid- >> > > >control/commit/75eb769d351434547899186f73ff70ae00d7934a >> > > >[5] https://github.com/openbmc/phosphor-pid- >> > > >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontro= lle >> > > >r.cpp#L64 >> > > >[6] https://github.com/openbmc/phosphor-pid- >> > > >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/dbus/dbuspass= i >> > > >ve.cpp#L158 >> > > > >> > > >> >> > > >>> >> > > >>> >> > > >>> [1] >> > > >>> https://github.com/openbmc/phosphor-pid- >> > > >>control/commit/fc2e803f5d92569 >> > > >>> 44e18c7c878a441606b1f121c >> > > >>> >> > > >>> [2] >> > > >>> https://github.com/openbmc/phosphor-pid- >> > > >>control/blob/a7ec8350d17b70153 >> > > >>> cebe666d3fbe88bddd02a1a/pid/fancontroller.cpp#L86 >> > > >>> >> > > >>> >> > > >>> Thanks, >> > > >>> >> > > >>> >> > > >>> Hank Liou >> > > >>> >> > > >>> Quanta Computer Inc. >> > > >>> >> > > >>> >> > > > >> > > >Sincerely, >> > > >Hank > > > > -- > Regards, > Kun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=james.feist@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46Rw8J0ZvMzDqLW for ; Tue, 10 Sep 2019 03:27:11 +1000 (AEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 10:27:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,486,1559545200"; d="scan'208";a="189088576" Received: from skyhawk.jf.intel.com (HELO [10.54.51.81]) ([10.54.51.81]) by orsmga006.jf.intel.com with ESMTP; 09 Sep 2019 10:27:08 -0700 Subject: Re: [phosphor-pid-control] scaling issue To: Patrick Venture , =?UTF-8?B?SGFuayBMaW91ICjlionmmYnnv7Ap?= Cc: "openbmc@lists.ozlabs.org" References: <369926533c3e448c9d1a0d28391fd688@quantatw.com> <02128993d3064b53ac289500746666ab@quantatw.com>

From: James Feist Message-ID: Date: Mon, 9 Sep 2019 10:27:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Sep 2019 17:27:13 -0000 On 9/9/19 9:57 AM, Patrick Venture wrote: > On Thu, Sep 5, 2019 at 12:25 AM Hank Liou (劉晉翰) wrote: >> >> Hi Patrick, >> >> >> Sorry for not clearly stating our problem. We have the following issue: >> >> >> temp sensor gets 31(C) -> 31 / 0.255 = 121.57 -> pid uses 127.57 as input for temp sensor -> >> >> stepwise fan table output 100 duty -> full speed fan > > Ok, so you're getting a dbus-based min/max value and you want to > ignore it? What is providing the dbus-based min/max? > In the json configuration, if you set the values to 0, > they are set to the default (0), so there'd be no clean way to know to > ignore dbus in this case, without adding a small check to only > consider min/max from dbus when sensor is not temp/margin. Basically, > only care about min/max on dbus if type is "fan" Why is the dbus-based min/max even there if you don't plan on using it? > > If that's right, James do you have a cycle to look at this one-liner? > >> >> >> As a result, fan will be at full speed while temp is low. Before the commit fc2e803 [1], this won't happen. The root cause is that, before fc2e803, pid will use config min/max, which is 0 in our case. This would not trigger scaling function, namely scaleSensorReading, in util.cpp. However, after such commit, min/max would be non-zero (-128/127 from DBus). This will trigger scaling function. >> >> >> [1] https://github.com/openbmc/phosphor-pid-control/commit/fc2e803f5d9256944e18c7c878a441606b1f121c >> >> >> Hank >> >> >> ________________________________ >> From: Hank Liou (劉晉翰) >> Sent: Monday, September 2, 2019 4:52 PM >> To: Patrick Venture >> Cc: James Feist; openbmc@lists.ozlabs.org >> Subject: Re: [phosphor-pid-control] scaling issue >> >> >> Hi Patrick, >> >> >> Since we use phosphor-sel-logger [1] at the same time, we do assign min and max of temp sensors to Dbus (max: 127, min: -128). So in the present case, our temp value will be divided by 0.255 (also due to exponent is -3 here). This will cause re-scaling problem. Therefore there should be an statement to distinguish sensor types. If it is "temp", then one assigns 0 to the min and max from Dbus. >> >> >> [1] https://github.com/openbmc/phosphor-sel-logger/blob/3d300fca24b30864b3e9a4f5768cfe5e769458ae/include/sensorutils.hpp#L59 >> >> >> Hank >> >> >> ________________________________ >> From: Patrick Venture >> Sent: Friday, August 30, 2019 1:47 AM >> To: Hank Liou (劉晉翰) >> Cc: James Feist; openbmc@lists.ozlabs.org >> Subject: Re: [phosphor-pid-control] scaling issue >> >> PTAL - https://gerrit.openbmc-project.xyz/24827 - this is merged, and >> the srcrev bump should propagate into openbmc/openbmc in a day or two. >> >> On Wed, Aug 28, 2019 at 11:00 PM Hank Liou (劉晉翰) wrote: >>> >>> Hi Patrick, >>> >>> I think it's OK to parse the config min&max for temp sensors. >>> >>> Any suggestion? >>> >>> Thanks, >>> Hank >>> >>>> -----Original Message----- >>>> From: openbmc [mailto:openbmc- >>>> bounces+hank.liou=quantatw.com@lists.ozlabs.org] On Behalf Of Hank Liou >>>> (劉晉翰) >>>> Sent: Friday, August 23, 2019 4:31 PM >>>> To: Patrick Venture ; James Feist >>>> >>>> Cc: openbmc@lists.ozlabs.org >>>> Subject: RE: [phosphor-pid-control] scaling issue >>>> >>>> Hi Patrick, >>>> >>>>> -----Original Message----- >>>>> From: Patrick Venture [mailto:venture@google.com] >>>>> Sent: Wednesday, August 21, 2019 10:32 PM >>>>> To: Hank Liou (劉晉翰) ; James Feist >>>>> >>>>> Cc: openbmc@lists.ozlabs.org >>>>> Subject: Re: [phosphor-pid-control] scaling issue >>>>> >>>>> On Wed, Aug 21, 2019 at 1:11 AM Hank Liou (劉晉翰) >>>>> wrote: >>>>>> >>>>>> Hi All, >>>>>> >>>>>> >>>>>> After commit [1], I found my temp sensor reading would be re-scaled >>>>>> by >>>>> multiplying 1 over 255, making temperature into unfamiliar unit. Also >>>>> the fan rpm reading would lie in [0,1] interval, letting the fan input >>>>> to be 0 (since the input value of fan is from an integer array [2]). Are these >>>> normal behaviors? >>>>> Or do I miss something? >>>>> >>>>> Are you using dbus configuration or json? If json, can you attach your config. >>>>> Since you're saying it was working and now isn't, I'm assuming there's >>>>> something about the config being treated differently with the code >>>>> changes in an unexpected way. >>>> >>>> I found pid control will first read min and max from dbus and then (before >>>> commit [1]) revise them if >>>> >>>> info->min != conf::inheritValueFromDbus (in dbus/dbuspassive.cpp) >>>> >>>> After value initialization, the min and max would be the ones in json file (Json >>>> file [3]). However, after commit [1] the min and max values of config would >>>> not be fed into the fan control process. The scaling issue is originated from >>>> commit [4] with the aim to treat fan rpm as percentage. It seems that commit >>>> [1] unexpectedly affects temp sensors in the sense that the temp is the >>>> integer reading not percentage. Before commit [1], it would not re-scale the >>>> temp reading since my min and max are 0 [6]. >>>> >>>> >>>> >>>> There is another issue with commit [1]. Now the fan rpm would be something >>>> like >>>> >>>> 1500 / 20000 = 0.075 >>>> >>>> where rpm max 20000 is from dbus. However the fan input function would >>>> transfer double into int, which is 0 for 0.075 (see [5]). Hence the fan input is 0 >>>> not percentage. Is there something wrong? >>>> >>>> [1] https://github.com/openbmc/phosphor-pid- >>>> control/commit/fc2e803f5d9256944e18c7c878a441606b1f121c >>>> [2] https://github.com/openbmc/phosphor-pid- >>>> control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontrolle >>>> r.cpp#L86 >>>> [3] >>>> { >>>> "name": "fan1", >>>> "type": "fan", >>>> "readPath": "/sys/class/hwmon/hwmon1/fan1_input", >>>> "writePath": "/sys/class/hwmon/hwmon1/pwm1", >>>> "min": 0, >>>> "max": 255 >>>> }, >>>> { >>>> "name": "temp1", >>>> "type": "temp", >>>> "readPath": "/xyz/openbmc_project/sensors/temperature/temp1", >>>> "writePath": "", >>>> "min": 0, >>>> "max": 0 >>>> } >>>> [4] https://github.com/openbmc/phosphor-pid- >>>> control/commit/75eb769d351434547899186f73ff70ae00d7934a >>>> [5] https://github.com/openbmc/phosphor-pid- >>>> control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontrolle >>>> r.cpp#L64 >>>> [6] https://github.com/openbmc/phosphor-pid- >>>> control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/dbus/dbuspassi >>>> ve.cpp#L158 >>>> >>>>> >>>>>> >>>>>> >>>>>> [1] >>>>>> https://github.com/openbmc/phosphor-pid- >>>>> control/commit/fc2e803f5d92569 >>>>>> 44e18c7c878a441606b1f121c >>>>>> >>>>>> [2] >>>>>> https://github.com/openbmc/phosphor-pid- >>>>> control/blob/a7ec8350d17b70153 >>>>>> cebe666d3fbe88bddd02a1a/pid/fancontroller.cpp#L86 >>>>>> >>>>>> >>>>>> Thanks, >>>>>> >>>>>> >>>>>> Hank Liou >>>>>> >>>>>> Quanta Computer Inc. >>>>>> >>>>>> >>>> >>>> Sincerely, >>>> Hank From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=quantatw.com (client-ip=220.128.79.91; helo=mx02.quantatw.com; envelope-from=prvs=149cca83e=hank.liou@quantatw.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=quantatw.com Received: from mx02.quantatw.com (mx02.quantatw.com [220.128.79.91]) by lists.ozlabs.org (Postfix) with ESMTP id 46SHYq75RvzDqXG for ; Tue, 10 Sep 2019 18:01:59 +1000 (AEST) Received: from unknown (HELO mailbx09.quanta.corp) ([10.243.91.106]) by mx02.quantatw.com with ESMTP; 10 Sep 2019 16:01:56 +0800 Received: from mailbx09.quanta.corp (10.243.91.106) by mailbx09.quanta.corp (10.243.91.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 10 Sep 2019 16:01:56 +0800 Received: from mailbx09.quanta.corp ([fe80::c501:1c2b:62fc:dd81]) by mailbx09.quanta.corp ([fe80::c501:1c2b:62fc:dd81%6]) with mapi id 15.01.1713.004; Tue, 10 Sep 2019 16:01:56 +0800 From: =?utf-8?B?SGFuayBMaW91ICjlionmmYnnv7Ap?= To: James Feist , Patrick Venture CC: "openbmc@lists.ozlabs.org" Subject: RE: [phosphor-pid-control] scaling issue Thread-Topic: [phosphor-pid-control] scaling issue Thread-Index: AQHVV/XbtwEoqXVk+kGbiKtv2uj0UqcFJGgAgAE9VwCAC0qVsIAAQT+AgAYx+NeABJmE/IAGcF0AgAAIKACAAWYjoA== Date: Tue, 10 Sep 2019 08:01:55 +0000 Message-ID: <4b7d382d292d45fdab63f4adcc40eded@quantatw.com> References: <369926533c3e448c9d1a0d28391fd688@quantatw.com> <02128993d3064b53ac289500746666ab@quantatw.com>

In-Reply-To: Accept-Language: en-US, zh-TW Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.243.91.252] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Sep 2019 08:02:11 -0000 Pi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+RnJvbTogSmFtZXMgRmVpc3QgW21haWx0bzpq YW1lcy5mZWlzdEBsaW51eC5pbnRlbC5jb21dDQo+U2VudDogVHVlc2RheSwgU2VwdGVtYmVyIDEw LCAyMDE5IDE6MjcgQU0NCj5UbzogUGF0cmljayBWZW50dXJlIDx2ZW50dXJlQGdvb2dsZS5jb20+ OyBIYW5rIExpb3UgKOWKieaZiee/sCkNCj48SGFuay5MaW91QHF1YW50YXR3LmNvbT4NCj5DYzog b3BlbmJtY0BsaXN0cy5vemxhYnMub3JnDQo+U3ViamVjdDogUmU6IFtwaG9zcGhvci1waWQtY29u dHJvbF0gc2NhbGluZyBpc3N1ZQ0KPg0KPk9uIDkvOS8xOSA5OjU3IEFNLCBQYXRyaWNrIFZlbnR1 cmUgd3JvdGU6DQo+PiBPbiBUaHUsIFNlcCA1LCAyMDE5IGF0IDEyOjI1IEFNIEhhbmsgTGlvdSAo 5YqJ5pmJ57+wKQ0KPjxIYW5rLkxpb3VAcXVhbnRhdHcuY29tPiB3cm90ZToNCj4+Pg0KPj4+IEhp IFBhdHJpY2ssDQo+Pj4NCj4+Pg0KPj4+IFNvcnJ5IGZvciBub3QgY2xlYXJseSBzdGF0aW5nIG91 ciBwcm9ibGVtLiBXZSBoYXZlIHRoZSBmb2xsb3dpbmcgaXNzdWU6DQo+Pj4NCj4+Pg0KPj4+IHRl bXAgc2Vuc29yIGdldHMgMzEoQykgLT4gMzEgLyAwLjI1NSA9IDEyMS41NyAtPiBwaWQgdXNlcyAx MjcuNTcgYXMNCj4+PiBpbnB1dCBmb3IgdGVtcCBzZW5zb3IgLT4NCj4+Pg0KPj4+IHN0ZXB3aXNl IGZhbiB0YWJsZSBvdXRwdXQgMTAwIGR1dHkgLT4gZnVsbCBzcGVlZCBmYW4NCj4+DQo+PiBPaywg c28geW91J3JlIGdldHRpbmcgYSBkYnVzLWJhc2VkIG1pbi9tYXggdmFsdWUgYW5kIHlvdSB3YW50 IHRvDQo+PiBpZ25vcmUgaXQ/DQoNClllcywgd2Ugd2FudCB0byBpZ25vcmUgaXQuDQoNCj4NCj5X aGF0IGlzIHByb3ZpZGluZyB0aGUgZGJ1cy1iYXNlZCBtaW4vbWF4Pw0KDQpXZSB1c2UgZGJ1cyBt aW4vbWF4IGZvciBwaG9zcGhvci1zZWwtbG9nZ2VyIHV0aWxpdHkuIFRoZSBkYnVzIG1pbi9tYXgg aXMgcHJvdmlkZWQgYnkgY29uZmlnIGZpbGUgb2YgcGhvc3Bob3ItaHdtb24uDQpJbiBvdXIgY2Fz ZSwgdGhleSBhcmUgLTEyOC8xMjcgcmVzcGVjdGl2ZWx5Lg0KDQpJIGhhdmUgYW4gb2JzZXJ2YXRp b246DQpJIGZvdW5kIHRoYXQgd2hpbGUgZmFuIHJlYWRwYXRoIGlzIG9mIHRoZSBmb3JtICIvc3lz Ly4uLiIsIHRoZSBmYW4gaW5wdXQgd291bGQgbm90IGJlIHJlc2NhbGVkLiBUaGUgc2FtZSBpcyBm b3Igb3RoZXIgc2Vuc29ycyBzaW5jZSB0aGUgaW5wdXQgdmFsdWUgd291bGQgbm90IGVudGVyIHJl c2NhbGluZyBmdW5jdGlvbi4NCkhvd2V2ZXIsIGluIG91ciBjYXNlIHdlIGRvbid0IGhhdmUgYSBz eXMgcGF0aCBmb3Igc29tZSB0aGVybWFsIHNlbnNvcnMuDQoNCj4NCj4+IEluIHRoZSBqc29uIGNv bmZpZ3VyYXRpb24sIGlmIHlvdSBzZXQgdGhlIHZhbHVlcyB0byAwLCB0aGV5IGFyZSBzZXQgdG8N Cj4+IHRoZSBkZWZhdWx0ICgwKSwgc28gdGhlcmUnZCBiZSBubyBjbGVhbiB3YXkgdG8ga25vdyB0 byBpZ25vcmUgZGJ1cyBpbg0KPj4gdGhpcyBjYXNlLCB3aXRob3V0IGFkZGluZyBhIHNtYWxsIGNo ZWNrIHRvIG9ubHkgY29uc2lkZXIgbWluL21heCBmcm9tDQo+PiBkYnVzIHdoZW4gc2Vuc29yIGlz IG5vdCB0ZW1wL21hcmdpbi4gIEJhc2ljYWxseSwgb25seSBjYXJlIGFib3V0DQo+PiBtaW4vbWF4 IG9uIGRidXMgaWYgdHlwZSBpcyAiZmFuIg0KPg0KDQpJIGFncmVlIHdpdGggdGhlIG9wdGlvbiB0 byBhZGQgYSBjaGVjayBzaW5jZSB0aGUgbWluL21heCBpcyBvbmx5IGZvciBmYW4gbm93Lg0KIA0K PldoeSBpcyB0aGUgZGJ1cy1iYXNlZCBtaW4vbWF4IGV2ZW4gdGhlcmUgaWYgeW91IGRvbid0IHBs YW4gb24gdXNpbmcgaXQ/DQo+DQo+Pg0KPj4gSWYgdGhhdCdzIHJpZ2h0LCBKYW1lcyBkbyB5b3Ug aGF2ZSBhIGN5Y2xlIHRvIGxvb2sgYXQgdGhpcyBvbmUtbGluZXI/DQo+Pg0KPj4+DQo+Pj4NCj4+ PiBBcyBhIHJlc3VsdCwgZmFuIHdpbGwgYmUgYXQgZnVsbCBzcGVlZCB3aGlsZSB0ZW1wIGlzIGxv dy4gQmVmb3JlIHRoZSBjb21taXQNCj5mYzJlODAzIFsxXSwgdGhpcyB3b24ndCBoYXBwZW4uIFRo ZSByb290IGNhdXNlIGlzIHRoYXQsIGJlZm9yZSBmYzJlODAzLCBwaWQgd2lsbA0KPnVzZSBjb25m aWcgbWluL21heCwgd2hpY2ggaXMgMCBpbiBvdXIgY2FzZS4gVGhpcyB3b3VsZCBub3QgdHJpZ2dl ciBzY2FsaW5nDQo+ZnVuY3Rpb24sIG5hbWVseSBzY2FsZVNlbnNvclJlYWRpbmcsIGluIHV0aWwu Y3BwLiBIb3dldmVyLCBhZnRlciBzdWNoIGNvbW1pdCwNCj5taW4vbWF4IHdvdWxkIGJlIG5vbi16 ZXJvICgtMTI4LzEyNyBmcm9tIERCdXMpLiBUaGlzIHdpbGwgdHJpZ2dlciBzY2FsaW5nDQo+ZnVu Y3Rpb24uDQo+Pj4NCj4+Pg0KPj4+IFsxXQ0KPj4+IGh0dHBzOi8vZ2l0aHViLmNvbS9vcGVuYm1j L3Bob3NwaG9yLXBpZC0NCj5jb250cm9sL2NvbW1pdC9mYzJlODAzZjVkOTI1Ng0KPj4+IDk0NGUx OGM3Yzg3OGE0NDE2MDZiMWYxMjFjDQo+Pj4NCj4+Pg0KPj4+IEhhbmsNCj4+Pg0KPj4+DQo+Pj4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCj4+PiBGcm9tOiBIYW5rIExpb3UgKOWK ieaZiee/sCkNCj4+PiBTZW50OiBNb25kYXksIFNlcHRlbWJlciAyLCAyMDE5IDQ6NTIgUE0NCj4+ PiBUbzogUGF0cmljayBWZW50dXJlDQo+Pj4gQ2M6IEphbWVzIEZlaXN0OyBvcGVuYm1jQGxpc3Rz Lm96bGFicy5vcmcNCj4+PiBTdWJqZWN0OiBSZTogW3Bob3NwaG9yLXBpZC1jb250cm9sXSBzY2Fs aW5nIGlzc3VlDQo+Pj4NCj4+Pg0KPj4+IEhpIFBhdHJpY2ssDQo+Pj4NCj4+Pg0KPj4+IFNpbmNl IHdlIHVzZSBwaG9zcGhvci1zZWwtbG9nZ2VyIFsxXSBhdCB0aGUgc2FtZSB0aW1lLCB3ZSBkbyBh c3NpZ24gbWluDQo+YW5kIG1heCBvZiB0ZW1wIHNlbnNvcnMgdG8gRGJ1cyAobWF4OiAxMjcsIG1p bjogLTEyOCkuIFNvIGluIHRoZSBwcmVzZW50IGNhc2UsDQo+b3VyIHRlbXAgdmFsdWUgd2lsbCBi ZSBkaXZpZGVkIGJ5IDAuMjU1IChhbHNvIGR1ZSB0byBleHBvbmVudCBpcyAtMyBoZXJlKS4gVGhp cw0KPndpbGwgY2F1c2UgcmUtc2NhbGluZyBwcm9ibGVtLiBUaGVyZWZvcmUgdGhlcmUgc2hvdWxk IGJlIGFuIHN0YXRlbWVudCB0bw0KPmRpc3Rpbmd1aXNoIHNlbnNvciB0eXBlcy4gSWYgaXQgaXMg InRlbXAiLCB0aGVuIG9uZSBhc3NpZ25zIDAgdG8gdGhlIG1pbiBhbmQgbWF4DQo+ZnJvbSBEYnVz Lg0KPj4+DQo+Pj4NCj4+PiBbMV0NCj4+PiBodHRwczovL2dpdGh1Yi5jb20vb3BlbmJtYy9waG9z cGhvci1zZWwtDQo+bG9nZ2VyL2Jsb2IvM2QzMDBmY2EyNGIzMDg2NGINCj4+PiAzZTlhNGY1NzY4 Y2ZlNWU3Njk0NThhZS9pbmNsdWRlL3NlbnNvcnV0aWxzLmhwcCNMNTkNCj4+Pg0KPj4+DQo+Pj4g SGFuaw0KPj4+DQo+Pj4NCj4+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KPj4+ IEZyb206IFBhdHJpY2sgVmVudHVyZSA8dmVudHVyZUBnb29nbGUuY29tPg0KPj4+IFNlbnQ6IEZy aWRheSwgQXVndXN0IDMwLCAyMDE5IDE6NDcgQU0NCj4+PiBUbzogSGFuayBMaW91ICjlionmmYnn v7ApDQo+Pj4gQ2M6IEphbWVzIEZlaXN0OyBvcGVuYm1jQGxpc3RzLm96bGFicy5vcmcNCj4+PiBT dWJqZWN0OiBSZTogW3Bob3NwaG9yLXBpZC1jb250cm9sXSBzY2FsaW5nIGlzc3VlDQo+Pj4NCj4+ PiBQVEFMIC0gaHR0cHM6Ly9nZXJyaXQub3BlbmJtYy1wcm9qZWN0Lnh5ei8yNDgyNyAtIHRoaXMg aXMgbWVyZ2VkLCBhbmQNCj4+PiB0aGUgc3JjcmV2IGJ1bXAgc2hvdWxkIHByb3BhZ2F0ZSBpbnRv IG9wZW5ibWMvb3BlbmJtYyBpbiBhIGRheSBvciB0d28uDQo+Pj4NCj4+PiBPbiBXZWQsIEF1ZyAy OCwgMjAxOSBhdCAxMTowMCBQTSBIYW5rIExpb3UgKOWKieaZiee/sCkNCj48SGFuay5MaW91QHF1 YW50YXR3LmNvbT4gd3JvdGU6DQo+Pj4+DQo+Pj4+IEhpIFBhdHJpY2ssDQo+Pj4+DQo+Pj4+IEkg dGhpbmsgaXQncyBPSyB0byBwYXJzZSB0aGUgY29uZmlnIG1pbiZtYXggZm9yIHRlbXAgc2Vuc29y cy4NCj4+Pj4NCj4+Pj4gQW55IHN1Z2dlc3Rpb24/DQo+Pj4+DQo+Pj4+IFRoYW5rcywNCj4+Pj4g SGFuaw0KPj4+Pg0KPj4+Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4+Pj4+IEZyb206 IG9wZW5ibWMgW21haWx0bzpvcGVuYm1jLQ0KPj4+Pj4gYm91bmNlcytoYW5rLmxpb3U9cXVhbnRh dHcuY29tQGxpc3RzLm96bGFicy5vcmddIE9uIEJlaGFsZiBPZiBIYW5rDQo+Pj4+PiBib3VuY2Vz K0xpb3UNCj4+Pj4+ICjlionmmYnnv7ApDQo+Pj4+PiBTZW50OiBGcmlkYXksIEF1Z3VzdCAyMywg MjAxOSA0OjMxIFBNDQo+Pj4+PiBUbzogUGF0cmljayBWZW50dXJlIDx2ZW50dXJlQGdvb2dsZS5j b20+OyBKYW1lcyBGZWlzdA0KPj4+Pj4gPGphbWVzLmZlaXN0QGxpbnV4LmludGVsLmNvbT4NCj4+ Pj4+IENjOiBvcGVuYm1jQGxpc3RzLm96bGFicy5vcmcNCj4+Pj4+IFN1YmplY3Q6IFJFOiBbcGhv c3Bob3ItcGlkLWNvbnRyb2xdIHNjYWxpbmcgaXNzdWUNCj4+Pj4+DQo+Pj4+PiBIaSBQYXRyaWNr LA0KPj4+Pj4NCj4+Pj4+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPj4+Pj4+IEZyb206 IFBhdHJpY2sgVmVudHVyZSBbbWFpbHRvOnZlbnR1cmVAZ29vZ2xlLmNvbV0NCj4+Pj4+PiBTZW50 OiBXZWRuZXNkYXksIEF1Z3VzdCAyMSwgMjAxOSAxMDozMiBQTQ0KPj4+Pj4+IFRvOiBIYW5rIExp b3UgKOWKieaZiee/sCkgPEhhbmsuTGlvdUBxdWFudGF0dy5jb20+OyBKYW1lcyBGZWlzdA0KPj4+ Pj4+IDxqYW1lcy5mZWlzdEBsaW51eC5pbnRlbC5jb20+DQo+Pj4+Pj4gQ2M6IG9wZW5ibWNAbGlz dHMub3psYWJzLm9yZw0KPj4+Pj4+IFN1YmplY3Q6IFJlOiBbcGhvc3Bob3ItcGlkLWNvbnRyb2xd IHNjYWxpbmcgaXNzdWUNCj4+Pj4+Pg0KPj4+Pj4+IE9uIFdlZCwgQXVnIDIxLCAyMDE5IGF0IDE6 MTEgQU0gSGFuayBMaW91ICjlionmmYnnv7ApDQo+Pj4+Pj4gPEhhbmsuTGlvdUBxdWFudGF0dy5j b20+IHdyb3RlOg0KPj4+Pj4+Pg0KPj4+Pj4+PiBIaSBBbGwsDQo+Pj4+Pj4+DQo+Pj4+Pj4+DQo+ Pj4+Pj4+IEFmdGVyIGNvbW1pdCBbMV0sIEkgZm91bmQgbXkgdGVtcCBzZW5zb3IgcmVhZGluZyB3 b3VsZCBiZQ0KPj4+Pj4+PiByZS1zY2FsZWQgYnkNCj4+Pj4+PiBtdWx0aXBseWluZyAxIG92ZXIg MjU1LCBtYWtpbmcgdGVtcGVyYXR1cmUgaW50byB1bmZhbWlsaWFyIHVuaXQuDQo+Pj4+Pj4gQWxz byB0aGUgZmFuIHJwbSByZWFkaW5nIHdvdWxkIGxpZSBpbiBbMCwxXSBpbnRlcnZhbCwgbGV0dGlu ZyB0aGUNCj4+Pj4+PiBmYW4gaW5wdXQgdG8gYmUgMCAoc2luY2UgdGhlIGlucHV0IHZhbHVlIG9m IGZhbiBpcyBmcm9tIGFuIGludGVnZXINCj4+Pj4+PiBhcnJheSBbMl0pLiBBcmUgdGhlc2UNCj4+ Pj4+IG5vcm1hbCBiZWhhdmlvcnM/DQo+Pj4+Pj4gT3IgZG8gSSBtaXNzIHNvbWV0aGluZz8NCj4+ Pj4+Pg0KPj4+Pj4+IEFyZSB5b3UgdXNpbmcgZGJ1cyBjb25maWd1cmF0aW9uIG9yIGpzb24/ICBJ ZiBqc29uLCBjYW4geW91IGF0dGFjaCB5b3VyDQo+Y29uZmlnLg0KPj4+Pj4+IFNpbmNlIHlvdSdy ZSBzYXlpbmcgaXQgd2FzIHdvcmtpbmcgYW5kIG5vdyBpc24ndCwgSSdtIGFzc3VtaW5nDQo+Pj4+ Pj4gdGhlcmUncyBzb21ldGhpbmcgYWJvdXQgdGhlIGNvbmZpZyBiZWluZyB0cmVhdGVkIGRpZmZl cmVudGx5IHdpdGgNCj4+Pj4+PiB0aGUgY29kZSBjaGFuZ2VzIGluIGFuIHVuZXhwZWN0ZWQgd2F5 Lg0KPj4+Pj4NCj4+Pj4+IEkgZm91bmQgcGlkIGNvbnRyb2wgd2lsbCBmaXJzdCByZWFkIG1pbiBh bmQgbWF4IGZyb20gZGJ1cyBhbmQgdGhlbg0KPj4+Pj4gKGJlZm9yZSBjb21taXQgWzFdKSByZXZp c2UgdGhlbSBpZg0KPj4+Pj4NCj4+Pj4+IGluZm8tPm1pbiAhPSBjb25mOjppbmhlcml0VmFsdWVG cm9tRGJ1cyAoaW4gZGJ1cy9kYnVzcGFzc2l2ZS5jcHApDQo+Pj4+Pg0KPj4+Pj4gQWZ0ZXIgdmFs dWUgaW5pdGlhbGl6YXRpb24sIHRoZSBtaW4gYW5kIG1heCB3b3VsZCBiZSB0aGUgb25lcyBpbg0K Pj4+Pj4ganNvbiBmaWxlIChKc29uIGZpbGUgWzNdKS4gSG93ZXZlciwgYWZ0ZXIgY29tbWl0IFsx XSB0aGUgbWluIGFuZA0KPj4+Pj4gbWF4IHZhbHVlcyBvZiBjb25maWcgd291bGQgbm90IGJlIGZl ZCBpbnRvIHRoZSBmYW4gY29udHJvbCBwcm9jZXNzLg0KPj4+Pj4gVGhlIHNjYWxpbmcgaXNzdWUg aXMgb3JpZ2luYXRlZCBmcm9tIGNvbW1pdCBbNF0gd2l0aCB0aGUgYWltIHRvDQo+Pj4+PiB0cmVh dCBmYW4gcnBtIGFzIHBlcmNlbnRhZ2UuIEl0IHNlZW1zIHRoYXQgY29tbWl0IFsxXSB1bmV4cGVj dGVkbHkNCj4+Pj4+IGFmZmVjdHMgdGVtcCBzZW5zb3JzIGluIHRoZSBzZW5zZSB0aGF0IHRoZSB0 ZW1wIGlzIHRoZSBpbnRlZ2VyDQo+Pj4+PiByZWFkaW5nIG5vdCBwZXJjZW50YWdlLiBCZWZvcmUg Y29tbWl0IFsxXSwgaXQgd291bGQgbm90IHJlLXNjYWxlIHRoZQ0KPnRlbXAgcmVhZGluZyBzaW5j ZSBteSBtaW4gYW5kIG1heCBhcmUgMCBbNl0uDQo+Pj4+Pg0KPj4+Pj4NCj4+Pj4+DQo+Pj4+PiBU aGVyZSBpcyBhbm90aGVyIGlzc3VlIHdpdGggY29tbWl0IFsxXS4gTm93IHRoZSBmYW4gcnBtIHdv dWxkIGJlDQo+Pj4+PiBzb21ldGhpbmcgbGlrZQ0KPj4+Pj4NCj4+Pj4+IDE1MDAgLyAyMDAwMCA9 IDAuMDc1DQo+Pj4+Pg0KPj4+Pj4gd2hlcmUgcnBtIG1heCAyMDAwMCBpcyBmcm9tIGRidXMuIEhv d2V2ZXIgdGhlIGZhbiBpbnB1dCBmdW5jdGlvbg0KPj4+Pj4gd291bGQgdHJhbnNmZXIgZG91Ymxl IGludG8gaW50LCB3aGljaCBpcyAwIGZvciAwLjA3NSAoc2VlIFs1XSkuDQo+Pj4+PiBIZW5jZSB0 aGUgZmFuIGlucHV0IGlzIDAgbm90IHBlcmNlbnRhZ2UuIElzIHRoZXJlIHNvbWV0aGluZyB3cm9u Zz8NCj4+Pj4+DQo+Pj4+PiBbMV0gaHR0cHM6Ly9naXRodWIuY29tL29wZW5ibWMvcGhvc3Bob3It cGlkLQ0KPj4+Pj4gY29udHJvbC9jb21taXQvZmMyZTgwM2Y1ZDkyNTY5NDRlMThjN2M4NzhhNDQx NjA2YjFmMTIxYw0KPj4+Pj4gWzJdIGh0dHBzOi8vZ2l0aHViLmNvbS9vcGVuYm1jL3Bob3NwaG9y LXBpZC0NCj4+Pj4+DQo+Y29udHJvbC9ibG9iL2E3ZWM4MzUwZDE3YjcwMTUzY2ViZTY2NmQzZmJl ODhiZGRkMDJhMWEvcGlkL2ZhbmNvbnRybw0KPj4+Pj4gbGxlDQo+Pj4+PiByLmNwcCNMODYNCj4+ Pj4+IFszXQ0KPj4+Pj4gICAgICAgIHsNCj4+Pj4+ICAgICAgICAgICAgICJuYW1lIjogImZhbjEi LA0KPj4+Pj4gICAgICAgICAgICAgInR5cGUiOiAiZmFuIiwNCj4+Pj4+ICAgICAgICAgICAgICJy ZWFkUGF0aCI6ICIvc3lzL2NsYXNzL2h3bW9uL2h3bW9uMS9mYW4xX2lucHV0IiwNCj4+Pj4+ICAg ICAgICAgICAgICJ3cml0ZVBhdGgiOiAiL3N5cy9jbGFzcy9od21vbi9od21vbjEvcHdtMSIsDQo+ Pj4+PiAgICAgICAgICAgICAibWluIjogMCwNCj4+Pj4+ICAgICAgICAgICAgICJtYXgiOiAyNTUN Cj4+Pj4+ICAgICAgICAgfSwNCj4+Pj4+ICAgICAgICAgew0KPj4+Pj4gICAgICAgICAgICAgIm5h bWUiOiAidGVtcDEiLA0KPj4+Pj4gICAgICAgICAgICAgInR5cGUiOiAidGVtcCIsDQo+Pj4+PiAg ICAgICAgICAgICAicmVhZFBhdGgiOg0KPiIveHl6L29wZW5ibWNfcHJvamVjdC9zZW5zb3JzL3Rl bXBlcmF0dXJlL3RlbXAxIiwNCj4+Pj4+ICAgICAgICAgICAgICJ3cml0ZVBhdGgiOiAiIiwNCj4+ Pj4+ICAgICAgICAgICAgICJtaW4iOiAwLA0KPj4+Pj4gICAgICAgICAgICAgIm1heCI6IDANCj4+ Pj4+ICAgICAgICAgfQ0KPj4+Pj4gWzRdIGh0dHBzOi8vZ2l0aHViLmNvbS9vcGVuYm1jL3Bob3Nw aG9yLXBpZC0NCj4+Pj4+IGNvbnRyb2wvY29tbWl0Lzc1ZWI3NjlkMzUxNDM0NTQ3ODk5MTg2Zjcz ZmY3MGFlMDBkNzkzNGENCj4+Pj4+IFs1XSBodHRwczovL2dpdGh1Yi5jb20vb3BlbmJtYy9waG9z cGhvci1waWQtDQo+Pj4+Pg0KPmNvbnRyb2wvYmxvYi9hN2VjODM1MGQxN2I3MDE1M2NlYmU2NjZk M2ZiZTg4YmRkZDAyYTFhL3BpZC9mYW5jb250cm8NCj4+Pj4+IGxsZQ0KPj4+Pj4gci5jcHAjTDY0 DQo+Pj4+PiBbNl0gaHR0cHM6Ly9naXRodWIuY29tL29wZW5ibWMvcGhvc3Bob3ItcGlkLQ0KPj4+ Pj4NCj5jb250cm9sL2Jsb2IvYTdlYzgzNTBkMTdiNzAxNTNjZWJlNjY2ZDNmYmU4OGJkZGQwMmEx YS9kYnVzL2RidXNwYXNzDQo+Pj4+PiBpDQo+Pj4+PiB2ZS5jcHAjTDE1OA0KPj4+Pj4NCj4+Pj4+ Pg0KPj4+Pj4+Pg0KPj4+Pj4+Pg0KPj4+Pj4+PiBbMV0NCj4+Pj4+Pj4gaHR0cHM6Ly9naXRodWIu Y29tL29wZW5ibWMvcGhvc3Bob3ItcGlkLQ0KPj4+Pj4+IGNvbnRyb2wvY29tbWl0L2ZjMmU4MDNm NWQ5MjU2OQ0KPj4+Pj4+PiA0NGUxOGM3Yzg3OGE0NDE2MDZiMWYxMjFjDQo+Pj4+Pj4+DQo+Pj4+ Pj4+IFsyXQ0KPj4+Pj4+PiBodHRwczovL2dpdGh1Yi5jb20vb3BlbmJtYy9waG9zcGhvci1waWQt DQo+Pj4+Pj4gY29udHJvbC9ibG9iL2E3ZWM4MzUwZDE3YjcwMTUzDQo+Pj4+Pj4+IGNlYmU2NjZk M2ZiZTg4YmRkZDAyYTFhL3BpZC9mYW5jb250cm9sbGVyLmNwcCNMODYNCj4+Pj4+Pj4NCj4+Pj4+ Pj4NCj4+Pj4+Pj4gVGhhbmtzLA0KPj4+Pj4+Pg0KPj4+Pj4+Pg0KPj4+Pj4+PiBIYW5rIExpb3UN Cj4+Pj4+Pj4NCj4+Pj4+Pj4gUXVhbnRhIENvbXB1dGVyIEluYy4NCj4+Pj4+Pj4NCj4+Pj4+Pj4N Cj4+Pj4+DQo+Pj4+PiBTaW5jZXJlbHksDQo+Pj4+PiBIYW5rDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::643; helo=mail-pl1-x643.google.com; envelope-from=venture@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="PjZdQg+t"; dkim-atps=neutral Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46SSP13KWtzF0dc for ; Wed, 11 Sep 2019 00:40:04 +1000 (AEST) Received: by mail-pl1-x643.google.com with SMTP id k1so8703295pls.11 for ; Tue, 10 Sep 2019 07:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cNmW3etY1twdQSNrz6t57cT8HuczhubfwKavmOfjxpA=; b=PjZdQg+tMRuNaHdOMImjXuuKHifDmzeJ0yW3P3G9FtZ7K/UvWvnVM1hvU9aymQ1GLd aOgFaw1aaAAFwCUaMvP23ai546rvbGLIjr9OIxB3ylLAitVhkdEndoqa70DrTaL/geWn 5O3jufAu/F8cyvhALyFNsD2uFxvss4wBomuNuDNZwjbIpxwHyyVYHou0qEOZ/f0eTq0c xOLMq3pYyU9zr+HKyWOlr8D1ZGntLEenxva+u52eeho6cJA0ULQpwDGJD7xhMehcD6oM 3pKA+0XVKz4Y0IhfKEA3iAgDj4k8mp7R3Pvt3f502Tkw8r5wLqWPQO8FLZKzbYRTesMp 7P4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cNmW3etY1twdQSNrz6t57cT8HuczhubfwKavmOfjxpA=; b=cRcI9QZfjgKB9QaaG+ojiuyQvZjaVszPK3TYKUrWNAnIcsGVy1Bgb5DDKl0gwoc4W2 dhiXDgIL5kxNzNGtDDFot+dnElLTO5FJ/Rle4TMdfkwSqcnR5DEcuMLErNdfskQRexc1 rA3Bjsn1YBMUGUni/CjodnsEmQr6NcWC5jTOsQyVHP8dLJZHtFPF38/rxj0kkFv6QP3A L/1GjQlpcJF5zZBTd71gfT3SHl7D8rVKWtN9I7AXNzaD3Bs2c4rzBgGmnoM3SI+T/2Ft anMopYsLkJ3IfO3Ip7Gi69puiJACLsonfYY08QtjkgVm8hwZu3m5vI+r8CwX0M9XIGoM wb+g== X-Gm-Message-State: APjAAAWHX0NafzuHWcl2QEQpwUMLxuwxeW6g/BAvowaGKMfKQP5p7zqa symvA+/SgscILV5VRVSRN/P71BbR9dylER0PoKdR5g== X-Google-Smtp-Source: APXvYqz2ZNjoORsvysiGANhiCKdhdbrI7krswUyfWiqnAseg4msYexJYmCy/8o4Xf/3Z0yn/PiAR89GoARknl6Du8eQ= X-Received: by 2002:a17:902:848c:: with SMTP id c12mr31441510plo.47.1568126400827; Tue, 10 Sep 2019 07:40:00 -0700 (PDT) MIME-Version: 1.0 References: <369926533c3e448c9d1a0d28391fd688@quantatw.com> <02128993d3064b53ac289500746666ab@quantatw.com>

<4b7d382d292d45fdab63f4adcc40eded@quantatw.com> In-Reply-To: <4b7d382d292d45fdab63f4adcc40eded@quantatw.com> From: Patrick Venture Date: Tue, 10 Sep 2019 07:39:49 -0700 Message-ID: Subject: Re: [phosphor-pid-control] scaling issue To: =?UTF-8?B?SGFuayBMaW91ICjlionmmYnnv7Ap?= Cc: James Feist , "openbmc@lists.ozlabs.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Sep 2019 14:40:06 -0000 On Tue, Sep 10, 2019 at 1:02 AM Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) wrote: > > >-----Original Message----- > >From: James Feist [mailto:james.feist@linux.intel.com] > >Sent: Tuesday, September 10, 2019 1:27 AM > >To: Patrick Venture ; Hank Liou (=E5=8A=89=E6=99=89= =E7=BF=B0) > > > >Cc: openbmc@lists.ozlabs.org > >Subject: Re: [phosphor-pid-control] scaling issue > > > >On 9/9/19 9:57 AM, Patrick Venture wrote: > >> On Thu, Sep 5, 2019 at 12:25 AM Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0= ) > > wrote: > >>> > >>> Hi Patrick, > >>> > >>> > >>> Sorry for not clearly stating our problem. We have the following issu= e: > >>> > >>> > >>> temp sensor gets 31(C) -> 31 / 0.255 =3D 121.57 -> pid uses 127.57 as > >>> input for temp sensor -> > >>> > >>> stepwise fan table output 100 duty -> full speed fan > >> > >> Ok, so you're getting a dbus-based min/max value and you want to > >> ignore it? > > Yes, we want to ignore it. It looks like the sensor value scaling should be ignored for non-fans. Per https://github.com/openbmc/phosphor-pid-control/commit/75eb769d35143454= 7899186f73ff70ae00d7934a, this change was only meant to deal with a fan case where the goal looks like it was to treat the fan values as percentages on reading the sensors, and not only on writing them by leveraging the min/max json sometimes? I can change the dbuspassive constructor to set the values back to their input values (ignoring dbus) if the type is not "fan", but I'm not sure that makes sense because the real use-case isn't clear to me, and I know the scaling from dbus is gone: https://github.com/openbmc/phosphor-pid-control/search?utf8=3D%E2%9C%93&q= =3DinheritValueFromDbus&type=3D I'll submit the patch real quick, but I'm not sure it's the right long-term fix. I'd like to clean this up if possible so that we don't leverage "unused" features of a configuration and instead explicitly use them (or not). > > > > >What is providing the dbus-based min/max? > > We use dbus min/max for phosphor-sel-logger utility. The dbus min/max is = provided by config file of phosphor-hwmon. > In our case, they are -128/127 respectively. > > I have an observation: > I found that while fan readpath is of the form "/sys/...", the fan input = would not be rescaled. The same is for other sensors since the input value = would not enter rescaling function. > However, in our case we don't have a sys path for some thermal sensors. > > > > >> In the json configuration, if you set the values to 0, they are set to > >> the default (0), so there'd be no clean way to know to ignore dbus in > >> this case, without adding a small check to only consider min/max from > >> dbus when sensor is not temp/margin. Basically, only care about > >> min/max on dbus if type is "fan" > > > > I agree with the option to add a check since the min/max is only for fan = now. > > >Why is the dbus-based min/max even there if you don't plan on using it? > > > >> > >> If that's right, James do you have a cycle to look at this one-liner? > >> > >>> > >>> > >>> As a result, fan will be at full speed while temp is low. Before the = commit > >fc2e803 [1], this won't happen. The root cause is that, before fc2e803, = pid will > >use config min/max, which is 0 in our case. This would not trigger scali= ng > >function, namely scaleSensorReading, in util.cpp. However, after such co= mmit, > >min/max would be non-zero (-128/127 from DBus). This will trigger scalin= g > >function. > >>> > >>> > >>> [1] > >>> https://github.com/openbmc/phosphor-pid- > >control/commit/fc2e803f5d9256 > >>> 944e18c7c878a441606b1f121c > >>> > >>> > >>> Hank > >>> > >>> > >>> ________________________________ > >>> From: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) > >>> Sent: Monday, September 2, 2019 4:52 PM > >>> To: Patrick Venture > >>> Cc: James Feist; openbmc@lists.ozlabs.org > >>> Subject: Re: [phosphor-pid-control] scaling issue > >>> > >>> > >>> Hi Patrick, > >>> > >>> > >>> Since we use phosphor-sel-logger [1] at the same time, we do assign m= in > >and max of temp sensors to Dbus (max: 127, min: -128). So in the present= case, > >our temp value will be divided by 0.255 (also due to exponent is -3 here= ). This > >will cause re-scaling problem. Therefore there should be an statement to > >distinguish sensor types. If it is "temp", then one assigns 0 to the min= and max > >from Dbus. > >>> > >>> > >>> [1] > >>> https://github.com/openbmc/phosphor-sel- > >logger/blob/3d300fca24b30864b > >>> 3e9a4f5768cfe5e769458ae/include/sensorutils.hpp#L59 > >>> > >>> > >>> Hank > >>> > >>> > >>> ________________________________ > >>> From: Patrick Venture > >>> Sent: Friday, August 30, 2019 1:47 AM > >>> To: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) > >>> Cc: James Feist; openbmc@lists.ozlabs.org > >>> Subject: Re: [phosphor-pid-control] scaling issue > >>> > >>> PTAL - https://gerrit.openbmc-project.xyz/24827 - this is merged, and > >>> the srcrev bump should propagate into openbmc/openbmc in a day or two= . > >>> > >>> On Wed, Aug 28, 2019 at 11:00 PM Hank Liou (=E5=8A=89=E6=99=89=E7=BF= =B0) > > wrote: > >>>> > >>>> Hi Patrick, > >>>> > >>>> I think it's OK to parse the config min&max for temp sensors. > >>>> > >>>> Any suggestion? > >>>> > >>>> Thanks, > >>>> Hank > >>>> > >>>>> -----Original Message----- > >>>>> From: openbmc [mailto:openbmc- > >>>>> bounces+hank.liou=3Dquantatw.com@lists.ozlabs.org] On Behalf Of Han= k > >>>>> bounces+Liou > >>>>> (=E5=8A=89=E6=99=89=E7=BF=B0) > >>>>> Sent: Friday, August 23, 2019 4:31 PM > >>>>> To: Patrick Venture ; James Feist > >>>>> > >>>>> Cc: openbmc@lists.ozlabs.org > >>>>> Subject: RE: [phosphor-pid-control] scaling issue > >>>>> > >>>>> Hi Patrick, > >>>>> > >>>>>> -----Original Message----- > >>>>>> From: Patrick Venture [mailto:venture@google.com] > >>>>>> Sent: Wednesday, August 21, 2019 10:32 PM > >>>>>> To: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) ; James Feist > >>>>>> > >>>>>> Cc: openbmc@lists.ozlabs.org > >>>>>> Subject: Re: [phosphor-pid-control] scaling issue > >>>>>> > >>>>>> On Wed, Aug 21, 2019 at 1:11 AM Hank Liou (=E5=8A=89=E6=99=89=E7= =BF=B0) > >>>>>> wrote: > >>>>>>> > >>>>>>> Hi All, > >>>>>>> > >>>>>>> > >>>>>>> After commit [1], I found my temp sensor reading would be > >>>>>>> re-scaled by > >>>>>> multiplying 1 over 255, making temperature into unfamiliar unit. > >>>>>> Also the fan rpm reading would lie in [0,1] interval, letting the > >>>>>> fan input to be 0 (since the input value of fan is from an integer > >>>>>> array [2]). Are these > >>>>> normal behaviors? > >>>>>> Or do I miss something? > >>>>>> > >>>>>> Are you using dbus configuration or json? If json, can you attach= your > >config. > >>>>>> Since you're saying it was working and now isn't, I'm assuming > >>>>>> there's something about the config being treated differently with > >>>>>> the code changes in an unexpected way. > >>>>> > >>>>> I found pid control will first read min and max from dbus and then > >>>>> (before commit [1]) revise them if > >>>>> > >>>>> info->min !=3D conf::inheritValueFromDbus (in dbus/dbuspassive.cpp) > >>>>> > >>>>> After value initialization, the min and max would be the ones in > >>>>> json file (Json file [3]). However, after commit [1] the min and > >>>>> max values of config would not be fed into the fan control process. > >>>>> The scaling issue is originated from commit [4] with the aim to > >>>>> treat fan rpm as percentage. It seems that commit [1] unexpectedly > >>>>> affects temp sensors in the sense that the temp is the integer > >>>>> reading not percentage. Before commit [1], it would not re-scale th= e > >temp reading since my min and max are 0 [6]. > >>>>> > >>>>> > >>>>> > >>>>> There is another issue with commit [1]. Now the fan rpm would be > >>>>> something like > >>>>> > >>>>> 1500 / 20000 =3D 0.075 > >>>>> > >>>>> where rpm max 20000 is from dbus. However the fan input function > >>>>> would transfer double into int, which is 0 for 0.075 (see [5]). > >>>>> Hence the fan input is 0 not percentage. Is there something wrong? > >>>>> > >>>>> [1] https://github.com/openbmc/phosphor-pid- > >>>>> control/commit/fc2e803f5d9256944e18c7c878a441606b1f121c > >>>>> [2] https://github.com/openbmc/phosphor-pid- > >>>>> > >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontro > >>>>> lle > >>>>> r.cpp#L86 > >>>>> [3] > >>>>> { > >>>>> "name": "fan1", > >>>>> "type": "fan", > >>>>> "readPath": "/sys/class/hwmon/hwmon1/fan1_input", > >>>>> "writePath": "/sys/class/hwmon/hwmon1/pwm1", > >>>>> "min": 0, > >>>>> "max": 255 > >>>>> }, > >>>>> { > >>>>> "name": "temp1", > >>>>> "type": "temp", > >>>>> "readPath": > >"/xyz/openbmc_project/sensors/temperature/temp1", > >>>>> "writePath": "", > >>>>> "min": 0, > >>>>> "max": 0 > >>>>> } > >>>>> [4] https://github.com/openbmc/phosphor-pid- > >>>>> control/commit/75eb769d351434547899186f73ff70ae00d7934a > >>>>> [5] https://github.com/openbmc/phosphor-pid- > >>>>> > >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontro > >>>>> lle > >>>>> r.cpp#L64 > >>>>> [6] https://github.com/openbmc/phosphor-pid- > >>>>> > >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/dbus/dbuspass > >>>>> i > >>>>> ve.cpp#L158 > >>>>> > >>>>>> > >>>>>>> > >>>>>>> > >>>>>>> [1] > >>>>>>> https://github.com/openbmc/phosphor-pid- > >>>>>> control/commit/fc2e803f5d92569 > >>>>>>> 44e18c7c878a441606b1f121c > >>>>>>> > >>>>>>> [2] > >>>>>>> https://github.com/openbmc/phosphor-pid- > >>>>>> control/blob/a7ec8350d17b70153 > >>>>>>> cebe666d3fbe88bddd02a1a/pid/fancontroller.cpp#L86 > >>>>>>> > >>>>>>> > >>>>>>> Thanks, > >>>>>>> > >>>>>>> > >>>>>>> Hank Liou > >>>>>>> > >>>>>>> Quanta Computer Inc. > >>>>>>> > >>>>>>> > >>>>> > >>>>> Sincerely, > >>>>> Hank From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::542; helo=mail-pg1-x542.google.com; envelope-from=venture@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="S5AaHyQG"; dkim-atps=neutral Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46SSgk0SLLzF0fL for ; Wed, 11 Sep 2019 00:52:49 +1000 (AEST) Received: by mail-pg1-x542.google.com with SMTP id n4so9906193pgv.2 for ; Tue, 10 Sep 2019 07:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=jX5FoQ83rFTbs3HO+AU4Uc0+9y4nsZTPgEmTxFT79VA=; b=S5AaHyQGL8x1AIlrUGkziTb616x/lgUJVi+oF2/0Lo+UC/IMxCd+HVxl1Q3Hoc8/fu egsj6nmeqXq3cyncLz7wR3LOwtje1xVZAWV9KcUzzvP1hW9F6p0kc+IXYalIo9pQP0EM YGs4CsGk5JDSH7F0cQrGa7y2W2iBiy5I5RurdyehOamPdCTo9qX82KazNKF8I4j8DmUB cEstfAY5Rv+wsmUjHxQnvqBJwSbVB3G15/u28gwXvOQ1Uh7dCgqkGuZyMGkSHlFDNkqN mdncsBUbR6ptm8mSdN+Av8qYO+brsPz6taUgGhfiRtDxVZh/Cp7kDac8CtQI865OiavS 9fsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=jX5FoQ83rFTbs3HO+AU4Uc0+9y4nsZTPgEmTxFT79VA=; b=gdmxwZuBIqPZJWokSmNoNrB5+ZLlcFTK24SsYGpQiDk3K2aSvsqmf4wUaDwrBqJtJS WuGhaDAa13/MLc7XBAMn6v2xbCRVCme5iiWKzWCb0AT/TDy7d3DXvVs3goyaU0PMHw0H JYbHYiih9iHBfLZ0jQQK7t+qlQWNj8RbwsUen1NKPkvyCTetp5Oy+mWt36SHqFY9JLlF tu/Ms+JFurCEq9ea6u3ZsPRxwU2o8Epfv7eUxSW0m/v5svETVvyRPzYSlUxZt7c00c5Q E1S2FbjcGEnr9IxhwFSJgcS9Sa+gTc3DehJnKDL9Nvb2X8YbRngWVRPNjYzpcicJpGUc LnuQ== X-Gm-Message-State: APjAAAVjCO/mHfW/HDy7xeNvmoin3O/7vYG1x/cB0iJw97yX74qNE9z5 r3myvHtfVMqDao8YBAkz4m6/4j7Y/AUkJqv/wzZaU/jSSKQ3hg== X-Google-Smtp-Source: APXvYqyu1OE40Ugwoh49TpzEYvQNIzPEAMDoHMWKHZcW5o2AlwcU+PYqV7cWy6qPFgIs8Xy3hQBi83rdForSScruvtU= X-Received: by 2002:a62:5b83:: with SMTP id p125mr3012522pfb.186.1568127165736; Tue, 10 Sep 2019 07:52:45 -0700 (PDT) MIME-Version: 1.0 References: <369926533c3e448c9d1a0d28391fd688@quantatw.com> <02128993d3064b53ac289500746666ab@quantatw.com>

<4b7d382d292d45fdab63f4adcc40eded@quantatw.com> In-Reply-To: From: Patrick Venture Date: Tue, 10 Sep 2019 07:52:34 -0700 Message-ID: Subject: Re: [phosphor-pid-control] scaling issue To: =?UTF-8?B?SGFuayBMaW91ICjlionmmYnnv7Ap?= Cc: James Feist , "openbmc@lists.ozlabs.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Sep 2019 14:52:50 -0000 On Tue, Sep 10, 2019 at 7:39 AM Patrick Venture wrote: > > On Tue, Sep 10, 2019 at 1:02 AM Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) <= Hank.Liou@quantatw.com> wrote: > > > > >-----Original Message----- > > >From: James Feist [mailto:james.feist@linux.intel.com] > > >Sent: Tuesday, September 10, 2019 1:27 AM > > >To: Patrick Venture ; Hank Liou (=E5=8A=89=E6=99= =89=E7=BF=B0) > > > > > >Cc: openbmc@lists.ozlabs.org > > >Subject: Re: [phosphor-pid-control] scaling issue > > > > > >On 9/9/19 9:57 AM, Patrick Venture wrote: > > >> On Thu, Sep 5, 2019 at 12:25 AM Hank Liou (=E5=8A=89=E6=99=89=E7=BF= =B0) > > > wrote: > > >>> > > >>> Hi Patrick, > > >>> > > >>> > > >>> Sorry for not clearly stating our problem. We have the following is= sue: > > >>> > > >>> > > >>> temp sensor gets 31(C) -> 31 / 0.255 =3D 121.57 -> pid uses 127.57 = as > > >>> input for temp sensor -> > > >>> > > >>> stepwise fan table output 100 duty -> full speed fan > > >> > > >> Ok, so you're getting a dbus-based min/max value and you want to > > >> ignore it? > > > > Yes, we want to ignore it. > > It looks like the sensor value scaling should be ignored for non-fans. > Per https://github.com/openbmc/phosphor-pid-control/commit/75eb769d351434= 547899186f73ff70ae00d7934a, > this change was only meant to deal with a fan case where the goal > looks like it was to treat the fan values as percentages on reading > the sensors, and not only on writing them by leveraging the min/max > json sometimes? > > I can change the dbuspassive constructor to set the values back to > their input values (ignoring dbus) if the type is not "fan", but I'm > not sure that makes sense because the real use-case isn't clear to me, > and I know the scaling from dbus is gone: > https://github.com/openbmc/phosphor-pid-control/search?utf8=3D%E2%9C%93&q= =3DinheritValueFromDbus&type=3D > > I'll submit the patch real quick, but I'm not sure it's the right > long-term fix. I'd like to clean this up if possible so that we don't > leverage "unused" features of a configuration and instead explicitly > use them (or not). This patch should address what you're seeing. Overall, I think there should be a larger change addressing the goal of the original change. https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-pid-control/+/25070 > > > > > > > > >What is providing the dbus-based min/max? > > > > We use dbus min/max for phosphor-sel-logger utility. The dbus min/max i= s provided by config file of phosphor-hwmon. > > In our case, they are -128/127 respectively. > > > > I have an observation: > > I found that while fan readpath is of the form "/sys/...", the fan inpu= t would not be rescaled. The same is for other sensors since the input valu= e would not enter rescaling function. > > However, in our case we don't have a sys path for some thermal sensors. > > > > > > > >> In the json configuration, if you set the values to 0, they are set = to > > >> the default (0), so there'd be no clean way to know to ignore dbus i= n > > >> this case, without adding a small check to only consider min/max fro= m > > >> dbus when sensor is not temp/margin. Basically, only care about > > >> min/max on dbus if type is "fan" > > > > > > > I agree with the option to add a check since the min/max is only for fa= n now. > > > > >Why is the dbus-based min/max even there if you don't plan on using it= ? > > > > > >> > > >> If that's right, James do you have a cycle to look at this one-liner= ? > > >> > > >>> > > >>> > > >>> As a result, fan will be at full speed while temp is low. Before th= e commit > > >fc2e803 [1], this won't happen. The root cause is that, before fc2e803= , pid will > > >use config min/max, which is 0 in our case. This would not trigger sca= ling > > >function, namely scaleSensorReading, in util.cpp. However, after such = commit, > > >min/max would be non-zero (-128/127 from DBus). This will trigger scal= ing > > >function. > > >>> > > >>> > > >>> [1] > > >>> https://github.com/openbmc/phosphor-pid- > > >control/commit/fc2e803f5d9256 > > >>> 944e18c7c878a441606b1f121c > > >>> > > >>> > > >>> Hank > > >>> > > >>> > > >>> ________________________________ > > >>> From: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) > > >>> Sent: Monday, September 2, 2019 4:52 PM > > >>> To: Patrick Venture > > >>> Cc: James Feist; openbmc@lists.ozlabs.org > > >>> Subject: Re: [phosphor-pid-control] scaling issue > > >>> > > >>> > > >>> Hi Patrick, > > >>> > > >>> > > >>> Since we use phosphor-sel-logger [1] at the same time, we do assign= min > > >and max of temp sensors to Dbus (max: 127, min: -128). So in the prese= nt case, > > >our temp value will be divided by 0.255 (also due to exponent is -3 he= re). This > > >will cause re-scaling problem. Therefore there should be an statement = to > > >distinguish sensor types. If it is "temp", then one assigns 0 to the m= in and max > > >from Dbus. > > >>> > > >>> > > >>> [1] > > >>> https://github.com/openbmc/phosphor-sel- > > >logger/blob/3d300fca24b30864b > > >>> 3e9a4f5768cfe5e769458ae/include/sensorutils.hpp#L59 > > >>> > > >>> > > >>> Hank > > >>> > > >>> > > >>> ________________________________ > > >>> From: Patrick Venture > > >>> Sent: Friday, August 30, 2019 1:47 AM > > >>> To: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) > > >>> Cc: James Feist; openbmc@lists.ozlabs.org > > >>> Subject: Re: [phosphor-pid-control] scaling issue > > >>> > > >>> PTAL - https://gerrit.openbmc-project.xyz/24827 - this is merged, a= nd > > >>> the srcrev bump should propagate into openbmc/openbmc in a day or t= wo. > > >>> > > >>> On Wed, Aug 28, 2019 at 11:00 PM Hank Liou (=E5=8A=89=E6=99=89=E7= =BF=B0) > > > wrote: > > >>>> > > >>>> Hi Patrick, > > >>>> > > >>>> I think it's OK to parse the config min&max for temp sensors. > > >>>> > > >>>> Any suggestion? > > >>>> > > >>>> Thanks, > > >>>> Hank > > >>>> > > >>>>> -----Original Message----- > > >>>>> From: openbmc [mailto:openbmc- > > >>>>> bounces+hank.liou=3Dquantatw.com@lists.ozlabs.org] On Behalf Of H= ank > > >>>>> bounces+Liou > > >>>>> (=E5=8A=89=E6=99=89=E7=BF=B0) > > >>>>> Sent: Friday, August 23, 2019 4:31 PM > > >>>>> To: Patrick Venture ; James Feist > > >>>>> > > >>>>> Cc: openbmc@lists.ozlabs.org > > >>>>> Subject: RE: [phosphor-pid-control] scaling issue > > >>>>> > > >>>>> Hi Patrick, > > >>>>> > > >>>>>> -----Original Message----- > > >>>>>> From: Patrick Venture [mailto:venture@google.com] > > >>>>>> Sent: Wednesday, August 21, 2019 10:32 PM > > >>>>>> To: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) ; James Feist > > >>>>>> > > >>>>>> Cc: openbmc@lists.ozlabs.org > > >>>>>> Subject: Re: [phosphor-pid-control] scaling issue > > >>>>>> > > >>>>>> On Wed, Aug 21, 2019 at 1:11 AM Hank Liou (=E5=8A=89=E6=99=89=E7= =BF=B0) > > >>>>>> wrote: > > >>>>>>> > > >>>>>>> Hi All, > > >>>>>>> > > >>>>>>> > > >>>>>>> After commit [1], I found my temp sensor reading would be > > >>>>>>> re-scaled by > > >>>>>> multiplying 1 over 255, making temperature into unfamiliar unit. > > >>>>>> Also the fan rpm reading would lie in [0,1] interval, letting th= e > > >>>>>> fan input to be 0 (since the input value of fan is from an integ= er > > >>>>>> array [2]). Are these > > >>>>> normal behaviors? > > >>>>>> Or do I miss something? > > >>>>>> > > >>>>>> Are you using dbus configuration or json? If json, can you atta= ch your > > >config. > > >>>>>> Since you're saying it was working and now isn't, I'm assuming > > >>>>>> there's something about the config being treated differently wit= h > > >>>>>> the code changes in an unexpected way. > > >>>>> > > >>>>> I found pid control will first read min and max from dbus and the= n > > >>>>> (before commit [1]) revise them if > > >>>>> > > >>>>> info->min !=3D conf::inheritValueFromDbus (in dbus/dbuspassive.cp= p) > > >>>>> > > >>>>> After value initialization, the min and max would be the ones in > > >>>>> json file (Json file [3]). However, after commit [1] the min and > > >>>>> max values of config would not be fed into the fan control proces= s. > > >>>>> The scaling issue is originated from commit [4] with the aim to > > >>>>> treat fan rpm as percentage. It seems that commit [1] unexpectedl= y > > >>>>> affects temp sensors in the sense that the temp is the integer > > >>>>> reading not percentage. Before commit [1], it would not re-scale = the > > >temp reading since my min and max are 0 [6]. > > >>>>> > > >>>>> > > >>>>> > > >>>>> There is another issue with commit [1]. Now the fan rpm would be > > >>>>> something like > > >>>>> > > >>>>> 1500 / 20000 =3D 0.075 > > >>>>> > > >>>>> where rpm max 20000 is from dbus. However the fan input function > > >>>>> would transfer double into int, which is 0 for 0.075 (see [5]). > > >>>>> Hence the fan input is 0 not percentage. Is there something wrong= ? > > >>>>> > > >>>>> [1] https://github.com/openbmc/phosphor-pid- > > >>>>> control/commit/fc2e803f5d9256944e18c7c878a441606b1f121c > > >>>>> [2] https://github.com/openbmc/phosphor-pid- > > >>>>> > > >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontro > > >>>>> lle > > >>>>> r.cpp#L86 > > >>>>> [3] > > >>>>> { > > >>>>> "name": "fan1", > > >>>>> "type": "fan", > > >>>>> "readPath": "/sys/class/hwmon/hwmon1/fan1_input", > > >>>>> "writePath": "/sys/class/hwmon/hwmon1/pwm1", > > >>>>> "min": 0, > > >>>>> "max": 255 > > >>>>> }, > > >>>>> { > > >>>>> "name": "temp1", > > >>>>> "type": "temp", > > >>>>> "readPath": > > >"/xyz/openbmc_project/sensors/temperature/temp1", > > >>>>> "writePath": "", > > >>>>> "min": 0, > > >>>>> "max": 0 > > >>>>> } > > >>>>> [4] https://github.com/openbmc/phosphor-pid- > > >>>>> control/commit/75eb769d351434547899186f73ff70ae00d7934a > > >>>>> [5] https://github.com/openbmc/phosphor-pid- > > >>>>> > > >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontro > > >>>>> lle > > >>>>> r.cpp#L64 > > >>>>> [6] https://github.com/openbmc/phosphor-pid- > > >>>>> > > >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/dbus/dbuspass > > >>>>> i > > >>>>> ve.cpp#L158 > > >>>>> > > >>>>>> > > >>>>>>> > > >>>>>>> > > >>>>>>> [1] > > >>>>>>> https://github.com/openbmc/phosphor-pid- > > >>>>>> control/commit/fc2e803f5d92569 > > >>>>>>> 44e18c7c878a441606b1f121c > > >>>>>>> > > >>>>>>> [2] > > >>>>>>> https://github.com/openbmc/phosphor-pid- > > >>>>>> control/blob/a7ec8350d17b70153 > > >>>>>>> cebe666d3fbe88bddd02a1a/pid/fancontroller.cpp#L86 > > >>>>>>> > > >>>>>>> > > >>>>>>> Thanks, > > >>>>>>> > > >>>>>>> > > >>>>>>> Hank Liou > > >>>>>>> > > >>>>>>> Quanta Computer Inc. > > >>>>>>> > > >>>>>>> > > >>>>> > > >>>>> Sincerely, > > >>>>> Hank From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::441; helo=mail-pf1-x441.google.com; envelope-from=venture@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="TITCHGdi"; dkim-atps=neutral Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46SXgC4nHbzF1Sd for ; Wed, 11 Sep 2019 03:52:39 +1000 (AEST) Received: by mail-pf1-x441.google.com with SMTP id x127so11971092pfb.7 for ; Tue, 10 Sep 2019 10:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=rj51HG3QF1UsdH1slDCYsFcoCLLvaDvqxPGvM62GQPw=; b=TITCHGdi1XMF2qYHOeol1nihVs9WkKBtC4AWrByATXMzuSte2kgn+qxXwoKxTrotxq grefb1hh7Q4x+yPzRr4mkP5/pWxjVHOrOjjnHMcWczT3QdPzQmyuSwWxr1/EEDTmWdZp EhSLhX+8CSICIbo3I186hM3Ytn08wIQYCpDVkWx1NyE2b/jMuH9iWFguDCCuZRqzAaSy 3Jbrm9lH6qQv5K/SneRI9qKbnMmy9tXbLCyCzBydNKvWvdzpA4DHW9UddbE3I5588NXC DZXCqnTrDeuTQ9ufhIbOWGFfT0Py+7tzyKt/1LuCtC8uqNJfEPJ5ytGxd8uGdkTggAVp VUoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=rj51HG3QF1UsdH1slDCYsFcoCLLvaDvqxPGvM62GQPw=; b=rxJUNWHLXpG678hzY45mAenxpJZVHs2YhWIFzBbOAhSL6ZNGKXljr584chCZf+3Yn9 Gdkpl3K7K3Sv8bJEQLnummVQk44sFoFKE8iPwZ8gqmnalrHeXLEz8zHNQM/z0FI+MXpA nVLicSuB8QvwmKGHBZEvEv+mZM1gN3/Ybs8McXQB1D8dMAcw8fGf0Hi3wWwSLOxSdNMS ZwIOapVynUfbiGRjFutD46WVzpaGqDFYIwk6EnnbszLshoVXXfZO/PERuySs/pWvsPuh Vqb11AyQfht19gROsIR4TWf6eFzLjc2uKN6ovtg4KpEAxs5+ojcMa0X4G1EUpMlks4Vb itoA== X-Gm-Message-State: APjAAAUxR0KEo0Bz7ltxwBtzGHmMoyOiUzTM85IWhzHseAeRhRodK6ap i3ZkrvfGf/wqPb48M00n+lUEmE3jGVoa3W80e1nHEw== X-Google-Smtp-Source: APXvYqzrzca2KOMWeGSekNKw9c2V5wJf3emNOpc/hMHgRCOhOzufEJOXAsotTje4WCE7kPZ+nN+sHnSkrBOSNjsOvPE= X-Received: by 2002:a63:1f1f:: with SMTP id f31mr28665981pgf.353.1568137955863; Tue, 10 Sep 2019 10:52:35 -0700 (PDT) MIME-Version: 1.0 References: <369926533c3e448c9d1a0d28391fd688@quantatw.com> <02128993d3064b53ac289500746666ab@quantatw.com>

<4b7d382d292d45fdab63f4adcc40eded@quantatw.com>

In-Reply-To: From: Patrick Venture Date: Tue, 10 Sep 2019 10:52:24 -0700 Message-ID: Subject: Re: [phosphor-pid-control] scaling issue To: =?UTF-8?B?SGFuayBMaW91ICjlionmmYnnv7Ap?= Cc: James Feist , "openbmc@lists.ozlabs.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Sep 2019 17:52:40 -0000 On Tue, Sep 10, 2019 at 7:52 AM Patrick Venture wrote: > > On Tue, Sep 10, 2019 at 7:39 AM Patrick Venture wrot= e: > > > > On Tue, Sep 10, 2019 at 1:02 AM Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0)= wrote: > > > > > > >-----Original Message----- > > > >From: James Feist [mailto:james.feist@linux.intel.com] > > > >Sent: Tuesday, September 10, 2019 1:27 AM > > > >To: Patrick Venture ; Hank Liou (=E5=8A=89=E6=99= =89=E7=BF=B0) > > > > > > > >Cc: openbmc@lists.ozlabs.org > > > >Subject: Re: [phosphor-pid-control] scaling issue > > > > > > > >On 9/9/19 9:57 AM, Patrick Venture wrote: > > > >> On Thu, Sep 5, 2019 at 12:25 AM Hank Liou (=E5=8A=89=E6=99=89=E7= =BF=B0) > > > > wrote: > > > >>> > > > >>> Hi Patrick, > > > >>> > > > >>> > > > >>> Sorry for not clearly stating our problem. We have the following = issue: > > > >>> > > > >>> > > > >>> temp sensor gets 31(C) -> 31 / 0.255 =3D 121.57 -> pid uses 127.5= 7 as > > > >>> input for temp sensor -> > > > >>> > > > >>> stepwise fan table output 100 duty -> full speed fan > > > >> > > > >> Ok, so you're getting a dbus-based min/max value and you want to > > > >> ignore it? > > > > > > Yes, we want to ignore it. > > > > It looks like the sensor value scaling should be ignored for non-fans. > > Per https://github.com/openbmc/phosphor-pid-control/commit/75eb769d3514= 34547899186f73ff70ae00d7934a, > > this change was only meant to deal with a fan case where the goal > > looks like it was to treat the fan values as percentages on reading > > the sensors, and not only on writing them by leveraging the min/max > > json sometimes? > > > > I can change the dbuspassive constructor to set the values back to > > their input values (ignoring dbus) if the type is not "fan", but I'm > > not sure that makes sense because the real use-case isn't clear to me, > > and I know the scaling from dbus is gone: > > https://github.com/openbmc/phosphor-pid-control/search?utf8=3D%E2%9C%93= &q=3DinheritValueFromDbus&type=3D > > > > I'll submit the patch real quick, but I'm not sure it's the right > > long-term fix. I'd like to clean this up if possible so that we don't > > leverage "unused" features of a configuration and instead explicitly > > use them (or not). > > This patch should address what you're seeing. Overall, I think there > should be a larger change addressing the goal of the original change. > > https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-pid-control/+/25070 I decided to take on the larger change because chances are we might hit it some other way: https://gerrit.openbmc-project.xyz/c/25072/ This lets you specify a json configuration option that will ignore the MinValue/MaxValue properties on dbus. > > > > > > > > > > > > > >What is providing the dbus-based min/max? > > > > > > We use dbus min/max for phosphor-sel-logger utility. The dbus min/max= is provided by config file of phosphor-hwmon. > > > In our case, they are -128/127 respectively. > > > > > > I have an observation: > > > I found that while fan readpath is of the form "/sys/...", the fan in= put would not be rescaled. The same is for other sensors since the input va= lue would not enter rescaling function. > > > However, in our case we don't have a sys path for some thermal sensor= s. > > > > > > > > > > >> In the json configuration, if you set the values to 0, they are se= t to > > > >> the default (0), so there'd be no clean way to know to ignore dbus= in > > > >> this case, without adding a small check to only consider min/max f= rom > > > >> dbus when sensor is not temp/margin. Basically, only care about > > > >> min/max on dbus if type is "fan" > > > > > > > > > > I agree with the option to add a check since the min/max is only for = fan now. > > > > > > >Why is the dbus-based min/max even there if you don't plan on using = it? > > > > > > > >> > > > >> If that's right, James do you have a cycle to look at this one-lin= er? > > > >> > > > >>> > > > >>> > > > >>> As a result, fan will be at full speed while temp is low. Before = the commit > > > >fc2e803 [1], this won't happen. The root cause is that, before fc2e8= 03, pid will > > > >use config min/max, which is 0 in our case. This would not trigger s= caling > > > >function, namely scaleSensorReading, in util.cpp. However, after suc= h commit, > > > >min/max would be non-zero (-128/127 from DBus). This will trigger sc= aling > > > >function. > > > >>> > > > >>> > > > >>> [1] > > > >>> https://github.com/openbmc/phosphor-pid- > > > >control/commit/fc2e803f5d9256 > > > >>> 944e18c7c878a441606b1f121c > > > >>> > > > >>> > > > >>> Hank > > > >>> > > > >>> > > > >>> ________________________________ > > > >>> From: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) > > > >>> Sent: Monday, September 2, 2019 4:52 PM > > > >>> To: Patrick Venture > > > >>> Cc: James Feist; openbmc@lists.ozlabs.org > > > >>> Subject: Re: [phosphor-pid-control] scaling issue > > > >>> > > > >>> > > > >>> Hi Patrick, > > > >>> > > > >>> > > > >>> Since we use phosphor-sel-logger [1] at the same time, we do assi= gn min > > > >and max of temp sensors to Dbus (max: 127, min: -128). So in the pre= sent case, > > > >our temp value will be divided by 0.255 (also due to exponent is -3 = here). This > > > >will cause re-scaling problem. Therefore there should be an statemen= t to > > > >distinguish sensor types. If it is "temp", then one assigns 0 to the= min and max > > > >from Dbus. > > > >>> > > > >>> > > > >>> [1] > > > >>> https://github.com/openbmc/phosphor-sel- > > > >logger/blob/3d300fca24b30864b > > > >>> 3e9a4f5768cfe5e769458ae/include/sensorutils.hpp#L59 > > > >>> > > > >>> > > > >>> Hank > > > >>> > > > >>> > > > >>> ________________________________ > > > >>> From: Patrick Venture > > > >>> Sent: Friday, August 30, 2019 1:47 AM > > > >>> To: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) > > > >>> Cc: James Feist; openbmc@lists.ozlabs.org > > > >>> Subject: Re: [phosphor-pid-control] scaling issue > > > >>> > > > >>> PTAL - https://gerrit.openbmc-project.xyz/24827 - this is merged,= and > > > >>> the srcrev bump should propagate into openbmc/openbmc in a day or= two. > > > >>> > > > >>> On Wed, Aug 28, 2019 at 11:00 PM Hank Liou (=E5=8A=89=E6=99=89=E7= =BF=B0) > > > > wrote: > > > >>>> > > > >>>> Hi Patrick, > > > >>>> > > > >>>> I think it's OK to parse the config min&max for temp sensors. > > > >>>> > > > >>>> Any suggestion? > > > >>>> > > > >>>> Thanks, > > > >>>> Hank > > > >>>> > > > >>>>> -----Original Message----- > > > >>>>> From: openbmc [mailto:openbmc- > > > >>>>> bounces+hank.liou=3Dquantatw.com@lists.ozlabs.org] On Behalf Of= Hank > > > >>>>> bounces+Liou > > > >>>>> (=E5=8A=89=E6=99=89=E7=BF=B0) > > > >>>>> Sent: Friday, August 23, 2019 4:31 PM > > > >>>>> To: Patrick Venture ; James Feist > > > >>>>> > > > >>>>> Cc: openbmc@lists.ozlabs.org > > > >>>>> Subject: RE: [phosphor-pid-control] scaling issue > > > >>>>> > > > >>>>> Hi Patrick, > > > >>>>> > > > >>>>>> -----Original Message----- > > > >>>>>> From: Patrick Venture [mailto:venture@google.com] > > > >>>>>> Sent: Wednesday, August 21, 2019 10:32 PM > > > >>>>>> To: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) ; James Feist > > > >>>>>> > > > >>>>>> Cc: openbmc@lists.ozlabs.org > > > >>>>>> Subject: Re: [phosphor-pid-control] scaling issue > > > >>>>>> > > > >>>>>> On Wed, Aug 21, 2019 at 1:11 AM Hank Liou (=E5=8A=89=E6=99=89= =E7=BF=B0) > > > >>>>>> wrote: > > > >>>>>>> > > > >>>>>>> Hi All, > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> After commit [1], I found my temp sensor reading would be > > > >>>>>>> re-scaled by > > > >>>>>> multiplying 1 over 255, making temperature into unfamiliar uni= t. > > > >>>>>> Also the fan rpm reading would lie in [0,1] interval, letting = the > > > >>>>>> fan input to be 0 (since the input value of fan is from an int= eger > > > >>>>>> array [2]). Are these > > > >>>>> normal behaviors? > > > >>>>>> Or do I miss something? > > > >>>>>> > > > >>>>>> Are you using dbus configuration or json? If json, can you at= tach your > > > >config. > > > >>>>>> Since you're saying it was working and now isn't, I'm assuming > > > >>>>>> there's something about the config being treated differently w= ith > > > >>>>>> the code changes in an unexpected way. > > > >>>>> > > > >>>>> I found pid control will first read min and max from dbus and t= hen > > > >>>>> (before commit [1]) revise them if > > > >>>>> > > > >>>>> info->min !=3D conf::inheritValueFromDbus (in dbus/dbuspassive.= cpp) > > > >>>>> > > > >>>>> After value initialization, the min and max would be the ones i= n > > > >>>>> json file (Json file [3]). However, after commit [1] the min an= d > > > >>>>> max values of config would not be fed into the fan control proc= ess. > > > >>>>> The scaling issue is originated from commit [4] with the aim to > > > >>>>> treat fan rpm as percentage. It seems that commit [1] unexpecte= dly > > > >>>>> affects temp sensors in the sense that the temp is the integer > > > >>>>> reading not percentage. Before commit [1], it would not re-scal= e the > > > >temp reading since my min and max are 0 [6]. > > > >>>>> > > > >>>>> > > > >>>>> > > > >>>>> There is another issue with commit [1]. Now the fan rpm would b= e > > > >>>>> something like > > > >>>>> > > > >>>>> 1500 / 20000 =3D 0.075 > > > >>>>> > > > >>>>> where rpm max 20000 is from dbus. However the fan input functio= n > > > >>>>> would transfer double into int, which is 0 for 0.075 (see [5]). > > > >>>>> Hence the fan input is 0 not percentage. Is there something wro= ng? > > > >>>>> > > > >>>>> [1] https://github.com/openbmc/phosphor-pid- > > > >>>>> control/commit/fc2e803f5d9256944e18c7c878a441606b1f121c > > > >>>>> [2] https://github.com/openbmc/phosphor-pid- > > > >>>>> > > > >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontro > > > >>>>> lle > > > >>>>> r.cpp#L86 > > > >>>>> [3] > > > >>>>> { > > > >>>>> "name": "fan1", > > > >>>>> "type": "fan", > > > >>>>> "readPath": "/sys/class/hwmon/hwmon1/fan1_input", > > > >>>>> "writePath": "/sys/class/hwmon/hwmon1/pwm1", > > > >>>>> "min": 0, > > > >>>>> "max": 255 > > > >>>>> }, > > > >>>>> { > > > >>>>> "name": "temp1", > > > >>>>> "type": "temp", > > > >>>>> "readPath": > > > >"/xyz/openbmc_project/sensors/temperature/temp1", > > > >>>>> "writePath": "", > > > >>>>> "min": 0, > > > >>>>> "max": 0 > > > >>>>> } > > > >>>>> [4] https://github.com/openbmc/phosphor-pid- > > > >>>>> control/commit/75eb769d351434547899186f73ff70ae00d7934a > > > >>>>> [5] https://github.com/openbmc/phosphor-pid- > > > >>>>> > > > >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancontro > > > >>>>> lle > > > >>>>> r.cpp#L64 > > > >>>>> [6] https://github.com/openbmc/phosphor-pid- > > > >>>>> > > > >control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/dbus/dbuspass > > > >>>>> i > > > >>>>> ve.cpp#L158 > > > >>>>> > > > >>>>>> > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> [1] > > > >>>>>>> https://github.com/openbmc/phosphor-pid- > > > >>>>>> control/commit/fc2e803f5d92569 > > > >>>>>>> 44e18c7c878a441606b1f121c > > > >>>>>>> > > > >>>>>>> [2] > > > >>>>>>> https://github.com/openbmc/phosphor-pid- > > > >>>>>> control/blob/a7ec8350d17b70153 > > > >>>>>>> cebe666d3fbe88bddd02a1a/pid/fancontroller.cpp#L86 > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> Thanks, > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> Hank Liou > > > >>>>>>> > > > >>>>>>> Quanta Computer Inc. > > > >>>>>>> > > > >>>>>>> > > > >>>>> > > > >>>>> Sincerely, > > > >>>>> Hank From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=quantatw.com (client-ip=220.128.79.91; helo=mx02.quantatw.com; envelope-from=prvs=1558554e7=hank.liou@quantatw.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=quantatw.com Received: from mx02.quantatw.com (mx02.quantatw.com [220.128.79.91]) by lists.ozlabs.org (Postfix) with ESMTP id 46X03d2YCPzF45p for ; Mon, 16 Sep 2019 18:37:12 +1000 (AEST) Received: from unknown (HELO mailbx09.quanta.corp) ([10.243.91.106]) by mx02.quantatw.com with ESMTP; 16 Sep 2019 16:37:08 +0800 Received: from mailbx09.quanta.corp (10.243.91.106) by mailbx09.quanta.corp (10.243.91.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 16 Sep 2019 16:37:08 +0800 Received: from mailbx09.quanta.corp ([fe80::c501:1c2b:62fc:dd81]) by mailbx09.quanta.corp ([fe80::c501:1c2b:62fc:dd81%6]) with mapi id 15.01.1713.004; Mon, 16 Sep 2019 16:37:08 +0800 From: =?utf-8?B?SGFuayBMaW91ICjlionmmYnnv7Ap?= To: Patrick Venture CC: James Feist , "openbmc@lists.ozlabs.org" Subject: RE: [phosphor-pid-control] scaling issue Thread-Topic: [phosphor-pid-control] scaling issue Thread-Index: AQHVV/XbtwEoqXVk+kGbiKtv2uj0UqcFJGgAgAE9VwCAC0qVsIAAQT+AgAYx+NeABJmE/IAGcF0AgAAIKACAAWYjoP///XOAgAADkACAADI+AIAJWILA Date: Mon, 16 Sep 2019 08:37:07 +0000 Message-ID: <5a46202d21694717b1aa40b4ef5105ea@quantatw.com> References: <369926533c3e448c9d1a0d28391fd688@quantatw.com> <02128993d3064b53ac289500746666ab@quantatw.com>

<4b7d382d292d45fdab63f4adcc40eded@quantatw.com>

In-Reply-To: Accept-Language: en-US, zh-TW Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.243.91.252] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2019 08:37:19 -0000 SGkgUGF0cmljaywNCg0KVGhhbmtzIGZvciB5b3VyIGhlbHAuIFRoaXMgY2hhbmdlIGRvZXMgc29s dmUgdGhlIGlzc3VlLg0KDQpIYW5rDQoNCj4tLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPkZy b206IFBhdHJpY2sgVmVudHVyZSBbbWFpbHRvOnZlbnR1cmVAZ29vZ2xlLmNvbV0NCj5TZW50OiBX ZWRuZXNkYXksIFNlcHRlbWJlciAxMSwgMjAxOSAxOjUyIEFNDQo+VG86IEhhbmsgTGlvdSAo5YqJ 5pmJ57+wKSA8SGFuay5MaW91QHF1YW50YXR3LmNvbT4NCj5DYzogSmFtZXMgRmVpc3QgPGphbWVz LmZlaXN0QGxpbnV4LmludGVsLmNvbT47IG9wZW5ibWNAbGlzdHMub3psYWJzLm9yZw0KPlN1Ympl Y3Q6IFJlOiBbcGhvc3Bob3ItcGlkLWNvbnRyb2xdIHNjYWxpbmcgaXNzdWUNCj4NCj5PbiBUdWUs IFNlcCAxMCwgMjAxOSBhdCA3OjUyIEFNIFBhdHJpY2sgVmVudHVyZSA8dmVudHVyZUBnb29nbGUu Y29tPg0KPndyb3RlOg0KPj4NCj4+IE9uIFR1ZSwgU2VwIDEwLCAyMDE5IGF0IDc6MzkgQU0gUGF0 cmljayBWZW50dXJlIDx2ZW50dXJlQGdvb2dsZS5jb20+DQo+d3JvdGU6DQo+PiA+DQo+PiA+IE9u IFR1ZSwgU2VwIDEwLCAyMDE5IGF0IDE6MDIgQU0gSGFuayBMaW91ICjlionmmYnnv7ApDQo+PEhh bmsuTGlvdUBxdWFudGF0dy5jb20+IHdyb3RlOg0KPj4gPiA+DQo+PiA+ID4gPi0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tDQo+PiA+ID4gPkZyb206IEphbWVzIEZlaXN0IFttYWlsdG86amFtZXMu ZmVpc3RAbGludXguaW50ZWwuY29tXQ0KPj4gPiA+ID5TZW50OiBUdWVzZGF5LCBTZXB0ZW1iZXIg MTAsIDIwMTkgMToyNyBBTQ0KPj4gPiA+ID5UbzogUGF0cmljayBWZW50dXJlIDx2ZW50dXJlQGdv b2dsZS5jb20+OyBIYW5rIExpb3UgKOWKieaZiee/sCkNCj4+ID4gPiA+PEhhbmsuTGlvdUBxdWFu dGF0dy5jb20+DQo+PiA+ID4gPkNjOiBvcGVuYm1jQGxpc3RzLm96bGFicy5vcmcNCj4+ID4gPiA+ U3ViamVjdDogUmU6IFtwaG9zcGhvci1waWQtY29udHJvbF0gc2NhbGluZyBpc3N1ZQ0KPj4gPiA+ ID4NCj4+ID4gPiA+T24gOS85LzE5IDk6NTcgQU0sIFBhdHJpY2sgVmVudHVyZSB3cm90ZToNCj4+ ID4gPiA+PiBPbiBUaHUsIFNlcCA1LCAyMDE5IGF0IDEyOjI1IEFNIEhhbmsgTGlvdSAo5YqJ5pmJ 57+wKQ0KPj4gPiA+ID48SGFuay5MaW91QHF1YW50YXR3LmNvbT4gd3JvdGU6DQo+PiA+ID4gPj4+ DQo+PiA+ID4gPj4+IEhpIFBhdHJpY2ssDQo+PiA+ID4gPj4+DQo+PiA+ID4gPj4+DQo+PiA+ID4g Pj4+IFNvcnJ5IGZvciBub3QgY2xlYXJseSBzdGF0aW5nIG91ciBwcm9ibGVtLiBXZSBoYXZlIHRo ZSBmb2xsb3dpbmcNCj5pc3N1ZToNCj4+ID4gPiA+Pj4NCj4+ID4gPiA+Pj4NCj4+ID4gPiA+Pj4g dGVtcCBzZW5zb3IgZ2V0cyAzMShDKSAtPiAzMSAvIDAuMjU1ID0gMTIxLjU3IC0+IHBpZCB1c2Vz DQo+PiA+ID4gPj4+IDEyNy41NyBhcyBpbnB1dCBmb3IgdGVtcCBzZW5zb3IgLT4NCj4+ID4gPiA+ Pj4NCj4+ID4gPiA+Pj4gc3RlcHdpc2UgZmFuIHRhYmxlIG91dHB1dCAxMDAgZHV0eSAtPiBmdWxs IHNwZWVkIGZhbg0KPj4gPiA+ID4+DQo+PiA+ID4gPj4gT2ssIHNvIHlvdSdyZSBnZXR0aW5nIGEg ZGJ1cy1iYXNlZCBtaW4vbWF4IHZhbHVlIGFuZCB5b3Ugd2FudA0KPj4gPiA+ID4+IHRvIGlnbm9y ZSBpdD8NCj4+ID4gPg0KPj4gPiA+IFllcywgd2Ugd2FudCB0byBpZ25vcmUgaXQuDQo+PiA+DQo+ PiA+IEl0IGxvb2tzIGxpa2UgdGhlIHNlbnNvciB2YWx1ZSBzY2FsaW5nIHNob3VsZCBiZSBpZ25v cmVkIGZvciBub24tZmFucy4NCj4+ID4gUGVyDQo+PiA+IGh0dHBzOi8vZ2l0aHViLmNvbS9vcGVu Ym1jL3Bob3NwaG9yLXBpZC0NCj5jb250cm9sL2NvbW1pdC83NWViNzY5ZDM1MTQzDQo+PiA+IDQ1 NDc4OTkxODZmNzNmZjcwYWUwMGQ3OTM0YSwgdGhpcyBjaGFuZ2Ugd2FzIG9ubHkgbWVhbnQgdG8g ZGVhbCB3aXRoDQo+PiA+IGEgZmFuIGNhc2Ugd2hlcmUgdGhlIGdvYWwgbG9va3MgbGlrZSBpdCB3 YXMgdG8gdHJlYXQgdGhlIGZhbiB2YWx1ZXMNCj4+ID4gYXMgcGVyY2VudGFnZXMgb24gcmVhZGlu ZyB0aGUgc2Vuc29ycywgYW5kIG5vdCBvbmx5IG9uIHdyaXRpbmcgdGhlbQ0KPj4gPiBieSBsZXZl cmFnaW5nIHRoZSBtaW4vbWF4IGpzb24gc29tZXRpbWVzPw0KPj4gPg0KPj4gPiBJIGNhbiBjaGFu Z2UgdGhlIGRidXNwYXNzaXZlIGNvbnN0cnVjdG9yIHRvIHNldCB0aGUgdmFsdWVzIGJhY2sgdG8N Cj4+ID4gdGhlaXIgaW5wdXQgdmFsdWVzIChpZ25vcmluZyBkYnVzKSBpZiB0aGUgdHlwZSBpcyBu b3QgImZhbiIsIGJ1dCBJJ20NCj4+ID4gbm90IHN1cmUgdGhhdCBtYWtlcyBzZW5zZSBiZWNhdXNl IHRoZSByZWFsIHVzZS1jYXNlIGlzbid0IGNsZWFyIHRvDQo+PiA+IG1lLCBhbmQgSSBrbm93IHRo ZSBzY2FsaW5nIGZyb20gZGJ1cyBpcyBnb25lOg0KPj4gPiBodHRwczovL2dpdGh1Yi5jb20vb3Bl bmJtYy9waG9zcGhvci1waWQtDQo+Y29udHJvbC9zZWFyY2g/dXRmOD0lRTIlOUMlOQ0KPj4gPiAz JnE9aW5oZXJpdFZhbHVlRnJvbURidXMmdHlwZT0NCj4+ID4NCj4+ID4gSSdsbCBzdWJtaXQgdGhl IHBhdGNoIHJlYWwgcXVpY2ssIGJ1dCBJJ20gbm90IHN1cmUgaXQncyB0aGUgcmlnaHQNCj4+ID4g bG9uZy10ZXJtIGZpeC4gIEknZCBsaWtlIHRvIGNsZWFuIHRoaXMgdXAgaWYgcG9zc2libGUgc28g dGhhdCB3ZQ0KPj4gPiBkb24ndCBsZXZlcmFnZSAidW51c2VkIiBmZWF0dXJlcyBvZiBhIGNvbmZp Z3VyYXRpb24gYW5kIGluc3RlYWQNCj4+ID4gZXhwbGljaXRseSB1c2UgdGhlbSAob3Igbm90KS4N Cj4+DQo+PiBUaGlzIHBhdGNoIHNob3VsZCBhZGRyZXNzIHdoYXQgeW91J3JlIHNlZWluZy4gIE92 ZXJhbGwsIEkgdGhpbmsgdGhlcmUNCj4+IHNob3VsZCBiZSBhIGxhcmdlciBjaGFuZ2UgYWRkcmVz c2luZyB0aGUgZ29hbCBvZiB0aGUgb3JpZ2luYWwgY2hhbmdlLg0KPj4NCj4+IGh0dHBzOi8vZ2Vy cml0Lm9wZW5ibWMtcHJvamVjdC54eXovYy9vcGVuYm1jL3Bob3NwaG9yLXBpZC1jb250cm9sLysv MjUNCj4+IDA3MA0KPg0KPkkgZGVjaWRlZCB0byB0YWtlIG9uIHRoZSBsYXJnZXIgY2hhbmdlIGJl Y2F1c2UgY2hhbmNlcyBhcmUgd2UgbWlnaHQgaGl0IGl0DQo+c29tZSBvdGhlciB3YXk6DQo+aHR0 cHM6Ly9nZXJyaXQub3BlbmJtYy1wcm9qZWN0Lnh5ei9jLzI1MDcyLw0KPg0KPlRoaXMgbGV0cyB5 b3Ugc3BlY2lmeSBhIGpzb24gY29uZmlndXJhdGlvbiBvcHRpb24gdGhhdCB3aWxsIGlnbm9yZSB0 aGUNCj5NaW5WYWx1ZS9NYXhWYWx1ZSBwcm9wZXJ0aWVzIG9uIGRidXMuDQo+DQo+Pg0KPj4gPg0K Pj4gPiA+DQo+PiA+ID4gPg0KPj4gPiA+ID5XaGF0IGlzIHByb3ZpZGluZyB0aGUgZGJ1cy1iYXNl ZCBtaW4vbWF4Pw0KPj4gPiA+DQo+PiA+ID4gV2UgdXNlIGRidXMgbWluL21heCBmb3IgcGhvc3Bo b3Itc2VsLWxvZ2dlciB1dGlsaXR5LiBUaGUgZGJ1cyBtaW4vbWF4DQo+aXMgcHJvdmlkZWQgYnkg Y29uZmlnIGZpbGUgb2YgcGhvc3Bob3ItaHdtb24uDQo+PiA+ID4gSW4gb3VyIGNhc2UsIHRoZXkg YXJlIC0xMjgvMTI3IHJlc3BlY3RpdmVseS4NCj4+ID4gPg0KPj4gPiA+IEkgaGF2ZSBhbiBvYnNl cnZhdGlvbjoNCj4+ID4gPiBJIGZvdW5kIHRoYXQgd2hpbGUgZmFuIHJlYWRwYXRoIGlzIG9mIHRo ZSBmb3JtICIvc3lzLy4uLiIsIHRoZSBmYW4gaW5wdXQNCj53b3VsZCBub3QgYmUgcmVzY2FsZWQu IFRoZSBzYW1lIGlzIGZvciBvdGhlciBzZW5zb3JzIHNpbmNlIHRoZSBpbnB1dCB2YWx1ZQ0KPndv dWxkIG5vdCBlbnRlciByZXNjYWxpbmcgZnVuY3Rpb24uDQo+PiA+ID4gSG93ZXZlciwgaW4gb3Vy IGNhc2Ugd2UgZG9uJ3QgaGF2ZSBhIHN5cyBwYXRoIGZvciBzb21lIHRoZXJtYWwgc2Vuc29ycy4N Cj4+ID4gPg0KPj4gPiA+ID4NCj4+ID4gPiA+PiBJbiB0aGUganNvbiBjb25maWd1cmF0aW9uLCBp ZiB5b3Ugc2V0IHRoZSB2YWx1ZXMgdG8gMCwgdGhleSBhcmUNCj4+ID4gPiA+PiBzZXQgdG8gdGhl IGRlZmF1bHQgKDApLCBzbyB0aGVyZSdkIGJlIG5vIGNsZWFuIHdheSB0byBrbm93IHRvDQo+PiA+ ID4gPj4gaWdub3JlIGRidXMgaW4gdGhpcyBjYXNlLCB3aXRob3V0IGFkZGluZyBhIHNtYWxsIGNo ZWNrIHRvIG9ubHkNCj4+ID4gPiA+PiBjb25zaWRlciBtaW4vbWF4IGZyb20gZGJ1cyB3aGVuIHNl bnNvciBpcyBub3QgdGVtcC9tYXJnaW4uDQo+PiA+ID4gPj4gQmFzaWNhbGx5LCBvbmx5IGNhcmUg YWJvdXQgbWluL21heCBvbiBkYnVzIGlmIHR5cGUgaXMgImZhbiINCj4+ID4gPiA+DQo+PiA+ID4N Cj4+ID4gPiBJIGFncmVlIHdpdGggdGhlIG9wdGlvbiB0byBhZGQgYSBjaGVjayBzaW5jZSB0aGUg bWluL21heCBpcyBvbmx5IGZvciBmYW4NCj5ub3cuDQo+PiA+ID4NCj4+ID4gPiA+V2h5IGlzIHRo ZSBkYnVzLWJhc2VkIG1pbi9tYXggZXZlbiB0aGVyZSBpZiB5b3UgZG9uJ3QgcGxhbiBvbiB1c2lu ZyBpdD8NCj4+ID4gPiA+DQo+PiA+ID4gPj4NCj4+ID4gPiA+PiBJZiB0aGF0J3MgcmlnaHQsIEph bWVzIGRvIHlvdSBoYXZlIGEgY3ljbGUgdG8gbG9vayBhdCB0aGlzIG9uZS1saW5lcj8NCj4+ID4g PiA+Pg0KPj4gPiA+ID4+Pg0KPj4gPiA+ID4+Pg0KPj4gPiA+ID4+PiBBcyBhIHJlc3VsdCwgZmFu IHdpbGwgYmUgYXQgZnVsbCBzcGVlZCB3aGlsZSB0ZW1wIGlzIGxvdy4NCj4+ID4gPiA+Pj4gQmVm b3JlIHRoZSBjb21taXQNCj4+ID4gPiA+ZmMyZTgwMyBbMV0sIHRoaXMgd29uJ3QgaGFwcGVuLiBU aGUgcm9vdCBjYXVzZSBpcyB0aGF0LCBiZWZvcmUNCj4+ID4gPiA+ZmMyZTgwMywgcGlkIHdpbGwg dXNlIGNvbmZpZyBtaW4vbWF4LCB3aGljaCBpcyAwIGluIG91ciBjYXNlLg0KPj4gPiA+ID5UaGlz IHdvdWxkIG5vdCB0cmlnZ2VyIHNjYWxpbmcgZnVuY3Rpb24sIG5hbWVseQ0KPj4gPiA+ID5zY2Fs ZVNlbnNvclJlYWRpbmcsIGluIHV0aWwuY3BwLiBIb3dldmVyLCBhZnRlciBzdWNoIGNvbW1pdCwN Cj4+ID4gPiA+bWluL21heCB3b3VsZCBiZSBub24temVybyAoLTEyOC8xMjcgZnJvbSBEQnVzKS4g VGhpcyB3aWxsIHRyaWdnZXINCj5zY2FsaW5nIGZ1bmN0aW9uLg0KPj4gPiA+ID4+Pg0KPj4gPiA+ ID4+Pg0KPj4gPiA+ID4+PiBbMV0NCj4+ID4gPiA+Pj4gaHR0cHM6Ly9naXRodWIuY29tL29wZW5i bWMvcGhvc3Bob3ItcGlkLQ0KPj4gPiA+ID5jb250cm9sL2NvbW1pdC9mYzJlODAzZjVkOTI1Ng0K Pj4gPiA+ID4+PiA5NDRlMThjN2M4NzhhNDQxNjA2YjFmMTIxYw0KPj4gPiA+ID4+Pg0KPj4gPiA+ ID4+Pg0KPj4gPiA+ID4+PiBIYW5rDQo+PiA+ID4gPj4+DQo+PiA+ID4gPj4+DQo+PiA+ID4gPj4+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQo+PiA+ID4gPj4+IEZyb206IEhhbmsg TGlvdSAo5YqJ5pmJ57+wKQ0KPj4gPiA+ID4+PiBTZW50OiBNb25kYXksIFNlcHRlbWJlciAyLCAy MDE5IDQ6NTIgUE0NCj4+ID4gPiA+Pj4gVG86IFBhdHJpY2sgVmVudHVyZQ0KPj4gPiA+ID4+PiBD YzogSmFtZXMgRmVpc3Q7IG9wZW5ibWNAbGlzdHMub3psYWJzLm9yZw0KPj4gPiA+ID4+PiBTdWJq ZWN0OiBSZTogW3Bob3NwaG9yLXBpZC1jb250cm9sXSBzY2FsaW5nIGlzc3VlDQo+PiA+ID4gPj4+ DQo+PiA+ID4gPj4+DQo+PiA+ID4gPj4+IEhpIFBhdHJpY2ssDQo+PiA+ID4gPj4+DQo+PiA+ID4g Pj4+DQo+PiA+ID4gPj4+IFNpbmNlIHdlIHVzZSBwaG9zcGhvci1zZWwtbG9nZ2VyIFsxXSBhdCB0 aGUgc2FtZSB0aW1lLCB3ZSBkbw0KPj4gPiA+ID4+PiBhc3NpZ24gbWluDQo+PiA+ID4gPmFuZCBt YXggb2YgdGVtcCBzZW5zb3JzIHRvIERidXMgKG1heDogMTI3LCBtaW46IC0xMjgpLiBTbyBpbiB0 aGUNCj4+ID4gPiA+cHJlc2VudCBjYXNlLCBvdXIgdGVtcCB2YWx1ZSB3aWxsIGJlIGRpdmlkZWQg YnkgMC4yNTUgKGFsc28gZHVlDQo+PiA+ID4gPnRvIGV4cG9uZW50IGlzIC0zIGhlcmUpLiBUaGlz IHdpbGwgY2F1c2UgcmUtc2NhbGluZyBwcm9ibGVtLg0KPj4gPiA+ID5UaGVyZWZvcmUgdGhlcmUg c2hvdWxkIGJlIGFuIHN0YXRlbWVudCB0byBkaXN0aW5ndWlzaCBzZW5zb3INCj4+ID4gPiA+dHlw ZXMuIElmIGl0IGlzICJ0ZW1wIiwgdGhlbiBvbmUgYXNzaWducyAwIHRvIHRoZSBtaW4gYW5kIG1h eCBmcm9tIERidXMuDQo+PiA+ID4gPj4+DQo+PiA+ID4gPj4+DQo+PiA+ID4gPj4+IFsxXQ0KPj4g PiA+ID4+PiBodHRwczovL2dpdGh1Yi5jb20vb3BlbmJtYy9waG9zcGhvci1zZWwtDQo+PiA+ID4g PmxvZ2dlci9ibG9iLzNkMzAwZmNhMjRiMzA4NjRiDQo+PiA+ID4gPj4+IDNlOWE0ZjU3NjhjZmU1 ZTc2OTQ1OGFlL2luY2x1ZGUvc2Vuc29ydXRpbHMuaHBwI0w1OQ0KPj4gPiA+ID4+Pg0KPj4gPiA+ ID4+Pg0KPj4gPiA+ID4+PiBIYW5rDQo+PiA+ID4gPj4+DQo+PiA+ID4gPj4+DQo+PiA+ID4gPj4+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQo+PiA+ID4gPj4+IEZyb206IFBhdHJp Y2sgVmVudHVyZSA8dmVudHVyZUBnb29nbGUuY29tPg0KPj4gPiA+ID4+PiBTZW50OiBGcmlkYXks IEF1Z3VzdCAzMCwgMjAxOSAxOjQ3IEFNDQo+PiA+ID4gPj4+IFRvOiBIYW5rIExpb3UgKOWKieaZ iee/sCkNCj4+ID4gPiA+Pj4gQ2M6IEphbWVzIEZlaXN0OyBvcGVuYm1jQGxpc3RzLm96bGFicy5v cmcNCj4+ID4gPiA+Pj4gU3ViamVjdDogUmU6IFtwaG9zcGhvci1waWQtY29udHJvbF0gc2NhbGlu ZyBpc3N1ZQ0KPj4gPiA+ID4+Pg0KPj4gPiA+ID4+PiBQVEFMIC0gaHR0cHM6Ly9nZXJyaXQub3Bl bmJtYy1wcm9qZWN0Lnh5ei8yNDgyNyAtIHRoaXMgaXMNCj4+ID4gPiA+Pj4gbWVyZ2VkLCBhbmQg dGhlIHNyY3JldiBidW1wIHNob3VsZCBwcm9wYWdhdGUgaW50bw0KPm9wZW5ibWMvb3BlbmJtYyBp biBhIGRheSBvciB0d28uDQo+PiA+ID4gPj4+DQo+PiA+ID4gPj4+IE9uIFdlZCwgQXVnIDI4LCAy MDE5IGF0IDExOjAwIFBNIEhhbmsgTGlvdSAo5YqJ5pmJ57+wKQ0KPj4gPiA+ID48SGFuay5MaW91 QHF1YW50YXR3LmNvbT4gd3JvdGU6DQo+PiA+ID4gPj4+Pg0KPj4gPiA+ID4+Pj4gSGkgUGF0cmlj aywNCj4+ID4gPiA+Pj4+DQo+PiA+ID4gPj4+PiBJIHRoaW5rIGl0J3MgT0sgdG8gcGFyc2UgdGhl IGNvbmZpZyBtaW4mbWF4IGZvciB0ZW1wIHNlbnNvcnMuDQo+PiA+ID4gPj4+Pg0KPj4gPiA+ID4+ Pj4gQW55IHN1Z2dlc3Rpb24/DQo+PiA+ID4gPj4+Pg0KPj4gPiA+ID4+Pj4gVGhhbmtzLA0KPj4g PiA+ID4+Pj4gSGFuaw0KPj4gPiA+ID4+Pj4NCj4+ID4gPiA+Pj4+PiAtLS0tLU9yaWdpbmFsIE1l c3NhZ2UtLS0tLQ0KPj4gPiA+ID4+Pj4+IEZyb206IG9wZW5ibWMgW21haWx0bzpvcGVuYm1jLQ0K Pj4gPiA+ID4+Pj4+IGJvdW5jZXMraGFuay5saW91PXF1YW50YXR3LmNvbUBsaXN0cy5vemxhYnMu b3JnXSBPbiBCZWhhbGYNCj4+ID4gPiA+Pj4+PiBib3VuY2VzK09mIEhhbmsgTGlvdQ0KPj4gPiA+ ID4+Pj4+ICjlionmmYnnv7ApDQo+PiA+ID4gPj4+Pj4gU2VudDogRnJpZGF5LCBBdWd1c3QgMjMs IDIwMTkgNDozMSBQTQ0KPj4gPiA+ID4+Pj4+IFRvOiBQYXRyaWNrIFZlbnR1cmUgPHZlbnR1cmVA Z29vZ2xlLmNvbT47IEphbWVzIEZlaXN0DQo+PiA+ID4gPj4+Pj4gPGphbWVzLmZlaXN0QGxpbnV4 LmludGVsLmNvbT4NCj4+ID4gPiA+Pj4+PiBDYzogb3BlbmJtY0BsaXN0cy5vemxhYnMub3JnDQo+ PiA+ID4gPj4+Pj4gU3ViamVjdDogUkU6IFtwaG9zcGhvci1waWQtY29udHJvbF0gc2NhbGluZyBp c3N1ZQ0KPj4gPiA+ID4+Pj4+DQo+PiA+ID4gPj4+Pj4gSGkgUGF0cmljaywNCj4+ID4gPiA+Pj4+ Pg0KPj4gPiA+ID4+Pj4+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPj4gPiA+ID4+Pj4+ PiBGcm9tOiBQYXRyaWNrIFZlbnR1cmUgW21haWx0bzp2ZW50dXJlQGdvb2dsZS5jb21dDQo+PiA+ ID4gPj4+Pj4+IFNlbnQ6IFdlZG5lc2RheSwgQXVndXN0IDIxLCAyMDE5IDEwOjMyIFBNDQo+PiA+ ID4gPj4+Pj4+IFRvOiBIYW5rIExpb3UgKOWKieaZiee/sCkgPEhhbmsuTGlvdUBxdWFudGF0dy5j b20+OyBKYW1lcw0KPkZlaXN0DQo+PiA+ID4gPj4+Pj4+IDxqYW1lcy5mZWlzdEBsaW51eC5pbnRl bC5jb20+DQo+PiA+ID4gPj4+Pj4+IENjOiBvcGVuYm1jQGxpc3RzLm96bGFicy5vcmcNCj4+ID4g PiA+Pj4+Pj4gU3ViamVjdDogUmU6IFtwaG9zcGhvci1waWQtY29udHJvbF0gc2NhbGluZyBpc3N1 ZQ0KPj4gPiA+ID4+Pj4+Pg0KPj4gPiA+ID4+Pj4+PiBPbiBXZWQsIEF1ZyAyMSwgMjAxOSBhdCAx OjExIEFNIEhhbmsgTGlvdSAo5YqJ5pmJ57+wKQ0KPj4gPiA+ID4+Pj4+PiA8SGFuay5MaW91QHF1 YW50YXR3LmNvbT4gd3JvdGU6DQo+PiA+ID4gPj4+Pj4+Pg0KPj4gPiA+ID4+Pj4+Pj4gSGkgQWxs LA0KPj4gPiA+ID4+Pj4+Pj4NCj4+ID4gPiA+Pj4+Pj4+DQo+PiA+ID4gPj4+Pj4+PiBBZnRlciBj b21taXQgWzFdLCBJIGZvdW5kIG15IHRlbXAgc2Vuc29yIHJlYWRpbmcgd291bGQgYmUNCj4+ID4g PiA+Pj4+Pj4+IHJlLXNjYWxlZCBieQ0KPj4gPiA+ID4+Pj4+PiBtdWx0aXBseWluZyAxIG92ZXIg MjU1LCBtYWtpbmcgdGVtcGVyYXR1cmUgaW50byB1bmZhbWlsaWFyIHVuaXQuDQo+PiA+ID4gPj4+ Pj4+IEFsc28gdGhlIGZhbiBycG0gcmVhZGluZyB3b3VsZCBsaWUgaW4gWzAsMV0gaW50ZXJ2YWws DQo+PiA+ID4gPj4+Pj4+IGxldHRpbmcgdGhlIGZhbiBpbnB1dCB0byBiZSAwIChzaW5jZSB0aGUg aW5wdXQgdmFsdWUgb2YgZmFuDQo+PiA+ID4gPj4+Pj4+IGlzIGZyb20gYW4gaW50ZWdlciBhcnJh eSBbMl0pLiBBcmUgdGhlc2UNCj4+ID4gPiA+Pj4+PiBub3JtYWwgYmVoYXZpb3JzPw0KPj4gPiA+ ID4+Pj4+PiBPciBkbyBJIG1pc3Mgc29tZXRoaW5nPw0KPj4gPiA+ID4+Pj4+Pg0KPj4gPiA+ID4+ Pj4+PiBBcmUgeW91IHVzaW5nIGRidXMgY29uZmlndXJhdGlvbiBvciBqc29uPyAgSWYganNvbiwg Y2FuIHlvdQ0KPj4gPiA+ID4+Pj4+PiBhdHRhY2ggeW91cg0KPj4gPiA+ID5jb25maWcuDQo+PiA+ ID4gPj4+Pj4+IFNpbmNlIHlvdSdyZSBzYXlpbmcgaXQgd2FzIHdvcmtpbmcgYW5kIG5vdyBpc24n dCwgSSdtDQo+PiA+ID4gPj4+Pj4+IGFzc3VtaW5nIHRoZXJlJ3Mgc29tZXRoaW5nIGFib3V0IHRo ZSBjb25maWcgYmVpbmcgdHJlYXRlZA0KPj4gPiA+ID4+Pj4+PiBkaWZmZXJlbnRseSB3aXRoIHRo ZSBjb2RlIGNoYW5nZXMgaW4gYW4gdW5leHBlY3RlZCB3YXkuDQo+PiA+ID4gPj4+Pj4NCj4+ID4g PiA+Pj4+PiBJIGZvdW5kIHBpZCBjb250cm9sIHdpbGwgZmlyc3QgcmVhZCBtaW4gYW5kIG1heCBm cm9tIGRidXMNCj4+ID4gPiA+Pj4+PiBhbmQgdGhlbiAoYmVmb3JlIGNvbW1pdCBbMV0pIHJldmlz ZSB0aGVtIGlmDQo+PiA+ID4gPj4+Pj4NCj4+ID4gPiA+Pj4+PiBpbmZvLT5taW4gIT0gY29uZjo6 aW5oZXJpdFZhbHVlRnJvbURidXMgKGluDQo+PiA+ID4gPj4+Pj4gaW5mby0+ZGJ1cy9kYnVzcGFz c2l2ZS5jcHApDQo+PiA+ID4gPj4+Pj4NCj4+ID4gPiA+Pj4+PiBBZnRlciB2YWx1ZSBpbml0aWFs aXphdGlvbiwgdGhlIG1pbiBhbmQgbWF4IHdvdWxkIGJlIHRoZQ0KPj4gPiA+ID4+Pj4+IG9uZXMg aW4ganNvbiBmaWxlIChKc29uIGZpbGUgWzNdKS4gSG93ZXZlciwgYWZ0ZXIgY29tbWl0IFsxXQ0K Pj4gPiA+ID4+Pj4+IHRoZSBtaW4gYW5kIG1heCB2YWx1ZXMgb2YgY29uZmlnIHdvdWxkIG5vdCBi ZSBmZWQgaW50byB0aGUgZmFuDQo+Y29udHJvbCBwcm9jZXNzLg0KPj4gPiA+ID4+Pj4+IFRoZSBz Y2FsaW5nIGlzc3VlIGlzIG9yaWdpbmF0ZWQgZnJvbSBjb21taXQgWzRdIHdpdGggdGhlIGFpbQ0K Pj4gPiA+ID4+Pj4+IHRvIHRyZWF0IGZhbiBycG0gYXMgcGVyY2VudGFnZS4gSXQgc2VlbXMgdGhh dCBjb21taXQgWzFdDQo+PiA+ID4gPj4+Pj4gdW5leHBlY3RlZGx5IGFmZmVjdHMgdGVtcCBzZW5z b3JzIGluIHRoZSBzZW5zZSB0aGF0IHRoZSB0ZW1wDQo+PiA+ID4gPj4+Pj4gaXMgdGhlIGludGVn ZXIgcmVhZGluZyBub3QgcGVyY2VudGFnZS4gQmVmb3JlIGNvbW1pdCBbMV0sIGl0DQo+PiA+ID4g Pj4+Pj4gd291bGQgbm90IHJlLXNjYWxlIHRoZQ0KPj4gPiA+ID50ZW1wIHJlYWRpbmcgc2luY2Ug bXkgbWluIGFuZCBtYXggYXJlIDAgWzZdLg0KPj4gPiA+ID4+Pj4+DQo+PiA+ID4gPj4+Pj4NCj4+ ID4gPiA+Pj4+Pg0KPj4gPiA+ID4+Pj4+IFRoZXJlIGlzIGFub3RoZXIgaXNzdWUgd2l0aCBjb21t aXQgWzFdLiBOb3cgdGhlIGZhbiBycG0NCj4+ID4gPiA+Pj4+PiB3b3VsZCBiZSBzb21ldGhpbmcg bGlrZQ0KPj4gPiA+ID4+Pj4+DQo+PiA+ID4gPj4+Pj4gMTUwMCAvIDIwMDAwID0gMC4wNzUNCj4+ ID4gPiA+Pj4+Pg0KPj4gPiA+ID4+Pj4+IHdoZXJlIHJwbSBtYXggMjAwMDAgaXMgZnJvbSBkYnVz LiBIb3dldmVyIHRoZSBmYW4gaW5wdXQNCj4+ID4gPiA+Pj4+PiBmdW5jdGlvbiB3b3VsZCB0cmFu c2ZlciBkb3VibGUgaW50byBpbnQsIHdoaWNoIGlzIDAgZm9yIDAuMDc1IChzZWUNCj5bNV0pLg0K Pj4gPiA+ID4+Pj4+IEhlbmNlIHRoZSBmYW4gaW5wdXQgaXMgMCBub3QgcGVyY2VudGFnZS4gSXMg dGhlcmUgc29tZXRoaW5nDQo+d3Jvbmc/DQo+PiA+ID4gPj4+Pj4NCj4+ID4gPiA+Pj4+PiBbMV0g aHR0cHM6Ly9naXRodWIuY29tL29wZW5ibWMvcGhvc3Bob3ItcGlkLQ0KPj4gPiA+ID4+Pj4+IGNv bnRyb2wvY29tbWl0L2ZjMmU4MDNmNWQ5MjU2OTQ0ZTE4YzdjODc4YTQ0MTYwNmIxZjEyMWMNCj4+ ID4gPiA+Pj4+PiBbMl0gaHR0cHM6Ly9naXRodWIuY29tL29wZW5ibWMvcGhvc3Bob3ItcGlkLQ0K Pj4gPiA+ID4+Pj4+DQo+PiA+ID4NCj4+Y29udHJvbC9ibG9iL2E3ZWM4MzUwZDE3YjcwMTUzY2Vi ZTY2NmQzZmJlODhiZGRkMDJhMWEvcGlkL2ZhbmNvbnQNCj4+ID4gPiA+cm8NCj4+ID4gPiA+Pj4+ PiBsbGUNCj4+ID4gPiA+Pj4+PiByLmNwcCNMODYNCj4+ID4gPiA+Pj4+PiBbM10NCj4+ID4gPiA+ Pj4+PiAgICAgICAgew0KPj4gPiA+ID4+Pj4+ICAgICAgICAgICAgICJuYW1lIjogImZhbjEiLA0K Pj4gPiA+ID4+Pj4+ICAgICAgICAgICAgICJ0eXBlIjogImZhbiIsDQo+PiA+ID4gPj4+Pj4gICAg ICAgICAgICAgInJlYWRQYXRoIjogIi9zeXMvY2xhc3MvaHdtb24vaHdtb24xL2ZhbjFfaW5wdXQi LA0KPj4gPiA+ID4+Pj4+ICAgICAgICAgICAgICJ3cml0ZVBhdGgiOiAiL3N5cy9jbGFzcy9od21v bi9od21vbjEvcHdtMSIsDQo+PiA+ID4gPj4+Pj4gICAgICAgICAgICAgIm1pbiI6IDAsDQo+PiA+ ID4gPj4+Pj4gICAgICAgICAgICAgIm1heCI6IDI1NQ0KPj4gPiA+ID4+Pj4+ICAgICAgICAgfSwN Cj4+ID4gPiA+Pj4+PiAgICAgICAgIHsNCj4+ID4gPiA+Pj4+PiAgICAgICAgICAgICAibmFtZSI6 ICJ0ZW1wMSIsDQo+PiA+ID4gPj4+Pj4gICAgICAgICAgICAgInR5cGUiOiAidGVtcCIsDQo+PiA+ ID4gPj4+Pj4gICAgICAgICAgICAgInJlYWRQYXRoIjoNCj4+ID4gPiA+Ii94eXovb3BlbmJtY19w cm9qZWN0L3NlbnNvcnMvdGVtcGVyYXR1cmUvdGVtcDEiLA0KPj4gPiA+ID4+Pj4+ICAgICAgICAg ICAgICJ3cml0ZVBhdGgiOiAiIiwNCj4+ID4gPiA+Pj4+PiAgICAgICAgICAgICAibWluIjogMCwN Cj4+ID4gPiA+Pj4+PiAgICAgICAgICAgICAibWF4IjogMA0KPj4gPiA+ID4+Pj4+ICAgICAgICAg fQ0KPj4gPiA+ID4+Pj4+IFs0XSBodHRwczovL2dpdGh1Yi5jb20vb3BlbmJtYy9waG9zcGhvci1w aWQtDQo+PiA+ID4gPj4+Pj4gY29udHJvbC9jb21taXQvNzVlYjc2OWQzNTE0MzQ1NDc4OTkxODZm NzNmZjcwYWUwMGQ3OTM0YQ0KPj4gPiA+ID4+Pj4+IFs1XSBodHRwczovL2dpdGh1Yi5jb20vb3Bl bmJtYy9waG9zcGhvci1waWQtDQo+PiA+ID4gPj4+Pj4NCj4+ID4gPg0KPj5jb250cm9sL2Jsb2Iv YTdlYzgzNTBkMTdiNzAxNTNjZWJlNjY2ZDNmYmU4OGJkZGQwMmExYS9waWQvZmFuY29udA0KPj4g PiA+ID5ybw0KPj4gPiA+ID4+Pj4+IGxsZQ0KPj4gPiA+ID4+Pj4+IHIuY3BwI0w2NA0KPj4gPiA+ ID4+Pj4+IFs2XSBodHRwczovL2dpdGh1Yi5jb20vb3BlbmJtYy9waG9zcGhvci1waWQtDQo+PiA+ ID4gPj4+Pj4NCj4+ID4gPg0KPj5jb250cm9sL2Jsb2IvYTdlYzgzNTBkMTdiNzAxNTNjZWJlNjY2 ZDNmYmU4OGJkZGQwMmExYS9kYnVzL2RidXNwYQ0KPj4gPiA+ID5zcw0KPj4gPiA+ID4+Pj4+IGkN Cj4+ID4gPiA+Pj4+PiB2ZS5jcHAjTDE1OA0KPj4gPiA+ID4+Pj4+DQo+PiA+ID4gPj4+Pj4+DQo+ PiA+ID4gPj4+Pj4+Pg0KPj4gPiA+ID4+Pj4+Pj4NCj4+ID4gPiA+Pj4+Pj4+IFsxXQ0KPj4gPiA+ ID4+Pj4+Pj4gaHR0cHM6Ly9naXRodWIuY29tL29wZW5ibWMvcGhvc3Bob3ItcGlkLQ0KPj4gPiA+ ID4+Pj4+PiBjb250cm9sL2NvbW1pdC9mYzJlODAzZjVkOTI1NjkNCj4+ID4gPiA+Pj4+Pj4+IDQ0 ZTE4YzdjODc4YTQ0MTYwNmIxZjEyMWMNCj4+ID4gPiA+Pj4+Pj4+DQo+PiA+ID4gPj4+Pj4+PiBb Ml0NCj4+ID4gPiA+Pj4+Pj4+IGh0dHBzOi8vZ2l0aHViLmNvbS9vcGVuYm1jL3Bob3NwaG9yLXBp ZC0NCj4+ID4gPiA+Pj4+Pj4gY29udHJvbC9ibG9iL2E3ZWM4MzUwZDE3YjcwMTUzDQo+PiA+ID4g Pj4+Pj4+PiBjZWJlNjY2ZDNmYmU4OGJkZGQwMmExYS9waWQvZmFuY29udHJvbGxlci5jcHAjTDg2 DQo+PiA+ID4gPj4+Pj4+Pg0KPj4gPiA+ID4+Pj4+Pj4NCj4+ID4gPiA+Pj4+Pj4+IFRoYW5rcywN Cj4+ID4gPiA+Pj4+Pj4+DQo+PiA+ID4gPj4+Pj4+Pg0KPj4gPiA+ID4+Pj4+Pj4gSGFuayBMaW91 DQo+PiA+ID4gPj4+Pj4+Pg0KPj4gPiA+ID4+Pj4+Pj4gUXVhbnRhIENvbXB1dGVyIEluYy4NCj4+ ID4gPiA+Pj4+Pj4+DQo+PiA+ID4gPj4+Pj4+Pg0KPj4gPiA+ID4+Pj4+DQo+PiA+ID4gPj4+Pj4g U2luY2VyZWx5LA0KPj4gPiA+ID4+Pj4+IEhhbmsNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::542; helo=mail-pg1-x542.google.com; envelope-from=venture@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="kmhKXL5V"; dkim-atps=neutral Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46X9Y96N88zF43k for ; Tue, 17 Sep 2019 01:45:01 +1000 (AEST) Received: by mail-pg1-x542.google.com with SMTP id n9so242656pgc.1 for ; Mon, 16 Sep 2019 08:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=0RYiibXmglOKth3Njfs6u881DVcoL+HDWxIDif7EgJA=; b=kmhKXL5VzLtvfkiu1oidwA6mDhgrgVvr8U+FWZijvSwp++2TvlkFY/Syu7f16aE0GK /tEI9KpKhVFVId7lzXHz9sC1/t/2+RT4yPQtfOxZJajpIQPc/j7WjjaP2mDnIl0MXFZf JaIiyY7Oere1sy3FJIJXt8vyuHLZOk7QMyunLxEqRFmWs5TBUa94o91ORcYrVGGZY5sh HDgNpnUaa+fQ+iEgiALYmP/v/IGxh5vzTJj6GXyp+l4AUSSVyyTFmTUzVVDZ1Xpdh6mB b5xOrSzT71z/hmtAJpwsTkLDr6PJBeDQt8HR2bVjjfdY0+6NWAxqFmwAWt3gACUkg8OV B89A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0RYiibXmglOKth3Njfs6u881DVcoL+HDWxIDif7EgJA=; b=HxsoEGj58t9hS8b1oc9xuWPYDYRokp5jRRddLm8D3lc+izrcNy9vR2Yl+2Y1sKwfRg TwSAnXlz/aGCj7PglSUKldUQ/iBic1kdsbKaownyA/Hc0Ql3H9MWniLUn3PSw5xCD3li vbsKlcTgpGMLl7kW/WhgR1JcJpdKHrRCPWkXSbPt26Z0TeNS5fiK1OK9HByo/KFpQVP8 iGr5q5WLZS8tP6QlDxU4xwDfzsCOma7ndgdJaCbMz2rRAn+mFBYvBFzoT2JxrnphEvrN ePtEkQEGUMUxG1ZF1Zcmh4VWAk4GMYTOwIhVbOPotfpmzco+rSXaQdLRsWQ35hESqkDA A9kg== X-Gm-Message-State: APjAAAUVskRU1wWb4LC08jp85WMVDMQ+ZBfqAXrRB2veKg+ineK+HJ91 nIKtYqAnBlhkysXd7/YlOOG/aFDx/8JXNGAlQTIKCQ== X-Google-Smtp-Source: APXvYqx5sZYBLI/wIY1hADODRR2d30TnTSTMhh6Gnf+9B1LfriLbEMR7g65AJaaQXJzKxumhkwHHXQeo4SaSo4/uYeM= X-Received: by 2002:a63:1f1f:: with SMTP id f31mr55945140pgf.353.1568648696199; Mon, 16 Sep 2019 08:44:56 -0700 (PDT) MIME-Version: 1.0 References: <369926533c3e448c9d1a0d28391fd688@quantatw.com> <02128993d3064b53ac289500746666ab@quantatw.com>

<4b7d382d292d45fdab63f4adcc40eded@quantatw.com>

<5a46202d21694717b1aa40b4ef5105ea@quantatw.com> In-Reply-To: <5a46202d21694717b1aa40b4ef5105ea@quantatw.com> From: Patrick Venture Date: Mon, 16 Sep 2019 08:44:43 -0700 Message-ID: Subject: Re: [phosphor-pid-control] scaling issue To: =?UTF-8?B?SGFuayBMaW91ICjlionmmYnnv7Ap?= Cc: James Feist , "openbmc@lists.ozlabs.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2019 15:45:02 -0000 On Mon, Sep 16, 2019 at 1:37 AM Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) wrote: > > Hi Patrick, > > Thanks for your help. This change does solve the issue. No problem! I enjoy it when someone hits an edge case or a situation not yet considered. We don't have nearly enough variety of configurations to really test quirks and unit-testing only covers so much. I saw your review requesting the configuration change, and +1'd it. Presumably you're well on your way. Thanks for your patience in this back-and-forth to resolve the issue. > > Hank > > >-----Original Message----- > >From: Patrick Venture [mailto:venture@google.com] > >Sent: Wednesday, September 11, 2019 1:52 AM > >To: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) > >Cc: James Feist ; openbmc@lists.ozlabs.org > >Subject: Re: [phosphor-pid-control] scaling issue > > > >On Tue, Sep 10, 2019 at 7:52 AM Patrick Venture > >wrote: > >> > >> On Tue, Sep 10, 2019 at 7:39 AM Patrick Venture > >wrote: > >> > > >> > On Tue, Sep 10, 2019 at 1:02 AM Hank Liou (=E5=8A=89=E6=99=89=E7=BF= =B0) > > wrote: > >> > > > >> > > >-----Original Message----- > >> > > >From: James Feist [mailto:james.feist@linux.intel.com] > >> > > >Sent: Tuesday, September 10, 2019 1:27 AM > >> > > >To: Patrick Venture ; Hank Liou (=E5=8A=89=E6= =99=89=E7=BF=B0) > >> > > > > >> > > >Cc: openbmc@lists.ozlabs.org > >> > > >Subject: Re: [phosphor-pid-control] scaling issue > >> > > > > >> > > >On 9/9/19 9:57 AM, Patrick Venture wrote: > >> > > >> On Thu, Sep 5, 2019 at 12:25 AM Hank Liou (=E5=8A=89=E6=99=89= =E7=BF=B0) > >> > > > wrote: > >> > > >>> > >> > > >>> Hi Patrick, > >> > > >>> > >> > > >>> > >> > > >>> Sorry for not clearly stating our problem. We have the followi= ng > >issue: > >> > > >>> > >> > > >>> > >> > > >>> temp sensor gets 31(C) -> 31 / 0.255 =3D 121.57 -> pid uses > >> > > >>> 127.57 as input for temp sensor -> > >> > > >>> > >> > > >>> stepwise fan table output 100 duty -> full speed fan > >> > > >> > >> > > >> Ok, so you're getting a dbus-based min/max value and you want > >> > > >> to ignore it? > >> > > > >> > > Yes, we want to ignore it. > >> > > >> > It looks like the sensor value scaling should be ignored for non-fan= s. > >> > Per > >> > https://github.com/openbmc/phosphor-pid- > >control/commit/75eb769d35143 > >> > 4547899186f73ff70ae00d7934a, this change was only meant to deal with > >> > a fan case where the goal looks like it was to treat the fan values > >> > as percentages on reading the sensors, and not only on writing them > >> > by leveraging the min/max json sometimes? > >> > > >> > I can change the dbuspassive constructor to set the values back to > >> > their input values (ignoring dbus) if the type is not "fan", but I'm > >> > not sure that makes sense because the real use-case isn't clear to > >> > me, and I know the scaling from dbus is gone: > >> > https://github.com/openbmc/phosphor-pid- > >control/search?utf8=3D%E2%9C%9 > >> > 3&q=3DinheritValueFromDbus&type=3D > >> > > >> > I'll submit the patch real quick, but I'm not sure it's the right > >> > long-term fix. I'd like to clean this up if possible so that we > >> > don't leverage "unused" features of a configuration and instead > >> > explicitly use them (or not). > >> > >> This patch should address what you're seeing. Overall, I think there > >> should be a larger change addressing the goal of the original change. > >> > >> https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-pid-control/+/25 > >> 070 > > > >I decided to take on the larger change because chances are we might hit = it > >some other way: > >https://gerrit.openbmc-project.xyz/c/25072/ > > > >This lets you specify a json configuration option that will ignore the > >MinValue/MaxValue properties on dbus. > > > >> > >> > > >> > > > >> > > > > >> > > >What is providing the dbus-based min/max? > >> > > > >> > > We use dbus min/max for phosphor-sel-logger utility. The dbus min/= max > >is provided by config file of phosphor-hwmon. > >> > > In our case, they are -128/127 respectively. > >> > > > >> > > I have an observation: > >> > > I found that while fan readpath is of the form "/sys/...", the fan= input > >would not be rescaled. The same is for other sensors since the input val= ue > >would not enter rescaling function. > >> > > However, in our case we don't have a sys path for some thermal sen= sors. > >> > > > >> > > > > >> > > >> In the json configuration, if you set the values to 0, they are > >> > > >> set to the default (0), so there'd be no clean way to know to > >> > > >> ignore dbus in this case, without adding a small check to only > >> > > >> consider min/max from dbus when sensor is not temp/margin. > >> > > >> Basically, only care about min/max on dbus if type is "fan" > >> > > > > >> > > > >> > > I agree with the option to add a check since the min/max is only f= or fan > >now. > >> > > > >> > > >Why is the dbus-based min/max even there if you don't plan on usi= ng it? > >> > > > > >> > > >> > >> > > >> If that's right, James do you have a cycle to look at this one-= liner? > >> > > >> > >> > > >>> > >> > > >>> > >> > > >>> As a result, fan will be at full speed while temp is low. > >> > > >>> Before the commit > >> > > >fc2e803 [1], this won't happen. The root cause is that, before > >> > > >fc2e803, pid will use config min/max, which is 0 in our case. > >> > > >This would not trigger scaling function, namely > >> > > >scaleSensorReading, in util.cpp. However, after such commit, > >> > > >min/max would be non-zero (-128/127 from DBus). This will trigger > >scaling function. > >> > > >>> > >> > > >>> > >> > > >>> [1] > >> > > >>> https://github.com/openbmc/phosphor-pid- > >> > > >control/commit/fc2e803f5d9256 > >> > > >>> 944e18c7c878a441606b1f121c > >> > > >>> > >> > > >>> > >> > > >>> Hank > >> > > >>> > >> > > >>> > >> > > >>> ________________________________ > >> > > >>> From: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) > >> > > >>> Sent: Monday, September 2, 2019 4:52 PM > >> > > >>> To: Patrick Venture > >> > > >>> Cc: James Feist; openbmc@lists.ozlabs.org > >> > > >>> Subject: Re: [phosphor-pid-control] scaling issue > >> > > >>> > >> > > >>> > >> > > >>> Hi Patrick, > >> > > >>> > >> > > >>> > >> > > >>> Since we use phosphor-sel-logger [1] at the same time, we do > >> > > >>> assign min > >> > > >and max of temp sensors to Dbus (max: 127, min: -128). So in the > >> > > >present case, our temp value will be divided by 0.255 (also due > >> > > >to exponent is -3 here). This will cause re-scaling problem. > >> > > >Therefore there should be an statement to distinguish sensor > >> > > >types. If it is "temp", then one assigns 0 to the min and max fro= m Dbus. > >> > > >>> > >> > > >>> > >> > > >>> [1] > >> > > >>> https://github.com/openbmc/phosphor-sel- > >> > > >logger/blob/3d300fca24b30864b > >> > > >>> 3e9a4f5768cfe5e769458ae/include/sensorutils.hpp#L59 > >> > > >>> > >> > > >>> > >> > > >>> Hank > >> > > >>> > >> > > >>> > >> > > >>> ________________________________ > >> > > >>> From: Patrick Venture > >> > > >>> Sent: Friday, August 30, 2019 1:47 AM > >> > > >>> To: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) > >> > > >>> Cc: James Feist; openbmc@lists.ozlabs.org > >> > > >>> Subject: Re: [phosphor-pid-control] scaling issue > >> > > >>> > >> > > >>> PTAL - https://gerrit.openbmc-project.xyz/24827 - this is > >> > > >>> merged, and the srcrev bump should propagate into > >openbmc/openbmc in a day or two. > >> > > >>> > >> > > >>> On Wed, Aug 28, 2019 at 11:00 PM Hank Liou (=E5=8A=89=E6=99=89= =E7=BF=B0) > >> > > > wrote: > >> > > >>>> > >> > > >>>> Hi Patrick, > >> > > >>>> > >> > > >>>> I think it's OK to parse the config min&max for temp sensors. > >> > > >>>> > >> > > >>>> Any suggestion? > >> > > >>>> > >> > > >>>> Thanks, > >> > > >>>> Hank > >> > > >>>> > >> > > >>>>> -----Original Message----- > >> > > >>>>> From: openbmc [mailto:openbmc- > >> > > >>>>> bounces+hank.liou=3Dquantatw.com@lists.ozlabs.org] On Behalf > >> > > >>>>> bounces+Of Hank Liou > >> > > >>>>> (=E5=8A=89=E6=99=89=E7=BF=B0) > >> > > >>>>> Sent: Friday, August 23, 2019 4:31 PM > >> > > >>>>> To: Patrick Venture ; James Feist > >> > > >>>>> > >> > > >>>>> Cc: openbmc@lists.ozlabs.org > >> > > >>>>> Subject: RE: [phosphor-pid-control] scaling issue > >> > > >>>>> > >> > > >>>>> Hi Patrick, > >> > > >>>>> > >> > > >>>>>> -----Original Message----- > >> > > >>>>>> From: Patrick Venture [mailto:venture@google.com] > >> > > >>>>>> Sent: Wednesday, August 21, 2019 10:32 PM > >> > > >>>>>> To: Hank Liou (=E5=8A=89=E6=99=89=E7=BF=B0) ; James > >Feist > >> > > >>>>>> > >> > > >>>>>> Cc: openbmc@lists.ozlabs.org > >> > > >>>>>> Subject: Re: [phosphor-pid-control] scaling issue > >> > > >>>>>> > >> > > >>>>>> On Wed, Aug 21, 2019 at 1:11 AM Hank Liou (=E5=8A=89=E6=99= =89=E7=BF=B0) > >> > > >>>>>> wrote: > >> > > >>>>>>> > >> > > >>>>>>> Hi All, > >> > > >>>>>>> > >> > > >>>>>>> > >> > > >>>>>>> After commit [1], I found my temp sensor reading would be > >> > > >>>>>>> re-scaled by > >> > > >>>>>> multiplying 1 over 255, making temperature into unfamiliar = unit. > >> > > >>>>>> Also the fan rpm reading would lie in [0,1] interval, > >> > > >>>>>> letting the fan input to be 0 (since the input value of fan > >> > > >>>>>> is from an integer array [2]). Are these > >> > > >>>>> normal behaviors? > >> > > >>>>>> Or do I miss something? > >> > > >>>>>> > >> > > >>>>>> Are you using dbus configuration or json? If json, can you > >> > > >>>>>> attach your > >> > > >config. > >> > > >>>>>> Since you're saying it was working and now isn't, I'm > >> > > >>>>>> assuming there's something about the config being treated > >> > > >>>>>> differently with the code changes in an unexpected way. > >> > > >>>>> > >> > > >>>>> I found pid control will first read min and max from dbus > >> > > >>>>> and then (before commit [1]) revise them if > >> > > >>>>> > >> > > >>>>> info->min !=3D conf::inheritValueFromDbus (in > >> > > >>>>> info->dbus/dbuspassive.cpp) > >> > > >>>>> > >> > > >>>>> After value initialization, the min and max would be the > >> > > >>>>> ones in json file (Json file [3]). However, after commit [1] > >> > > >>>>> the min and max values of config would not be fed into the f= an > >control process. > >> > > >>>>> The scaling issue is originated from commit [4] with the aim > >> > > >>>>> to treat fan rpm as percentage. It seems that commit [1] > >> > > >>>>> unexpectedly affects temp sensors in the sense that the temp > >> > > >>>>> is the integer reading not percentage. Before commit [1], it > >> > > >>>>> would not re-scale the > >> > > >temp reading since my min and max are 0 [6]. > >> > > >>>>> > >> > > >>>>> > >> > > >>>>> > >> > > >>>>> There is another issue with commit [1]. Now the fan rpm > >> > > >>>>> would be something like > >> > > >>>>> > >> > > >>>>> 1500 / 20000 =3D 0.075 > >> > > >>>>> > >> > > >>>>> where rpm max 20000 is from dbus. However the fan input > >> > > >>>>> function would transfer double into int, which is 0 for 0.07= 5 (see > >[5]). > >> > > >>>>> Hence the fan input is 0 not percentage. Is there something > >wrong? > >> > > >>>>> > >> > > >>>>> [1] https://github.com/openbmc/phosphor-pid- > >> > > >>>>> control/commit/fc2e803f5d9256944e18c7c878a441606b1f121c > >> > > >>>>> [2] https://github.com/openbmc/phosphor-pid- > >> > > >>>>> > >> > > > >>control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancont > >> > > >ro > >> > > >>>>> lle > >> > > >>>>> r.cpp#L86 > >> > > >>>>> [3] > >> > > >>>>> { > >> > > >>>>> "name": "fan1", > >> > > >>>>> "type": "fan", > >> > > >>>>> "readPath": "/sys/class/hwmon/hwmon1/fan1_input"= , > >> > > >>>>> "writePath": "/sys/class/hwmon/hwmon1/pwm1", > >> > > >>>>> "min": 0, > >> > > >>>>> "max": 255 > >> > > >>>>> }, > >> > > >>>>> { > >> > > >>>>> "name": "temp1", > >> > > >>>>> "type": "temp", > >> > > >>>>> "readPath": > >> > > >"/xyz/openbmc_project/sensors/temperature/temp1", > >> > > >>>>> "writePath": "", > >> > > >>>>> "min": 0, > >> > > >>>>> "max": 0 > >> > > >>>>> } > >> > > >>>>> [4] https://github.com/openbmc/phosphor-pid- > >> > > >>>>> control/commit/75eb769d351434547899186f73ff70ae00d7934a > >> > > >>>>> [5] https://github.com/openbmc/phosphor-pid- > >> > > >>>>> > >> > > > >>control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/pid/fancont > >> > > >ro > >> > > >>>>> lle > >> > > >>>>> r.cpp#L64 > >> > > >>>>> [6] https://github.com/openbmc/phosphor-pid- > >> > > >>>>> > >> > > > >>control/blob/a7ec8350d17b70153cebe666d3fbe88bddd02a1a/dbus/dbuspa > >> > > >ss > >> > > >>>>> i > >> > > >>>>> ve.cpp#L158 > >> > > >>>>> > >> > > >>>>>> > >> > > >>>>>>> > >> > > >>>>>>> > >> > > >>>>>>> [1] > >> > > >>>>>>> https://github.com/openbmc/phosphor-pid- > >> > > >>>>>> control/commit/fc2e803f5d92569 > >> > > >>>>>>> 44e18c7c878a441606b1f121c > >> > > >>>>>>> > >> > > >>>>>>> [2] > >> > > >>>>>>> https://github.com/openbmc/phosphor-pid- > >> > > >>>>>> control/blob/a7ec8350d17b70153 > >> > > >>>>>>> cebe666d3fbe88bddd02a1a/pid/fancontroller.cpp#L86 > >> > > >>>>>>> > >> > > >>>>>>> > >> > > >>>>>>> Thanks, > >> > > >>>>>>> > >> > > >>>>>>> > >> > > >>>>>>> Hank Liou > >> > > >>>>>>> > >> > > >>>>>>> Quanta Computer Inc. > >> > > >>>>>>> > >> > > >>>>>>> > >> > > >>>>> > >> > > >>>>> Sincerely, > >> > > >>>>> Hank