From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jitendra Bhivare via iommu Subject: Re: [RFC 1/5] dt-bindings: iommu: Add reserved-dma-region for IOMMU device Date: Mon, 12 Mar 2018 12:04:22 +0530 Message-ID: References: <1520312368-7068-1-git-send-email-jitendra.bhivare@broadcom.com> <1520312368-7068-2-git-send-email-jitendra.bhivare@broadcom.com> <23f7c879-2dfe-dbdf-f259-dcc44f045c96@arm.com> Reply-To: Jitendra Bhivare Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6754305182804173284==" Return-path: In-Reply-To: <23f7c879-2dfe-dbdf-f259-dcc44f045c96-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Robin Murphy Cc: will.deacon-5wv7dgnIgG8@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org --===============6754305182804173284== Content-Type: multipart/alternative; boundary="001a1149750a22d1c40567315514" --001a1149750a22d1c40567315514 Content-Type: text/plain; charset="UTF-8" On Tue, Mar 6, 2018 at 5:11 PM, Robin Murphy wrote: > On 06/03/18 04:59, Jitendra Bhivare wrote: > >> Certain regions in IO virtual address space may need to be reserved to be >> not used for devices configured behind IOMMU. >> >> Add documentation of the property to allow such regions to be specified in >> DT to be reserved using IOMMU_RESV_RESERVED type. >> > > That sounds like software policy; DT is for describing hardware. It is to describe the holes in address space for which hardware can't provide mappings. > > > Reviewed-by: Ray Jui >> Reviewed-by: Vikram Prakash >> Reviewed-by: Scott Branden >> Signed-off-by: Jitendra Bhivare >> --- >> Documentation/devicetree/bindings/iommu/iommu.txt | 17 >> +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iommu/iommu.txt >> b/Documentation/devicetree/bindings/iommu/iommu.txt >> index 5a8b462..5a58ef2 100644 >> --- a/Documentation/devicetree/bindings/iommu/iommu.txt >> +++ b/Documentation/devicetree/bindings/iommu/iommu.txt >> @@ -98,6 +98,20 @@ requirements of that use-case haven't been fully >> determined yet. Implementing >> this is therefore not recommended without further discussion and >> extension of >> this binding. >> +Optional properties: >> +-------------------- >> +- reserved-dma-region: This specifies DMA region to be reserved with >> specific >> + prot in IOVA space. It is in tuples of (busno,prot,bus_addr,size). >> > > What do busno and prot actually mean, and what are valid values for them? busno was part of initial commit 4e0ee78f in implementation of of_get_dma_window. I am not sure what was the use of it in Powerpc. Similar implementation can be seen in of_parse_dma_window. prot is access permission flags for the region for reserving in SW.This I will remove. > > > Robin. > > > +- #region-address-cells: specifies number of cells needed to encode >> bus_addr >> + >> +- #region-size-cells: specifies number of cells needed to encode size >> + >> +Notes: >> +====== >> +This can be applied to IOMMU master node or to children (such as PCI host >> +bridges) on the bus behind IOMMU. >> + >> Examples: >> ========= >> @@ -173,6 +187,9 @@ Multiple-master IOMMU with configurable DMA window: >> * master (i.e. the I/O virtual address space). >> */ >> #iommu-cells = <4>; >> + #region-address-cells = <2>; >> + #region-size-cells = <2>; >> + reserved-dma-region = <0x0 0x0 0x04 0x0 0x04 0x0>; >> }; >> master { >> >> --001a1149750a22d1c40567315514 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On T= ue, Mar 6, 2018 at 5:11 PM, Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org><= /span> wrote:
On 06/03/18 04:59, Jitendra Bhivare wrote:
Certain regions in IO virtual address space may need to be reserved to be not used for devices configured behind IOMMU.

Add documentation of the property to allow such regions to be specified in<= br> DT to be reserved using IOMMU_RESV_RESERVED type.

 That sounds like software policy; DT is for describing hardware.
It is to describe the holes in address space for which hardware can&= #39;t provide mappings.=C2=A0


Reviewed-by: Ray Jui <ray.jui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Reviewed-by: Vikram Prakash <vikram.prakash-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Reviewed-by: Scott Branden <scott.branden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Signed-off-by: Jitendra Bhivare <jitendra.bhivare-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
---
=C2=A0 Documentation/devicetree/bindings/iommu/iommu.txt | 17 ++++++++= +++++++++
=C2=A0 1 file changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/iommu/iommu.txt b/Docum= entation/devicetree/bindings/iommu/iommu.txt
index 5a8b462..5a58ef2 100644
--- a/Documentation/devicetree/bindings/iommu/iommu.txt
+++ b/Documentation/devicetree/bindings/iommu/iommu.txt
@@ -98,6 +98,20 @@ requirements of that use-case haven't been fully det= ermined yet. Implementing
=C2=A0 this is therefore not recommended without further discussion and ext= ension of
=C2=A0 this binding.
=C2=A0 +Optional properties:
+--------------------
+- reserved-dma-region: This specifies DMA region to be reserved with speci= fic
+=C2=A0 prot in IOVA space. It is in tuples of (busno,prot,bus_addr,size).<= br>

What do busno and prot actually mean, and what are valid values for them?
busno was part of initial commit 4e0ee78f in implementation= of of_get_dma_window.
I am not sure what was the use of it in Po= werpc. Similar implementation can be seen
in of_parse_dma_win= dow.
prot is access permission flags for the region for reserving= in SW.This I will remove.


Robin.

+- #region-address-cells: specifies number of cells needed to encode bus_ad= dr
+
+- #region-size-cells: specifies number of cells needed to encode size
+
+Notes:
+=3D=3D=3D=3D=3D=3D
+This can be applied to IOMMU master node or to children (such as PCI host<= br> +bridges) on the bus behind IOMMU.
+
=C2=A0 =C2=A0 Examples:
=C2=A0 =3D=3D=3D=3D=3D=3D=3D=3D=3D
@@ -173,6 +187,9 @@ Multiple-master IOMMU with configurable DMA window:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0* master (i.e. the I/O virtual address space).
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0*/
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 #iommu-cells =3D <4>;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0#region-address-cells =3D <2>;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0#region-size-cells =3D <2>;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0reserved-dma-region =3D <0x0 0x0 0x04 0x0 0x04 0x0>;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 };
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 master {


--001a1149750a22d1c40567315514-- --===============6754305182804173284== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============6754305182804173284==--