Re: [dpdk-dev] [PATCH v7] ethdev: add namespace

From: Somnath Kotur <somnath.kotur@broadcom.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	Maryam Tahhan <maryam.tahhan@intel.com>,
	 Reshma Pattan <reshma.pattan@intel.com>,
	Jerin Jacob <jerinj@marvell.com>,
	 Wisam Jaddo <wisamm@nvidia.com>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	 Xiaoyun Li <xiaoyun.li@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	 Jay Jayatheerthan <jay.jayatheerthan@intel.com>,
	Chas Williams <chas3@att.com>,
	"Min Hu (Connor)" <humin29@huawei.com>,
	Pavan Nikhilesh <pbhagavatula@marvell.com>,
	 Shijith Thotton <sthotton@marvell.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	 John Daley <johndale@cisco.com>,
	Hyong Youb Kim <hyonkim@cisco.com>,
	Qi Zhang <qi.z.zhang@intel.com>,
	 Xiao Wang <xiao.w.wang@intel.com>,
	Beilei Xing <beilei.xing@intel.com>,
	 Haiyue Wang <haiyue.wang@intel.com>,
	Matan Azrad <matan@nvidia.com>,
	 Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	Keith Wiles <keith.wiles@intel.com>,
	 Jiayu Hu <jiayu.hu@intel.com>,
	Olivier Matz <olivier.matz@6wind.com>, Ori Kam <orika@nvidia.com>,
	 Akhil Goyal <gakhil@marvell.com>,
	Declan Doherty <declan.doherty@intel.com>,
	 Ray Kinsella <mdr@ashroe.eu>,
	Radu Nicolau <radu.nicolau@intel.com>,
	 Hemant Agrawal <hemant.agrawal@nxp.com>,
	Sachin Saxena <sachin.saxena@oss.nxp.com>,
	 Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	 Sunil Kumar Kori <skori@marvell.com>,
	Satha Rao <skoteshwar@marvell.com>,
	 "John W. Linville" <linville@tuxdriver.com>,
	Ciara Loftus <ciara.loftus@intel.com>,
	 Shepard Siegel <shepard.siegel@atomicrules.com>,
	Ed Czeck <ed.czeck@atomicrules.com>,
	 John Miller <john.miller@atomicrules.com>,
	Igor Russkikh <irusskikh@marvell.com>,
	 Steven Webster <steven.webster@windriver.com>,
	Matt Peters <matt.peters@windriver.com>,
	 Chandubabu Namburu <chandu@amd.com>,
	Rasesh Mody <rmody@marvell.com>,
	Shahed Shaikh <shshaikh@marvell.com>,
	 Bruce Richardson <bruce.richardson@intel.com>,
	 Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Ruifeng Wang <ruifeng.wang@arm.com>,
	 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
	Marcin Wojtas <mw@semihalf.com>,
	 Michal Krawczyk <mk@semihalf.com>,
	Shai Brandes <shaibran@amazon.com>,
	 Evgeny Schemeilin <evgenys@amazon.com>,
	Igor Chauskin <igorch@amazon.com>,
	 Gagandeep Singh <g.singh@nxp.com>, Gaetan Rivet <grive@u256.net>,
	Ziyang Xuan <xuanziyang2@huawei.com>,
	 Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
	Guoyang Zhou <zhouguoyang@huawei.com>,
	 Yisen Zhuang <yisen.zhuang@huawei.com>,
	Lijun Ou <oulijun@huawei.com>,
	 Jingjing Wu <jingjing.wu@intel.com>,
	Qiming Yang <qiming.yang@intel.com>,
	 Andrew Boyer <aboyer@pensando.io>, Rosen Xu <rosen.xu@intel.com>,
	 Srisivasubramanian Srinivasan <srinivasan@marvell.com>,
	Jakub Grajciar <jgrajcia@cisco.com>,
	 Zyta Szpak <zr@semihalf.com>, Liron Himi <lironh@marvell.com>,
	 Stephen Hemminger <sthemmin@microsoft.com>,
	Long Li <longli@microsoft.com>,
	 Martin Spinler <spinler@cesnet.cz>,
	Heinrich Kuhn <heinrich.kuhn@corigine.com>,
	Jiawen Wu <jiawenwu@trustnetic.com>,
	Tetsuya Mukawa <mtetsuyah@gmail.com>,
	 Harman Kalra <hkalra@marvell.com>,
	Anoob Joseph <anoobj@marvell.com>,
	 Nalla Pradeep <pnalla@marvell.com>,
	Radha Mohan Chintakuntla <radhac@marvell.com>,
	 Veerasenareddy Burru <vburru@marvell.com>,
	Devendra Singh Rawat <dsinghrawat@marvell.com>,
	 Jasvinder Singh <jasvinder.singh@intel.com>,
	Maciej Czekaj <mczekaj@marvell.com>,
	Jian Wang <jianwang@trustnetic.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	 Chenbo Xia <chenbo.xia@intel.com>,
	Yong Wang <yongwang@vmware.com>,
	 Nicolas Chautru <nicolas.chautru@intel.com>,
	David Hunt <david.hunt@intel.com>,
	Harry van Haaren <harry.van.haaren@intel.com>,
	 Bernard Iremonger <bernard.iremonger@intel.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	 John McNamara <john.mcnamara@intel.com>,
	Kirill Rybalchenko <kirill.rybalchenko@intel.com>,
	 Byron Marohn <byron.marohn@intel.com>,
	Yipeng Wang <yipeng1.wang@intel.com>, dev <dev@dpdk.org>,
	Tyler Retzlaff <roretzla@linux.microsoft.com>,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v7] ethdev: add namespace
Date: Fri, 22 Oct 2021 17:59:14 +0530	[thread overview]
Message-ID: <CAOBf=mv5QWVqSb=2-WpMFPicZgD88=TJeQ+b28cbOUs2xYFtkw@mail.gmail.com> (raw)
In-Reply-To: <b3ef393a-67be-19e9-6f7b-ebb3360dce4b@oktetlabs.ru>

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

On Fri, 22 Oct 2021, 16:58 Andrew Rybchenko, <andrew.rybchenko@oktetlabs.ru>
wrote:

> On 10/22/21 2:03 PM, Ferruh Yigit wrote:
> > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible
> > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible
>
> LGTM except two lines duplicated above.
>
> > way. The macros for backward compatibility can be removed in next LTS.
> > Also updated some struct names to have 'rte_eth' prefix.
> >
> > All internal components switched to using new names.
> >
> > Syntax fixed on lines that this patch touches.
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> > Acked-by: Wisam Jaddo <wisamm@nvidia.com>
> > Acked-by: Rosen Xu <rosen.xu@intel.com>
> > Acked-by: Chenbo Xia <chenbo.xia@intel.com>
> > Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>
Acked-by: Somnath Kotur
somnath.kotur@broadcom.com

>
>