From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755724AbcJUVBn (ORCPT ); Fri, 21 Oct 2016 17:01:43 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:34001 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755056AbcJUVBk (ORCPT ); Fri, 21 Oct 2016 17:01:40 -0400 MIME-Version: 1.0 In-Reply-To: References: <20161021140106.21531-1-woogyom.kim@gmail.com> <20161021140106.21531-6-woogyom.kim@gmail.com> From: Robert Nelson Date: Fri, 21 Oct 2016 16:01:09 -0500 Message-ID: Subject: Re: [PATCH 5/7] ARM: dts: am335x: Add the charger interrupt To: Milo Kim Cc: =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , "linux-omap@vger.kernel.org" , devicetree , "linux-arm-kernel@lists.infradead.org" , linux kernel , Lee Jones , Keerthy Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 21, 2016 at 3:47 PM, Robert Nelson wrote: > On Fri, Oct 21, 2016 at 9:01 AM, Milo Kim wrote: >> This enables the charger driver gets corresponding IRQ number by using >> platform_get_irq_byname() helper. >> >> Signed-off-by: Milo Kim >> --- >> arch/arm/boot/dts/am335x-bone-common.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi >> index 25303d9..cec9d91 100644 >> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi >> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi >> @@ -6,6 +6,8 @@ >> * published by the Free Software Foundation. >> */ >> >> +#include > > ^ this hasn't been posted nor pushed to mainline yet.. ;) So, with this patchset + Keerthy's [RESEND PATCH v8 0/5] mfd: tps65218: Clean ups: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1250918.html and this patch, as systemd is looking for "tps65217_pwr_but".. https://github.com/systemd/systemd/blob/master/src/login/70-power-switch.rules#L13 Shutdown is working on my BBB/BBG/BBGW/BBBW's... diff --git a/drivers/input/misc/tps65218-pwrbutton.c b/drivers/input/misc/tps65218-pwrbutton.c index cc74a41..f7e5492 100644 --- a/drivers/input/misc/tps65218-pwrbutton.c +++ b/drivers/input/misc/tps65218-pwrbutton.c @@ -36,7 +36,7 @@ struct tps6521x_data { static const struct tps6521x_data tps65217_data = { .reg_status = TPS65217_REG_STATUS, .pb_mask = TPS65217_STATUS_PB, - .name = "tps65217_pwrbutton", + .name = "tps65217_pwr_but", }; static const struct tps6521x_data tps65218_data = { diff --git a/include/dt-bindings/mfd/tps65217.h b/include/dt-bindings/mfd/tps65217.h new file mode 100644 index 0000000..26b2ba8 --- /dev/null +++ b/include/dt-bindings/mfd/tps65217.h @@ -0,0 +1,9 @@ +#ifndef __DT_BINDINGS_TPS65217_H +#define __DT_BINDINGS_TPS65217_H + +#define TPS65217_IRQ_USB 0 +#define TPS65217_IRQ_AC 1 +#define TPS65217_IRQ_PB 2 +#define TPS65217_NUM_IRQ 3 + +#endif /* __DT_BINDINGS_TPS65217_H */ Regards, -- Robert Nelson https://rcn-ee.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: robertcnelson@gmail.com (Robert Nelson) Date: Fri, 21 Oct 2016 16:01:09 -0500 Subject: [PATCH 5/7] ARM: dts: am335x: Add the charger interrupt In-Reply-To: References: <20161021140106.21531-1-woogyom.kim@gmail.com> <20161021140106.21531-6-woogyom.kim@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Oct 21, 2016 at 3:47 PM, Robert Nelson wrote: > On Fri, Oct 21, 2016 at 9:01 AM, Milo Kim wrote: >> This enables the charger driver gets corresponding IRQ number by using >> platform_get_irq_byname() helper. >> >> Signed-off-by: Milo Kim >> --- >> arch/arm/boot/dts/am335x-bone-common.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi >> index 25303d9..cec9d91 100644 >> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi >> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi >> @@ -6,6 +6,8 @@ >> * published by the Free Software Foundation. >> */ >> >> +#include > > ^ this hasn't been posted nor pushed to mainline yet.. ;) So, with this patchset + Keerthy's [RESEND PATCH v8 0/5] mfd: tps65218: Clean ups: https://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1250918.html and this patch, as systemd is looking for "tps65217_pwr_but".. https://github.com/systemd/systemd/blob/master/src/login/70-power-switch.rules#L13 Shutdown is working on my BBB/BBG/BBGW/BBBW's... diff --git a/drivers/input/misc/tps65218-pwrbutton.c b/drivers/input/misc/tps65218-pwrbutton.c index cc74a41..f7e5492 100644 --- a/drivers/input/misc/tps65218-pwrbutton.c +++ b/drivers/input/misc/tps65218-pwrbutton.c @@ -36,7 +36,7 @@ struct tps6521x_data { static const struct tps6521x_data tps65217_data = { .reg_status = TPS65217_REG_STATUS, .pb_mask = TPS65217_STATUS_PB, - .name = "tps65217_pwrbutton", + .name = "tps65217_pwr_but", }; static const struct tps6521x_data tps65218_data = { diff --git a/include/dt-bindings/mfd/tps65217.h b/include/dt-bindings/mfd/tps65217.h new file mode 100644 index 0000000..26b2ba8 --- /dev/null +++ b/include/dt-bindings/mfd/tps65217.h @@ -0,0 +1,9 @@ +#ifndef __DT_BINDINGS_TPS65217_H +#define __DT_BINDINGS_TPS65217_H + +#define TPS65217_IRQ_USB 0 +#define TPS65217_IRQ_AC 1 +#define TPS65217_IRQ_PB 2 +#define TPS65217_NUM_IRQ 3 + +#endif /* __DT_BINDINGS_TPS65217_H */ Regards, -- Robert Nelson https://rcn-ee.com/