From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [Patch v6 6/7] regmap: add SLIMBUS support Date: Thu, 19 Oct 2017 22:00:35 -0700 Message-ID: References: <20171006155136.4682-1-srinivas.kandagatla@linaro.org> <20171006155136.4682-7-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171006155136.4682-7-srinivas.kandagatla@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Srinivas Kandagatla Cc: Mark Rutland , alsa-devel@alsa-project.org, Michael Opdenacker , poeschel@lemonage.de, Andreas Noever , gong.chen@linux.intel.com, Arnd Bergmann , kheitke@audience.com, Thierry Reding , devicetree , james.hogan@imgtec.com, Pawel Moll , linux-arm-msm , sharon.dvir1@mail.huji.ac.il, Rob Herring , Sagar Dharia , alan@linux.intel.com, bp@suse.de, Mathieu Poirier , Greg Kroah-Hartman , lkml , Mark Brown , Daniel Vetter , Jiri Kosina , joe@perches.com, David Miller List-Id: linux-arm-msm@vger.kernel.org On Fri 06 Oct 08:51 PDT 2017, srinivas.kandagatla@linaro.org wrote: > diff --git a/drivers/base/regmap/regmap-slimbus.c b/drivers/base/regmap/regmap-slimbus.c [..] > +static int regmap_slimbus_byte_reg_read(void *context, unsigned int reg, > + unsigned int *val) > +{ > + struct slim_device *slim = context; > + struct slim_val_inf msg = {0,}; > + > + msg.start_offset = reg; > + msg.num_bytes = 1; > + msg.rbuf = (void *)val; Turn rbuf into a void * and you don't need this cast (think I commented on this on a previous patch as well). > + > + return slim_request_val_element(slim, &msg); > +} > + > +static int regmap_slimbus_byte_reg_write(void *context, unsigned int reg, > + unsigned int val) > +{ > + struct slim_device *slim = context; > + struct slim_val_inf msg = {0,}; > + > + msg.start_offset = reg; > + msg.num_bytes = 1; > + msg.wbuf = (void *)&val; Dito > + > + return slim_change_val_element(slim, &msg); > +} Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751426AbdJTFAo (ORCPT ); Fri, 20 Oct 2017 01:00:44 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:50411 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbdJTFAg (ORCPT ); Fri, 20 Oct 2017 01:00:36 -0400 X-Google-Smtp-Source: ABhQp+TmQ3X9r0eC2A96vsC3PI283mDHWTX5kP7qq+nT14ok4sBFk7Sa2Uv8GC4ChlsVPGAC0vcIQNmIgHyjPxQz4ek= MIME-Version: 1.0 In-Reply-To: <20171006155136.4682-7-srinivas.kandagatla@linaro.org> References: <20171006155136.4682-1-srinivas.kandagatla@linaro.org> <20171006155136.4682-7-srinivas.kandagatla@linaro.org> From: Bjorn Andersson Date: Thu, 19 Oct 2017 22:00:35 -0700 Message-ID: Subject: Re: [Patch v6 6/7] regmap: add SLIMBUS support To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , Mark Brown , alsa-devel@alsa-project.org, Sagar Dharia , bp@suse.de, poeschel@lemonage.de, Thierry Reding , gong.chen@linux.intel.com, Andreas Noever , alan@linux.intel.com, Mathieu Poirier , Daniel Vetter , Jiri Kosina , sharon.dvir1@mail.huji.ac.il, joe@perches.com, David Miller , james.hogan@imgtec.com, Michael Opdenacker , Rob Herring , Pawel Moll , Mark Rutland , devicetree , lkml , kheitke@audience.com, linux-arm-msm , Arnd Bergmann Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 06 Oct 08:51 PDT 2017, srinivas.kandagatla@linaro.org wrote: > diff --git a/drivers/base/regmap/regmap-slimbus.c b/drivers/base/regmap/regmap-slimbus.c [..] > +static int regmap_slimbus_byte_reg_read(void *context, unsigned int reg, > + unsigned int *val) > +{ > + struct slim_device *slim = context; > + struct slim_val_inf msg = {0,}; > + > + msg.start_offset = reg; > + msg.num_bytes = 1; > + msg.rbuf = (void *)val; Turn rbuf into a void * and you don't need this cast (think I commented on this on a previous patch as well). > + > + return slim_request_val_element(slim, &msg); > +} > + > +static int regmap_slimbus_byte_reg_write(void *context, unsigned int reg, > + unsigned int val) > +{ > + struct slim_device *slim = context; > + struct slim_val_inf msg = {0,}; > + > + msg.start_offset = reg; > + msg.num_bytes = 1; > + msg.wbuf = (void *)&val; Dito > + > + return slim_change_val_element(slim, &msg); > +} Regards, Bjorn